[GitHub] [calcite] rubenada commented on a change in pull request #2050: Site: Remove '(for Calcite committers)' suffix from headers in section dedicated to committers

2020-07-01 Thread GitBox
rubenada commented on a change in pull request #2050: URL: https://github.com/apache/calcite/pull/2050#discussion_r448327076 ## File path: site/_docs/howto.md ## @@ -474,7 +474,7 @@ $ ./src/main/scripts/generate-protobuf.sh The following sections are of interest to Calcite

[GitHub] [calcite] zinking commented on pull request #2014: [CALCITE-4022] Support evaluate SqlInsert SqlBasicCall.toString()

2020-07-01 Thread GitBox
zinking commented on pull request #2014: URL: https://github.com/apache/calcite/pull/2014#issuecomment-652388128 I guess you need to clarify the issue first in JIRA. implementation looks weird before that. This is an

[GitHub] [calcite] zinking commented on pull request #1944: [CALCITE-3956] Unify comparison logic for RelOptCost

2020-07-01 Thread GitBox
zinking commented on pull request #1944: URL: https://github.com/apache/calcite/pull/1944#issuecomment-652379106 > > I don't see interface definition needs to be changed, the change should be made in the IMPlementation file. > > @zinking Thanks for your good suggestion. I have

[GitHub] [calcite] zinking commented on a change in pull request #1991: [CALCITE-3916] Support top-down rule apply and upper bound space pruning

2020-07-01 Thread GitBox
zinking commented on a change in pull request #1991: URL: https://github.com/apache/calcite/pull/1991#discussion_r448352213 ## File path: plus/src/test/java/org/apache/calcite/adapter/tpcds/TpcdsTest.java ## @@ -220,29 +220,33 @@ protected void foo(CalciteAssert.AssertThat

[GitHub] [calcite] liyafan82 commented on pull request #1944: [CALCITE-3956] Unify comparison logic for RelOptCost

2020-07-01 Thread GitBox
liyafan82 commented on pull request #1944: URL: https://github.com/apache/calcite/pull/1944#issuecomment-652392499 > > > I don't see interface definition needs to be changed, the change should be made in the IMPlementation file. > > > > > > @zinking Thanks for your good

[GitHub] [calcite] zinking commented on a change in pull request #2014: [CALCITE-4022] Support evaluate SqlInsert SqlBasicCall.toString()

2020-07-01 Thread GitBox
zinking commented on a change in pull request #2014: URL: https://github.com/apache/calcite/pull/2014#discussion_r448358283 ## File path: core/src/main/java/org/apache/calcite/sql/SqlUtil.java ## @@ -261,6 +261,32 @@ public static boolean isLiteralChain(SqlNode node) { }

[GitHub] [calcite] danny0405 opened a new pull request #2052: [CALCITE-4077] Exception when joined with built-in table functions

2020-07-01 Thread GitBox
danny0405 opened a new pull request #2052: URL: https://github.com/apache/calcite/pull/2052 The scope of SqlWindowTableFunction is special because all its operands (except the first) should have the fucntion's first operand's scope, the first operand is always an explicit table

[GitHub] [calcite] zinking commented on pull request #2052: [CALCITE-4077] Exception when joined with built-in table functions

2020-07-01 Thread GitBox
zinking commented on pull request #2052: URL: https://github.com/apache/calcite/pull/2052#issuecomment-652380194 LGTM, +1 for those details in documentations This is an automated message from the Apache Git Service. To

[GitHub] [calcite] zinking commented on a change in pull request #1991: [CALCITE-3916] Support top-down rule apply and upper bound space pruning

2020-07-01 Thread GitBox
zinking commented on a change in pull request #1991: URL: https://github.com/apache/calcite/pull/1991#discussion_r448349666 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/IterativeRuleDriver.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] neoremind commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-07-01 Thread GitBox
neoremind commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-652330139 @XuQianJin-Stars I have addressed the comments above. For the question: *What is the production usage scenario of this MySQL InnoDB Java Reader?* Calcite's InnoDB

[GitHub] [calcite] xy2953396112 commented on pull request #2014: [CALCITE-4022] Support evaluate SqlInsert SqlBasicCall.toString()

2020-07-01 Thread GitBox
xy2953396112 commented on pull request #2014: URL: https://github.com/apache/calcite/pull/2014#issuecomment-652405333 > I guess you need to clarify the issue first in JIRA. > implementation looks weird before that. Thanks for review. If a sql `insert into emps select * from emps`

[GitHub] [calcite] zinking commented on a change in pull request #2014: [CALCITE-4022] Support evaluate SqlInsert SqlBasicCall.toString()

2020-07-01 Thread GitBox
zinking commented on a change in pull request #2014: URL: https://github.com/apache/calcite/pull/2014#discussion_r448358925 ## File path: core/src/main/java/org/apache/calcite/sql/SqlUtil.java ## @@ -261,6 +261,32 @@ public static boolean isLiteralChain(SqlNode node) { }

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-07-01 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r448440265 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,45 @@

[GitHub] [calcite] Aaaaaaron commented on pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

2020-07-01 Thread GitBox
Aaron commented on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-652490486 > Please refer the doc[1] about the format of commit message. > > [1]https://calcite.apache.org/develop/#contributing Would you please point the problem about the

[GitHub] [calcite] hsyuan merged pull request #2051: [CALCITE-4097] Avoid requesting unnecessary trait request when deriving traits

2020-07-01 Thread GitBox
hsyuan merged pull request #2051: URL: https://github.com/apache/calcite/pull/2051 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[calcite] branch master updated: [CALCITE-4097] Avoid requesting unnecessary trait request when deriving traits

2020-07-01 Thread hyuan
This is an automated email from the ASF dual-hosted git repository. hyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 640da7c [CALCITE-4097] Avoid requesting

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-07-01 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r448438918 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,45 @@

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-07-01 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r448439014 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,47 @@

[GitHub] [calcite] zinking commented on a change in pull request #2014: [CALCITE-4022] Support evaluate SqlInsert SqlBasicCall.toString()

2020-07-01 Thread GitBox
zinking commented on a change in pull request #2014: URL: https://github.com/apache/calcite/pull/2014#discussion_r448360495 ## File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java ## @@ -5818,6 +5818,21 @@ public void

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

2020-07-01 Thread GitBox
Aaron commented on a change in pull request #2030: URL: https://github.com/apache/calcite/pull/2030#discussion_r448445136 ## File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java ## @@ -872,6 +900,20 @@ private RelNode mockCountOver(String table,

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

2020-07-01 Thread GitBox
Aaron commented on a change in pull request #2030: URL: https://github.com/apache/calcite/pull/2030#discussion_r448442551 ## File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java ## @@ -385,6 +385,34 @@ + " ]\n" + "}"; + public static

[GitHub] [calcite] danny0405 commented on a change in pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

2020-07-01 Thread GitBox
danny0405 commented on a change in pull request #2030: URL: https://github.com/apache/calcite/pull/2030#discussion_r448135284 ## File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java ## @@ -872,6 +900,20 @@ private RelNode mockCountOver(String table,

[GitHub] [calcite] chunweilei commented on a change in pull request #2050: Site: Remove '(for Calcite committers)' suffix from headers in section dedicated to committers

2020-07-01 Thread GitBox
chunweilei commented on a change in pull request #2050: URL: https://github.com/apache/calcite/pull/2050#discussion_r448156429 ## File path: site/_docs/howto.md ## @@ -474,7 +474,7 @@ $ ./src/main/scripts/generate-protobuf.sh The following sections are of interest to Calcite

[GitHub] [calcite] chunweilei edited a comment on pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

2020-07-01 Thread GitBox
chunweilei edited a comment on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-652762129 > > Please refer the doc[1] about the format of commit message. > > [1]https://calcite.apache.org/develop/#contributing > > Would you please point the problem

[GitHub] [calcite] danny0405 commented on a change in pull request #2049: [CALCITE-4094] Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

2020-07-01 Thread GitBox
danny0405 commented on a change in pull request #2049: URL: https://github.com/apache/calcite/pull/2049#discussion_r448732851 ## File path: core/src/main/java/org/apache/calcite/plan/Strong.java ## @@ -85,8 +86,32 @@ public static boolean isNotTrue(RexNode node,

[GitHub] [calcite] liyafan82 opened a new pull request #2053: [CALCITE-4102] Some improvements to aggregate related operations

2020-07-01 Thread GitBox
liyafan82 opened a new pull request #2053: URL: https://github.com/apache/calcite/pull/2053 1. Improve the use of data structures 2. Extract common methods 3. Avoid expensive operations This is an automated message

[GitHub] [calcite] chunweilei commented on a change in pull request #2050: Site: Remove '(for Calcite committers)' suffix from headers in section dedicated to committers

2020-07-01 Thread GitBox
chunweilei commented on a change in pull request #2050: URL: https://github.com/apache/calcite/pull/2050#discussion_r448728958 ## File path: site/_docs/howto.md ## @@ -474,7 +474,7 @@ $ ./src/main/scripts/generate-protobuf.sh The following sections are of interest to Calcite

[calcite] branch master updated: [CALCITE-4077] Exception when joined with built-in table functions

2020-07-01 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new c2df42e [CALCITE-4077] Exception when

[GitHub] [calcite] danny0405 merged pull request #2052: [CALCITE-4077] Exception when joined with built-in table functions

2020-07-01 Thread GitBox
danny0405 merged pull request #2052: URL: https://github.com/apache/calcite/pull/2052 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] danny0405 commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-07-01 Thread GitBox
danny0405 commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r448727632 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,34 @@

[GitHub] [calcite] chunweilei commented on pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

2020-07-01 Thread GitBox
chunweilei commented on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-652762129 > > Please refer the doc[1] about the format of commit message. > > [1]https://calcite.apache.org/develop/#contributing > > Would you please point the problem about

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-07-01 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r448732591 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,34 @@

[GitHub] [calcite] amaliujia commented on pull request #2052: [CALCITE-4077] Exception when joined with built-in table functions

2020-07-01 Thread GitBox
amaliujia commented on pull request #2052: URL: https://github.com/apache/calcite/pull/2052#issuecomment-652776214 +1 thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] Aaaaaaron commented on pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

2020-07-01 Thread GitBox
Aaron commented on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-652780850 > > > Please refer the doc[1] about the format of commit message. > > > [1]https://calcite.apache.org/develop/#contributing > > > > > > Would you please point the

[GitHub] [calcite] James-Jeyun-Kim edited a comment on pull request #2046: [CALCITE-4092] NPE using WITH clause without a corresponding SELECT FROM (James Kim)

2020-07-01 Thread GitBox
James-Jeyun-Kim edited a comment on pull request #2046: URL: https://github.com/apache/calcite/pull/2046#issuecomment-650403210 This PR catches an invalid WITH clause during the query validation step so that it doesn't lead to a NPE later on in the sqlToRelConverter stage. An invalid WITH

[GitHub] [calcite] liyafan82 commented on pull request #1944: [CALCITE-3956] Unify comparison logic for RelOptCost

2020-07-01 Thread GitBox
liyafan82 commented on pull request #1944: URL: https://github.com/apache/calcite/pull/1944#issuecomment-652273329 > I don't see interface definition needs to be changed, the change should be made in the IMPlementation file. @zinking Thanks for your good suggestion. I have reverted