[GitHub] [calcite] rubenada commented on pull request #2122: [CALCITE-4195] Cast between types with different collators must be evaluated as not monotonic

rubenada commented on pull request #2122: URL: https://github.com/apache/calcite/pull/2122#issuecomment-682370289 Thanks for your review @chunweilei ! This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] rubenada merged pull request #2122: [CALCITE-4195] Cast between types with different collators must be evaluated as not monotonic

rubenada merged pull request #2122: URL: https://github.com/apache/calcite/pull/2122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[calcite] branch master updated: [CALCITE-4195] Cast between types with different collators must be evaluated as not monotonic

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 425f170 [CALCITE-4195] Cast between types

[GitHub] [calcite] fageiguanbing commented on a change in pull request #2123: Support for Elasticsearch basic authentication

fageiguanbing commented on a change in pull request #2123: URL: https://github.com/apache/calcite/pull/2123#discussion_r478879223 ## File path: elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java ## @@ -100,14 +106,27 @@ public

[GitHub] [calcite] fageiguanbing commented on a change in pull request #2123: Support for Elasticsearch basic authentication

fageiguanbing commented on a change in pull request #2123: URL: https://github.com/apache/calcite/pull/2123#discussion_r478879223 ## File path: elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java ## @@ -100,14 +106,27 @@ public

[GitHub] [calcite] julianhyde opened a new pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

julianhyde opened a new pull request #2124: URL: https://github.com/apache/calcite/pull/2124 Obsolete use of IN in RexCall; in Druid, replace some uses with DRUID_IN operator. Create Sarg instances during RexSimplify of AND, OR. Also during simplify, strengthen

[GitHub] [calcite] amaliujia commented on pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

amaliujia commented on pull request #2006: URL: https://github.com/apache/calcite/pull/2006#issuecomment-683150884 @rubenada maybe we can tag this PR as `LGTM merging soon` to attract people to review, if anyone has an interest?

[GitHub] [calcite] vlsi commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

vlsi commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r479556442 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -653,15 +657,19 @@ private RexNode simplifyUnaryPlus(RexCall call,

[GitHub] [calcite] vlsi commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

vlsi commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r479555285 ## File path: core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java ## @@ -640,10 +640,10 @@ public Result visit(Values e) { //

[GitHub] [calcite] vlsi commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

vlsi commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r479557881 ## File path: core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml ## @@ -6976,7 +6976,7 @@ GROUP by deptno, job]]>

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r479603946 ## File path: core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml ## @@ -6976,7 +6976,7 @@ GROUP by deptno, job]]>

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r479603916 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -653,15 +657,19 @@ private RexNode simplifyUnaryPlus(RexCall call,

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r479603588 ## File path: core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java ## @@ -640,10 +640,10 @@ public Result visit(Values e) {