[GitHub] [calcite] vlsi commented on a change in pull request #2144: [CALCITE-4237] Sarg with single IS NULL operand causes AssertionError

2020-09-09 Thread GitBox
vlsi commented on a change in pull request #2144: URL: https://github.com/apache/calcite/pull/2144#discussion_r485468654 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -2690,7 +2691,14 @@ int complexity() { } @Override public

[GitHub] [calcite] julianhyde commented on a change in pull request #2144: [CALCITE-4237] Sarg with single IS NULL operand causes AssertionError

2020-09-09 Thread GitBox
julianhyde commented on a change in pull request #2144: URL: https://github.com/apache/calcite/pull/2144#discussion_r485806842 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -2690,7 +2691,14 @@ int complexity() { } @Override public

[GitHub] [calcite] asfgit closed pull request #2141: [CALCITE-4173] Fix assertion error when RexSimplify generates Sarg with single null only

2020-09-09 Thread GitBox
asfgit closed pull request #2141: URL: https://github.com/apache/calcite/pull/2141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[calcite] branch master updated: [CALCITE-4237] Following [CALCITE-4173], fix assertion error when RexSimplify generates Sarg with single null only

2020-09-09 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 60aa74f [CALCITE-4237] Following

[GitHub] [calcite] asfgit merged pull request #2144: [CALCITE-4237] Sarg with single IS NULL operand causes AssertionError

2020-09-09 Thread GitBox
asfgit merged pull request #2144: URL: https://github.com/apache/calcite/pull/2144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[calcite] branch master updated (60aa74f -> 32ac731)

2020-09-09 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 60aa74f [CALCITE-4237] Following [CALCITE-4173], fix assertion error when RexSimplify generates Sarg with single

[calcite] 02/04: [CALCITE-4201] AssertionError when registering Druid rules due to conflict in description

2020-09-09 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit c09c08076bdab92c6a8b2ea62b2eeeada4471b2b Author: Stamatis Zampetakis AuthorDate: Mon Aug 31 14:42:29 2020 +0300

[GitHub] [calcite] zabetak merged pull request #2137: [CALCITE-4200] [CALCITE-4201] [CALCITE-4221] Druid problems

2020-09-09 Thread GitBox
zabetak merged pull request #2137: URL: https://github.com/apache/calcite/pull/2137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[calcite] 03/04: [CALCITE-4221] Update stale integration tests in Druid adapter

2020-09-09 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit fb8961528ff559e109612465cdef3e62eee852e2 Author: Stamatis Zampetakis AuthorDate: Wed Sep 2 13:54:17 2020 +0300

[calcite] 01/04: [CALCITE-4200] ExceptionInInitializerError when initializing DruidRules

2020-09-09 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 740444503fd26c7bc45d35b5e6d099d6954efecf Author: Stamatis Zampetakis AuthorDate: Mon Aug 31 13:29:10 2020 +0300

[calcite] 04/04: Minor refactoring of DruidAdapterIT and DruidAdapter2IT

2020-09-09 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 32ac7311cef3aa539538a069026d21b1a31f1d24 Author: Stamatis Zampetakis AuthorDate: Wed Sep 2 15:03:04 2020 +0300

[GitHub] [calcite] julianhyde commented on a change in pull request #2141: [CALCITE-4173] Fix assertion error when RexSimplify generates Sarg with single null only

2020-09-09 Thread GitBox
julianhyde commented on a change in pull request #2141: URL: https://github.com/apache/calcite/pull/2141#discussion_r485832224 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -80,7 +80,6 @@ protected RexCall( this.nodeCount =

[calcite-site] branch master updated: Site: Add Rui Wang as committer, Ruben Quesada Lopez as PMC

2020-09-09 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/master by this push: new a39814c Site: Add Rui Wang as

[calcite] branch master updated: Site: Add Rui Wang as committer, Ruben Quesada Lopez as PMC

2020-09-09 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 0920796 Site: Add Rui Wang as committer,

[calcite] branch site updated: Site: Add Rui Wang as committer, Ruben Quesada Lopez as PMC

2020-09-09 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new b659447 Site: Add Rui Wang as committer, Ruben

[GitHub] [calcite] amaliujia commented on pull request #2113: [CALCITE-4176] Key descriptor can be optional in SESSION table function (Rui Wang)

2020-09-09 Thread GitBox
amaliujia commented on pull request #2113: URL: https://github.com/apache/calcite/pull/2113#issuecomment-689993485 @danny0405 Got really busy recently and I can try to finish this one before next release. If there is an urgency that requires this change, I might be able to pick

[GitHub] [calcite] liyafan82 commented on a change in pull request #2145: [CALCITE-4239] RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

2020-09-09 Thread GitBox
liyafan82 commented on a change in pull request #2145: URL: https://github.com/apache/calcite/pull/2145#discussion_r486042142 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdColumnUniqueness.java ## @@ -348,10 +348,13 @@ public Boolean

[GitHub] [calcite] danny0405 commented on pull request #2113: [CALCITE-4176] Key descriptor can be optional in SESSION table function (Rui Wang)

2020-09-09 Thread GitBox
danny0405 commented on pull request #2113: URL: https://github.com/apache/calcite/pull/2113#issuecomment-689968819 Hi, @amaliujia , what is the progress of this PR ? This is an automated message from the Apache Git Service.

[GitHub] [calcite] chunweilei commented on a change in pull request #2145: [CALCITE-4239] RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

2020-09-09 Thread GitBox
chunweilei commented on a change in pull request #2145: URL: https://github.com/apache/calcite/pull/2145#discussion_r486044687 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdColumnUniqueness.java ## @@ -348,10 +348,13 @@ public Boolean

[GitHub] [calcite] chunweilei opened a new pull request #2145: [CALCITE-4239] RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

2020-09-09 Thread GitBox
chunweilei opened a new pull request #2145: URL: https://github.com/apache/calcite/pull/2145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] rubenada commented on a change in pull request #2141: [CALCITE-4173] Fix assertion error when RexSimplify generates Sarg with single null only

2020-09-09 Thread GitBox
rubenada commented on a change in pull request #2141: URL: https://github.com/apache/calcite/pull/2141#discussion_r485385731 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -80,7 +80,6 @@ protected RexCall( this.nodeCount = RexUtil.nodeCount(1,

[GitHub] [calcite] julianhyde commented on a change in pull request #2141: [CALCITE-4173] Fix assertion error when RexSimplify generates Sarg with single null only

2020-09-09 Thread GitBox
julianhyde commented on a change in pull request #2141: URL: https://github.com/apache/calcite/pull/2141#discussion_r485392343 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -80,7 +80,6 @@ protected RexCall( this.nodeCount =

[GitHub] [calcite] danny0405 commented on a change in pull request #2130: [CALCITE-4207] Validation fails for positional aggregate with current_date in 'case' expression

2020-09-09 Thread GitBox
danny0405 commented on a change in pull request #2130: URL: https://github.com/apache/calcite/pull/2130#discussion_r485393863 ## File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java ## @@ -11685,6 +11685,19 @@ private void

[GitHub] [calcite] julianhyde opened a new pull request #2144: [CALCITE-4237] Sarg with single IS NULL operand causes AssertionError

2020-09-09 Thread GitBox
julianhyde opened a new pull request #2144: URL: https://github.com/apache/calcite/pull/2144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] danny0405 commented on a change in pull request #2141: [CALCITE-4173] Fix assertion error when RexSimplify generates Sarg with single null only

2020-09-09 Thread GitBox
danny0405 commented on a change in pull request #2141: URL: https://github.com/apache/calcite/pull/2141#discussion_r485401212 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -80,7 +80,6 @@ protected RexCall( this.nodeCount = RexUtil.nodeCount(1,

[GitHub] [calcite] danny0405 commented on a change in pull request #2144: [CALCITE-4237] Sarg with single IS NULL operand causes AssertionError

2020-09-09 Thread GitBox
danny0405 commented on a change in pull request #2144: URL: https://github.com/apache/calcite/pull/2144#discussion_r485404856 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -1640,6 +1640,21 @@ private void checkExponentialCnf(int n) {

[GitHub] [calcite] julianhyde commented on a change in pull request #2144: [CALCITE-4237] Sarg with single IS NULL operand causes AssertionError

2020-09-09 Thread GitBox
julianhyde commented on a change in pull request #2144: URL: https://github.com/apache/calcite/pull/2144#discussion_r485407995 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -1640,6 +1640,21 @@ private void checkExponentialCnf(int n) {

[GitHub] [calcite] rubenada commented on a change in pull request #2141: [CALCITE-4173] Fix assertion error when RexSimplify generates Sarg with single null only

2020-09-09 Thread GitBox
rubenada commented on a change in pull request #2141: URL: https://github.com/apache/calcite/pull/2141#discussion_r485429428 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -80,7 +80,6 @@ protected RexCall( this.nodeCount = RexUtil.nodeCount(1,

[GitHub] [calcite] rubenada commented on a change in pull request #2141: [CALCITE-4173] Fix assertion error when RexSimplify generates Sarg with single null only

2020-09-09 Thread GitBox
rubenada commented on a change in pull request #2141: URL: https://github.com/apache/calcite/pull/2141#discussion_r485429428 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -80,7 +80,6 @@ protected RexCall( this.nodeCount = RexUtil.nodeCount(1,

[GitHub] [calcite] rubenada commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-09 Thread GitBox
rubenada commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r485431434 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -246,6 +246,8 @@ default String getDigest() { return

[GitHub] [calcite] ihuzenko commented on a change in pull request #2130: [CALCITE-4207] Validation fails for positional aggregate with current_date in 'case' expression

2020-09-09 Thread GitBox
ihuzenko commented on a change in pull request #2130: URL: https://github.com/apache/calcite/pull/2130#discussion_r485431560 ## File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java ## @@ -11685,6 +11685,19 @@ private void

[GitHub] [calcite] vlsi commented on a change in pull request #2144: [CALCITE-4237] Sarg with single IS NULL operand causes AssertionError

2020-09-09 Thread GitBox
vlsi commented on a change in pull request #2144: URL: https://github.com/apache/calcite/pull/2144#discussion_r485439222 ## File path: plus/src/test/java/org/apache/calcite/adapter/tpcds/TpcdsTest.java ## @@ -367,15 +366,13 @@ protected void foo(CalciteAssert.AssertThat with,

[GitHub] [calcite] zabetak commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-09 Thread GitBox
zabetak commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r485442570 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -246,6 +246,8 @@ default String getDigest() { return

[GitHub] [calcite] vlsi commented on a change in pull request #2144: [CALCITE-4237] Sarg with single IS NULL operand causes AssertionError

2020-09-09 Thread GitBox
vlsi commented on a change in pull request #2144: URL: https://github.com/apache/calcite/pull/2144#discussion_r485449641 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -2690,7 +2691,14 @@ int complexity() { } @Override public

[GitHub] [calcite] rubenada commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-09 Thread GitBox
rubenada commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r485457551 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -246,6 +246,8 @@ default String getDigest() { return