Re: [PR] [CALCITE-6300] Function MAP_VALUES/MAP_KEYS gives exception when mapVauleType and mapKeyType not equals map Biggest mapKeytype or mapValueType [calcite]

macroguo-ghy commented on PR #3721: URL: https://github.com/apache/calcite/pull/3721#issuecomment-2005945947 > @macroguo-ghy If you have time, you can help me take a look. I think it is reasonable to only recognize map. Thank you. Sorry, I'm very busy this week, I will review at the

Re: [PR] [CALCITE-6300] Function MAP_VALUES/MAP_KEYS gives exception when mapVauleType and mapKeyType not equals map Biggest mapKeytype or mapValueType [calcite]

caicancai commented on PR #3721: URL: https://github.com/apache/calcite/pull/3721#issuecomment-2006296571 > > @macroguo-ghy If you have time, you can help me take a look. I think it is reasonable to only recognize map. Thank you. > > @caicancai Sorry, I'm very busy this week, I will

Re: [PR] [CALCITE-6015] AssertionError during optimization of EXTRACT expression [calcite]

rubenada commented on code in PR #3435: URL: https://github.com/apache/calcite/pull/3435#discussion_r1530145137 ## site/_docs/history.md: ## @@ -57,6 +57,10 @@ other software versions as specified in gradle.properties. Bug-fixes, API changes and minor enhancements {:

Re: [PR] [CALCITE-6321] Add copy(List) method to Window class [calcite]

rubenada commented on code in PR #3736: URL: https://github.com/apache/calcite/pull/3736#discussion_r1530147098 ## core/src/main/java/org/apache/calcite/rel/core/Window.java: ## @@ -111,6 +111,14 @@ public Window(RelOptCluster cluster, RelTraitSet traitSet, RelNode input,

Re: [PR] [CALCITE-6248] Illegal dates are accepted by casts [calcite-avatica]

mihaibudiu commented on code in PR #238: URL: https://github.com/apache/calcite-avatica/pull/238#discussion_r1530647044 ## core/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java: ## @@ -739,6 +744,25 @@ private static int parseFraction(String v, int multiplier)

Re: [PR] [CALCITE-6282] Avatica ignores time precision when returning TIME results [calcite-avatica]

mihaibudiu commented on code in PR #241: URL: https://github.com/apache/calcite-avatica/pull/241#discussion_r1530777139 ## core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java: ## @@ -955,10 +955,12 @@ protected Number getNumber() throws SQLException { */

Re: [PR] [CALCITE-6321] Add copy(List) method to Window class [calcite]

normanj-bitquill commented on code in PR #3736: URL: https://github.com/apache/calcite/pull/3736#discussion_r1530808516 ## core/src/main/java/org/apache/calcite/rel/core/Window.java: ## @@ -111,6 +111,14 @@ public Window(RelOptCluster cluster, RelTraitSet traitSet, RelNode

Re: [PR] [CALCITE-6321] Add copy(List) method to Window class [calcite]

normanj-bitquill commented on code in PR #3736: URL: https://github.com/apache/calcite/pull/3736#discussion_r1530716832 ## core/src/main/java/org/apache/calcite/rel/core/Window.java: ## @@ -111,6 +111,14 @@ public Window(RelOptCluster cluster, RelTraitSet traitSet, RelNode

Re: [PR] [CALCITE-6321] Add copy(List) method to Window class [calcite]

mihaibudiu commented on code in PR #3736: URL: https://github.com/apache/calcite/pull/3736#discussion_r1530774009 ## core/src/main/java/org/apache/calcite/rel/core/Window.java: ## @@ -111,6 +111,14 @@ public Window(RelOptCluster cluster, RelTraitSet traitSet, RelNode input,

Re: [PR] [CALCITE-6321] Add copy(List) method to Window class [calcite]

sonarcloud[bot] commented on PR #3736: URL: https://github.com/apache/calcite/pull/3736#issuecomment-2007784236 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6321] Add copy(List) method to Window class [calcite]

normanj-bitquill commented on code in PR #3736: URL: https://github.com/apache/calcite/pull/3736#discussion_r1530824635 ## core/src/main/java/org/apache/calcite/rel/core/Window.java: ## @@ -111,6 +111,14 @@ public Window(RelOptCluster cluster, RelTraitSet traitSet, RelNode

Re: [PR] [CALCITE-6015] AssertionError during optimization of EXTRACT expression [calcite]

mihaibudiu commented on code in PR #3435: URL: https://github.com/apache/calcite/pull/3435#discussion_r1531432890 ## site/_docs/history.md: ## @@ -57,6 +57,10 @@ other software versions as specified in gradle.properties. Bug-fixes, API changes and minor enhancements {:

Re: [PR] [CALCITE-5681] Support authorization via GRANT and REVOKE DDL commands [calcite]

YiwenWu commented on code in PR #3726: URL: https://github.com/apache/calcite/pull/3726#discussion_r1531402290 ## site/_docs/reference.md: ## @@ -3542,6 +3544,34 @@ dropFunctionStatement: truncateTableStatement: TRUNCATE TABLE name [ CONTINUE IDENTITY | RESTART

Re: [PR] [CALCITE-6248] Illegal dates are accepted by casts [calcite-avatica]

mihaibudiu commented on code in PR #238: URL: https://github.com/apache/calcite-avatica/pull/238#discussion_r1531438930 ## core/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java: ## @@ -739,6 +744,25 @@ private static int parseFraction(String v, int multiplier)

Re: [PR] [CALCITE-6282] Avatica ignores time precision when returning TIME results [calcite-avatica]

mihaibudiu commented on code in PR #241: URL: https://github.com/apache/calcite-avatica/pull/241#discussion_r1531463054 ## core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java: ## @@ -955,10 +955,12 @@ protected Number getNumber() throws SQLException { */

Re: [PR] [CALCITE-6015] AssertionError during optimization of EXTRACT expression [calcite]

sonarcloud[bot] commented on PR #3435: URL: https://github.com/apache/calcite/pull/3435#issuecomment-2008561216 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate