[jira] [Comment Edited] (CASSANDRA-19414) Skinny dev circle workflow
[ https://issues.apache.org/jira/browse/CASSANDRA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821056#comment-17821056 ] Berenguer Blasi edited comment on CASSANDRA-19414 at 2/27/24 8:29 AM: -- Trunk PR attached, everything rebased and green CI runs attached. Both PRs are the same. I'll merge tomorrow unless you spot anything wrong. Thx for the reviews! was (Author: bereng): Trunk PR attached, everything rebased and gree CI runs attached. Both PRs are the same. I'll merge tomorrow unless you spot anything wrong. Thx for the reviews! > Skinny dev circle workflow > -- > > Key: CASSANDRA-19414 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19414 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0.x, 5.x > > > CircleCi CI runs are getting pretty heavy. During dev iterations we trigger > many CI pre-commit jobs which are just an overkill. > This ticket has the purpose to purge from the pre-commit workflow all > variations of the test matrix but the vanilla one. That should enable us for > a quick and cheap to iterate *during dev*, this is not a substitute for > pre-commit . This ticket's work will serve as the basis for the upcoming > changes being discussed > [atm|https://lists.apache.org/thread/qf5c3hhz6qkpyqvbd3sppzlmftlc0bw0] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19414) Skinny dev circle workflow
[ https://issues.apache.org/jira/browse/CASSANDRA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820729#comment-17820729 ] Stefan Miklosovic edited comment on CASSANDRA-19414 at 2/26/24 2:52 PM: I have never done that and I think it is a bad practice in general. In a lot of cases one config is not even applicable to other people because of the differences in CircleCI plan, parallelism, resource classes etc ... that commit has even such commit message "DO NOT COMMIT". Anyway, to close this, just make that workflow called differently if you all think it is better and I ll somehow cope with it. was (Author: smiklosovic): I have never done that and I think it is a bad practice in general. In a lot of cases one config is not even applicable to the other because of the differences in CircleCI plan, parallelism, resource classes etc ... that commit has even such commit message "DO NOT COMMIT". > Skinny dev circle workflow > -- > > Key: CASSANDRA-19414 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19414 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0.x, 5.x > > > CircleCi CI runs are getting pretty heavy. During dev iterations we trigger > many CI pre-commit jobs which are just an overkill. > This ticket has the purpose to purge from the pre-commit workflow all > variations of the test matrix but the vanilla one. That should enable us for > a quick and cheap to iterate *during dev*, this is not a substitute for > pre-commit . This ticket's work will serve as the basis for the upcoming > changes being discussed > [atm|https://lists.apache.org/thread/qf5c3hhz6qkpyqvbd3sppzlmftlc0bw0] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19414) Skinny dev circle workflow
[
https://issues.apache.org/jira/browse/CASSANDRA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820727#comment-17820727
]
Ekaterina Dimitrova edited comment on CASSANDRA-19414 at 2/26/24 2:49 PM:
--
You forget many people cherry-pick a config commit from others and do not use
the script, [~smiklosovic]
{quote}there is always a committer looking over their shoulder.
{quote}
As a committer, I prefer clarity so we can have shorter review cycles
was (Author: e.dimitrova):
You forget many people cherry-pick a config commit from others and do not use
the script, [~smiklosovic]
> Skinny dev circle workflow
> --
>
> Key: CASSANDRA-19414
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19414
> Project: Cassandra
> Issue Type: Improvement
> Components: CI
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> CircleCi CI runs are getting pretty heavy. During dev iterations we trigger
> many CI pre-commit jobs which are just an overkill.
> This ticket has the purpose to purge from the pre-commit workflow all
> variations of the test matrix but the vanilla one. That should enable us for
> a quick and cheap to iterate *during dev*, this is not a substitute for
> pre-commit . This ticket's work will serve as the basis for the upcoming
> changes being discussed
> [atm|https://lists.apache.org/thread/qf5c3hhz6qkpyqvbd3sppzlmftlc0bw0]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19414) Skinny dev circle workflow
[ https://issues.apache.org/jira/browse/CASSANDRA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820727#comment-17820727 ] Ekaterina Dimitrova edited comment on CASSANDRA-19414 at 2/26/24 2:48 PM: -- You forget many people cherry-pick a config commit from others and do not use the script, [~smiklosovic] was (Author: e.dimitrova): You forget many people cherry-pick the config and do not use the script, [~smiklosovic] > Skinny dev circle workflow > -- > > Key: CASSANDRA-19414 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19414 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0.x, 5.x > > > CircleCi CI runs are getting pretty heavy. During dev iterations we trigger > many CI pre-commit jobs which are just an overkill. > This ticket has the purpose to purge from the pre-commit workflow all > variations of the test matrix but the vanilla one. That should enable us for > a quick and cheap to iterate *during dev*, this is not a substitute for > pre-commit . This ticket's work will serve as the basis for the upcoming > changes being discussed > [atm|https://lists.apache.org/thread/qf5c3hhz6qkpyqvbd3sppzlmftlc0bw0] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19414) Skinny dev circle workflow
[
https://issues.apache.org/jira/browse/CASSANDRA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820126#comment-17820126
]
Ekaterina Dimitrova edited comment on CASSANDRA-19414 at 2/23/24 4:42 PM:
--
{quote} We discussed this offline iirc. Creating a new workflow would be great
but it means new configs throughout, a new workflow to maintain, etc.
{quote}
Indeed, we discussed that we won't add new workflows. We may add one behind the
new flag if we want to use it.
Here is what I suggest: I pushed a patch that changes the names of the
pre-commit workflows to during_dev when using -d. Thus, it will be easier for
people to differentiate workflows. Please check and let me know what you think.
The rest of the changes look good to me.
Patch:
[https://github.com/ekaterinadimitrova2/cassandra/commit/154a0ab6d59639f7aed441fd5abb9b747b5548e1]
(line 393 should go to 421)
This is what it looks like in CircleCI:
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19406-5.0-proposal]
was (Author: e.dimitrova):
{quote} We discussed this offline iirc. Creating a new workflow would be great
but it means new configs throughout, a new workflow to maintain, etc.
{quote}
Indeed, we discussed that we won't add new workflows. We may add one behind the
new flag if we want to use it.
Here is what I suggest: I pushed a patch that changes the names of the
pre-commit workflows to during_dev when using -d. Thus, it will be easier for
people to differentiate workflows. Please check and let me know what you think.
The rest of the changes look good to me.
Patch:
[https://github.com/ekaterinadimitrova2/cassandra/commit/154a0ab6d59639f7aed441fd5abb9b747b5548e1]
This is what it looks like in CircleCI:
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19406-5.0-proposal]
> Skinny dev circle workflow
> --
>
> Key: CASSANDRA-19414
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19414
> Project: Cassandra
> Issue Type: Improvement
> Components: CI
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> CircleCi CI runs are getting pretty heavy. During dev iterations we trigger
> many CI pre-commit jobs which are just an overkill.
> This ticket has the purpose to purge from the pre-commit workflow all
> variations of the test matrix but the vanilla one. That should enable us for
> a quick and cheap to iterate *during dev*, this is not a substitute for
> pre-commit . This ticket's work will serve as the basis for the upcoming
> changes being discussed
> [atm|https://lists.apache.org/thread/qf5c3hhz6qkpyqvbd3sppzlmftlc0bw0]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19414) Skinny dev circle workflow
[
https://issues.apache.org/jira/browse/CASSANDRA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820126#comment-17820126
]
Ekaterina Dimitrova edited comment on CASSANDRA-19414 at 2/23/24 4:31 PM:
--
{quote} We discussed this offline iirc. Creating a new workflow would be great
but it means new configs throughout, a new workflow to maintain, etc.
{quote}
Indeed, we discussed that we won't add new workflows. We may add one behind the
new flag if we want to use it.
Here is what I suggest: I pushed a patch that changes the names of the
pre-commit workflows to during_dev when using -d. Thus, it will be easier for
people to differentiate workflows. Please check and let me know what you think.
The rest of the changes look good to me.
Patch:
[https://github.com/ekaterinadimitrova2/cassandra/commit/154a0ab6d59639f7aed441fd5abb9b747b5548e1]
This is what it looks like in CircleCI:
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19406-5.0-proposal]
was (Author: e.dimitrova):
{quote} We discussed this offline iirc. Creating a new workflow would be great
but it means new configs throughout, a new workflow to maintain, etc.
{quote}
Indeed, we discussed that we won't add new workflows. We may add one behind the
new flag if we want to use it.
Here is what I suggest: I pushed a patch that changes the names of the
pre-commit workflows to during_dev when using -d. Thus, it will be easier for
people to differentiate workflows. Please check and let me know what you think.
The rest of your changes look good to me.
Patch:
https://github.com/ekaterinadimitrova2/cassandra/commit/154a0ab6d59639f7aed441fd5abb9b747b5548e1
This is what it looks like in CircleCI:
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19406-5.0-proposal
> Skinny dev circle workflow
> --
>
> Key: CASSANDRA-19414
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19414
> Project: Cassandra
> Issue Type: Improvement
> Components: CI
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> CircleCi CI runs are getting pretty heavy. During dev iterations we trigger
> many CI pre-commit jobs which are just an overkill.
> This ticket has the purpose to purge from the pre-commit workflow all
> variations of the test matrix but the vanilla one. That should enable us for
> a quick and cheap to iterate *during dev*, this is not a substitute for
> pre-commit . This ticket's work will serve as the basis for the upcoming
> changes being discussed
> [atm|https://lists.apache.org/thread/qf5c3hhz6qkpyqvbd3sppzlmftlc0bw0]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19414) Skinny dev circle workflow
[ https://issues.apache.org/jira/browse/CASSANDRA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819831#comment-17819831 ] Ekaterina Dimitrova edited comment on CASSANDRA-19414 at 2/22/24 10:46 PM: --- This patch suggests a -d flag to be added for generate.sh, which changes in place the pre-commit workflow to the minimal config workflow seen [here|https://app.circleci.com/pipelines/github/bereng/cassandra/1170/workflows/7707b811-6d4e-4cff-92de-9aff85d8ee03] for JDK11 and [here|https://app.circleci.com/pipelines/github/bereng/cassandra/1170/workflows/d76e0134-61e0-4c4d-95fe-a9e214c9d3ea] for JDK 17. * [~Bereng], I think changing the pre-commit workflow to the skinny one in place is confusing. Shouldn't the flag generate a new workflow with a different name? Like during_dev_tests or so? I can see how some people will start cherry-picking config commits from others and use this config for pre-commit because it also uses the same name, and then reviewers will have to make them add the missing jobs. You will be surprised how many people use cherry-pick instead of learning how generate.sh works and using it themselves. If people learn there is a different workflow name, they will be at least cherry-picking a different commit :D * I do not see a cqlsh_dtests job? Even as one to be approved? * Why only 5.0+? How about 4.0 and 4.1, which will still be maintained for some time? The rest is nits on the PR was (Author: e.dimitrova): This patch suggests a -d flag to be added for generate.sh, which changes in place the pre-commit workflow to the minimal config workflow seen [here|https://app.circleci.com/pipelines/github/bereng/cassandra/1170/workflows/7707b811-6d4e-4cff-92de-9aff85d8ee03] for JDK11 and [here|https://app.circleci.com/pipelines/github/bereng/cassandra/1170/workflows/d76e0134-61e0-4c4d-95fe-a9e214c9d3ea] for JDK 17. * [~Bereng], I think changing the pre-commit workflow to the skinny one in place is confusing. Shouldn't the flag generate a new workflow with a different name? Like during_dev_tests or so? I can see how some people will start cherry-picking config commits from others and use this config for pre-commit because it also uses the same name, and then reviewers will have to make them add the missing jobs. You will be surprised how many people use cherry-pick instead of learning how generate.sh works and using it themselves. If people learn there is a different workflow name, they will be at least cherry-picking a different commit :D * I do not see a cqlsh_dtests job? Even as one to be approved? The rest is nits on the PR > Skinny dev circle workflow > -- > > Key: CASSANDRA-19414 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19414 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0.x, 5.x > > > CircleCi CI runs are getting pretty heavy. During dev iterations we trigger > many CI pre-commit jobs which are just an overkill. > This ticket has the purpose to purge from the pre-commit workflow all > variations of the test matrix but the vanilla one. That should enable us for > a quick and cheap to iterate *during dev*, this is not a substitute for > pre-commit . This ticket's work will serve as the basis for the upcoming > changes being discussed > [atm|https://lists.apache.org/thread/qf5c3hhz6qkpyqvbd3sppzlmftlc0bw0] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19414) Skinny dev circle workflow
[ https://issues.apache.org/jira/browse/CASSANDRA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819677#comment-17819677 ] Stefan Miklosovic edited comment on CASSANDRA-19414 at 2/22/24 2:48 PM: Bereng privately agreed we should probably remove it. edit: that is, separate workflows. was (Author: smiklosovic): Bereng privately agreed we should probably remove it. > Skinny dev circle workflow > -- > > Key: CASSANDRA-19414 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19414 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0.x, 5.x > > > CircleCi CI runs are getting pretty heavy. During dev iterations we trigger > many CI pre-commit jobs which are just an overkill. > This ticket has the purpose to purge from the pre-commit workflow all > variations of the test matrix but the vanilla one. That should enable us for > a quick and cheap to iterate *during dev*, this is not a substitute for > pre-commit . This ticket's work will serve as the basis for the upcoming > changes being discussed > [atm|https://lists.apache.org/thread/qf5c3hhz6qkpyqvbd3sppzlmftlc0bw0] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19414) Skinny dev circle workflow
[ https://issues.apache.org/jira/browse/CASSANDRA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819677#comment-17819677 ] Stefan Miklosovic edited comment on CASSANDRA-19414 at 2/22/24 2:47 PM: Bereng privately agreed we should probably remove it. was (Author: smiklosovic): Bereng offline agreed we should probably remove it. > Skinny dev circle workflow > -- > > Key: CASSANDRA-19414 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19414 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0.x, 5.x > > > CircleCi CI runs are getting pretty heavy. During dev iterations we trigger > many CI pre-commit jobs which are just an overkill. > This ticket has the purpose to purge from the pre-commit workflow all > variations of the test matrix but the vanilla one. That should enable us for > a quick and cheap to iterate *during dev*, this is not a substitute for > pre-commit . This ticket's work will serve as the basis for the upcoming > changes being discussed > [atm|https://lists.apache.org/thread/qf5c3hhz6qkpyqvbd3sppzlmftlc0bw0] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19414) Skinny dev circle workflow
[ https://issues.apache.org/jira/browse/CASSANDRA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819674#comment-17819674 ] Ekaterina Dimitrova edited comment on CASSANDRA-19414 at 2/22/24 2:41 PM: -- >From a discussion with [~bereng] the other day, this skinny thing is if you >want to run something minimum during development and skip the clicking from >the separate workflow. It will be possible to generate the config with a flag. >This does not mean that the separate workflow should be removed. There are >many times when people want to run single jobs. We should not remove it. This new config is a great improvement to save people from clicking when they use separate workflow during development to run just a minimum test suite, but it is complimentary. was (Author: e.dimitrova): >From a discussion with [~bereng] the other day, this skinny thing is if you >want to run something minimum during development and skip the clicking from >the separate workflow. It will be possible to generate the config with a flag. >This does not mean that the separate workflow should be removed. There are >many times when people want to run single jobs. We should not remove it. > Skinny dev circle workflow > -- > > Key: CASSANDRA-19414 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19414 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0.x, 5.x > > > CircleCi CI runs are getting pretty heavy. During dev iterations we trigger > many CI pre-commit jobs which are just an overkill. > This ticket has the purpose to purge from the pre-commit workflow all > variations of the test matrix but the vanilla one. That should enable us for > a quick and cheap to iterate *during dev*, this is not a substitute for > pre-commit . This ticket's work will serve as the basis for the upcoming > changes being discussed > [atm|https://lists.apache.org/thread/qf5c3hhz6qkpyqvbd3sppzlmftlc0bw0] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
