[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-23 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158593073 ## File path: server/src/com/cloud/network/IpAddressManagerImpl.java ## @@ -799,28 +798,55 @@

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-23 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158593073 ## File path: server/src/com/cloud/network/IpAddressManagerImpl.java ## @@ -799,28 +798,55 @@

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-23 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158593073 ## File path: server/src/com/cloud/network/IpAddressManagerImpl.java ## @@ -799,28 +798,55 @@

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158495419 ## File path: tools/appliance/systemvmtemplate/scripts/definition.rb ## @@ -77,7 +77,7 @@

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158495394 ## File path: tools/appliance/definitions/systemvmtemplate/preseed.cfg ## @@ -17,22 +17,35 @@

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158495264 ## File path: tools/appliance/definitions/systemvmtemplate/authorized_keys.sh ## @@ -25,5

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158495151 ## File path: test/integration/smoke/test_ssvm.py ## @@ -73,7 +73,7 @@ def

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158495014 ## File path: test/integration/smoke/test_list_ids_parameter.py ## @@ -105,20 +105,20 @@ def

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158494923 ## File path: systemvm/patches/debian/opt/cloud/bin/cs/CsRedundant.py ## @@ -74,8 +74,8 @@

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158495088 ## File path: tools/appliance/builtin/template.json ## @@ -0,0 +1,53 @@ +{ Review comment:

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158494883 ## File path: systemvm/patches/debian/config/opt/cloud/bin/setup/common.sh ## @@ -0,0 +1,862

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158494883 ## File path: systemvm/patches/debian/config/opt/cloud/bin/setup/common.sh ## @@ -0,0 +1,862

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158494622 ## File path: systemvm/patches/debian/config/opt/cloud/bin/patchsystemvm.sh ## @@ -149,11

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158494593 ## File path: systemvm/patches/debian/config/opt/cloud/bin/ipsectunnel.sh ## @@ -139,36

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158494303 ## File path: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ## @@ -70,8 +70,8 @@

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158494240 ## File path: systemvm/patches/debian/config/etc/ssh/sshd_config ## @@ -13,7 +13,6 @@ Port

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158494191 ## File path: systemvm/patches/debian/config/etc/rc.local ## @@ -1,4 +1,4 @@ -#/bin/bash

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158494158 ## File path: systemvm/patches/debian/config/etc/init.d/cloud-early-config ## @@ -48,71

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158493959 ## File path: systemvm/conf/log4j-cloud.xml ## @@ -18,64 +18,82 @@ specific language

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158494007 ## File path: systemvm/debian/opt/cloud/bin/cs/CsRedundant.py ## @@ -110,9 +107,10 @@ def

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158494007 ## File path: systemvm/debian/opt/cloud/bin/cs/CsRedundant.py ## @@ -110,9 +107,10 @@ def

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158493553 ## File path: systemvm/conf/log4j-cloud.xml ## @@ -18,64 +18,82 @@ specific language

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158493503 ## File path: engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java ## @@ -52,8

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158493483 ## File path: engine/schema/resources/META-INF/db/schema-41000to41100.sql ## @@ -489,3 +489,6

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-22 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158493405 ## File path: tools/appliance/systemvmtemplate/template.json ## @@ -0,0 +1,82 @@ +{ +

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-21 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158294932 ## File path: engine/schema/src/com/cloud/user/UserAccountVO.java ## @@ -33,6 +33,7 @@

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-21 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158236647 ## File path: systemvm/agent/conf/log4j-cloud.xml ## @@ -0,0 +1,131 @@ + + +

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-21 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158234432 ## File path: engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java ## @@ -52,8

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-21 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158234432 ## File path: engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java ## @@ -52,8

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-21 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158233166 ## File path: tools/appliance/systemvmtemplate/scripts/definition.rb ## @@ -29,7 +29,7 @@

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-21 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158232805 ## File path: python/lib/cloudutils/utilities.py ## @@ -216,8 +216,8 @@ def

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-21 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158232644 ## File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py ## @@ -80,7 +80,7 @@ def

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-19 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r157717581 ## File path: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-19 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r157717384 ## File path: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-19 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r157717384 ## File path: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-08 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r155747551 ## File path: systemvm/debian/etc/systemd/system/cloud-password-server@.service ## @@ -0,0

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-12-08 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r155745859 ## File path: systemvm/debian/etc/systemd/system/cloud-password-server@.service ## @@ -0,0

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-11-29 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r153797429 ## File path: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh ##

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-11-28 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r153578554 ## File path: tools/appliance/definitions/systemvmtemplate/configure_networking.sh ## @@

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-11-28 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r153578494 ## File path: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh ##

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-11-23 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r152745371 ## File path: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh ##

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-11-23 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r152745166 ## File path: tools/appliance/definitions/systemvmtemplate/definition.rb ## @@ -25,25 +25,19

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-11-21 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r152253028 ## File path: systemvm/patches/debian/config/opt/cloud/bin/configure.py ## @@ -172,8 +172,13

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-08-10 Thread git
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132454805 ## File path: utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-08-10 Thread git
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132454476 ## File path: tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh ##

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-08-10 Thread git
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132436288 ## File path: tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh ##

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-08-10 Thread git
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132432437 ## File path: tools/appliance/definitions/systemvmtemplate/configure_login.sh ## @@ -23,11

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-08-10 Thread git
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132431725 ## File path: tools/appliance/definitions/systemvmtemplate/configure_networking.sh ## @@

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-08-10 Thread git
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132431563 ## File path: tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh ##