[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask

2020-08-05 Thread GitBox
yangyichao-mango commented on a change in pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r465585345 ## File path: pom.xml ## @@ -783,12 +783,38 @@ **/common/utils/RetryerUtilsTest.java

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask

2020-08-03 Thread GitBox
yangyichao-mango commented on a change in pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464268239 ## File path: dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/ConditionsTaskTest.java ## @@

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask

2020-08-03 Thread GitBox
yangyichao-mango commented on a change in pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464259687 ## File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java ## @@ -16,19

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask

2020-08-03 Thread GitBox
yangyichao-mango commented on a change in pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464259687 ## File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java ## @@ -16,19

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask

2020-08-03 Thread GitBox
yangyichao-mango commented on a change in pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464259230 ## File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java ## @@ -391,7 +391,12