[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346630087 ## File path: core/src/main/java/org/apache/druid/data/input/InputRowListPlusJson.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346630028 ## File path: core/src/main/java/org/apache/druid/data/input/Firehose.java ## @@ -74,13 +74,13

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346536451 ## File path: core/src/main/java/org/apache/druid/guice/annotations/UnstableApi.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346536395 ## File path: core/src/main/java/org/apache/druid/data/input/impl/CsvReader.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346536429 ## File path: processing/src/main/java/org/apache/druid/segment/transform/Transformer.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346536351 ## File path: core/src/main/java/org/apache/druid/data/input/InputEntity.java ## @@ -0,0 +1,115

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346536378 ## File path: core/src/main/java/org/apache/druid/data/input/InputEntity.java ## @@ -0,0 +1,115

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346088626 ## File path: core/src/main/java/org/apache/druid/data/input/InputSourceReader.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346088647 ## File path: core/src/main/java/org/apache/druid/data/input/InputEntity.java ## @@ -0,0 +1,113

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346088634 ## File path: core/src/main/java/org/apache/druid/data/input/AbstractInputSource.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346088614 ## File path: core/src/main/java/org/apache/druid/data/input/TextReader.java ## @@ -0,0 +1,134

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344976325 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344951696 ## File path: core/src/main/java/org/apache/druid/data/input/InputSourceReader.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344951548 ## File path: core/src/main/java/org/apache/druid/data/input/ObjectSource.java ## @@ -50,41

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344951687 ## File path: core/src/main/java/org/apache/druid/data/input/ObjectSource.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344951666 ## File path: core/src/main/java/org/apache/druid/data/input/ObjectSource.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344951648 ## File path: core/src/main/java/org/apache/druid/data/input/InputSource.java ## @@ -0,0 +1,78

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344951516 ## File path: core/src/main/java/org/apache/druid/data/input/ObjectSource.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344951638 ## File path: core/src/main/java/org/apache/druid/data/input/FiniteFirehoseFactory.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344951623 ## File path: core/src/main/java/org/apache/druid/data/input/Formattable.java ## @@ -0,0 +1,39

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344433817 ## File path: core/src/main/java/org/apache/druid/java/util/common/FileUtils.java ## @@ -306,6

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344433322 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FileSource.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344424620 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FileSource.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422389 ## File path: core/src/test/java/org/apache/druid/data/input/impl/CsvInputFormatTest.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422376 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422402 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422407 ## File path: indexing-service/src/test/java/org/apache/druid/indexing/common/task/IndexTaskTest.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422393 ## File path: core/src/main/java/org/apache/druid/java/util/common/FileUtils.java ## @@ -306,6

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422386 ## File path: core/src/test/java/org/apache/druid/data/input/impl/JsonReaderTest.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422380 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422375 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422382 ## File path: core/src/test/java/org/apache/druid/data/input/impl/JsonReaderTest.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422405 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422397 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422347 ## File path: core/src/main/java/org/apache/druid/data/input/SplitSource.java ## @@ -0,0 +1,111

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422367 ## File path: core/src/test/java/org/apache/druid/data/input/impl/SplitIteratingReaderTest.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422359 ## File path: core/src/main/java/org/apache/druid/data/input/impl/LocalInputSource.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422338 ## File path: core/src/main/java/org/apache/druid/data/input/impl/CsvReader.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422322 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FileSource.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422315 ## File path: core/src/main/java/org/apache/druid/data/input/impl/JSONParseSpec.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422336 ## File path: core/src/main/java/org/apache/druid/data/input/impl/CsvInputFormat.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422356 ## File path: core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422320 ## File path: core/src/main/java/org/apache/druid/data/input/SplitSource.java ## @@ -0,0 +1,111

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422363 ## File path: core/src/main/java/org/apache/druid/data/input/impl/SplitIteratingReader.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422328 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422355 ## File path: core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422371 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopInputSource.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422343 ## File path: core/src/test/java/org/apache/druid/data/input/impl/CsvReaderTest.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422310 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422306 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422287 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422293 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/TaskToolbox.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422286 ## File path: core/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422296 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422291 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopDruidIndexerConfig.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422300 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@