[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r223959389 ## File path: src/executor/graph_executor.cc ## @@ -1561,15 +1561,32 @@ static

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r223937667 ## File path: src/executor/graph_executor.cc ## @@ -1561,15 +1561,32 @@ static

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r223912091 ## File path: src/executor/graph_executor.cc ## @@ -1561,15 +1561,32 @@ static

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r223906681 ## File path: src/executor/graph_executor.cc ## @@ -1561,15 +1561,32 @@ static

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r223906681 ## File path: src/executor/graph_executor.cc ## @@ -1561,15 +1561,32 @@ static

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r223906681 ## File path: src/executor/graph_executor.cc ## @@ -1561,15 +1561,32 @@ static

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r223569976 ## File path: src/operator/quantization/mkldnn/mkldnn_quantize-inl.h ## @@ -75,6

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r223378669 ## File path: src/operator/subgraph/mkldnn/mkldnn_conv_property.cc ## @@ -0,0

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r223241107 ## File path: src/operator/subgraph/subgraph_property.h ## @@ -92,6 +92,22 @@

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r223165686 ## File path: src/c_api/c_api_symbolic.cc ## @@ -696,3 +696,21 @@ int

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222604179 ## File path: tests/python/mkl/test_subgraph.py ## @@ -0,0 +1,472 @@ +# Licensed

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222603978 ## File path: src/ndarray/ndarray.cc ## @@ -1592,8 +1601,12 @@ void

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222594664 ## File path: src/c_api/c_api_symbolic.cc ## @@ -696,3 +696,21 @@ int

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222592299 ## File path: tests/python/mkl/test_subgraph.py ## @@ -0,0 +1,472 @@ +# Licensed

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222592005 ## File path: python/mxnet/contrib/quantization.py ## @@ -53,6 +53,7 @@ def

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222591350 ## File path: src/operator/subgraph/subgraph_property.h ## @@ -92,6 +92,22 @@

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r221443657 ## File path: src/operator/subgraph/mkldnn/mkldnn_conv_property.cc ## @@ -0,0

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r221416274 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@ -89,17

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r221407486 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@ -89,17

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r221407486 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@ -89,17

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r221130858 ## File path: src/operator/subgraph/mkldnn/mkldnn_conv-inl.h ## @@ -0,0 +1,48 @@

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r221126691 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@ -89,17

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220422029 ## File path: src/operator/subgraph/mkldnn/mkldnn_conv_post_quantize_property.cc

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220414425 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@ -199,33

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220409445 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@ -89,17

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220405988 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@ -89,17

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220091220 ## File path: python/mxnet/contrib/quantization.py ## @@ -408,12 +420,23 @@ def

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220079910 ## File path: python/mxnet/contrib/quantization.py ## @@ -40,7 +40,7 @@ from

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220079292 ## File path: example/quantization/imagenet_gen_qsym_mkldnn.py ## @@ -0,0 +1,213

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220034121 ## File path: src/operator/subgraph/mkldnn/mkldnn_conv-inl.h ## @@ -0,0 +1,48 @@

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220034161 ## File path: src/operator/subgraph/mkldnn/mkldnn_conv.cc ## @@ -0,0 +1,678 @@

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220034180 ## File path: src/operator/subgraph/mkldnn/mkldnn_conv.cc ## @@ -0,0 +1,678 @@

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220032850 ## File path: src/operator/quantization/mkldnn/mkldnn_quantize-inl.h ## @@ -75,6

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220032675 ## File path: src/executor/attach_op_execs_pass.cc ## @@ -180,12 +184,14 @@ class

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220032476 ## File path: src/executor/attach_op_execs_pass.cc ## @@ -159,9 +159,13 @@ class

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220032426 ## File path: include/mxnet/c_api.h ## @@ -1535,6 +1534,15 @@ MXNET_DLL int

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220031940 ## File path: src/operator/nn/mkldnn/mkldnn_convolution-inl.h ## @@ -35,19 +36,79

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r219376896 ## File path: src/operator/nn/mkldnn/mkldnn_convolution-inl.h ## @@ -35,19 +36,79

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r219376787 ## File path: src/operator/subgraph/mkldnn/mkldnn_conv.cc ## @@ -0,0 +1,670 @@

[GitHub] ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

ZhennanQin commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization. URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r219376419 ## File path: src/operator/nn/mkldnn/mkldnn_convolution.cc ## @@ -257,32 +300,59