[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-05 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r166166236 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-04 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165864917 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-04 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165864917 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165792490 ## File path: src/engine/threaded_engine.cc ## @@ -391,6 +400,11 @@ void ThreadedEngine::WaitForA

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165781254 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165781254 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165775192 ## File path: src/engine/threaded_engine.h ## @@ -476,6 +507,9 @@ class ThreadedEngine : public E

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165775147 ## File path: src/storage/gpu_device_storage.h ## @@ -62,7 +62,7 @@ inline void* GPUDeviceStorage

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165774874 ## File path: tests/python/unittest/test_exc_handling.py ## @@ -0,0 +1,112 @@ +# Licensed to the

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165774834 ## File path: include/mxnet/engine.h ## @@ -182,7 +182,7 @@ class MXNET_API Engine {

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165774551 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165773869 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165773582 ## File path: src/engine/threaded_engine.h ## @@ -175,6 +175,8 @@ class ThreadedVar final stat

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165773086 ## File path: src/engine/threaded_engine.cc ## @@ -403,7 +417,11 @@ inline void ThreadedEngine::O

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165772898 ## File path: src/engine/threaded_engine.cc ## @@ -403,7 +417,11 @@ inline void ThreadedEngine::O

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165772820 ## File path: src/engine/threaded_engine.cc ## @@ -391,6 +400,11 @@ void ThreadedEngine::WaitForA

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165772731 ## File path: src/engine/threaded_engine.cc ## @@ -356,7 +357,11 @@ void ThreadedEngine::DeleteVa

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165772677 ## File path: include/mxnet/engine.h ## @@ -182,7 +182,7 @@ class MXNET_API Engine {

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165772505 ## File path: tests/python/unittest/test_exc_handling.py ## @@ -0,0 +1,112 @@ +# Licensed to the