[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257584462 ## File path: nimble/host/include/host/ble_gap.h ## @@ -708,6 +711,47 @@ struct ble_gap_event {

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257625928 ## File path: nimble/host/src/ble_hs_hci_evt.c ## @@ -28,8 +28,6 @@ #include "ble_hs_priv.h" #include

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257595528 ## File path: nimble/host/mesh/src/prov.c ## @@ -449,7 +451,7 @@ static int prov_send_adv(struct os_mbuf

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257586646 ## File path: nimble/host/include/host/ble_gap.h ## @@ -708,6 +711,47 @@ struct ble_gap_event {

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257622012 ## File path: nimble/host/src/ble_gap.c ## @@ -2919,13 +3049,533 @@ ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257590465 ## File path: nimble/host/include/host/ble_gap.h ## @@ -913,6 +966,28 @@ int ble_gap_ext_adv_stop(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257635790 ## File path: porting/nimble/include/syscfg/syscfg.h ## @@ -389,6 +389,10 @@ #define

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257596832 ## File path: nimble/host/src/ble_gap.c ## @@ -128,6 +129,13 @@ struct ble_gap_master_state {

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257623756 ## File path: nimble/host/src/ble_hs_hci_cmd.c ## @@ -1605,6 +1605,167 @@

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257595895 ## File path: nimble/host/mesh/src/proxy.c ## @@ -417,7 +417,7 @@ void bt_mesh_proxy_beacon_send(struct

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257619010 ## File path: nimble/host/src/ble_gap.c ## @@ -2919,13 +3049,533 @@ ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257628078 ## File path: nimble/host/src/ble_hs_periodic_disc.c ## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257612951 ## File path: nimble/host/src/ble_gap.c ## @@ -1353,15 +1477,15 @@ ble_gap_rx_conn_complete(struct

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257617713 ## File path: nimble/host/src/ble_gap.c ## @@ -2919,13 +3049,533 @@ ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257625038 ## File path: nimble/host/src/ble_hs_hci_cmd.c ## @@ -1605,6 +1605,167 @@

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257617433 ## File path: nimble/host/src/ble_gap.c ## @@ -2919,13 +3049,533 @@ ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257606400 ## File path: nimble/host/src/ble_gap.c ## @@ -182,11 +194,14 @@ struct ble_gap_snapshot { void

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257607496 ## File path: nimble/host/src/ble_gap.c ## @@ -1315,6 +1333,112 @@ ble_gap_rx_adv_set_terminated(struct

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257633933 ## File path: nimble/host/src/ble_hs_stop.c ## @@ -71,8 +111,8 @@ ble_hs_stop_terminate_next_conn(void)

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257636645 ## File path: nimble/syscfg.yml ## @@ -34,6 +34,10 @@ syscfg.defs: BLE_MAX_CONNECTIONS:

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257616398 ## File path: nimble/host/src/ble_gap.c ## @@ -2919,13 +3049,533 @@ ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257620884 ## File path: nimble/host/src/ble_gap.c ## @@ -2919,13 +3049,533 @@ ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257617527 ## File path: nimble/host/src/ble_gap.c ## @@ -2919,13 +3049,533 @@ ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257617850 ## File path: nimble/host/src/ble_gap.c ## @@ -2919,13 +3049,533 @@ ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257627439 ## File path: nimble/host/src/ble_hs_hci_evt.c ## @@ -631,7 +709,8 @@

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257617349 ## File path: nimble/host/src/ble_gap.c ## @@ -2919,13 +3049,533 @@ ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257619204 ## File path: nimble/host/src/ble_gap.c ## @@ -2919,13 +3049,533 @@ ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257635662 ## File path: porting/nimble/include/syscfg/syscfg.h ## @@ -378,7 +378,7 @@ /*** nimble */ #ifndef

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257635867 ## File path: porting/nimble/include/syscfg/syscfg.h ## @@ -418,6 +422,11 @@ #define

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257628177 ## File path: nimble/host/src/ble_hs_periodic_disc.c ## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257602282 ## File path: nimble/host/src/ble_gap.c ## @@ -155,6 +163,10 @@ struct ble_gap_slave_state { unsigned

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257629476 ## File path: nimble/host/src/ble_hs_periodic_disc_priv.h ## @@ -0,0 +1,63 @@ +/* + * Licensed to the

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257618851 ## File path: nimble/host/src/ble_gap.c ## @@ -2919,13 +3049,533 @@ ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257623578 ## File path: nimble/host/src/ble_hs_hci_cmd.c ## @@ -1605,6 +1605,167 @@

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257584500 ## File path: nimble/host/include/host/ble_gap.h ## @@ -708,6 +711,47 @@ struct ble_gap_event {

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-02-18 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257618690 ## File path: nimble/host/src/ble_gap.c ## @@ -2919,13 +3049,533 @@ ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250656047 ## File path: nimble/host/include/host/ble_gap.h ## @@ -969,23 +969,23 @@ int

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250689134 ## File path: nimble/host/src/ble_gap.c ## @@ -1355,7 +1377,7 @@ ble_gap_rx_per_adv_sync_estab(struct

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250689904 ## File path: nimble/host/src/ble_gap.c ## @@ -1388,23 +1410,33 @@ ble_gap_rx_per_adv_rpt(struct

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250681768 ## File path: nimble/host/src/ble_gap.c ## @@ -1336,14 +1336,36 @@ ble_gap_rx_adv_set_terminated(struct

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250682665 ## File path: nimble/host/src/ble_gap.c ## @@ -1336,14 +1336,36 @@ ble_gap_rx_adv_set_terminated(struct

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250625641 ## File path: nimble/include/nimble/hci_common.h ## @@ -984,12 +1001,23 @@ struct hci_ext_adv_params

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250688315 ## File path: nimble/host/include/host/ble_gap.h ## @@ -969,23 +969,23 @@ int

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250629567 ## File path: nimble/host/src/ble_hs_hci_priv.h ## @@ -235,6 +235,48 @@

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250683320 ## File path: nimble/host/src/ble_gap.c ## @@ -1336,14 +1336,36 @@ ble_gap_rx_adv_set_terminated(struct

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250625758 ## File path: nimble/include/nimble/hci_common.h ## @@ -984,12 +1001,23 @@ struct hci_ext_adv_params

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250695263 ## File path: nimble/host/src/ble_gap.c ## @@ -1336,14 +1336,36 @@ ble_gap_rx_adv_set_terminated(struct

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250625027 ## File path: porting/nimble/include/syscfg/syscfg.h ## @@ -378,7 +378,7 @@ /*** nimble */ #ifndef

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-24 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250625159 ## File path: porting/nimble/include/syscfg/syscfg.h ## @@ -418,6 +418,11 @@ #define

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-17 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r248716373 ## File path: nimble/host/include/host/ble_gap.h ## @@ -913,6 +966,28 @@ int ble_gap_ext_adv_stop(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-17 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r248564637 ## File path: nimble/host/src/ble_gap.c ## @@ -2915,8 +2985,515 @@ ble_gap_ext_adv_remove(uint8_t instance)

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-17 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r248563114 ## File path: nimble/host/src/ble_hs_dbg.c ## @@ -675,7 +676,7 @@ ble_hs_dbg_event_disp(uint8_t *evbuf)

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-17 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r248564324 ## File path: nimble/include/nimble/hci_common.h ## @@ -552,9 +552,17 @@ extern "C" { /* --- LE set

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-17 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r248563641 ## File path: nimble/host/src/ble_hs_hci_evt.c ## @@ -20,14 +20,14 @@ #include #include #include

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246777201 ## File path: nimble/host/src/ble_hs_dbg.c ## @@ -675,7 +676,7 @@ ble_hs_dbg_event_disp(uint8_t *evbuf)

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246772097 ## File path: nimble/host/include/host/ble_gap.h ## @@ -913,6 +966,28 @@ int ble_gap_ext_adv_stop(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246743021 ## File path: nimble/host/src/ble_gap.c ## @@ -2915,8 +2985,515 @@ ble_gap_ext_adv_remove(uint8_t instance)

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246771377 ## File path: nimble/host/include/host/ble_gap.h ## @@ -913,6 +966,28 @@ int ble_gap_ext_adv_stop(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246742609 ## File path: nimble/host/src/ble_gap.c ## @@ -2915,8 +2985,515 @@ ble_gap_ext_adv_remove(uint8_t instance)

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246773685 ## File path: nimble/host/src/ble_gap.c ## @@ -2915,8 +2985,515 @@ ble_gap_ext_adv_remove(uint8_t instance)

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246774743 ## File path: nimble/host/src/ble_gap.c ## @@ -2915,8 +2985,515 @@ ble_gap_ext_adv_remove(uint8_t instance)

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246775167 ## File path: nimble/host/src/ble_gap.c ## @@ -2915,8 +2985,515 @@ ble_gap_ext_adv_remove(uint8_t instance)

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246755740 ## File path: nimble/host/src/ble_gap.c ## @@ -1033,7 +1033,7 @@ ble_gap_conn_broken(uint16_t conn_handle,

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246760551 ## File path: nimble/host/src/ble_gap.c ## @@ -1315,6 +1315,76 @@ ble_gap_rx_adv_set_terminated(struct

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246783111 ## File path: nimble/host/src/ble_hs_startup.c ## @@ -256,12 +256,15 @@

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246792196 ## File path: nimble/include/nimble/hci_common.h ## @@ -552,9 +552,17 @@ extern "C" { /* --- LE set

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246739108 ## File path: nimble/host/include/host/ble_gap.h ## @@ -124,6 +124,9 @@ struct hci_conn_update; #define

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246776456 ## File path: nimble/host/src/ble_gap.c ## @@ -3478,7 +4055,7 @@ ble_gap_ext_conn_create_tx(

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246776946 ## File path: nimble/host/src/ble_gap_priv.h ## @@ -82,6 +82,11 @@ void ble_gap_rx_le_scan_timeout(void);

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246779124 ## File path: nimble/host/src/ble_hs_hci_evt.c ## @@ -92,14 +94,18 @@ static const struct

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246777301 ## File path: nimble/host/src/ble_hs_hci_cmd.c ## @@ -1605,6 +1605,119 @@

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246755098 ## File path: nimble/host/include/host/ble_gap.h ## @@ -913,6 +966,28 @@ int ble_gap_ext_adv_stop(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246773258 ## File path: nimble/host/src/ble_gap.c ## @@ -2915,8 +2985,515 @@ ble_gap_ext_adv_remove(uint8_t instance)

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246779059 ## File path: nimble/host/src/ble_hs_hci_evt.c ## @@ -92,14 +94,18 @@ static const struct

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246780701 ## File path: nimble/host/src/ble_hs_hci_evt.c ## @@ -620,6 +626,73 @@

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246778276 ## File path: nimble/host/src/ble_hs_hci_cmd.c ## @@ -1605,6 +1605,119 @@

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246784139 ## File path: nimble/include/nimble/hci_common.h ## @@ -552,9 +552,17 @@ extern "C" { /* --- LE set

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246780280 ## File path: nimble/host/src/ble_hs_hci_evt.c ## @@ -20,14 +20,14 @@ #include #include #include

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

2019-01-10 Thread GitBox
rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246779326 ## File path: nimble/host/src/ble_hs_hci_evt.c ## @@ -620,6 +626,73 @@