[GitHub] mkiiskila commented on a change in pull request #66: image: Add support for RSA-PSS signatures

mkiiskila commented on a change in pull request #66: image: Add support for RSA-PSS signatures URL: https://github.com/apache/incubator-mynewt-newt/pull/66#discussion_r121031912 ## File path: newt/image/image.go ## @@ -46,6 +46,10 @@ import (

[GitHub] ccollins476ad commented on a change in pull request #293: apps/btshell: add bletiny clone that uses new shell

ccollins476ad commented on a change in pull request #293: apps/btshell: add bletiny clone that uses new shell URL: https://github.com/apache/incubator-mynewt-core/pull/293#discussion_r121025656 ## File path: net/nimble/host/src/ble_gatts.c ## @@ -2080,6 +2080,141 @@

[GitHub] wes3 opened a new pull request #321: No jira ticket: remove unnecessary calls to os_cputime_timer_stop

wes3 opened a new pull request #321: No jira ticket: remove unnecessary calls to os_cputime_timer_stop URL: https://github.com/apache/incubator-mynewt-core/pull/321 If the only way the timer expiration function can be called is from the timer callback there is no need to stop the

[GitHub] ccollins476ad opened a new pull request #322: MYNEWT-775 Crash; unaligned accesses: CoAP parsing

ccollins476ad opened a new pull request #322: MYNEWT-775 Crash; unaligned accesses: CoAP parsing URL: https://github.com/apache/incubator-mynewt-core/pull/322 This change is briefly described in https://issues.apache.org/jira/browse/MYNEWT-775.

[GitHub] cwanda opened a new pull request #198: MYNEWT-762 Doc Update for 1.1 newtmgr conn add format

cwanda opened a new pull request #198: MYNEWT-762 Doc Update for 1.1 newtmgr conn add format URL: https://github.com/apache/incubator-mynewt-site/pull/198 1) Removed addr and addrtype from var-name. All ble addressing information are specified in the connstring. 2) serial and

[GitHub] IMGJulian closed pull request #319: hw: mcu: pic32mz2048efg100: Reduce code duplication in hal_uart

IMGJulian closed pull request #319: hw: mcu: pic32mz2048efg100: Reduce code duplication in hal_uart URL: https://github.com/apache/incubator-mynewt-core/pull/319 This is an automated message from the Apache Git Service. To

[GitHub] IMGJulian closed pull request #316: hw: mcu: pic32mz2048efg100: Implement hal_reset_cause

IMGJulian closed pull request #316: hw: mcu: pic32mz2048efg100: Implement hal_reset_cause URL: https://github.com/apache/incubator-mynewt-core/pull/316 This is an automated message from the Apache Git Service. To respond

[GitHub] francois-berder opened a new pull request #320: hw: mcu: pic32mz2048efg100: Reduce number of UART TX interrupts

francois-berder opened a new pull request #320: hw: mcu: pic32mz2048efg100: Reduce number of UART TX interrupts URL: https://github.com/apache/incubator-mynewt-core/pull/320 The UART TXIF flag is set when there is some space in the TX FIFO. In the current implementation, only one byte

[GitHub] francois-berder opened a new pull request #319: hw: mcu: pic32mz2048efg100: Reduce code duplication

francois-berder opened a new pull request #319: hw: mcu: pic32mz2048efg100: Reduce code duplication URL: https://github.com/apache/incubator-mynewt-core/pull/319 Signed-off-by: Francois Berder This is

[GitHub] mkiiskila closed pull request #60: image erase command

mkiiskila closed pull request #60: image erase command URL: https://github.com/apache/incubator-mynewt-newt/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] ccollins476ad closed pull request #288: MYNEWT-742 Initialize OIC automatically.

ccollins476ad closed pull request #288: MYNEWT-742 Initialize OIC automatically. URL: https://github.com/apache/incubator-mynewt-core/pull/288 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mkiiskila commented on a change in pull request #318: MYNEWT-681 remove flash write protection in download scripts

mkiiskila commented on a change in pull request #318: MYNEWT-681 remove flash write protection in download scripts URL: https://github.com/apache/incubator-mynewt-core/pull/318#discussion_r120980684 ## File path: hw/bsp/rb-nano2/rb-nano2_download.sh ## @@ -37,6 +37,15

[GitHub] vrahane closed pull request #317: mn_socket: Unix domain socket support.

vrahane closed pull request #317: mn_socket: Unix domain socket support. URL: https://github.com/apache/incubator-mynewt-core/pull/317 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] mkiiskila commented on a change in pull request #66: image: Add support for RSA-PSS signatures

mkiiskila commented on a change in pull request #66: image: Add support for RSA-PSS signatures URL: https://github.com/apache/incubator-mynewt-newt/pull/66#discussion_r120978879 ## File path: newt/image/image.go ## @@ -46,6 +46,10 @@ import (

[GitHub] sjanc closed pull request #311: MYNEWT-738: Fix parameter arrays

sjanc closed pull request #311: MYNEWT-738: Fix parameter arrays URL: https://github.com/apache/incubator-mynewt-core/pull/311 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] mkiiskila commented on issue #288: MYNEWT-742 Initialize OIC automatically.

mkiiskila commented on issue #288: MYNEWT-742 Initialize OIC automatically. URL: https://github.com/apache/incubator-mynewt-core/pull/288#issuecomment-307205836 Rest of the changes are ok, BTW. I would just remove oc_ev_start/oc_event_start().

[GitHub] d3zd3z commented on a change in pull request #66: image: Add support for RSA-PSS signatures

d3zd3z commented on a change in pull request #66: image: Add support for RSA-PSS signatures URL: https://github.com/apache/incubator-mynewt-newt/pull/66#discussion_r120989575 ## File path: newt/image/image.go ## @@ -46,6 +46,10 @@ import (

[GitHub] wes3 commented on issue #322: MYNEWT-775 Crash; unaligned accesses: CoAP parsing

wes3 commented on issue #322: MYNEWT-775 Crash; unaligned accesses: CoAP parsing URL: https://github.com/apache/incubator-mynewt-core/pull/322#issuecomment-307231501 Changes look good. This is an automated message from the

[GitHub] wes3 closed pull request #321: No jira ticket: remove unnecessary calls to os_cputime_timer_stop

wes3 closed pull request #321: No jira ticket: remove unnecessary calls to os_cputime_timer_stop URL: https://github.com/apache/incubator-mynewt-core/pull/321 This is an automated message from the Apache Git Service. To

[GitHub] ccollins476ad closed pull request #322: MYNEWT-775 Crash; unaligned accesses: CoAP parsing

ccollins476ad closed pull request #322: MYNEWT-775 Crash; unaligned accesses: CoAP parsing URL: https://github.com/apache/incubator-mynewt-core/pull/322 This is an automated message from the Apache Git Service. To respond

[GitHub] ccollins476ad closed pull request #323: MYNEWT-774 Serial errors in newtmgr messages

ccollins476ad closed pull request #323: MYNEWT-774 Serial errors in newtmgr messages URL: https://github.com/apache/incubator-mynewt-core/pull/323 This is an automated message from the Apache Git Service. To respond to the

[GitHub] vrahane commented on a change in pull request #318: MYNEWT-681 remove flash write protection in download scripts

vrahane commented on a change in pull request #318: MYNEWT-681 remove flash write protection in download scripts URL: https://github.com/apache/incubator-mynewt-core/pull/318#discussion_r120995342 ## File path: hw/bsp/rb-nano2/rb-nano2_download.sh ## @@ -37,6 +37,15 @@

[GitHub] ccollins476ad commented on a change in pull request #293: apps/btshell: add bletiny clone that uses new shell

ccollins476ad commented on a change in pull request #293: apps/btshell: add bletiny clone that uses new shell URL: https://github.com/apache/incubator-mynewt-core/pull/293#discussion_r121020741 ## File path: net/nimble/host/src/ble_gatts.c ## @@ -2080,6 +2080,141 @@

[GitHub] ccollins476ad commented on a change in pull request #293: apps/btshell: add bletiny clone that uses new shell

ccollins476ad commented on a change in pull request #293: apps/btshell: add bletiny clone that uses new shell URL: https://github.com/apache/incubator-mynewt-core/pull/293#discussion_r121022811 ## File path: apps/btshell/src/parse.c ## @@ -0,0 +1,611 @@ +/* Review

[GitHub] ccollins476ad commented on a change in pull request #293: apps/btshell: add bletiny clone that uses new shell

ccollins476ad commented on a change in pull request #293: apps/btshell: add bletiny clone that uses new shell URL: https://github.com/apache/incubator-mynewt-core/pull/293#discussion_r121022904 ## File path: apps/btshell/src/cmd.c ## @@ -0,0 +1,2515 @@ +/* + * Licensed