chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431606971
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockMultiValIterator.java
##
@@ -18,33 +18,15 @@
*/
package
chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431615072
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/AndDocIdSet.java
##
@@ -0,0 +1,156 @@
+/**
+ * Licensed to the
harleyjj opened a new pull request #5460:
URL: https://github.com/apache/incubator-pinot/pull/5460
## Description
1) Removes Bower and packages that depend on Bower
2) Uses standard ember-c3 instead of the custom c3 built before, due to
Bower dependency
chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431604976
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockSingleValIterator.java
##
@@ -18,37 +18,17 @@
*/
package
chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431604799
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockDocIdSet.java
##
@@ -21,6 +21,4 @@
public interface BlockDocIdSet {
chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431604484
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockMultiValIterator.java
##
@@ -18,33 +18,15 @@
*/
package
chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431606505
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockValIterator.java
##
@@ -20,9 +20,23 @@
public interface
chenboat commented on pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#issuecomment-635136647
This PR is too big to review effectively IMO. 89 files in total. Can you
break it down to 3-4 smaller PRs for review: one covering method removal; 1 or
2 PR each
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at c7c941a Adding transform function support for case-when-else
This branch includes
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 5bf635da66507bfbc0a226553a67fd3d6054916b
Author: Xiang Fu
AuthorDate: Tue May 26
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit c7c941a5b4fe51bfb1b81bd57fb7040ca9413061
Author: Xiang Fu
AuthorDate: Wed May 27
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 5a97ea4025113740e036d68888963f945b0c
Author: Xiang Fu
AuthorDate: Wed May 27
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard c7c941a Adding transform function support for case-when-else
new 5a97ea4
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 5a97ea4 Adding transform function support for case-when-else
new 83d9af5
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 83d9af59a23fb3a18c9e41489b4365acff83ffdd
Author: Xiang Fu
AuthorDate: Wed May 27
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 720c9688b4ebd0bc717864d6f2a8cfeee6fb6813
Author: Xiang Fu
AuthorDate: Wed May 27
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 83d9af5 Adding transform function support for case-when-else
new 720c968
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 3e7d64f82cfc51fda4840dc17aa94bd7d0d79dbb
Author: Xiang Fu
AuthorDate: Wed May 27
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 83f81c1 Adding transform function support for case-when-else
new 3e7d64f
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard ceef961 Adding transform function support for case-when-else
add fbace8b
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 83f81c157d3755aeaa3f26c777960219777a61af
Author: Xiang Fu
AuthorDate: Wed May 27
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 720c968 Adding transform function support for case-when-else
new 83f81c1
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 3e7d64f Adding transform function support for case-when-else
add ceef961
KKcorps opened a new issue #5462:
URL: https://github.com/apache/incubator-pinot/issues/5462
Currently the Generic Transform function only supports the single value
scalar functions and not the multivalue ones. This support needs to be added.
xiaohui-sun commented on a change in pull request #5435:
URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431942838
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java
##
@@ -160,14
jihaozh commented on a change in pull request #5435:
URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r432004017
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java
##
@@ -160,14 +155,12
npawar closed issue #2583:
URL: https://github.com/apache/incubator-pinot/issues/2583
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
npawar commented on issue #2583:
URL:
https://github.com/apache/incubator-pinot/issues/2583#issuecomment-635477885
closing this issue, as this was completed a while ago
This is an automated message from the Apache Git
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch support_case_when_statement
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard fbace8b Adding transform function support for case-when-else
add 5667776
npawar commented on pull request #5455:
URL: https://github.com/apache/incubator-pinot/pull/5455#issuecomment-635445884
> Shall we use temp directory or use current directory with better structure?
> I remember @kishoreg mentioned some issue users facing about the temp dir?
What
xiaohui-sun commented on a change in pull request #5435:
URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431935559
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/AnomalyResource.java
##
@@ -101,21 +99,18
Jackie-Jiang commented on pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#issuecomment-635539613
> This PR is too big to review effectively IMO. 89 files in total. Can you
break it down to 3-4 smaller PRs for review: one covering method removal; 1 or
2 PR each
kishoreg commented on a change in pull request #5440:
URL: https://github.com/apache/incubator-pinot/pull/5440#discussion_r432148125
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/StringFunctions.java
##
@@ -0,0 +1,123 @@
+/**
+ * Licensed to the
npawar opened a new issue #5463:
URL: https://github.com/apache/incubator-pinot/issues/5463
Noticed today that adding a schema with a field missing in a spec resulted
in just 500 error with message "Failed to add schema". See below example,
`timeType` is missing in the spec.
```
{
Jackie-Jiang commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r432043014
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockDocIdSet.java
##
@@ -21,6 +21,4 @@
public interface BlockDocIdSet
Jackie-Jiang commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r432060103
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/AndDocIdSet.java
##
@@ -0,0 +1,156 @@
+/**
+ * Licensed to
kishoreg commented on a change in pull request #5445:
URL: https://github.com/apache/incubator-pinot/pull/5445#discussion_r432146659
##
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickStartCommand.java
##
@@ -34,6 +34,9 @@
@Option(name =
kishoreg commented on a change in pull request #5441:
URL: https://github.com/apache/incubator-pinot/pull/5441#discussion_r432151926
##
File path: .gitignore
##
@@ -44,4 +44,8 @@ yarn.lock
npm-debug.log*
yarn-debug.log*
-yarn-error.log*
\ No newline at end of file
npawar opened a new pull request #5464:
URL: https://github.com/apache/incubator-pinot/pull/5464
## Description
TransformFunction was being ignored when adding schema via swagger. Worked
fine if reading Schema file, or Schema object, hence went undetected in some of
the transform field
Jackie-Jiang commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r432045689
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/AndDocIdSet.java
##
@@ -0,0 +1,156 @@
+/**
+ * Licensed to
This is an automated email from the ASF dual-hosted git repository.
nehapawar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 94aad60 Include transformFunction
npawar merged pull request #5464:
URL: https://github.com/apache/incubator-pinot/pull/5464
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
fx19880617 closed issue #5423:
URL: https://github.com/apache/incubator-pinot/issues/5423
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fx19880617 merged pull request #5425:
URL: https://github.com/apache/incubator-pinot/pull/5425
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 6d92937 Update k8s superset scripts
This is an automated email from the ASF dual-hosted git repository.
kishoreg pushed a change to branch ignore-quickstart-files
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 7aa6a60 Adding files generated by running quickstart to gitignore
add 5223abf
Jackie-Jiang commented on pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#issuecomment-635648350
Removed the changes not closely related to the enhancement to reduce the
size of the change
This
fx19880617 edited a comment on pull request #5461:
URL: https://github.com/apache/incubator-pinot/pull/5461#issuecomment-635662402
> very nicely done!. You made it look simple.
>
> Check the datatypes compatibility of left and right transform functions.
>
> What happens if the
mcvsubbu commented on a change in pull request #5459:
URL: https://github.com/apache/incubator-pinot/pull/5459#discussion_r432180426
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java
##
@@ -51,7 +51,7 @@
import
Jackie-Jiang commented on a change in pull request #5459:
URL: https://github.com/apache/incubator-pinot/pull/5459#discussion_r432207006
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java
##
@@ -51,7 +51,7 @@
import
harleyjj opened a new pull request #5466:
URL: https://github.com/apache/incubator-pinot/pull/5466
## Description
1) Removes dead components from frontend code
2) Fixes minor bugs with Report Anomaly Modal and Delete Anomaly Modal
siddharthteotia edited a comment on pull request #5409:
URL: https://github.com/apache/incubator-pinot/pull/5409#issuecomment-635650062
Here are the JMH results: cc @kishoreg @Jackie-Jiang
`
Benchmark | Score | Mode
-- | -- | --
siddharthteotia edited a comment on pull request #5409:
URL: https://github.com/apache/incubator-pinot/pull/5409#issuecomment-635650062
Here are the JMH results: cc @kishoreg @Jackie-Jiang
Benchmark | Score | Mode
-- | -- | --
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch default_pinot_startable_to_use_config_files
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 8626188 Adding more config alias
discard 51b3e96 Make Pinot
siddharthteotia edited a comment on pull request #5409:
URL: https://github.com/apache/incubator-pinot/pull/5409#issuecomment-635650062
Here are the JMH results: cc @kishoreg @Jackie-Jiang
Please see the
mcvsubbu commented on a change in pull request #5459:
URL: https://github.com/apache/incubator-pinot/pull/5459#discussion_r432213242
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java
##
@@ -51,7 +51,7 @@
import
Jackie-Jiang commented on a change in pull request #5459:
URL: https://github.com/apache/incubator-pinot/pull/5459#discussion_r432246733
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java
##
@@ -51,7 +51,7 @@
import
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a commit to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 75f58bc279988d3818969bd9b8ce850b82202eaa
Author: Haibo Wang
AuthorDate: Thu May 28 21:15:15 2020
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a commit to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 0ee908370bbca888bac5356304e1217391d54f78
Author: Haibo Wang
AuthorDate: Thu May 28 22:00:09 2020
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a commit to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit e425f5ae5a77955748cefcee94b92ebcbcd2559f
Author: Haibo Wang
AuthorDate: Thu May 28 21:59:47 2020
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a change to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 0ee9083 [maven-release-plugin] prepare for next development iteration
This branch includes the
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a commit to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit f26f19b674604dbd7afce9e81954198b245e4338
Author: Xiang Fu
AuthorDate: Wed May 27 21:55:14 2020
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch enhance_quickstart
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 7504fbc Update Quickstart to take tmp dir as a parameter and default
to current dir
add
fx19880617 commented on a change in pull request #5445:
URL: https://github.com/apache/incubator-pinot/pull/5445#discussion_r432157695
##
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickStartCommand.java
##
@@ -34,6 +34,9 @@
@Option(name =
siddharthteotia commented on pull request #5409:
URL: https://github.com/apache/incubator-pinot/pull/5409#issuecomment-635647360
Address the review comments. Please take another look. This is standalone
code at this point so want to get this in sooner and put up follow-ups in next
couple
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a commit to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit b359badceadcfcb3e27634a5ed2e2af6eff8e610
Author: Haibo Wang
AuthorDate: Thu May 28 20:48:59 2020
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a change to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at b359bad [maven-release-plugin] prepare release release-0.4.0-rc2
This branch includes the
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a commit to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit f26f19b674604dbd7afce9e81954198b245e4338
Author: Xiang Fu
AuthorDate: Wed May 27 21:55:14 2020
siddharthteotia commented on a change in pull request #5409:
URL: https://github.com/apache/incubator-pinot/pull/5409#discussion_r432163975
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/util/PinotDataBitSetV2.java
##
@@ -0,0 +1,516 @@
+/**
+ * Licensed to
fx19880617 commented on pull request #5461:
URL: https://github.com/apache/incubator-pinot/pull/5461#issuecomment-635662402
> very nicely done!. You made it look simple.
>
> Check the datatypes compatibility of left and right transform functions.
>
> What happens if the right
mayankshriv opened a new pull request #5465:
URL: https://github.com/apache/incubator-pinot/pull/5465
1. Support a variation of theta sketch based distinct count aggregation
function that returns
serialized bytes of the final aggregated sketch, instead of the actual
distinct value.
mcvsubbu commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r432211637
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/AndDocIdIterator.java
##
@@ -18,112 +18,52 @@
*/
Jackie-Jiang commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r432244794
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/AndDocIdIterator.java
##
@@ -18,112 +18,52 @@
*/
kishoreg commented on a change in pull request #5461:
URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r432162832
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java
##
@@ -0,0 +1,114
siddharthteotia edited a comment on pull request #5409:
URL: https://github.com/apache/incubator-pinot/pull/5409#issuecomment-635647360
Address the review comments. Please take another look. This is standalone
code at this point so want to get this in sooner and put up follow-ups in next
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a change to tag release-0.4.0
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 0ee9083 (commit)
No new revisions were added by this update.
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch enhance_log4j
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 72c7411 Update log4j2.xml
discard 9b7be2f Update Pinot-admin and quickstart log4j config
siddharthteotia commented on pull request #5409:
URL: https://github.com/apache/incubator-pinot/pull/5409#issuecomment-635650062
Here are the JMH results:
`
Benchmark | Score | Mode
-- | -- | --
BenchmarkPinotDataBitSet.twoBitBulkWithGaps | 28.537 ops/ms |
siddharthteotia edited a comment on pull request #5409:
URL: https://github.com/apache/incubator-pinot/pull/5409#issuecomment-635650062
Here are the JMH results: cc @kishoreg @Jackie-Jiang
Please see the spreadsheet for additional performance numbers obtained via
manual
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a commit to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit e425f5ae5a77955748cefcee94b92ebcbcd2559f
Author: Haibo Wang
AuthorDate: Thu May 28 21:59:47 2020
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a commit to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit f26f19b674604dbd7afce9e81954198b245e4338
Author: Xiang Fu
AuthorDate: Wed May 27 21:55:14 2020
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a commit to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 75f58bc279988d3818969bd9b8ce850b82202eaa
Author: Haibo Wang
AuthorDate: Thu May 28 21:15:15 2020
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a commit to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/release-0.4.0-rc2 by this push:
new ead32f1
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a change to annotated tag release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
*** WARNING: tag release-0.4.0-rc2 was modified! ***
from e425f5a (commit)
to b4269a6
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a change to branch release-0.4.0-rc2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at e425f5a [maven-release-plugin] prepare release release-0.4.0-rc2
This branch includes the
85 matches
Mail list logo
