[GitHub] [incubator-pinot] adriancole commented on pull request #6039: WIP: ServiceManager ADD_TABLE role

adriancole commented on pull request #6039: URL: https://github.com/apache/incubator-pinot/pull/6039#issuecomment-706963614 nagging https://github.com/apache/incubator-pinot/issues/5975 as ran into it again. This is an

[GitHub] [incubator-pinot] adriancole commented on pull request #6039: WIP: ServiceManager ADD_TABLE role

adriancole commented on pull request #6039: URL: https://github.com/apache/incubator-pinot/pull/6039#issuecomment-707063779 functionally, this works if the "add table" commands are done last (because effectively, you end up needing to wait for everything anyway). Verified here

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6131: F master fix

fx19880617 commented on a change in pull request #6131: URL: https://github.com/apache/incubator-pinot/pull/6131#discussion_r503389188 ## File path: Dockerfile.jdk14 ## @@ -0,0 +1,74 @@ +# Review comment: should you put this under thirdeye/docker ?

[GitHub] [incubator-pinot] venkatvghub closed pull request #6130: F master fix

venkatvghub closed pull request #6130: URL: https://github.com/apache/incubator-pinot/pull/6130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] venkatvghub commented on pull request #6130: F master fix

venkatvghub commented on pull request #6130: URL: https://github.com/apache/incubator-pinot/pull/6130#issuecomment-707011270 Invalid This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] venkatvghub opened a new pull request #6130: F master fix

venkatvghub opened a new pull request #6130: URL: https://github.com/apache/incubator-pinot/pull/6130 ## Description - Merges from upstream master - Adds support for drone, JDK 14 and Mysql 8 ## Documentation If you have introduced a new feature or configuration, please add it

[GitHub] [incubator-pinot] venkatvghub opened a new pull request #6131: F master fix

venkatvghub opened a new pull request #6131: URL: https://github.com/apache/incubator-pinot/pull/6131 ## Description - Adds drone.yml - Adds support for java 11+ - Updates mysql connector to 8+ - Adds custom Docker file for above changes

[GitHub] [incubator-pinot] codecov-io commented on pull request #6133: Remove flaky test from SegmentReducerTest

codecov-io commented on pull request #6133: URL: https://github.com/apache/incubator-pinot/pull/6133#issuecomment-707295123 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6133?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6129: Issue #4854 Framework for adding compatibility tests

sajjad-moradi commented on a change in pull request #6129: URL: https://github.com/apache/incubator-pinot/pull/6129#discussion_r503461466 ## File path: compatibility-verifier/compCheck.sh ## @@ -157,20 +181,27 @@ fi # Setup initial cluster with olderCommit and do rolling

[GitHub] [incubator-pinot] mcvsubbu opened a new issue #6132: Intermittent failures in SegmentReducerTest

mcvsubbu opened a new issue #6132: URL: https://github.com/apache/incubator-pinot/issues/6132 We see this occasionally: Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.924 sec <<< FAILURE! - in org.apache.pinot.core.segment.processing.framework.SegmentReducerTest

[incubator-pinot] 01/01: Adding a flag in PinotServiceManager to allow health check includes all components health check

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch pinotSM_flag_for_health_check in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 01419655e077675768a9e641258a8313be767b13 Author: Xiang Fu AuthorDate: Mon Oct 12

[incubator-pinot] branch pinotSM_flag_for_health_check created (now 0141965)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch pinotSM_flag_for_health_check in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 0141965 Adding a flag in PinotServiceManager to allow health check includes all

[GitHub] [incubator-pinot] npawar opened a new pull request #6133: Remove flaky test from SegmentReducerTest

npawar opened a new pull request #6133: URL: https://github.com/apache/incubator-pinot/pull/6133 It seems the order returned in File#listFiles() is not guaranteed. The results of this test change depending on the order of the files returned in File#listFiles(). We received some

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #6134: Adding a flag in PinotServiceManager to allow health check includes all components health check

fx19880617 opened a new pull request #6134: URL: https://github.com/apache/incubator-pinot/pull/6134 ## Description - Adding a flag in PinotServiceManager to allow health check includes all components health check This

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6129: Issue #4854 Framework for adding compatibility tests

sajjad-moradi commented on a change in pull request #6129: URL: https://github.com/apache/incubator-pinot/pull/6129#discussion_r503462097 ## File path: compatibility-verifier/compCheck.sh ## @@ -157,20 +181,27 @@ fi # Setup initial cluster with olderCommit and do rolling

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6133: Remove flaky test from SegmentReducerTest

codecov-io edited a comment on pull request #6133: URL: https://github.com/apache/incubator-pinot/pull/6133#issuecomment-707295123 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6133?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6022: Add IN_SUBQUERY support

Jackie-Jiang commented on pull request #6022: URL: https://github.com/apache/incubator-pinot/pull/6022#issuecomment-707302712 > Why do we need a transform function to support subquery? Can we use the standard SQL syntax of providing the subquery inside parentheses to clearly distinguish

[GitHub] [incubator-pinot] deemoliu commented on a change in pull request #6112: add max length support in schema builder

deemoliu commented on a change in pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503563957 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java ## @@ -80,6 +80,18 @@ public void testFieldSpec() {

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6125: Make transform functions support underscore in the query functions

Jackie-Jiang commented on a change in pull request #6125: URL: https://github.com/apache/incubator-pinot/pull/6125#discussion_r503583619 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java ## @@ -62,73 +63,73

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6112: add max length support in schema builder

chenboat commented on a change in pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503563222 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java ## @@ -80,6 +80,18 @@ public void testFieldSpec() {

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6113: Adding the upsert support to real-time ingestion and query

mcvsubbu commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r503515858 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java ## @@ -132,6 +146,19 @@

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6124: RealtimeToOfflineSegments task generator

mcvsubbu commented on a change in pull request #6124: URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r503594418 ## File path: pinot-minion/src/main/java/org/apache/pinot/minion/executor/PinotTaskExecutor.java ## @@ -26,6 +26,12 @@ */ public interface

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6134: Adding a flag in PinotServiceManager to allow health check includes all components health check

codecov-io edited a comment on pull request #6134: URL: https://github.com/apache/incubator-pinot/pull/6134#issuecomment-707351920 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6134?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6112: add max length support in schema builder

codecov-io edited a comment on pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#issuecomment-704563263 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6112?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #6135: [TE] Add thirdeye-dashboard dep to thirdeye-dist

vincentchenjl opened a new pull request #6135: URL: https://github.com/apache/incubator-pinot/pull/6135 This PR is to fix the failure when maven runs `maven-assembly-plugin` before the `maven-shade-plugin`, which causes that maven cannot find `thirdeye-dashboard-1.0.0-SNAPSHOT.jar` for

[GitHub] [incubator-pinot] deemoliu commented on a change in pull request #6112: add max length support in schema builder

deemoliu commented on a change in pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503541176 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java ## @@ -80,6 +80,18 @@ public void testFieldSpec() {

[GitHub] [incubator-pinot] mcvsubbu commented on issue #6121: Reduce ingestion latency during segment sealing

mcvsubbu commented on issue #6121: URL: https://github.com/apache/incubator-pinot/issues/6121#issuecomment-707370550 Follow up discussion in slack This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6112: add max length support in schema builder

codecov-io edited a comment on pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#issuecomment-704563263 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6112?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6124: RealtimeToOfflineSegments task generator

mcvsubbu commented on a change in pull request #6124: URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r503580109 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/RealtimeToOfflineSegmentsTaskGenerator.java

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6112: add max length support in schema builder

codecov-io edited a comment on pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#issuecomment-704563263 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6112?src=pr=h1) Report > Merging

[incubator-pinot] branch throw-exception-when-column-mismatch updated (16167e9 -> bb210aa)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch throw-exception-when-column-mismatch in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 16167e9 Add warn level message and emit metric if this behavior detected

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6066: Detect the behavior when column name mismatches in the query

jackjlli commented on a change in pull request #6066: URL: https://github.com/apache/incubator-pinot/pull/6066#discussion_r503610423 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -769,94 +786,133 @@ private

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6066: Detect the behavior when column name mismatches in the query

jackjlli commented on a change in pull request #6066: URL: https://github.com/apache/incubator-pinot/pull/6066#discussion_r503610443 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -769,94 +786,133 @@ private

[incubator-pinot] branch throw-exception-when-column-mismatch updated (bb210aa -> 7c6b34e)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch throw-exception-when-column-mismatch in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard bb210aa Address PR comments add 7c6b34e Address PR comments This update

[GitHub] [incubator-pinot] codecov-io commented on pull request #6134: Adding a flag in PinotServiceManager to allow health check includes all components health check

codecov-io commented on pull request #6134: URL: https://github.com/apache/incubator-pinot/pull/6134#issuecomment-707351920 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6134?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] deemoliu commented on a change in pull request #6112: add max length support in schema builder

deemoliu commented on a change in pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503562057 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java ## @@ -499,6 +499,15 @@ public SchemaBuilder

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6112: add max length support in schema builder

codecov-io edited a comment on pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#issuecomment-704563263 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6112?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jihaozh merged pull request #6097: Fix Thirdeye Maven publish

jihaozh merged pull request #6097: URL: https://github.com/apache/incubator-pinot/pull/6097 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated (6275818 -> 86ce7c6)

This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 6275818 Fix superset docker image build script (#5965) add 86ce7c6 [TE] Fix Thirdeye Maven publish

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503637782 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@ -47,8 +57,32 @@ @ThreadSafe

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503637680 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@ -47,8 +57,32 @@ @ThreadSafe

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6113: Adding the upsert support to real-time ingestion and query

yupeng9 commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r503668532 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java ## @@ -132,6 +146,19 @@

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6044: Support for multi-threaded Group By reducer for SQL.

codecov-io edited a comment on pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#issuecomment-707475996 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6044?src=pr=h1) Report > Merging

[incubator-pinot] branch throw-exception-when-column-mismatch updated (7c6b34e -> 1c01c8b)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch throw-exception-when-column-mismatch in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 7c6b34e Address PR comments add 1c01c8b Address PR comments This update

[GitHub] [incubator-pinot] codecov-io commented on pull request #6066: Detect the behavior when column name mismatches in the query

codecov-io commented on pull request #6066: URL: https://github.com/apache/incubator-pinot/pull/6066#issuecomment-707443440 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6066?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503636090 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ## @@ -166,6 +166,11 @@ public static final

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503635525 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -102,7 +102,7 @@

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6044: Support for multi-threaded Group By reducer for SQL.

codecov-io edited a comment on pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#issuecomment-707475996 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6044?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6066: Detect the behavior when column name mismatches in the query

codecov-io edited a comment on pull request #6066: URL: https://github.com/apache/incubator-pinot/pull/6066#issuecomment-707443440 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6066?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6094: Implement the segment merge task generator

npawar commented on a change in pull request #6094: URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r503600877 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/mergestrategy/MergeStrategy.java ## @@ -0,0 +1,28 @@

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503640236 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java ## @@ -231,58 +239,130 @@ private

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503640614 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java ## @@ -231,58 +239,130 @@ private

[GitHub] [incubator-pinot] codecov-io commented on pull request #6044: Support for multi-threaded Group By reducer for SQL.

codecov-io commented on pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#issuecomment-707475996 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6044?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6044: Support for multi-threaded Group By reducer for SQL.

codecov-io edited a comment on pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#issuecomment-707475996 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6044?src=pr=h1) Report > Merging