[GitHub] [pulsar] wolfstudy opened a new pull request #6059: [Go Functions] Replace cgo client with native go client in Go Function

2020-01-15 Thread GitBox
wolfstudy opened a new pull request #6059: [Go Functions] Replace cgo client with native go client in Go Function URL: https://github.com/apache/pulsar/pull/6059 Signed-off-by: xiaolong.ran Fixes # ### Motivation Currently, the Go Functions depends on the cgo client, u

[GitHub] [pulsar] ntysdd opened a new pull request #6060: [Issue 5505] fix NPE

2020-01-15 Thread GitBox
ntysdd opened a new pull request #6060: [Issue 5505] fix NPE URL: https://github.com/apache/pulsar/pull/6060 Fix a NullPointerException This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [pulsar] wolfstudy commented on issue #6053: Enable action CI on Go Functions

2020-01-15 Thread GitBox
wolfstudy commented on issue #6053: Enable action CI on Go Functions URL: https://github.com/apache/pulsar/pull/6053#issuecomment-574547802 The pull request depends on #6059 This is an automated message from the Apache Git Se

[GitHub] [pulsar] Jennifer88huang commented on issue #6050: [docs] Update client-libraries in Get Started chapter

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #6050: [docs] Update client-libraries in Get Started chapter URL: https://github.com/apache/pulsar/pull/6050#issuecomment-574556079 run java8 tests This is an automated message from the Apac

[GitHub] [pulsar] Jennifer88huang commented on issue #6007: [Issue 5996][docs] Update links in 2.4.1 and 2.4.2 releases

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #6007: [Issue 5996][docs] Update links in 2.4.1 and 2.4.2 releases URL: https://github.com/apache/pulsar/pull/6007#issuecomment-574556942 retest this please This is an automated message from

[GitHub] [pulsar-client-go] dsmlily opened a new issue #173: lookupTopicResponse cause crash

2020-01-15 Thread GitBox
dsmlily opened a new issue #173: lookupTopicResponse cause crash URL: https://github.com/apache/pulsar-client-go/issues/173 time="2020-01-15T03:53:19+08:00" level=debug msg="Wait until connection is ready. State: Initializing" remote_addr="pulsar://10.109.2.72:6650" time="2020-01-15T03:5

[GitHub] [pulsar] sijie opened a new issue #6061: Support auto-deleting inactive topics for regex subscription

2020-01-15 Thread GitBox
sijie opened a new issue #6061: Support auto-deleting inactive topics for regex subscription URL: https://github.com/apache/pulsar/issues/6061 *Motivation* In some use cases, it is useful to support inactive topic auto-deletion for regex subscription. A topic is treated as "i

[GitHub] [pulsar] Jennifer88huang commented on issue #2793: TLS Hostname verification undefined for C++/python client

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #2793: TLS Hostname verification undefined for C++/python client URL: https://github.com/apache/pulsar/issues/2793#issuecomment-574566846 hostname verification has been added in #1208 This i

[GitHub] [pulsar] juanpecatala opened a new issue #6062: Add SQL Server CDC Debezium or JDBC Source Connector

2020-01-15 Thread GitBox
juanpecatala opened a new issue #6062: Add SQL Server CDC Debezium or JDBC Source Connector URL: https://github.com/apache/pulsar/issues/6062 **Is your feature request related to a problem? Please describe.** Right now there is no Pulsar connector to connect to a SQL Server database.

[GitHub] [pulsar] Jennifer88huang commented on issue #6057: [docs] Add docs on TypedMessageBuilder

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #6057: [docs] Add docs on TypedMessageBuilder URL: https://github.com/apache/pulsar/issues/6057#issuecomment-574573464 Add specification at http://pulsar.apache.org/docs/en/next/concepts-messaging/#messages

[GitHub] [pulsar] Jennifer88huang commented on issue #6056: [docs] Add info on how to choose partition when using a key

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #6056: [docs] Add info on how to choose partition when using a key URL: https://github.com/apache/pulsar/issues/6056#issuecomment-574574494 @zymap Could you please share a code snippet for this? Thank you. -

[GitHub] [pulsar-client-go] wolfstudy opened a new pull request #174: [Issue:173] Fix logrus crash

2020-01-15 Thread GitBox
wolfstudy opened a new pull request #174: [Issue:173] Fix logrus crash URL: https://github.com/apache/pulsar-client-go/pull/174 Signed-off-by: xiaolong.ran Fixes #173 ### Motivation Fix `logrus` crash, the error as follows: ``` panic: reflect: call of reflect.

[GitHub] [pulsar] Jennifer88huang edited a comment on issue #2793: TLS Hostname verification undefined for C++/python client

2020-01-15 Thread GitBox
Jennifer88huang edited a comment on issue #2793: TLS Hostname verification undefined for C++/python client URL: https://github.com/apache/pulsar/issues/2793#issuecomment-574566846 hostname verification has been added in C++ in #2475 -

[GitHub] [pulsar] Jennifer88huang edited a comment on issue #2793: TLS Hostname verification undefined for C++/python client

2020-01-15 Thread GitBox
Jennifer88huang edited a comment on issue #2793: TLS Hostname verification undefined for C++/python client URL: https://github.com/apache/pulsar/issues/2793#issuecomment-574566846 hostname verification has been added in C++ in #2475 This issue has been recorded in 2.3.0 missing docs. -

[GitHub] [pulsar] zymap commented on issue #6056: [docs] Add info on how to choose partition when using a key

2020-01-15 Thread GitBox
zymap commented on issue #6056: [docs] Add info on how to choose partition when using a key URL: https://github.com/apache/pulsar/issues/6056#issuecomment-574582667 ``` // If the message has a key, it supersedes the round robin routing policy if (msg.hasKey()) {

[GitHub] [pulsar] sijie commented on issue #6055: Ftr: The pulsar function specifies the outtopic internally, not when the function is started

2020-01-15 Thread GitBox
sijie commented on issue #6055: Ftr: The pulsar function specifies the outtopic internally, not when the function is started URL: https://github.com/apache/pulsar/issues/6055#issuecomment-574582630 @pantianying you can use [context.publish](http://pulsar.apache.org/docs/en/functions-develo

[GitHub] [pulsar] sijie commented on issue #6054: Catastrophic frequent random topic freezes, especially on high-traffic topics.

2020-01-15 Thread GitBox
sijie commented on issue #6054: Catastrophic frequent random topic freezes, especially on high-traffic topics. URL: https://github.com/apache/pulsar/issues/6054#issuecomment-574584836 @devinbost have you looked into `permits` when this issue happens? ---

[GitHub] [pulsar] wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function

2020-01-15 Thread GitBox
wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function URL: https://github.com/apache/pulsar/pull/6059#issuecomment-574589010 Action ci Unit - Brokers error as follows: ``` [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 1

[GitHub] [pulsar] wolfstudy edited a comment on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function

2020-01-15 Thread GitBox
wolfstudy edited a comment on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function URL: https://github.com/apache/pulsar/pull/6059#issuecomment-574589010 Action ci `Unit - Brokers` error as follows: ``` [ERROR] Tests run: 2, Failures: 1, Errors: 0, S

[GitHub] [pulsar-client-go] wolfstudy merged pull request #174: [Issue:173] Fix logrus crash

2020-01-15 Thread GitBox
wolfstudy merged pull request #174: [Issue:173] Fix logrus crash URL: https://github.com/apache/pulsar-client-go/pull/174 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar-client-go] wolfstudy closed issue #173: lookupTopicResponse cause crash

2020-01-15 Thread GitBox
wolfstudy closed issue #173: lookupTopicResponse cause crash URL: https://github.com/apache/pulsar-client-go/issues/173 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[pulsar-client-go] branch master updated: [Issue:173] Fix logrus crash (#174)

2020-01-15 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new e78a368 [Issue:173] Fix logrus crash (#1

[GitHub] [pulsar] Jennifer88huang commented on issue #6007: [Issue 5996][docs] Update links in 2.4.1 and 2.4.2 releases

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #6007: [Issue 5996][docs] Update links in 2.4.1 and 2.4.2 releases URL: https://github.com/apache/pulsar/pull/6007#issuecomment-574597131 run java8 tests This is an automated message from th

[GitHub] [pulsar] wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function

2020-01-15 Thread GitBox
wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function URL: https://github.com/apache/pulsar/pull/6059#issuecomment-574599050 @sijie @jiazhai PTAL thanks This is an automate

[pulsar] annotated tag v2.5.0 updated (f2afad3 -> b182361)

2020-01-15 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to annotated tag v2.5.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git. *** WARNING: tag v2.5.0 was modified! *** from f2afad3 (commit) to b182361 (tag) tagging f2afad353795f70c0

svn commit: r37628 - /release/pulsar/pulsar-2.4.1/

2020-01-15 Thread sijie
Author: sijie Date: Wed Jan 15 10:36:55 2020 New Revision: 37628 Log: Remove pulsar 2.4.1 Removed: release/pulsar/pulsar-2.4.1/

svn commit: r37627 - /dev/pulsar/pulsar-2.5.0-candidate-2/ /release/pulsar/pulsar-2.5.0/

2020-01-15 Thread sijie
Author: sijie Date: Wed Jan 15 10:36:17 2020 New Revision: 37627 Log: Apache Pulsar release 2.5.0 Added: release/pulsar/pulsar-2.5.0/ - copied from r37626, dev/pulsar/pulsar-2.5.0-candidate-2/ Removed: dev/pulsar/pulsar-2.5.0-candidate-2/

svn commit: r37629 - /release/pulsar/pulsar-2.4.2/

2020-01-15 Thread sijie
Author: sijie Date: Wed Jan 15 10:37:09 2020 New Revision: 37629 Log: Remove Pulsar 2.4.2 Removed: release/pulsar/pulsar-2.4.2/

[GitHub] [pulsar] wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function

2020-01-15 Thread GitBox
wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function URL: https://github.com/apache/pulsar/pull/6059#issuecomment-574637362 run java8 tests This is an automated message fr

[GitHub] [pulsar] wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function

2020-01-15 Thread GitBox
wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function URL: https://github.com/apache/pulsar/pull/6059#issuecomment-574646291 run java8 tests This is an automated me

[GitHub] [pulsar] abrahamsangha commented on issue #3968: Can`t get pulsar-client-go lib

2020-01-15 Thread GitBox
abrahamsangha commented on issue #3968: Can`t get pulsar-client-go lib URL: https://github.com/apache/pulsar/issues/3968#issuecomment-574660905 @gurgen2727 how did you solve this issue? This is an automated message from the Ap

[GitHub] [pulsar] tuteng commented on issue #6026: [website]Hot fixed website generate document order error

2020-01-15 Thread GitBox
tuteng commented on issue #6026: [website]Hot fixed website generate document order error URL: https://github.com/apache/pulsar/pull/6026#issuecomment-574666879 run java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] gurgen2727 commented on issue #3968: Can`t get pulsar-client-go lib

2020-01-15 Thread GitBox
gurgen2727 commented on issue #3968: Can`t get pulsar-client-go lib URL: https://github.com/apache/pulsar/issues/3968#issuecomment-57461 > @gurgen2727 how did you solve this issue? just run server correctly before running client, was stupid question from my side, easy solvable.

[GitHub] [pulsar] wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function

2020-01-15 Thread GitBox
wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function URL: https://github.com/apache/pulsar/pull/6059#issuecomment-574713480 run java8 tests This is an automated message fr

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r366946654 ## File path: pulsar-function-go/pf/instanceConf.go

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r366943358 ## File path: pulsar-function-go/pf/context.go #

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r366943929 ## File path: pulsar-function-go/pf/instance.go

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r366947839 ## File path: pulsar-function-go/pf/instance_test.go ###

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r366945364 ## File path: pulsar-function-go/pf/instance.go

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r366948527 ## File path: pulsar-function-go/pf/instance_test.go ###

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r366944885 ## File path: pulsar-function-go/pf/instance.go

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r366943599 ## File path: pulsar-function-go/pf/context.go #

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r366946940 ## File path: pulsar-function-go/pf/instanceControlServic

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r366948954 ## File path: pulsar-function-go/pf/instance_test.go ###

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r366943004 ## File path: pulsar-function-go/pb/doc.go ## @

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r366949152 ## File path: pulsar-function-go/pf/instance_test.go ###

[GitHub] [pulsar] wolfstudy commented on issue #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on issue #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#issuecomment-574720857 @devinbost I'm adding Action CI for Go Functions, make ensure that test cases can p

[GitHub] [pulsar] wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function

2020-01-15 Thread GitBox
wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function URL: https://github.com/apache/pulsar/pull/6059#issuecomment-574721113 > org.apache.pulsar.functions.utils.FunctionCommonTest.testDownloadFile org.apache.pulsar.functions.utils.Func

[GitHub] [pulsar] wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function

2020-01-15 Thread GitBox
wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function URL: https://github.com/apache/pulsar/pull/6059#issuecomment-574736988 run java8 tests This is an automated message fr

[GitHub] [pulsar] devinbost commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
devinbost commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r367027547 ## File path: pulsar-function-go/pf/instance.go

[GitHub] [pulsar] devinbost commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
devinbost commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r367028823 ## File path: pulsar-function-go/pf/instanceConf.go

[GitHub] [pulsar] devinbost commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
devinbost commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r367028948 ## File path: pulsar-function-go/pf/instanceControlServic

[GitHub] [pulsar] devinbost commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
devinbost commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r367031387 ## File path: pulsar-function-go/pf/instance_test.go ###

[GitHub] [pulsar] rdhabalia commented on issue #5604: [pulsar-broker] recover zk-badversion while updating cursor metadata

2020-01-15 Thread GitBox
rdhabalia commented on issue #5604: [pulsar-broker] recover zk-badversion while updating cursor metadata URL: https://github.com/apache/pulsar/pull/5604#issuecomment-574786995 @sijie ping. Can we please merge this one asap as it happens very often. -

[GitHub] [pulsar] rdhabalia commented on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx

2020-01-15 Thread GitBox
rdhabalia commented on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx URL: https://github.com/apache/pulsar/pull/3705#issuecomment-574787798 @merlimat this is related to PIP-51. This is an automa

[GitHub] [pulsar] devinbost commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
devinbost commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#discussion_r367037327 ## File path: pulsar-function-go/pf/instance_test.go ###

[GitHub] [pulsar] devinbost commented on issue #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
devinbost commented on issue #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#issuecomment-574792239 I made the changes that I could. Regarding everything that wasn't modified, please

[GitHub] [pulsar] vzhikserg opened a new pull request #6063: Remove duplicated lombok annotations in functions instance

2020-01-15 Thread GitBox
vzhikserg opened a new pull request #6063: Remove duplicated lombok annotations in functions instance URL: https://github.com/apache/pulsar/pull/6063 ### Motivation Some of the classes in the pulsar-functions module had a mixture of the following lombok annotations: ``` @D

[GitHub] [pulsar] merlimat commented on a change in pull request #6050: [docs] Update client-libraries in Get Started chapter

2020-01-15 Thread GitBox
merlimat commented on a change in pull request #6050: [docs] Update client-libraries in Get Started chapter URL: https://github.com/apache/pulsar/pull/6050#discussion_r367133394 ## File path: site2/docs/getting-started-clients.md ## @@ -6,53 +6,26 @@ sidebar_label: Use Pul

[GitHub] [pulsar] merlimat commented on a change in pull request #6027: [Issue 5999] Support create/update tenant with empty cluster

2020-01-15 Thread GitBox
merlimat commented on a change in pull request #6027: [Issue 5999] Support create/update tenant with empty cluster URL: https://github.com/apache/pulsar/pull/6027#discussion_r367183846 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TenantsBase.java #

[GitHub] [pulsar] merlimat commented on issue #6027: [Issue 5999] Support create/update tenant with empty cluster

2020-01-15 Thread GitBox
merlimat commented on issue #6027: [Issue 5999] Support create/update tenant with empty cluster URL: https://github.com/apache/pulsar/pull/6027#issuecomment-574929929 I'm not understanding the purpose of this fix. A "blank" string shouldn't be allowed as a cluster name. Per the ori

[GitHub] [pulsar] murong00 commented on a change in pull request #6027: [Issue 5999] Support create/update tenant with empty cluster

2020-01-15 Thread GitBox
murong00 commented on a change in pull request #6027: [Issue 5999] Support create/update tenant with empty cluster URL: https://github.com/apache/pulsar/pull/6027#discussion_r367193013 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TenantsBase.java #

[GitHub] [pulsar] wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function

2020-01-15 Thread GitBox
wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function URL: https://github.com/apache/pulsar/pull/6059#issuecomment-574941822 run java8 tests This is an automated message fr

[GitHub] [pulsar] wolfstudy commented on issue #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

2020-01-15 Thread GitBox
wolfstudy commented on issue #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage URL: https://github.com/apache/pulsar/pull/6031#issuecomment-574942435 retest this please

[GitHub] [pulsar] murong00 commented on issue #6027: [Issue 5999] Support create/update tenant with empty cluster

2020-01-15 Thread GitBox
murong00 commented on issue #6027: [Issue 5999] Support create/update tenant with empty cluster URL: https://github.com/apache/pulsar/pull/6027#issuecomment-574942574 @merlimat Thanks for pointing this. The original of this fix [(f7772ec)](https://github.com/apache/pulsar/pull/6027/commits

[GitHub] [pulsar] codelipenghui commented on issue #6051: Expose lastConsumedTimestamp and lastAckedTimestamp to consumer stats

2020-01-15 Thread GitBox
codelipenghui commented on issue #6051: Expose lastConsumedTimestamp and lastAckedTimestamp to consumer stats URL: https://github.com/apache/pulsar/pull/6051#issuecomment-574951740 retest this please This is an automated mess

[GitHub] [pulsar] wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function

2020-01-15 Thread GitBox
wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function URL: https://github.com/apache/pulsar/pull/6059#issuecomment-574952967 run java8 tests This is an automated message fr

[GitHub] [pulsar] codelipenghui commented on issue #6063: Remove duplicated lombok annotations in functions instance

2020-01-15 Thread GitBox
codelipenghui commented on issue #6063: Remove duplicated lombok annotations in functions instance URL: https://github.com/apache/pulsar/pull/6063#issuecomment-574953594 retest this please This is an automated message from th

[GitHub] [pulsar] yjshen opened a new pull request #6064: [minor] make acker in BatchMessageIdImpl transient

2020-01-15 Thread GitBox
yjshen opened a new pull request #6064: [minor] make acker in BatchMessageIdImpl transient URL: https://github.com/apache/pulsar/pull/6064 Since `MessageId` is serializable and `BatchMessageIdImpl` extends it, `acker` should be marked as transient since it breaks the serialization. --

[GitHub] [pulsar] Jennifer88huang opened a new pull request #6065: [Issue 6065][docs] Add example on how to choose partition when using a key

2020-01-15 Thread GitBox
Jennifer88huang opened a new pull request #6065: [Issue 6065][docs] Add example on how to choose partition when using a key URL: https://github.com/apache/pulsar/pull/6065 Fixes #6065 ### Motivation There is no doc telling users how to choose partition when you use a key. #

[GitHub] [pulsar] Jennifer88huang opened a new pull request #6066: [Issue 6057][docs] Add description and usage on TypedMessageBuilder

2020-01-15 Thread GitBox
Jennifer88huang opened a new pull request #6066: [Issue 6057][docs] Add description and usage on TypedMessageBuilder URL: https://github.com/apache/pulsar/pull/6066 Fixes #6057 Fixes #6038 ### Motivation 1. There is no description on how to use TypedMessageBuilder in docs;

[GitHub] [pulsar] codelipenghui commented on issue #5936: Add maxUnackedMessagesPerSubscription and maxUnackedMessagesPerConsumer on namespaces policies

2020-01-15 Thread GitBox
codelipenghui commented on issue #5936: Add maxUnackedMessagesPerSubscription and maxUnackedMessagesPerConsumer on namespaces policies URL: https://github.com/apache/pulsar/pull/5936#issuecomment-574969960 @sijie I took a look, maybe not solve my previous comment. I think @wolfstudy can ad

[GitHub] [pulsar] Jennifer88huang opened a new pull request #6067: [Issue 6057][docs] Add description and usage on TypedMessageBuilder

2020-01-15 Thread GitBox
Jennifer88huang opened a new pull request #6067: [Issue 6057][docs] Add description and usage on TypedMessageBuilder URL: https://github.com/apache/pulsar/pull/6067 Fixes #6057 Fixes #6038 ### Motivation 1. There is no description on how to use TypedMessageBuilder in docs;

[GitHub] [pulsar] Jennifer88huang commented on issue #6066: [Issue 6057][docs] Add description and usage on TypedMessageBuilder

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #6066: [Issue 6057][docs] Add description and usage on TypedMessageBuilder URL: https://github.com/apache/pulsar/pull/6066#issuecomment-574971295 Push to a wrong branch. This is an automate

[GitHub] [pulsar] Jennifer88huang closed pull request #6066: [Issue 6057][docs] Add description and usage on TypedMessageBuilder

2020-01-15 Thread GitBox
Jennifer88huang closed pull request #6066: [Issue 6057][docs] Add description and usage on TypedMessageBuilder URL: https://github.com/apache/pulsar/pull/6066 This is an automated message from the Apache Git Service. To res

[GitHub] [pulsar] Jennifer88huang commented on issue #6065: [Issue 6056][docs] Add example on how to choose partition when using a key

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #6065: [Issue 6056][docs] Add example on how to choose partition when using a key URL: https://github.com/apache/pulsar/pull/6065#issuecomment-574973956 run integration tests This is an auto

[GitHub] [pulsar] wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function

2020-01-15 Thread GitBox
wolfstudy commented on issue #6059: [Go Functions] Replace cgo client with native go client in Go Function URL: https://github.com/apache/pulsar/pull/6059#issuecomment-574978357 run java8 tests This is an automated message fr

[GitHub] [pulsar] wolfstudy opened a new pull request #6068: Fix maven broken link

2020-01-15 Thread GitBox
wolfstudy opened a new pull request #6068: Fix maven broken link URL: https://github.com/apache/pulsar/pull/6068 Signed-off-by: xiaolong.ran ### Motivation Currently, maven requires all links that start with https to download the required lib ### Modifications -

[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #6050: [docs] Update client-libraries in Get Started chapter

2020-01-15 Thread GitBox
Jennifer88huang commented on a change in pull request #6050: [docs] Update client-libraries in Get Started chapter URL: https://github.com/apache/pulsar/pull/6050#discussion_r367239322 ## File path: site2/docs/getting-started-clients.md ## @@ -6,53 +6,26 @@ sidebar_label:

[GitHub] [pulsar] Jennifer88huang commented on issue #6007: [Issue 5996][docs] Update links in 2.4.1 and 2.4.2 releases

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #6007: [Issue 5996][docs] Update links in 2.4.1 and 2.4.2 releases URL: https://github.com/apache/pulsar/pull/6007#issuecomment-574993083 run java8 tests This is an automated message from th

[GitHub] [pulsar] murong00 commented on issue #6027: [Issue 5999] Support create/update tenant with empty cluster

2020-01-15 Thread GitBox
murong00 commented on issue #6027: [Issue 5999] Support create/update tenant with empty cluster URL: https://github.com/apache/pulsar/pull/6027#issuecomment-574994966 By the way, the current behavior of CLI tool [(CmdTenants.Create)](https://github.com/apache/pulsar/blob/master/pulsar-clie

[GitHub] [pulsar] Jennifer88huang commented on issue #6067: [Issue 6057][docs] Add description and usage on TypedMessageBuilder

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #6067: [Issue 6057][docs] Add description and usage on TypedMessageBuilder URL: https://github.com/apache/pulsar/pull/6067#issuecomment-575010740 @zymap Could you please help review the content? Thank you.

[GitHub] [pulsar] Jennifer88huang commented on issue #6050: [docs] Update client-libraries in Get Started chapter

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #6050: [docs] Update client-libraries in Get Started chapter URL: https://github.com/apache/pulsar/pull/6050#issuecomment-575011185 run integration tests run java8 tests This is an automa

[GitHub] [pulsar] Jennifer88huang commented on issue #6067: [Issue 6057][docs] Add description and usage on TypedMessageBuilder

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #6067: [Issue 6057][docs] Add description and usage on TypedMessageBuilder URL: https://github.com/apache/pulsar/pull/6067#issuecomment-575010970 @codelipenghui Is Key_shared subscription still beta feature? --

[GitHub] [pulsar] Jennifer88huang commented on issue #6065: [Issue 6056][docs] Add example on how to choose partition when using a key

2020-01-15 Thread GitBox
Jennifer88huang commented on issue #6065: [Issue 6056][docs] Add example on how to choose partition when using a key URL: https://github.com/apache/pulsar/pull/6065#issuecomment-575014643 @zymap could you help review? Thank you. -

[GitHub] [pulsar] ShadowDAssange closed issue #5095: Error while producing messages

2020-01-15 Thread GitBox
ShadowDAssange closed issue #5095: Error while producing messages URL: https://github.com/apache/pulsar/issues/5095 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] ShadowDAssange commented on issue #5095: Error while producing messages

2020-01-15 Thread GitBox
ShadowDAssange commented on issue #5095: Error while producing messages URL: https://github.com/apache/pulsar/issues/5095#issuecomment-575019637 Sorry,I have solved This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] wolfstudy commented on issue #6068: Fix maven broken link

2020-01-15 Thread GitBox
wolfstudy commented on issue #6068: Fix maven broken link URL: https://github.com/apache/pulsar/pull/6068#issuecomment-575028141 retest this please This is an automated message from the Apache Git Service. To respond to the me