[GitHub] merlimat closed pull request #1099: Support ztsUrl parameter in athenz client plugin

2018-01-24 Thread GitBox
merlimat closed pull request #1099: Support ztsUrl parameter in athenz client plugin URL: https://github.com/apache/incubator-pulsar/pull/1099 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Support ztsUrl parameter in athenz client plugin (#1099)

2018-01-24 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new da4bd4a Support ztsUrl parameter in

[GitHub] rdhabalia opened a new pull request #1105: Advertise localhost address for unit test

2018-01-24 Thread GitBox
rdhabalia opened a new pull request #1105: Advertise localhost address for unit test URL: https://github.com/apache/incubator-pulsar/pull/1105 ### Motivation After #929 : I face below unit-test failures on my local mac when machine connects to different n/w/ ``` 10484

[GitHub] rdhabalia commented on a change in pull request #1107: Log only first exception in the connection exception handler

2018-01-24 Thread GitBox
rdhabalia commented on a change in pull request #1107: Log only first exception in the connection exception handler URL: https://github.com/apache/incubator-pulsar/pull/1107#discussion_r163666414 ## File path:

[GitHub] merlimat commented on issue #1098: Consolidate deployment assets into a single directory

2018-01-24 Thread GitBox
merlimat commented on issue #1098: Consolidate deployment assets into a single directory URL: https://github.com/apache/incubator-pulsar/pull/1098#issuecomment-360262323 @lucperkins One thing I forgot about this change is that we need to fix the configuration for the source distribution

[GitHub] merlimat commented on a change in pull request #1087: Add basic authentication plugin

2018-01-24 Thread GitBox
merlimat commented on a change in pull request #1087: Add basic authentication plugin URL: https://github.com/apache/incubator-pulsar/pull/1087#discussion_r163461362 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationService.java

[GitHub] rdhabalia commented on issue #1104: Set loadBalancerEnabled=true in ServiceConfiguration

2018-01-24 Thread GitBox
rdhabalia commented on issue #1104: Set loadBalancerEnabled=true in ServiceConfiguration URL: https://github.com/apache/incubator-pulsar/pull/1104#issuecomment-360238841 retest this please This is an automated message from

[GitHub] rdhabalia opened a new pull request #1106: Fix: ignore auth flag for websocket-proxy to broker authentication

2018-01-24 Thread GitBox
rdhabalia opened a new pull request #1106: Fix: ignore auth flag for websocket-proxy to broker authentication URL: https://github.com/apache/incubator-pulsar/pull/1106 ### Motivation Right now, when user wants to deploy websocket proxy which communicates to broker it requires -

[GitHub] merlimat opened a new pull request #1107: Log only first exception in the connection exception handler

2018-01-24 Thread GitBox
merlimat opened a new pull request #1107: Log only first exception in the connection exception handler URL: https://github.com/apache/incubator-pulsar/pull/1107 ### Motivation After the switch to Netty-4.1, we have seen that when a connection is reset all the pending write

[GitHub] merlimat opened a new pull request #1108: Fixed race condition between write operation and send timeout

2018-01-24 Thread GitBox
merlimat opened a new pull request #1108: Fixed race condition between write operation and send timeout URL: https://github.com/apache/incubator-pulsar/pull/1108 ### Motivation There is a possible race condition between a send operation getting written on a socket channel and

[GitHub] merlimat commented on a change in pull request #1108: Fixed race condition between write operation and send timeout

2018-01-24 Thread GitBox
merlimat commented on a change in pull request #1108: Fixed race condition between write operation and send timeout URL: https://github.com/apache/incubator-pulsar/pull/1108#discussion_r163710145 ## File path:

[GitHub] rdhabalia commented on issue #1105: Advertise localhost address for unit test

2018-01-24 Thread GitBox
rdhabalia commented on issue #1105: Advertise localhost address for unit test URL: https://github.com/apache/incubator-pulsar/pull/1105#issuecomment-360318596 retest this please This is an automated message from the Apache

[GitHub] rdhabalia commented on issue #1105: Advertise localhost address for unit test

2018-01-24 Thread GitBox
rdhabalia commented on issue #1105: Advertise localhost address for unit test URL: https://github.com/apache/incubator-pulsar/pull/1105#issuecomment-360318596 retest this please This is an automated message from the Apache

[GitHub] jai1 commented on a change in pull request #1108: Fixed race condition between write operation and send timeout

2018-01-24 Thread GitBox
jai1 commented on a change in pull request #1108: Fixed race condition between write operation and send timeout URL: https://github.com/apache/incubator-pulsar/pull/1108#discussion_r163709882 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java

[GitHub] lucperkins opened a new pull request #1109: Fix source distribution XML config to reflect new directory structure (WIP)

2018-01-24 Thread GitBox
lucperkins opened a new pull request #1109: Fix source distribution XML config to reflect new directory structure (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1109 @merlimat Should the entire `deployment` directory be included?

[incubator-pulsar] branch master updated: Introduce config to skip non-recoverable data-ledger (#1046)

2018-01-24 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new f5a2ec7 Introduce config to skip

[GitHub] rdhabalia closed pull request #1046: Introduce config to skip non-recoverable data-ledger

2018-01-24 Thread GitBox
rdhabalia closed pull request #1046: Introduce config to skip non-recoverable data-ledger URL: https://github.com/apache/incubator-pulsar/pull/1046 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] rdhabalia commented on issue #1107: Log only first exception in the connection exception handler

2018-01-24 Thread GitBox
rdhabalia commented on issue #1107: Log only first exception in the connection exception handler URL: https://github.com/apache/incubator-pulsar/pull/1107#issuecomment-360282380 retest this please This is an automated

[GitHub] merlimat opened a new pull request #1110: Fix ByteBufPair encoder to release buffers

2018-01-24 Thread GitBox
merlimat opened a new pull request #1110: Fix ByteBufPair encoder to release buffers URL: https://github.com/apache/incubator-pulsar/pull/1110 ### Motivation In the recent commit that changed the `DoubleByteBuf` for the `ByteBufPair`, the provided encoder was not releasing the

[GitHub] rdhabalia commented on issue #896: PIP-7 Introduce Failure-domain and Anti-affinity-namespace group

2018-01-24 Thread GitBox
rdhabalia commented on issue #896: PIP-7 Introduce Failure-domain and Anti-affinity-namespace group URL: https://github.com/apache/incubator-pulsar/pull/896#issuecomment-360318811 retest this please This is an automated

[GitHub] yush1ga commented on a change in pull request #1087: Add basic authentication plugin

2018-01-24 Thread GitBox
yush1ga commented on a change in pull request #1087: Add basic authentication plugin URL: https://github.com/apache/incubator-pulsar/pull/1087#discussion_r163719058 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationService.java

[GitHub] merlimat commented on issue #1108: Fixed race condition between write operation and send timeout

2018-01-24 Thread GitBox
merlimat commented on issue #1108: Fixed race condition between write operation and send timeout URL: https://github.com/apache/incubator-pulsar/pull/1108#issuecomment-360316720 retest this please This is an automated

[GitHub] merlimat commented on issue #1108: Fixed race condition between write operation and send timeout

2018-01-24 Thread GitBox
merlimat commented on issue #1108: Fixed race condition between write operation and send timeout URL: https://github.com/apache/incubator-pulsar/pull/1108#issuecomment-360316720 retest this please This is an automated

[GitHub] rdhabalia commented on issue #1107: Log only first exception in the connection exception handler

2018-01-24 Thread GitBox
rdhabalia commented on issue #1107: Log only first exception in the connection exception handler URL: https://github.com/apache/incubator-pulsar/pull/1107#issuecomment-360282380 retest this please This is an automated

[GitHub] rdhabalia commented on issue #1105: Advertise localhost address for unit test

2018-01-24 Thread GitBox
rdhabalia commented on issue #1105: Advertise localhost address for unit test URL: https://github.com/apache/incubator-pulsar/pull/1105#issuecomment-360282550 retest this please This is an automated message from the Apache

[GitHub] rdhabalia commented on issue #1105: Advertise localhost address for unit test

2018-01-24 Thread GitBox
rdhabalia commented on issue #1105: Advertise localhost address for unit test URL: https://github.com/apache/incubator-pulsar/pull/1105#issuecomment-360282550 retest this please This is an automated message from the Apache

[GitHub] rdhabalia commented on issue #896: PIP-7 Introduce Failure-domain and Anti-affinity-namespace group

2018-01-24 Thread GitBox
rdhabalia commented on issue #896: PIP-7 Introduce Failure-domain and Anti-affinity-namespace group URL: https://github.com/apache/incubator-pulsar/pull/896#issuecomment-360289850 retest this please This is an automated

[GitHub] rdhabalia commented on issue #896: PIP-7 Introduce Failure-domain and Anti-affinity-namespace group

2018-01-24 Thread GitBox
rdhabalia commented on issue #896: PIP-7 Introduce Failure-domain and Anti-affinity-namespace group URL: https://github.com/apache/incubator-pulsar/pull/896#issuecomment-360290095 retest this please This is an automated

[GitHub] rdhabalia commented on issue #896: PIP-7 Introduce Failure-domain and Anti-affinity-namespace group

2018-01-24 Thread GitBox
rdhabalia commented on issue #896: PIP-7 Introduce Failure-domain and Anti-affinity-namespace group URL: https://github.com/apache/incubator-pulsar/pull/896#issuecomment-360289850 retest this please This is an automated

[GitHub] rdhabalia commented on issue #896: PIP-7 Introduce Failure-domain and Anti-affinity-namespace group

2018-01-24 Thread GitBox
rdhabalia commented on issue #896: PIP-7 Introduce Failure-domain and Anti-affinity-namespace group URL: https://github.com/apache/incubator-pulsar/pull/896#issuecomment-360290095 retest this please This is an automated

[GitHub] lucperkins commented on issue #1098: Consolidate deployment assets into a single directory

2018-01-24 Thread GitBox
lucperkins commented on issue #1098: Consolidate deployment assets into a single directory URL: https://github.com/apache/incubator-pulsar/pull/1098#issuecomment-360310712 @merlimat Okay, I'll take a look. This is an

[GitHub] merlimat commented on issue #1110: Fix ByteBufPair encoder to release buffers

2018-01-24 Thread GitBox
merlimat commented on issue #1110: Fix ByteBufPair encoder to release buffers URL: https://github.com/apache/incubator-pulsar/pull/1110#issuecomment-360368602 retest this please This is an automated message from the Apache

[GitHub] merlimat commented on issue #1104: Set loadBalancerEnabled=true in ServiceConfiguration

2018-01-24 Thread GitBox
merlimat commented on issue #1104: Set loadBalancerEnabled=true in ServiceConfiguration URL: https://github.com/apache/incubator-pulsar/pull/1104#issuecomment-360326981 retest this please This is an automated message from

[GitHub] zhaijack commented on issue #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-01-24 Thread GitBox
zhaijack commented on issue #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#issuecomment-360331086 @ivankelly @sijie @merlimat Would you please help take a look of the new change? Thanks.

[incubator-pulsar] branch master updated: Fixed race condition between write operation and send timeout (#1108)

2018-01-24 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e1ad269 Fixed race condition between

[incubator-pulsar] branch master updated: Log only first exception in the connection exception handler (#1107)

2018-01-24 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new f57cd88 Log only first exception in

[GitHub] merlimat closed pull request #1108: Fixed race condition between write operation and send timeout

2018-01-24 Thread GitBox
merlimat closed pull request #1108: Fixed race condition between write operation and send timeout URL: https://github.com/apache/incubator-pulsar/pull/1108 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat closed pull request #1107: Log only first exception in the connection exception handler

2018-01-24 Thread GitBox
merlimat closed pull request #1107: Log only first exception in the connection exception handler URL: https://github.com/apache/incubator-pulsar/pull/1107 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Set loadBalancerEnabled=true in ServiceConfiguration (#1104)

2018-01-24 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ed488b2 Set loadBalancerEnabled=true

[incubator-pulsar] branch master updated: Fix: ignore auth flag for websocket-proxy to broker authentication (#1106)

2018-01-24 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 574ebde Fix: ignore auth flag for

[GitHub] merlimat closed pull request #1104: Set loadBalancerEnabled=true in ServiceConfiguration

2018-01-24 Thread GitBox
merlimat closed pull request #1104: Set loadBalancerEnabled=true in ServiceConfiguration URL: https://github.com/apache/incubator-pulsar/pull/1104 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] rdhabalia commented on issue #1105: Advertise localhost address for unit test

2018-01-24 Thread GitBox
rdhabalia commented on issue #1105: Advertise localhost address for unit test URL: https://github.com/apache/incubator-pulsar/pull/1105#issuecomment-360328223 retest this please This is an automated message from the Apache

[GitHub] rdhabalia closed pull request #1106: Fix: ignore auth flag for websocket-proxy to broker authentication

2018-01-24 Thread GitBox
rdhabalia closed pull request #1106: Fix: ignore auth flag for websocket-proxy to broker authentication URL: https://github.com/apache/incubator-pulsar/pull/1106 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[incubator-pulsar] branch master updated: Advertise localhost address for unit test (#1105)

2018-01-24 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 72432ce Advertise localhost

[GitHub] rdhabalia closed pull request #1105: Advertise localhost address for unit test

2018-01-24 Thread GitBox
rdhabalia closed pull request #1105: Advertise localhost address for unit test URL: https://github.com/apache/incubator-pulsar/pull/1105 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] zhaijack commented on issue #1014: Rename global zookeeper cluster to configuration/replication-configuration cluster

2018-01-24 Thread GitBox
zhaijack commented on issue #1014: Rename global zookeeper cluster to configuration/replication-configuration cluster URL: https://github.com/apache/incubator-pulsar/issues/1014#issuecomment-360332644 https://github.com/apache/incubator-pulsar/pull/1059 is for the fix. @merlimat Since

[GitHub] rdhabalia commented on issue #1106: Fix: ignore auth flag for websocket-proxy to broker authentication

2018-01-24 Thread GitBox
rdhabalia commented on issue #1106: Fix: ignore auth flag for websocket-proxy to broker authentication URL: https://github.com/apache/incubator-pulsar/pull/1106#issuecomment-360338171 retest this please This is an automated

[GitHub] XiaoZYang commented on issue #1069: Provide a setting in consumer configuration to specify where to start consuming messages

2018-01-24 Thread GitBox
XiaoZYang commented on issue #1069: Provide a setting in consumer configuration to specify where to start consuming messages URL: https://github.com/apache/incubator-pulsar/issues/1069#issuecomment-360351677 I'd like to have a try on fixing this issue. :)

[GitHub] zhaijack opened a new issue #1102: PIP-13-3: sub-regex: auto-discover topic addition/deletion

2018-01-24 Thread GitBox
zhaijack opened a new issue #1102: PIP-13-3: sub-regex: auto-discover topic addition/deletion URL: https://github.com/apache/incubator-pulsar/issues/1102 This is tracking the sub task 3 for [PIP

[GitHub] merlimat commented on issue #1095: Publish pulsar-client-admin as a shaded artifact

2018-01-24 Thread GitBox
merlimat commented on issue #1095: Publish pulsar-client-admin as a shaded artifact URL: https://github.com/apache/incubator-pulsar/pull/1095#issuecomment-360164248 retest this please This is an automated message from the

[GitHub] zhaijack opened a new issue #1100: PIP-13-1: Provide `TopicsConsumer` to consume from several topics under same namespace.

2018-01-24 Thread GitBox
zhaijack opened a new issue #1100: PIP-13-1: Provide `TopicsConsumer` to consume from several topics under same namespace. URL: https://github.com/apache/incubator-pulsar/issues/1100 This is tracking the sub task 1 for [PIP

[GitHub] merlimat opened a new pull request #1104: Set loadBalancerEnabled=true in ServiceConfiguration

2018-01-24 Thread GitBox
merlimat opened a new pull request #1104: Set loadBalancerEnabled=true in ServiceConfiguration URL: https://github.com/apache/incubator-pulsar/pull/1104 ### Motivation The intended default is to have the load manager enabled and the same setting is set to be the default in

[GitHub] merlimat closed pull request #1094: Include BoringSSL native implementation for faster TLS

2018-01-24 Thread GitBox
merlimat closed pull request #1094: Include BoringSSL native implementation for faster TLS URL: https://github.com/apache/incubator-pulsar/pull/1094 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: Include BoringSSL native implementation for faster TLS (#1094)

2018-01-24 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a6e02bf Include BoringSSL native

[GitHub] ivankelly commented on a change in pull request #1044: Compact algo

2018-01-24 Thread GitBox
ivankelly commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r163491091 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/TwoPhaseCompactor.java ## @@ -0,0 +1,275 @@ +/** + *

[GitHub] hrsakai opened a new pull request #1099: Support ztsUrl parameter in athenz client plugin

2018-01-24 Thread GitBox
hrsakai opened a new pull request #1099: Support ztsUrl parameter in athenz client plugin URL: https://github.com/apache/incubator-pulsar/pull/1099 ### Motivation Currently, we have to place athenz configuration file for zts url. ### Modifications Enable zts url to be

[GitHub] zhaijack opened a new pull request #1103: Issue 1100: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-01-24 Thread GitBox
zhaijack opened a new pull request #1103: Issue 1100: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103 ### Motivation This is a first sub-task for pip-13, which would like handle subscription to

[GitHub] sschepens commented on issue #1095: Publish pulsar-client-admin as a shaded artifact

2018-01-24 Thread GitBox
sschepens commented on issue #1095: Publish pulsar-client-admin as a shaded artifact URL: https://github.com/apache/incubator-pulsar/pull/1095#issuecomment-360147143 :+1: This is an automated message from the Apache Git

[GitHub] zhaijack opened a new issue #1101: PIP-13-2: support regex based subscription

2018-01-24 Thread GitBox
zhaijack opened a new issue #1101: PIP-13-2: support regex based subscription URL: https://github.com/apache/incubator-pulsar/issues/1101 This is tracking the sub task 2 for [PIP