[GitHub] srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry

2018-08-13 Thread GitBox
srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r209760478 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java

[GitHub] rdhabalia commented on issue #2347: Fix: function with multi-topic not acking on effectively-once

2018-08-13 Thread GitBox
rdhabalia commented on issue #2347: Fix: function with multi-topic not acking on effectively-once URL: https://github.com/apache/incubator-pulsar/pull/2347#issuecomment-412666274 @sijie @merlimat can we merge this PR.? This

[GitHub] rdhabalia removed a comment on issue #2353: Set correct exception if function runnable fails with Error

2018-08-13 Thread GitBox
rdhabalia removed a comment on issue #2353: Set correct exception if function runnable fails with Error URL: https://github.com/apache/incubator-pulsar/pull/2353#issuecomment-412666125 rerun java8 tests This is an automated

[GitHub] rdhabalia commented on issue #2353: Set correct exception if function runnable fails with Error

2018-08-13 Thread GitBox
rdhabalia commented on issue #2353: Set correct exception if function runnable fails with Error URL: https://github.com/apache/incubator-pulsar/pull/2353#issuecomment-412666125 rerun java8 tests This is an automated message

[GitHub] sijie commented on issue #2347: Fix: function with multi-topic not acking on effectively-once

2018-08-13 Thread GitBox
sijie commented on issue #2347: Fix: function with multi-topic not acking on effectively-once URL: https://github.com/apache/incubator-pulsar/pull/2347#issuecomment-412668786 @rdhabalia merged. I also changed the milestone to 2.2.0 since it is merged to master. when it is

[GitHub] sijie commented on issue #2195: Can't start Global Zookeeper in a Multi-cluster setup

2018-08-13 Thread GitBox
sijie commented on issue #2195: Can't start Global Zookeeper in a Multi-cluster setup URL: https://github.com/apache/incubator-pulsar/issues/2195#issuecomment-412614078 @dsambandam it seems that there is inconsistent metadata after you copied the metadata. as the log say it has been a

[GitHub] rdhabalia commented on issue #2354: add function package-url into function-get api response

2018-08-13 Thread GitBox
rdhabalia commented on issue #2354: add function package-url into function-get api response URL: https://github.com/apache/incubator-pulsar/pull/2354#issuecomment-412666891 @sijie @jerrypeng can you please take a look .. we want to know function-pkg url to know actual package-version

[GitHub] rdhabalia commented on issue #2347: Fix: function with multi-topic not acking on effectively-once

2018-08-13 Thread GitBox
rdhabalia commented on issue #2347: Fix: function with multi-topic not acking on effectively-once URL: https://github.com/apache/incubator-pulsar/pull/2347#issuecomment-412669097 sure..  This is an automated message from

[GitHub] sijie commented on issue #2289: Broker suddenly goes down

2018-08-13 Thread GitBox
sijie commented on issue #2289: Broker suddenly goes down URL: https://github.com/apache/incubator-pulsar/issues/2289#issuecomment-412614644 @massakam great finding! so it seems the problems have been addressed in 2.x releases?

[GitHub] rdhabalia opened a new pull request #2365: Add support to restart function

2018-08-13 Thread GitBox
rdhabalia opened a new pull request #2365: Add support to restart function URL: https://github.com/apache/incubator-pulsar/pull/2365 ### Motivation Few times we have seen that our function process is stuck and not consuming messages from pulsar-source or computing as per

[GitHub] sijie commented on issue #2353: Set correct exception if function runnable fails with Error

2018-08-13 Thread GitBox
sijie commented on issue #2353: Set correct exception if function runnable fails with Error URL: https://github.com/apache/incubator-pulsar/pull/2353#issuecomment-412670139 run java8 tests This is an automated message from

[GitHub] srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry

2018-08-13 Thread GitBox
srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r209755250 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java

[incubator-pulsar] branch master updated: Fix: function with multi-topic not acking on effectively-once (#2347)

2018-08-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0d2154e Fix: function with

[GitHub] sijie closed pull request #2347: Fix: function with multi-topic not acking on effectively-once

2018-08-13 Thread GitBox
sijie closed pull request #2347: Fix: function with multi-topic not acking on effectively-once URL: https://github.com/apache/incubator-pulsar/pull/2347 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry

2018-08-13 Thread GitBox
srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r209757660 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java

[GitHub] sijie commented on a change in pull request #2362: [documentation][deploy] Update deployment instructions for deploying pulsar to minikube

2018-08-13 Thread GitBox
sijie commented on a change in pull request #2362: [documentation][deploy] Update deployment instructions for deploying pulsar to minikube URL: https://github.com/apache/incubator-pulsar/pull/2362#discussion_r209694791 ## File path: deployment/kubernetes/generic/bookie.yaml

[GitHub] sijie opened a new pull request #2364: [documentation] Cherry-pick tiered storage documentation to new website

2018-08-13 Thread GitBox
sijie opened a new pull request #2364: [documentation] Cherry-pick tiered storage documentation to new website URL: https://github.com/apache/incubator-pulsar/pull/2364 ### Motivation Cherry-pick #2152

[GitHub] rdhabalia commented on issue #2365: Add support to restart function

2018-08-13 Thread GitBox
rdhabalia commented on issue #2365: Add support to restart function URL: https://github.com/apache/incubator-pulsar/pull/2365#issuecomment-412723540 > If one doesn't specify instance_id does it make sense to restart all instances? Sure, let me make the change.

[GitHub] srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry

2018-08-13 Thread GitBox
srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r209770637 ## File path: pulsar-functions/proto/src/main/proto/Function.proto ## @@ -68,7 +73,15 @@

[incubator-pulsar] branch master updated: Fixed linking of python wrapper to boost-python in MacOS build (#2366)

2018-08-13 Thread hrsakai
This is an automated email from the ASF dual-hosted git repository. hrsakai pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 82771da Fixed linking of python

[GitHub] hrsakai closed pull request #2366: Fixed linking of python wrapper to boost-python in MacOS build

2018-08-13 Thread GitBox
hrsakai closed pull request #2366: Fixed linking of python wrapper to boost-python in MacOS build URL: https://github.com/apache/incubator-pulsar/pull/2366 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat opened a new pull request #2366: Fixed linking of python wrapper to boost-python in MacOS build

2018-08-13 Thread GitBox
merlimat opened a new pull request #2366: Fixed linking of python wrapper to boost-python in MacOS build URL: https://github.com/apache/incubator-pulsar/pull/2366 ### Motivation With newer cmake and boost versions from Homebrew, the variable for boost-python library name path had

[GitHub] sijie opened a new pull request #2367: [compaction] make topic compaction works with partitioned topic

2018-08-13 Thread GitBox
sijie opened a new pull request #2367: [compaction] make topic compaction works with partitioned topic URL: https://github.com/apache/incubator-pulsar/pull/2367 ### Motivation Topic compaction doesn't work with partitioned topic. ### Changes - make `RawReaderImpl`

[incubator-pulsar] branch master updated: [cpp] receiver queue size config acorss partitions in multi-topics-consumer (#2311)

2018-08-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 296830a [cpp] receiver queue size

[GitHub] merlimat commented on a change in pull request #2266: Integrate functions and io with schema registry

2018-08-13 Thread GitBox
merlimat commented on a change in pull request #2266: Integrate functions and io with schema registry URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r209789545 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java

[GitHub] rdhabalia commented on issue #2365: Add support to restart function

2018-08-13 Thread GitBox
rdhabalia commented on issue #2365: Add support to restart function URL: https://github.com/apache/incubator-pulsar/pull/2365#issuecomment-412728342 @srkukarni added support to restart all instances of the function. This is

[GitHub] srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry

2018-08-13 Thread GitBox
srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r209768156 ## File path:

[GitHub] k2la opened a new pull request #2368: Fix Copy Command in Pulsar IO Getting Started

2018-08-13 Thread GitBox
k2la opened a new pull request #2368: Fix Copy Command in Pulsar IO Getting Started URL: https://github.com/apache/incubator-pulsar/pull/2368 ### Motivation In https://pulsar.incubator.apache.org/docs/en/io-quickstart/ , `connectors` directory cannot be copied because copy

[incubator-pulsar] branch master updated: add function package-url into function-get api response (#2354)

2018-08-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new cb2f4ee add function package-url into

[GitHub] sijie closed pull request #2354: add function package-url into function-get api response

2018-08-13 Thread GitBox
sijie closed pull request #2354: add function package-url into function-get api response URL: https://github.com/apache/incubator-pulsar/pull/2354 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] merlimat closed pull request #2311: [cpp] receiver queue size config acorss partitions in multi-topics-consumer

2018-08-13 Thread GitBox
merlimat closed pull request #2311: [cpp] receiver queue size config acorss partitions in multi-topics-consumer URL: https://github.com/apache/incubator-pulsar/pull/2311 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] k2la commented on issue #2368: Fix Copy Command in Pulsar IO Getting Started

2018-08-13 Thread GitBox
k2la commented on issue #2368: Fix Copy Command in Pulsar IO Getting Started URL: https://github.com/apache/incubator-pulsar/pull/2368#issuecomment-412753369 retest this please This is an automated message from the Apache Git

[GitHub] srkukarni opened a new pull request #2369: If --customSerdeInputs is specified, please update the right variable

2018-08-13 Thread GitBox
srkukarni opened a new pull request #2369: If --customSerdeInputs is specified, please update the right variable URL: https://github.com/apache/incubator-pulsar/pull/2369 ### Motivation When we made the switch to get away from camel-case arguments for functions, we moved the camel

[GitHub] rdhabalia closed pull request #2365: Add support to restart function

2018-08-13 Thread GitBox
rdhabalia closed pull request #2365: Add support to restart function URL: https://github.com/apache/incubator-pulsar/pull/2365 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] rdhabalia closed pull request #2353: Set correct exception if function runnable fails with Error

2018-08-13 Thread GitBox
rdhabalia closed pull request #2353: Set correct exception if function runnable fails with Error URL: https://github.com/apache/incubator-pulsar/pull/2353 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Set correct exception if function runnable fails with Error (#2353)

2018-08-13 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new c9988cf Set correct exception if

[GitHub] srkukarni commented on a change in pull request #2365: Add support to restart function

2018-08-13 Thread GitBox
srkukarni commented on a change in pull request #2365: Add support to restart function URL: https://github.com/apache/incubator-pulsar/pull/2365#discussion_r209824676 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java

[GitHub] srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry

2018-08-13 Thread GitBox
srkukarni commented on a change in pull request #2266: Integrate functions and io with schema registry URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r209824852 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java

[GitHub] rdhabalia commented on a change in pull request #2365: Add support to restart function

2018-08-13 Thread GitBox
rdhabalia commented on a change in pull request #2365: Add support to restart function URL: https://github.com/apache/incubator-pulsar/pull/2365#discussion_r209829347 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java

[incubator-pulsar] branch master updated: Add support to restart function (#2365)

2018-08-13 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7bcd893 Add support to restart

[incubator-pulsar] branch asf-site updated: Updated site at revision c0a5072

2018-08-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new a50747e Updated site at revision

[GitHub] sijie commented on issue #2363: [documentation][deploy] Improve helm deployment script to deploy Pulsar to minikube

2018-08-13 Thread GitBox
sijie commented on issue #2363: [documentation][deploy] Improve helm deployment script to deploy Pulsar to minikube URL: https://github.com/apache/incubator-pulsar/pull/2363#issuecomment-412465063 for reviewers: this change is based on #2362 , so commit 0c49a8d is the change to

[GitHub] merlimat commented on a change in pull request #2362: [documentation][deploy] Update deployment instructions for deploying pulsar to minikube

2018-08-13 Thread GitBox
merlimat commented on a change in pull request #2362: [documentation][deploy] Update deployment instructions for deploying pulsar to minikube URL: https://github.com/apache/incubator-pulsar/pull/2362#discussion_r209669024 ## File path: deployment/kubernetes/generic/bookie.yaml

[incubator-pulsar] branch master updated: [docker] Publish pulsar-all image to docker hub (#2361)

2018-08-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 777223d [docker] Publish pulsar-all

[GitHub] merlimat closed pull request #2361: [docker] Publish pulsar-all image to docker hub

2018-08-13 Thread GitBox
merlimat closed pull request #2361: [docker] Publish pulsar-all image to docker hub URL: https://github.com/apache/incubator-pulsar/pull/2361 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As