[GitHub] jerrypeng commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-07 Thread GitBox
jerrypeng commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537#discussion_r215858084 ## File path:

[GitHub] sijie commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-07 Thread GitBox
sijie commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537#discussion_r215859148 ## File path:

[GitHub] jerrypeng commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-07 Thread GitBox
jerrypeng commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537#discussion_r215860896 ## File path:

[GitHub] ivankelly opened a new pull request #2544: Readd MockBookKeeper to Pulsar

2018-09-07 Thread GitBox
ivankelly opened a new pull request #2544: Readd MockBookKeeper to Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2544 These mocks were moved out of pulsar to the bookkeeper project a few months ago. While it is good to have mocks generally available for bookkeeper, if

[GitHub] maskit commented on issue #2544: Readd MockBookKeeper to Pulsar

2018-09-07 Thread GitBox
maskit commented on issue #2544: Readd MockBookKeeper to Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2544#issuecomment-419520495 Do the namespaces have to be "org.apache.bookkeeper.client"? These mocks are now Pulsar's, right? (Am I the only one who read the subject

[GitHub] dave2wave commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-07 Thread GitBox
dave2wave commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419521175 I think that the topic being discussed - how to tag and build a release including the policies should be

[GitHub] vli02 commented on issue #2525: fixed zookeeper name references in helm charts.

2018-09-07 Thread GitBox
vli02 commented on issue #2525: fixed zookeeper name references in helm charts. URL: https://github.com/apache/incubator-pulsar/pull/2525#issuecomment-419514407 Can someone re-run the failed check? This is an automated

[GitHub] merlimat commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-07 Thread GitBox
merlimat commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537#discussion_r216012606 ## File path: pulsar-functions/java-examples/pom.xml ## @@

[GitHub] jerrypeng commented on issue #2534: set correct guice version to prevent dependency inject errors in docker container

2018-09-07 Thread GitBox
jerrypeng commented on issue #2534: set correct guice version to prevent dependency inject errors in docker container URL: https://github.com/apache/incubator-pulsar/pull/2534#issuecomment-419519288 rerun java8 tests This is

[GitHub] srkukarni commented on issue #2525: fixed zookeeper name references in helm charts.

2018-09-07 Thread GitBox
srkukarni commented on issue #2525: fixed zookeeper name references in helm charts. URL: https://github.com/apache/incubator-pulsar/pull/2525#issuecomment-419519461 run integration tests This is an automated message from the

[GitHub] sijie commented on issue #2500: [schema] add schemas for primtive types

2018-09-07 Thread GitBox
sijie commented on issue #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500#issuecomment-419529566 retest this please This is an automated message from the Apache Git

[GitHub] sijie commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-07 Thread GitBox
sijie commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419482578 i think there is a confusion here. There is no policy coded into the script. It is still left to the community to

[GitHub] maskit commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-07 Thread GitBox
maskit commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419516617 Alright, it seems like I need to read what the script actually does. Although I haven't read the script at

[GitHub] sijie commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-07 Thread GitBox
sijie commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419524091 @dave2wave yes. there was already an email thread about "how to label milestone". I was hoping the discussion

[GitHub] srkukarni commented on a change in pull request #2539: Elastic connector

2018-09-07 Thread GitBox
srkukarni commented on a change in pull request #2539: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2539#discussion_r216009801 ## File path: pulsar-io/pom.xml ## @@ -42,6 +42,8 @@ hdfs jdbc data-genenator +hdfs Review

[GitHub] massakam commented on issue #2542: Fix status code of REST API to get partitioned topic stats

2018-09-07 Thread GitBox
massakam commented on issue #2542: Fix status code of REST API to get partitioned topic stats URL: https://github.com/apache/incubator-pulsar/pull/2542#issuecomment-419422773 rerun java8 tests This is an automated message

[GitHub] david-streamlio opened a new pull request #2539: Elastic connector

2018-09-07 Thread GitBox
david-streamlio opened a new pull request #2539: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2539 ### Motivation Added a sink connector that writes JSON documents into ElasticSearch ### Modifications Added new pulsar-io module and associated

[GitHub] ivankelly commented on issue #240: Intermittent test failures in ManagedLedgerErrorsTest.recoverLongTimeAfterMultipleWriteErrors

2018-09-07 Thread GitBox
ivankelly commented on issue #240: Intermittent test failures in ManagedLedgerErrorsTest.recoverLongTimeAfterMultipleWriteErrors URL: https://github.com/apache/incubator-pulsar/issues/240#issuecomment-419445815 I repro'd on a checkout from when this was reported, and it looks like a

[GitHub] maskit commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-07 Thread GitBox
maskit commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419464632 > agreed. that's what I stated in the mail thread. what I need is a clear policy. the tool here is adding

[GitHub] david-streamlio closed pull request #2539: Elastic connector

2018-09-07 Thread GitBox
david-streamlio closed pull request #2539: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2539 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] massakam opened a new pull request #2542: Fix status code of REST API to get partitioned topic stats

2018-09-07 Thread GitBox
massakam opened a new pull request #2542: Fix status code of REST API to get partitioned topic stats URL: https://github.com/apache/incubator-pulsar/pull/2542 ### Motivation If trying to get stats of partitioned topic whose internal topics have not been generated, `500 Internal

[GitHub] codelipenghui opened a new pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC…

2018-09-07 Thread GitBox
codelipenghui opened a new pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC… URL: https://github.com/apache/incubator-pulsar/pull/2543 Support build Pulsar client with serviceUrlProvider method. ### Motivation With serviceUrlProvider

[GitHub] hrsakai commented on issue #2541: Enclose client_auth_params value in single quotes

2018-09-07 Thread GitBox
hrsakai commented on issue #2541: Enclose client_auth_params value in single quotes URL: https://github.com/apache/incubator-pulsar/pull/2541#issuecomment-41937 I may have misunderstood, so I close this once. This is an

[GitHub] hrsakai closed pull request #2541: Enclose client_auth_params value in single quotes

2018-09-07 Thread GitBox
hrsakai closed pull request #2541: Enclose client_auth_params value in single quotes URL: https://github.com/apache/incubator-pulsar/pull/2541 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sijie commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC…

2018-09-07 Thread GitBox
sijie commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC… URL: https://github.com/apache/incubator-pulsar/pull/2543#discussion_r216063192 ## File path:

[GitHub] sijie commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC…

2018-09-07 Thread GitBox
sijie commented on a change in pull request #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC… URL: https://github.com/apache/incubator-pulsar/pull/2543#discussion_r216063470 ## File path:

[GitHub] sijie commented on issue #2516: Fix: get function status with auth enable

2018-09-07 Thread GitBox
sijie commented on issue #2516: Fix: get function status with auth enable URL: https://github.com/apache/incubator-pulsar/pull/2516#issuecomment-419541323 @jerrypeng can you review this one? This is an automated message from

[GitHub] sijie commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord

2018-09-07 Thread GitBox
sijie commented on a change in pull request #2537: [schema] enable Schema.AUTO if functions or connectors are using GenericRecord URL: https://github.com/apache/incubator-pulsar/pull/2537#discussion_r216062802 ## File path: pulsar-functions/java-examples/pom.xml ## @@

[incubator-pulsar] branch master updated: fixed zookeeper name references in helm charts. (#2525)

2018-09-07 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 879c730 fixed zookeeper name

[GitHub] sijie closed pull request #2525: fixed zookeeper name references in helm charts.

2018-09-07 Thread GitBox
sijie closed pull request #2525: fixed zookeeper name references in helm charts. URL: https://github.com/apache/incubator-pulsar/pull/2525 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: support nested fields in Pulsar presto connector (#2515)

2018-09-07 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2023b48 support nested fields in

[GitHub] jerrypeng closed pull request #2515: support nested fields in Pulsar presto connector

2018-09-07 Thread GitBox
jerrypeng closed pull request #2515: support nested fields in Pulsar presto connector URL: https://github.com/apache/incubator-pulsar/pull/2515 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: set correct guice version to prevent dependency inject errors in docker container (#2534)

2018-09-07 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9f6f5c0 set correct guice version

[GitHub] jerrypeng closed pull request #2534: set correct guice version to prevent dependency inject errors in docker container

2018-09-07 Thread GitBox
jerrypeng closed pull request #2534: set correct guice version to prevent dependency inject errors in docker container URL: https://github.com/apache/incubator-pulsar/pull/2534 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] sijie commented on issue #2500: [schema] add schemas for primtive types

2018-09-07 Thread GitBox
sijie commented on issue #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500#issuecomment-419588399 retest this please This is an automated message from the Apache Git

[GitHub] sijie opened a new pull request #2545: [docker] introduce a pulsar standalone image

2018-09-07 Thread GitBox
sijie opened a new pull request #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545 ## Motivation `pulsar` and `pulsar-all` are designed for running pulsar components on production. although it can be used for running

[GitHub] david-streamlio opened a new pull request #2546: Elastic connector

2018-09-07 Thread GitBox
david-streamlio opened a new pull request #2546: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2546 ### Motivation Added a sink connector that writes JSON documents into ElasticSearch ### Modifications Added new pulsar-io module and associated

[GitHub] david-streamlio closed pull request #2539: Elastic connector

2018-09-07 Thread GitBox
david-streamlio closed pull request #2539: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2539 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] david-streamlio commented on issue #2539: Elastic connector

2018-09-07 Thread GitBox
david-streamlio commented on issue #2539: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2539#issuecomment-419580734 Going to create a new PR for this This is an automated message from the Apache Git

[GitHub] sijie commented on issue #2545: [docker] introduce a pulsar standalone image

2018-09-07 Thread GitBox
sijie commented on issue #2545: [docker] introduce a pulsar standalone image URL: https://github.com/apache/incubator-pulsar/pull/2545#issuecomment-419582422 @cckellogg ^^ This is an automated message from the Apache Git

[GitHub] srkukarni commented on a change in pull request #2546: Elastic connector

2018-09-07 Thread GitBox
srkukarni commented on a change in pull request #2546: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2546#discussion_r216108285 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java ##

[GitHub] srkukarni commented on a change in pull request #2546: Elastic connector

2018-09-07 Thread GitBox
srkukarni commented on a change in pull request #2546: Elastic connector URL: https://github.com/apache/incubator-pulsar/pull/2546#discussion_r216108235 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java ##