[GitHub] merlimat commented on a change in pull request #1319: Schema registry (2/N)

2018-03-02 Thread GitBox
merlimat commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171969057 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/schema/Schema.java ## @@ -0,0 +1,32 @@ +/** + *

[GitHub] merlimat commented on a change in pull request #1319: Schema registry (2/N)

2018-03-02 Thread GitBox
merlimat commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171965788 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/schema/SchemaVersion.java ## @@ -0,0 +1,26 @@

[GitHub] merlimat commented on a change in pull request #1319: Schema registry (2/N)

2018-03-02 Thread GitBox
merlimat commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171967465 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaStorage.java ## @@ -0,0

[GitHub] merlimat commented on a change in pull request #1319: Schema registry (2/N)

2018-03-02 Thread GitBox
merlimat commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r17197 ## File path: pulsar-broker/pom.xml ## @@ -54,6 +54,12 @@ netty-all + + com.google.protobuf +

[GitHub] merlimat commented on a change in pull request #1319: Schema registry (2/N)

2018-03-02 Thread GitBox
merlimat commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171965586 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/schema/Schema.java ## @@ -0,0 +1,32 @@ +/** + *

[GitHub] merlimat commented on a change in pull request #1319: Schema registry (2/N)

2018-03-02 Thread GitBox
merlimat commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171966891 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java ## @@ -288,6 +288,13 @@

[GitHub] merlimat commented on a change in pull request #1319: Schema registry (2/N)

2018-03-02 Thread GitBox
merlimat commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171967014 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/api/data/SchemaInfo.java ## @@ -0,0 +1,34 @@ +/**

[GitHub] merlimat commented on a change in pull request #1319: Schema registry (2/N)

2018-03-02 Thread GitBox
merlimat commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171902476 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryFormat.java ## @@

[GitHub] merlimat commented on a change in pull request #1319: Schema registry (2/N)

2018-03-02 Thread GitBox
merlimat commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171901176 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java ## @@ -125,4 +126,8 @@ void

[GitHub] merlimat commented on a change in pull request #1319: Schema registry (2/N)

2018-03-02 Thread GitBox
merlimat commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171966347 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java ## @@ -288,6 +288,13 @@

[GitHub] merlimat commented on a change in pull request #1319: Schema registry (2/N)

2018-03-02 Thread GitBox
merlimat commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171902129 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistry.java ## @@ -0,0