[GitHub] [incubator-tvm] mikeseven commented on issue #5102: [VOTE] VTA HW/SW refactor

2020-03-23 Thread GitBox
mikeseven commented on issue #5102: [VOTE] VTA HW/SW refactor URL: https://github.com/apache/incubator-tvm/issues/5102#issuecomment-602421538 +1 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-tvm] masahi merged pull request #4981: [Relay, Topi, TF Frontend] Isfinite operator

2020-03-23 Thread GitBox
masahi merged pull request #4981: [Relay, Topi, TF Frontend] Isfinite operator URL: https://github.com/apache/incubator-tvm/pull/4981 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] masahi commented on issue #4981: [Relay, Topi, TF Frontend] Isfinite operator

2020-03-23 Thread GitBox
masahi commented on issue #4981: [Relay, Topi, TF Frontend] Isfinite operator URL: https://github.com/apache/incubator-tvm/pull/4981#issuecomment-602530876 Merging it for now, thanks @maheshambule @jwfromm @FrozenGene This is

[incubator-tvm] branch master updated: [Relay, Topi, TF Frontend] Isfinite operator (#4981)

2020-03-23 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 9037f4e [Relay, Topi, TF Frontend] Isfin

[GitHub] [incubator-tvm] Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core

2020-03-23 Thread GitBox
Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core URL: https://github.com/apache/incubator-tvm/pull/5099#discussion_r396376850 ## File path: topi/python/topi/cuda/conv2d_nhwc_tensorcore.py ## @@ -0,0 +

[GitHub] [incubator-tvm] Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core

2020-03-23 Thread GitBox
Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core URL: https://github.com/apache/incubator-tvm/pull/5099#discussion_r396380908 ## File path: topi/python/topi/cuda/conv2d_nhwc_tensorcore.py ## @@ -0,0 +

[GitHub] [incubator-tvm] Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core

2020-03-23 Thread GitBox
Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core URL: https://github.com/apache/incubator-tvm/pull/5099#discussion_r396380908 ## File path: topi/python/topi/cuda/conv2d_nhwc_tensorcore.py ## @@ -0,0 +

[GitHub] [incubator-tvm] Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core

2020-03-23 Thread GitBox
Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core URL: https://github.com/apache/incubator-tvm/pull/5099#discussion_r396381225 ## File path: topi/python/topi/cuda/conv2d_nhwc_tensorcore.py ## @@ -0,0 +

[GitHub] [incubator-tvm] Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core

2020-03-23 Thread GitBox
Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core URL: https://github.com/apache/incubator-tvm/pull/5099#discussion_r396384057 ## File path: topi/python/topi/cuda/dense_tensorcore.py ## @@ -0,0 +1,290

[GitHub] [incubator-tvm] masahi opened a new pull request #5132: [Torch] Fix conv2d conversion for group conv (group > 1 but != in channels)

2020-03-23 Thread GitBox
masahi opened a new pull request #5132: [Torch] Fix conv2d conversion for group conv (group > 1 but != in channels) URL: https://github.com/apache/incubator-tvm/pull/5132 Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and

[GitHub] [incubator-tvm] Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core

2020-03-23 Thread GitBox
Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core URL: https://github.com/apache/incubator-tvm/pull/5099#discussion_r396385361 ## File path: topi/tests/python/test_topi_conv2d_nhwc_tensorcore.py ## @@

[GitHub] [incubator-tvm] maheshambule commented on issue #4981: [Relay, Topi, TF Frontend] Isfinite operator

2020-03-23 Thread GitBox
maheshambule commented on issue #4981: [Relay, Topi, TF Frontend] Isfinite operator URL: https://github.com/apache/incubator-tvm/pull/4981#issuecomment-602538577 Thanks @masahi. I will try to check for the exact use case and will let you know. Also, the proposal to add support to fallba

[GitHub] [incubator-tvm] maheshambule commented on issue #5082: [Relay, Topi] [TF, MXNet] Unravel Index operator

2020-03-23 Thread GitBox
maheshambule commented on issue #5082: [Relay, Topi] [TF, MXNet] Unravel Index operator URL: https://github.com/apache/incubator-tvm/pull/5082#issuecomment-602539164 Thanks @jwfromm, @masahi for review and comments. This is a

[GitHub] [incubator-tvm] Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core

2020-03-23 Thread GitBox
Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core URL: https://github.com/apache/incubator-tvm/pull/5099#discussion_r396387219 ## File path: topi/python/topi/cuda/conv2d_nhwc_tensorcore.py ## @@ -0,0 +

[GitHub] [incubator-tvm] masahi opened a new issue #5133: [Torch] A list of missing op conversion in need of help

2020-03-23 Thread GitBox
masahi opened a new issue #5133: [Torch] A list of missing op conversion in need of help URL: https://github.com/apache/incubator-tvm/issues/5133 Let's keep a list of missing conversion reported so far here. The list will continue to grow as Torch has too many ops. cc @alexwong @jwfromm @

[GitHub] [incubator-tvm] masahi commented on issue #5079: NotImplementedError: The following operators are not implemented: ['aten::split']

2020-03-23 Thread GitBox
masahi commented on issue #5079: NotImplementedError: The following operators are not implemented: ['aten::split'] URL: https://github.com/apache/incubator-tvm/issues/5079#issuecomment-602572214 Added to the list. See https://github.com/apache/incubator-tvm/issues/5133

[GitHub] [incubator-tvm] masahi closed issue #5079: NotImplementedError: The following operators are not implemented: ['aten::split']

2020-03-23 Thread GitBox
masahi closed issue #5079: NotImplementedError: The following operators are not implemented: ['aten::split'] URL: https://github.com/apache/incubator-tvm/issues/5079 This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core

2020-03-23 Thread GitBox
Shawn-Inspur commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core URL: https://github.com/apache/incubator-tvm/pull/5099#discussion_r396531303 ## File path: topi/tests/python/test_topi_dense_tensorcore.py ## @@ -0,0 +

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5128: [Refactor] Relay Node::make to constructor

2020-03-23 Thread GitBox
tqchen commented on a change in pull request #5128: [Refactor] Relay Node::make to constructor URL: https://github.com/apache/incubator-tvm/pull/5128#discussion_r396545827 ## File path: include/tvm/relay/adt.h ## @@ -28,9 +28,10 @@ #include #include #include -#includ

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5128: [Refactor] Relay Node::make to constructor

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5128: [Refactor] Relay Node::make to constructor URL: https://github.com/apache/incubator-tvm/pull/5128#discussion_r396547261 ## File path: include/tvm/relay/adt.h ## @@ -91,13 +91,9 @@ class PatternVar; /*! \brief PatternVar

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5128: [Refactor] Relay Node::make to constructor

2020-03-23 Thread GitBox
tqchen commented on a change in pull request #5128: [Refactor] Relay Node::make to constructor URL: https://github.com/apache/incubator-tvm/pull/5128#discussion_r396547387 ## File path: src/tir/ir/data_layout.cc ## @@ -350,20 +350,16 @@ Array BijectiveLayout::BackwardShape

[GitHub] [incubator-tvm] tqchen commented on issue #5124: [uTVM][Runtime] Introduce Virtual Memory Allocator to CRT

2020-03-23 Thread GitBox
tqchen commented on issue #5124: [uTVM][Runtime] Introduce Virtual Memory Allocator to CRT URL: https://github.com/apache/incubator-tvm/pull/5124#issuecomment-602682420 cc @tmoreau89 @ajtulloch @ZihengJiang @weberlo please help to take a look ---

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization

2020-03-23 Thread GitBox
tqchen commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization URL: https://github.com/apache/incubator-tvm/pull/5121#discussion_r396549865 ## File path: include/tvm/te/autodiff.h ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization

2020-03-23 Thread GitBox
tqchen commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization URL: https://github.com/apache/incubator-tvm/pull/5121#discussion_r396549865 ## File path: include/tvm/te/autodiff.h ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] tqchen merged pull request #5115: [Bugfix] Fixed bug where shifting by out-of-bounds value results in no compute code being emitted.

2020-03-23 Thread GitBox
tqchen merged pull request #5115: [Bugfix] Fixed bug where shifting by out-of-bounds value results in no compute code being emitted. URL: https://github.com/apache/incubator-tvm/pull/5115 This is an automated message from th

[GitHub] [incubator-tvm] tqchen commented on issue #5115: [Bugfix] Fixed bug where shifting by out-of-bounds value results in no compute code being emitted.

2020-03-23 Thread GitBox
tqchen commented on issue #5115: [Bugfix] Fixed bug where shifting by out-of-bounds value results in no compute code being emitted. URL: https://github.com/apache/incubator-tvm/pull/5115#issuecomment-602685970 Thanks @dpankratz !

[incubator-tvm] branch master updated: [Bugfix] Fixed bug where shifting by out-of-bounds value results in no compute code being emitted. (#5115)

2020-03-23 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new a422589 [Bugfix] Fixed bug where shiftin

[GitHub] [incubator-tvm] mbaret commented on issue #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
mbaret commented on issue #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#issuecomment-602701366 cc @zhiics @comaniac @tqchen This is an automated message from the A

[GitHub] [incubator-tvm] mbaret commented on issue #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
mbaret commented on issue #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#issuecomment-602704711 Removed mentions of 'subgraph' and replaced this with the term 'AnnotatedRegion'. ---

[GitHub] [incubator-tvm] comaniac commented on issue #5131: register topi schedule for Relay fast_exp and fast_tanh

2020-03-23 Thread GitBox
comaniac commented on issue #5131: register topi schedule for Relay fast_exp and fast_tanh URL: https://github.com/apache/incubator-tvm/pull/5131#issuecomment-602709689 Could we have a unit test to guard this issue in the future? cc @icemelon9 --

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
MarisaKirisame commented on a change in pull request #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396596815 ## File path: src/relay/transforms/gradient_cell.cc ## @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
MarisaKirisame commented on a change in pull request #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396597422 ## File path: src/relay/transforms/gradient_cell.cc ## @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] mbaret opened a new pull request #5134: [RELAY] Add MergeCompilerRegions pass

2020-03-23 Thread GitBox
mbaret opened a new pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134 This is part of the infrastructure necessary to support multiple outputs in the BYOC graph partitioning framework. It corresponds to step 3 of the flow outli

[GitHub] [incubator-tvm] mbaret commented on issue #5134: [RELAY] Add MergeCompilerRegions pass

2020-03-23 Thread GitBox
mbaret commented on issue #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#issuecomment-602732171 cc @zhiics @comaniac @masahi @tqchen This is an automated message from the A

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
comaniac commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396598730 ## File path: python/tvm/relay/analysis/__init__.py ## @@ -19,9 +19,15 @@ # Analysis passes fr

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
comaniac commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396604369 ## File path: src/relay/analysis/annotated_region_set.cc ## @@ -0,0 +1,239 @@ +/* + * Licensed t

[incubator-tvm] branch master updated (a422589 -> 7bc0b27)

2020-03-23 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from a422589 [Bugfix] Fixed bug where shifting by out-of-bounds value results in no compute code being emitted. (#5

[GitHub] [incubator-tvm] zhiics merged pull request #5020: [Frontend][TensorFlow]TensorFlow Parser Control Flow Enhancement

2020-03-23 Thread GitBox
zhiics merged pull request #5020: [Frontend][TensorFlow]TensorFlow Parser Control Flow Enhancement URL: https://github.com/apache/incubator-tvm/pull/5020 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-tvm] zhiics commented on issue #5020: [Frontend][TensorFlow]TensorFlow Parser Control Flow Enhancement

2020-03-23 Thread GitBox
zhiics commented on issue #5020: [Frontend][TensorFlow]TensorFlow Parser Control Flow Enhancement URL: https://github.com/apache/incubator-tvm/pull/5020#issuecomment-602744862 Thanks @kevinthesun This is an automated message

[GitHub] [incubator-tvm] hzfan commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization

2020-03-23 Thread GitBox
hzfan commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization URL: https://github.com/apache/incubator-tvm/pull/5121#discussion_r396628415 ## File path: src/te/autodiff/jacobian.cc ## @@ -0,0 +1,381 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] hzfan commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization

2020-03-23 Thread GitBox
hzfan commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization URL: https://github.com/apache/incubator-tvm/pull/5121#discussion_r396631729 ## File path: python/tvm/te/autodiff.py ## @@ -0,0 +1,72 @@ +# Licensed to the Apache Softwar

[GitHub] [incubator-tvm] tqchen merged pull request #5129: [DOCS] Minimize necessary doc change

2020-03-23 Thread GitBox
tqchen merged pull request #5129: [DOCS] Minimize necessary doc change URL: https://github.com/apache/incubator-tvm/pull/5129 This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-tvm] branch master updated: [DOCS] Minimize necessary doc change (#5129)

2020-03-23 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 1405b7b [DOCS] Minimize necessary doc ch

[GitHub] [incubator-tvm] siju-samuel opened a new pull request #5135: [ONNX]Pool3d & upsample3d op support

2020-03-23 Thread GitBox
siju-samuel opened a new pull request #5135: [ONNX]Pool3d & upsample3d op support URL: https://github.com/apache/incubator-tvm/pull/5135 Pool3d(fix) and upsample op for onnx frontend. @FrozenGene @masahi @zhiics Please help to review and merge this PR. Thanks for contributing to

[GitHub] [incubator-tvm] hypercubestart commented on a change in pull request #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
hypercubestart commented on a change in pull request #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396652494 ## File path: src/relay/transforms/gradient_cell.cc ## @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] tqchen merged pull request #5128: [Refactor] Relay Node::make to constructor

2020-03-23 Thread GitBox
tqchen merged pull request #5128: [Refactor] Relay Node::make to constructor URL: https://github.com/apache/incubator-tvm/pull/5128 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-tvm] tqchen closed issue #5069: [RELAY] Update the C++ Node convention

2020-03-23 Thread GitBox
tqchen closed issue #5069: [RELAY] Update the C++ Node convention URL: https://github.com/apache/incubator-tvm/issues/5069 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-tvm] branch master updated (1405b7b -> 2adcb73)

2020-03-23 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 1405b7b [DOCS] Minimize necessary doc change (#5129) add 2adcb73 [Refactor] Relay Node::make to constru

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396636430 ## File path: python/tvm/relay/analysis/annotated_regions.py ## @@ -0,0 +1,62 @@ +# Licensed to th

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396600188 ## File path: python/tvm/relay/analysis/__init__.py ## @@ -19,9 +19,15 @@ # Analysis passes from

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396652760 ## File path: src/relay/analysis/annotated_region_set.cc ## @@ -0,0 +1,239 @@ +/* + * Licensed to

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396646449 ## File path: src/relay/analysis/annotated_region_set.h ## @@ -0,0 +1,277 @@ +/* + * Licensed to t

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396652235 ## File path: src/relay/analysis/annotated_region_set.cc ## @@ -0,0 +1,239 @@ +/* + * Licensed to

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396644680 ## File path: src/relay/analysis/annotated_region_set.h ## @@ -0,0 +1,277 @@ +/* + * Licensed to t

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396639383 ## File path: src/relay/analysis/annotated_region_set.h ## @@ -0,0 +1,277 @@ +/* + * Licensed to t

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396643280 ## File path: src/relay/analysis/annotated_region_set.h ## @@ -0,0 +1,277 @@ +/* + * Licensed to t

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396641051 ## File path: src/relay/analysis/annotated_region_set.h ## @@ -0,0 +1,277 @@ +/* + * Licensed to t

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396658432 ## File path: python/tvm/relay/analysis/annotated_regions.py ## @@ -0,0 +1,62 @@ +# Licensed to th

[GitHub] [incubator-tvm] zhiics commented on issue #5135: [ONNX]Pool3d & upsample3d op support

2020-03-23 Thread GitBox
zhiics commented on issue #5135: [ONNX]Pool3d & upsample3d op support URL: https://github.com/apache/incubator-tvm/pull/5135#issuecomment-602778625 cc @cchung100m and @jwfromm as you guys have more experience on ONNX This is a

[GitHub] [incubator-tvm] tmoreau89 commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime

2020-03-23 Thread GitBox
tmoreau89 commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime URL: https://github.com/apache/incubator-tvm/issues/5060#issuecomment-602779963 @liangfu regarding "superseding uTVM standalone runtime", will MISRA-C runtime support running on bare-metal systems? -

[GitHub] [incubator-tvm] tmoreau89 commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime

2020-03-23 Thread GitBox
tmoreau89 commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime URL: https://github.com/apache/incubator-tvm/issues/5060#issuecomment-602780418 @ajtulloch @weberlo @u99127 (this might be of interest to you) -

[GitHub] [incubator-tvm] hypercubestart commented on a change in pull request #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
hypercubestart commented on a change in pull request #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396670706 ## File path: src/relay/transforms/gradient_cell.cc ## @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #5124: [uTVM][Runtime] Introduce Virtual Memory Allocator to CRT

2020-03-23 Thread GitBox
tmoreau89 commented on a change in pull request #5124: [uTVM][Runtime] Introduce Virtual Memory Allocator to CRT URL: https://github.com/apache/incubator-tvm/pull/5124#discussion_r396667543 ## File path: src/runtime/crt/crt_runtime_api.c ## @@ -79,7 +79,7 @@ int TVMModGetF

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #5124: [uTVM][Runtime] Introduce Virtual Memory Allocator to CRT

2020-03-23 Thread GitBox
tmoreau89 commented on a change in pull request #5124: [uTVM][Runtime] Introduce Virtual Memory Allocator to CRT URL: https://github.com/apache/incubator-tvm/pull/5124#discussion_r396671649 ## File path: apps/bundle_deploy/Makefile ## @@ -37,6 +37,9 @@ demo: $(build_dir)/d

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #5124: [uTVM][Runtime] Introduce Virtual Memory Allocator to CRT

2020-03-23 Thread GitBox
tmoreau89 commented on a change in pull request #5124: [uTVM][Runtime] Introduce Virtual Memory Allocator to CRT URL: https://github.com/apache/incubator-tvm/pull/5124#discussion_r39973 ## File path: src/runtime/crt/graph_runtime.c ## @@ -208,20 +218,24 @@ int TVMGrap

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization

2020-03-23 Thread GitBox
yzhliu commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization URL: https://github.com/apache/incubator-tvm/pull/5121#discussion_r396670848 ## File path: python/tvm/testing.py ## @@ -68,6 +69,10 @@ def check_numerical_grads(function

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization

2020-03-23 Thread GitBox
yzhliu commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization URL: https://github.com/apache/incubator-tvm/pull/5121#discussion_r396681870 ## File path: python/tvm/te/autodiff.py ## @@ -0,0 +1,72 @@ +# Licensed to the Apache Softwa

[GitHub] [incubator-tvm] tqchen commented on issue #5128: [Refactor] Relay Node::make to constructor

2020-03-23 Thread GitBox
tqchen commented on issue #5128: [Refactor] Relay Node::make to constructor URL: https://github.com/apache/incubator-tvm/pull/5128#issuecomment-602796108 @zhiics would you be able to do a quick patch to fix the remaining issue on the master?

[GitHub] [incubator-tvm] zhiics commented on issue #5128: [Refactor] Relay Node::make to constructor

2020-03-23 Thread GitBox
zhiics commented on issue #5128: [Refactor] Relay Node::make to constructor URL: https://github.com/apache/incubator-tvm/pull/5128#issuecomment-602821236 I can spend some time on it late today? could you please give a pointer to the remaining issue?

[GitHub] [incubator-tvm] tqchen commented on issue #5128: [Refactor] Relay Node::make to constructor

2020-03-23 Thread GitBox
tqchen commented on issue #5128: [Refactor] Relay Node::make to constructor URL: https://github.com/apache/incubator-tvm/pull/5128#issuecomment-602826462 Seems was a false alarm, neve rmind This is an automated message from th

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
mbaret commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396727369 ## File path: python/tvm/relay/analysis/annotated_regions.py ## @@ -0,0 +1,62 @@ +# Licensed to th

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
mbaret commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396727704 ## File path: src/relay/analysis/annotated_region_set.h ## @@ -0,0 +1,277 @@ +/* + * Licensed to t

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
mbaret commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396728879 ## File path: src/relay/analysis/annotated_region_set.h ## @@ -0,0 +1,277 @@ +/* + * Licensed to t

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
mbaret commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396729916 ## File path: python/tvm/relay/analysis/annotated_regions.py ## @@ -0,0 +1,62 @@ +# Licensed to th

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396765779 ## File path: python/tvm/relay/analysis/annotated_regions.py ## @@ -0,0 +1,62 @@ +# Licensed to th

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

2020-03-23 Thread GitBox
zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396765779 ## File path: python/tvm/relay/analysis/annotated_regions.py ## @@ -0,0 +1,62 @@ +# Licensed to th

[GitHub] [incubator-tvm] shoubhik opened a new pull request #5136: Fix for issue #4831. The data_min_idx and data_max_idx were flipped.

2020-03-23 Thread GitBox
shoubhik opened a new pull request #5136: Fix for issue #4831. The data_min_idx and data_max_idx were flipped. URL: https://github.com/apache/incubator-tvm/pull/5136 Existing test cases cover this fix. In addition I have added an assert to make sure that the data_min is always less than eq

[GitHub] [incubator-tvm] shoubhik commented on issue #5136: Fix for issue #4831. The data_min_idx and data_max_idx were flipped.

2020-03-23 Thread GitBox
shoubhik commented on issue #5136: Fix for issue #4831. The data_min_idx and data_max_idx were flipped. URL: https://github.com/apache/incubator-tvm/pull/5136#issuecomment-602867946 @anijain2305 and @GuoliangLiCN can you take a look at the fix. -

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization

2020-03-23 Thread GitBox
yzhliu commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization URL: https://github.com/apache/incubator-tvm/pull/5121#discussion_r396785055 ## File path: src/te/autodiff/jacobian.cc ## @@ -0,0 +1,381 @@ +/* + * Licensed to the Apach

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #5132: [Torch] Fix conv2d conversion for group conv (group > 1 but != in channels)

2020-03-23 Thread GitBox
jwfromm commented on a change in pull request #5132: [Torch] Fix conv2d conversion for group conv (group > 1 but != in channels) URL: https://github.com/apache/incubator-tvm/pull/5132#discussion_r396793785 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -250,7 +25

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #5135: [ONNX]Pool3d & upsample3d op support

2020-03-23 Thread GitBox
jwfromm commented on a change in pull request #5135: [ONNX]Pool3d & upsample3d op support URL: https://github.com/apache/incubator-tvm/pull/5135#discussion_r396796126 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -780,19 +784,36 @@ def _impl_v9(cls, inputs, attr, p

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #5135: [ONNX]Pool3d & upsample3d op support

2020-03-23 Thread GitBox
jwfromm commented on a change in pull request #5135: [ONNX]Pool3d & upsample3d op support URL: https://github.com/apache/incubator-tvm/pull/5135#discussion_r396797603 ## File path: tests/python/frontend/onnx/test_forward.py ## @@ -800,11 +824,45 @@ def _test_upsample_bilin

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #5135: [ONNX]Pool3d & upsample3d op support

2020-03-23 Thread GitBox
jwfromm commented on a change in pull request #5135: [ONNX]Pool3d & upsample3d op support URL: https://github.com/apache/incubator-tvm/pull/5135#discussion_r396797392 ## File path: tests/python/frontend/onnx/test_forward.py ## @@ -741,6 +741,30 @@ def _test_upsample_neares

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #5135: [ONNX]Pool3d & upsample3d op support

2020-03-23 Thread GitBox
jwfromm commented on a change in pull request #5135: [ONNX]Pool3d & upsample3d op support URL: https://github.com/apache/incubator-tvm/pull/5135#discussion_r396796719 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -780,19 +784,36 @@ def _impl_v9(cls, inputs, attr, p

[GitHub] [incubator-tvm] liangfu commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime

2020-03-23 Thread GitBox
liangfu commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime URL: https://github.com/apache/incubator-tvm/issues/5060#issuecomment-602903542 > @liangfu regarding "superseding uTVM standalone runtime", will MISRA-C runtime support running on bare-metal systems?

[GitHub] [incubator-tvm] tmoreau89 commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime

2020-03-23 Thread GitBox
tmoreau89 commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime URL: https://github.com/apache/incubator-tvm/issues/5060#issuecomment-602905526 We can test it on the STM board that @weberlo implemented a demo on: https://github.com/apache/incubator-tvm/pull/4274

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization

2020-03-23 Thread GitBox
MarisaKirisame commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization URL: https://github.com/apache/incubator-tvm/pull/5121#discussion_r396814133 ## File path: python/tvm/testing.py ## @@ -68,6 +69,10 @@ def check_numerical_grads(

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization

2020-03-23 Thread GitBox
MarisaKirisame commented on a change in pull request #5121: [TE] reverse-mode autodiff without any optimization URL: https://github.com/apache/incubator-tvm/pull/5121#discussion_r396814445 ## File path: src/te/autodiff/jacobian.cc ## @@ -0,0 +1,381 @@ +/* + * Licensed to t

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396822569 ## File path: python/tvm/relay/transform/transform.py ## @@ -219,6 +219,18 @@ def DeadCodeElimination(inline_on

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396822650 ## File path: python/tvm/relay/transform/transform.py ## @@ -219,6 +219,18 @@ def DeadCodeElimination(inline_on

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396822885 ## File path: src/relay/transforms/gradient_cell.cc ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396822980 ## File path: src/relay/transforms/gradient_cell.cc ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396823122 ## File path: src/relay/transforms/gradient_cell.cc ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396823052 ## File path: src/relay/transforms/gradient_cell.cc ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396823191 ## File path: src/relay/transforms/gradient_cell.cc ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
jroesch commented on a change in pull request #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396823371 ## File path: tests/python/relay/test_pass_gradient_cell.py ## @@ -0,0 +1,401 @@ +# Licensed to the Apache Soft

[GitHub] [incubator-tvm] jroesch commented on issue #5052: Relay to ONNX converter

2020-03-23 Thread GitBox
jroesch commented on issue #5052: Relay to ONNX converter URL: https://github.com/apache/incubator-tvm/pull/5052#issuecomment-602918319 cc @tqchen RE: naming I think we should probably refer to these as `exporters` or some kind of specialized `target`. Conversion is always no

[GitHub] [incubator-tvm] jwfromm commented on issue #5039: [Relay] GradientCell Relay Pass

2020-03-23 Thread GitBox
jwfromm commented on issue #5039: [Relay] GradientCell Relay Pass URL: https://github.com/apache/incubator-tvm/pull/5039#issuecomment-602919614 It would be great if you can add some information on why this pass is useful / needed. I understand that its important to conserve memory when comp

[GitHub] [incubator-tvm] masahi merged pull request #5116: Add thrust support for nms

2020-03-23 Thread GitBox
masahi merged pull request #5116: Add thrust support for nms URL: https://github.com/apache/incubator-tvm/pull/5116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-tvm] masahi commented on issue #5116: Add thrust support for nms

2020-03-23 Thread GitBox
masahi commented on issue #5116: Add thrust support for nms URL: https://github.com/apache/incubator-tvm/pull/5116#issuecomment-602921562 Thanks @Laurawly @kazum This is an automated message from the Apache Git Service. To re

  1   2   >