[jira] [Updated] (HADOOP-15616) Incorporate Tencent Cloud COS File System Implementation

2019-05-09 Thread YangY (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YangY updated HADOOP-15616: --- Attachment: (was: HADOOP-15616.010.patch) > Incorporate Tencent Cloud COS File System Implementation >

[jira] [Updated] (HADOOP-15616) Incorporate Tencent Cloud COS File System Implementation

2019-05-09 Thread YangY (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YangY updated HADOOP-15616: --- Attachment: HADOOP-15616.010.patch > Incorporate Tencent Cloud COS File System Implementation >

[jira] [Comment Edited] (HADOOP-16247) NPE in FsUrlConnection

2019-05-09 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836875#comment-16836875 ] Bharat Viswanadham edited comment on HADOOP-16247 at 5/10/19 4:56 AM:

[jira] [Commented] (HADOOP-16247) NPE in FsUrlConnection

2019-05-09 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836875#comment-16836875 ] Bharat Viswanadham commented on HADOOP-16247: - +1 LGTM. I Will wait for a couple of days

[jira] [Comment Edited] (HADOOP-16247) NPE in FsUrlConnection

2019-05-09 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836875#comment-16836875 ] Bharat Viswanadham edited comment on HADOOP-16247 at 5/10/19 4:38 AM:

[GitHub] [hadoop] ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-09 Thread GitBox
ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-491144178 Some weird stuff is going on in `testRenameEventuallyConsistentDirectory`

[jira] [Commented] (HADOOP-16247) NPE in FsUrlConnection

2019-05-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836848#comment-16836848 ] Hadoop QA commented on HADOOP-16247: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] arp7 opened a new pull request #811: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contri…

2019-05-09 Thread GitBox
arp7 opened a new pull request #811: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contri… URL: https://github.com/apache/hadoop/pull/811 …buted by Supratim Deka This is an automated message from the Apache

[GitHub] [hadoop] hadoop-yetus commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-09 Thread GitBox
hadoop-yetus commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#issuecomment-491126699 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file.

2019-05-09 Thread GitBox
hadoop-yetus commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file. URL: https://github.com/apache/hadoop/pull/795#issuecomment-491124559 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16247) NPE in FsUrlConnection

2019-05-09 Thread Karthik Palanisamy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836818#comment-16836818 ] Karthik Palanisamy commented on HADOOP-16247: - Thank you [~bharatviswa] for reviewing this

[jira] [Updated] (HADOOP-16247) NPE in FsUrlConnection

2019-05-09 Thread Karthik Palanisamy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Palanisamy updated HADOOP-16247: Attachment: HADOOP-16247-008.patch > NPE in FsUrlConnection >

[GitHub] [hadoop] hanishakoneru commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file.

2019-05-09 Thread GitBox
hanishakoneru commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file. URL: https://github.com/apache/hadoop/pull/795#issuecomment-491110158 Thank you @bshashikant for the review. I have addressed your review comments. Also, there was a mistake

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-09 Thread GitBox
bharatviswa504 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#discussion_r282709424 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-09 Thread GitBox
bharatviswa504 commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#issuecomment-491109791 Thank You @lokeshj1703 for the review. I have addressed the review comments.

[GitHub] [hadoop] hanishakoneru commented on issue #809: HDDS-1474. "ozone.scm.datanode.id" config should take path for a dir and not a file

2019-05-09 Thread GitBox
hanishakoneru commented on issue #809: HDDS-1474. "ozone.scm.datanode.id" config should take path for a dir and not a file URL: https://github.com/apache/hadoop/pull/809#issuecomment-491109589 LGTM. +1. Will merge the PR. Thanks @vivekratnavel

[GitHub] [hadoop] hanishakoneru merged pull request #809: HDDS-1474. "ozone.scm.datanode.id" config should take path for a dir and not a file

2019-05-09 Thread GitBox
hanishakoneru merged pull request #809: HDDS-1474. "ozone.scm.datanode.id" config should take path for a dir and not a file URL: https://github.com/apache/hadoop/pull/809 This is an automated message from the Apache Git

[jira] [Commented] (HADOOP-16286) Add opentracing into KMS server/client

2019-05-09 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836787#comment-16836787 ] Wei-Chiu Chuang commented on HADOOP-16286: -- This is a work in progress, but I have to post it

[jira] [Comment Edited] (HADOOP-16247) NPE in FsUrlConnection

2019-05-09 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836742#comment-16836742 ] Bharat Viswanadham edited comment on HADOOP-16247 at 5/9/19 10:19 PM:

[jira] [Commented] (HADOOP-16247) NPE in FsUrlConnection

2019-05-09 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836742#comment-16836742 ] Bharat Viswanadham commented on HADOOP-16247: - +1. Could you add some explanation for the

[GitHub] [hadoop] hadoop-yetus commented on issue #809: HDDS-1474. "ozone.scm.datanode.id" config should take path for a dir and not a file

2019-05-09 Thread GitBox
hadoop-yetus commented on issue #809: HDDS-1474. "ozone.scm.datanode.id" config should take path for a dir and not a file URL: https://github.com/apache/hadoop/pull/809#issuecomment-491063721 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-15183) S3Guard store becomes inconsistent after partial failure of rename

2019-05-09 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836690#comment-16836690 ] Steve Loughran commented on HADOOP-15183: - HADOOP-15604 also has the bulk update problem; I'm

[GitHub] [hadoop] bharatviswa504 commented on issue #810: HDDS-1512. Implement DoubleBuffer in OzoneManager.

2019-05-09 Thread GitBox
bharatviswa504 commented on issue #810: HDDS-1512. Implement DoubleBuffer in OzoneManager. URL: https://github.com/apache/hadoop/pull/810#issuecomment-491059971 cc @anuengineer (I am not able to add you in reviewer, tagging here to notify about this)

[GitHub] [hadoop] bharatviswa504 opened a new pull request #810: HDDS-1512. Implement DoubleBuffer in OzoneManager.

2019-05-09 Thread GitBox
bharatviswa504 opened a new pull request #810: HDDS-1512. Implement DoubleBuffer in OzoneManager. URL: https://github.com/apache/hadoop/pull/810 1. In this Jira added double buffer implementation. (Not integrated to OM, this will be done in further jira's) 2. Added a few response

[GitHub] [hadoop] steveloughran commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-05-09 Thread GitBox
steveloughran commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/654#issuecomment-491055414 Test failure: interesting. Will fix. For people watching this, rename seems happy, but I don't

[jira] [Commented] (HADOOP-16278) With S3A Filesystem, Long Running services End up Doing lot of GC and eventually die

2019-05-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836670#comment-16836670 ] Hudson commented on HADOOP-16278: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16534 (See

[GitHub] [hadoop] ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-09 Thread GitBox
ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-491052429 > BTW, note that the CopyOutcome class only stores SdkBaseExceptions raised in

[jira] [Updated] (HADOOP-16278) With S3A Filesystem, Long Running services End up Doing lot of GC and eventually die

2019-05-09 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16278: Resolution: Fixed Status: Resolved (was: Patch Available) +1 committed to

[jira] [Assigned] (HADOOP-16278) With S3A Filesystem, Long Running services End up Doing lot of GC and eventually die

2019-05-09 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-16278: --- Assignee: Rajat Khandelwal > With S3A Filesystem, Long Running services End up

[jira] [Updated] (HADOOP-16278) With S3A Filesystem, Long Running services End up Doing lot of GC and eventually die

2019-05-09 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16278: Fix Version/s: 3.2.1 3.3.0 > With S3A Filesystem, Long Running

[GitHub] [hadoop] ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-09 Thread GitBox
ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-491047554 Good catches. This retry stuff is a bit tricky. I obviously overlooked the

[jira] [Commented] (HADOOP-15616) Incorporate Tencent Cloud COS File System Implementation

2019-05-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836664#comment-16836664 ] Hadoop QA commented on HADOOP-15616: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] vivekratnavel commented on issue #809: HDDS-1474. "ozone.scm.datanode.id" config should take path for a dir and not a file

2019-05-09 Thread GitBox
vivekratnavel commented on issue #809: HDDS-1474. "ozone.scm.datanode.id" config should take path for a dir and not a file URL: https://github.com/apache/hadoop/pull/809#issuecomment-491046014 /label ozone This is an

[GitHub] [hadoop] vivekratnavel opened a new pull request #809: HDDS-1474. "ozone.scm.datanode.id" config should take path for a dir and not a file

2019-05-09 Thread GitBox
vivekratnavel opened a new pull request #809: HDDS-1474. "ozone.scm.datanode.id" config should take path for a dir and not a file URL: https://github.com/apache/hadoop/pull/809 Currently, the ozone config "ozone.scm.datanode.id" takes file path as its value. It should instead take dir

[GitHub] [hadoop] hadoop-yetus commented on issue #807: HADOOP-16085 S3Guard versioning (stevel patch 002)

2019-05-09 Thread GitBox
hadoop-yetus commented on issue #807: HADOOP-16085 S3Guard versioning (stevel patch 002) URL: https://github.com/apache/hadoop/pull/807#issuecomment-491025222 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #798: HDDS-1499. OzoneManager Cache.

2019-05-09 Thread GitBox
hadoop-yetus commented on issue #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#issuecomment-491023563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 |

[jira] [Assigned] (HADOOP-16305) hadoop-functions.sh Cannot set priority of daemon process misleads

2019-05-09 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhu Joseph reassigned HADOOP-16305: -- Assignee: Prabhu Joseph > hadoop-functions.sh Cannot set priority of daemon process

[jira] [Commented] (HADOOP-16251) ABFS: add FSMainOperationsBaseTest

2019-05-09 Thread Aaron Fabbri (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836626#comment-16836626 ] Aaron Fabbri commented on HADOOP-16251: --- I had one remaining question on your Ignore annotation

[GitHub] [hadoop] ajfabbri commented on a change in pull request #787: HADOOP-16251. ABFS: add FSMainOperationsBaseTest

2019-05-09 Thread GitBox
ajfabbri commented on a change in pull request #787: HADOOP-16251. ABFS: add FSMainOperationsBaseTest URL: https://github.com/apache/hadoop/pull/787#discussion_r282611587 ## File path:

[GitHub] [hadoop] steveloughran commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-09 Thread GitBox
steveloughran commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-491013417 That'd be great. If you turn @debug logging on for the tests you can get a

[jira] [Updated] (HADOOP-15616) Incorporate Tencent Cloud COS File System Implementation

2019-05-09 Thread YangY (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YangY updated HADOOP-15616: --- Attachment: HADOOP-15616.010.patch > Incorporate Tencent Cloud COS File System Implementation >

[GitHub] [hadoop] hanishakoneru merged pull request #808: Revert "HDDS-1474. ozone.scm.datanode.id config should take path for a dir "

2019-05-09 Thread GitBox
hanishakoneru merged pull request #808: Revert "HDDS-1474. ozone.scm.datanode.id config should take path for a dir " URL: https://github.com/apache/hadoop/pull/808 This is an automated message from the Apache Git Service.

[GitHub] [hadoop] hanishakoneru opened a new pull request #808: Revert "HDDS-1474. ozone.scm.datanode.id config should take path for a dir "

2019-05-09 Thread GitBox
hanishakoneru opened a new pull request #808: Revert "HDDS-1474. ozone.scm.datanode.id config should take path for a dir " URL: https://github.com/apache/hadoop/pull/808 Reverts apache/hadoop#792 This is an automated message

[GitHub] [hadoop] hanishakoneru commented on issue #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir

2019-05-09 Thread GitBox
hanishakoneru commented on issue #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir URL: https://github.com/apache/hadoop/pull/792#issuecomment-491011189 Thanks @anuengineer for catching this. I will revert the patch.

[GitHub] [hadoop] anuengineer commented on a change in pull request #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir

2019-05-09 Thread GitBox
anuengineer commented on a change in pull request #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir URL: https://github.com/apache/hadoop/pull/792#discussion_r282601151 ## File path: hadoop-ozone/dist/src/main/k8s/examples/minikube/config-configmap.yaml

[GitHub] [hadoop] anuengineer commented on a change in pull request #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir

2019-05-09 Thread GitBox
anuengineer commented on a change in pull request #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir URL: https://github.com/apache/hadoop/pull/792#discussion_r282601506 ## File path: hadoop-ozone/dist/src/main/k8s/examples/ozone/config-configmap.yaml

[GitHub] [hadoop] anuengineer commented on a change in pull request #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir

2019-05-09 Thread GitBox
anuengineer commented on a change in pull request #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir URL: https://github.com/apache/hadoop/pull/792#discussion_r282601151 ## File path: hadoop-ozone/dist/src/main/k8s/examples/minikube/config-configmap.yaml

[GitHub] [hadoop] anuengineer commented on a change in pull request #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir

2019-05-09 Thread GitBox
anuengineer commented on a change in pull request #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir URL: https://github.com/apache/hadoop/pull/792#discussion_r282601401 ## File path: hadoop-ozone/dist/src/main/k8s/examples/ozone-dev/config-configmap.yaml

[jira] [Created] (HADOOP-16305) hadoop-functions.sh Cannot set priority of daemon process misleads

2019-05-09 Thread Prabhu Joseph (JIRA)
Prabhu Joseph created HADOOP-16305: -- Summary: hadoop-functions.sh Cannot set priority of daemon process misleads Key: HADOOP-16305 URL: https://issues.apache.org/jira/browse/HADOOP-16305 Project:

[GitHub] [hadoop] ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-09 Thread GitBox
ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-490998313 Perfect. I had a quick review of your changes and as before they look good.

[GitHub] [hadoop] hanishakoneru commented on issue #804: HDDS-1496. Support partial chunk reads and checksum verification

2019-05-09 Thread GitBox
hanishakoneru commented on issue #804: HDDS-1496. Support partial chunk reads and checksum verification URL: https://github.com/apache/hadoop/pull/804#issuecomment-490999735 This patch requires more changes (after HDDS-1491 which fixes seek operation). 1. In BlockInputStream#seek(), it

[GitHub] [hadoop] ben-roling commented on a change in pull request #807: HADOOP-16085 S3Guard versioning (stevel patch 002)

2019-05-09 Thread GitBox
ben-roling commented on a change in pull request #807: HADOOP-16085 S3Guard versioning (stevel patch 002) URL: https://github.com/apache/hadoop/pull/807#discussion_r282587263 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/CopyOutcome.java

[GitHub] [hadoop] hanishakoneru edited a comment on issue #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir

2019-05-09 Thread GitBox
hanishakoneru edited a comment on issue #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir URL: https://github.com/apache/hadoop/pull/792#issuecomment-490987959 +1. Thanks @vivekratnavel . Test failures are unrelated. I will merge this shortly.

[GitHub] [hadoop] hanishakoneru merged pull request #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir

2019-05-09 Thread GitBox
hanishakoneru merged pull request #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir URL: https://github.com/apache/hadoop/pull/792 This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] bharatviswa504 commented on issue #798: HDDS-1499. OzoneManager Cache.

2019-05-09 Thread GitBox
bharatviswa504 commented on issue #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#issuecomment-490992025 Thank You @hanishakoneru for the review. I have addressed review comments. This

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-09 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r282584180 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/PartialTableCache.java ## @@

[GitHub] [hadoop] hanishakoneru commented on issue #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir

2019-05-09 Thread GitBox
hanishakoneru commented on issue #792: HDDS-1474. ozone.scm.datanode.id config should take path for a dir URL: https://github.com/apache/hadoop/pull/792#issuecomment-490987959 +1. Thanks @vivekratnavel . I will merge this shortly.

[jira] [Commented] (HADOOP-16266) Add more fine-grained processing time metrics to the RPC layer

2019-05-09 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836554#comment-16836554 ] Erik Krogen commented on HADOOP-16266: -- Hi [~daryn], do you still plan to review? > Add more

[GitHub] [hadoop] steveloughran opened a new pull request #807: HADOOP-16085 S3Guard versioning (stevel patch 002)

2019-05-09 Thread GitBox
steveloughran opened a new pull request #807: HADOOP-16085 S3Guard versioning (stevel patch 002) URL: https://github.com/apache/hadoop/pull/807 -move CopyOutcome -add new (failing) test for directory renaming where one of the files underneath is eventually consistent. -pull out

[GitHub] [hadoop] steveloughran commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-09 Thread GitBox
steveloughran commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-490985741 here: #807 -move CopyOutcome into fs.s3a.impl package -add new

[GitHub] [hadoop] bshashikant commented on a change in pull request #806: HDDS-1224. Restructure code to validate the response from server in the Read path

2019-05-09 Thread GitBox
bshashikant commented on a change in pull request #806: HDDS-1224. Restructure code to validate the response from server in the Read path URL: https://github.com/apache/hadoop/pull/806#discussion_r282565511 ## File path:

[GitHub] [hadoop] ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-09 Thread GitBox
ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-490972810 > new exception will include the operation and only include a position if >= 0:

[GitHub] [hadoop] hadoop-yetus commented on issue #806: HDDS-1224. Restructure code to validate the response from server in the Read path

2019-05-09 Thread GitBox
hadoop-yetus commented on issue #806: HDDS-1224. Restructure code to validate the response from server in the Read path URL: https://github.com/apache/hadoop/pull/806#issuecomment-490970181 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16302) Fix typo on Hadoop Site Help dropdown menu

2019-05-09 Thread Dinesh Chitlangia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836490#comment-16836490 ] Dinesh Chitlangia commented on HADOOP-16302: [~elek] Is there something else that needs to

[GitHub] [hadoop] jiwq commented on a change in pull request #806: HDDS-1224. Restructure code to validate the response from server in the Read path

2019-05-09 Thread GitBox
jiwq commented on a change in pull request #806: HDDS-1224. Restructure code to validate the response from server in the Read path URL: https://github.com/apache/hadoop/pull/806#discussion_r282540719 ## File path:

[GitHub] [hadoop] steveloughran commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-09 Thread GitBox
steveloughran commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-490942826 new exception will include the operation and only include a position if >= 0:

[GitHub] [hadoop] ben-roling edited a comment on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-09 Thread GitBox
ben-roling edited a comment on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-490941054 > One thing which needs changing: the error message. Currently it says "on

[GitHub] [hadoop] ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-09 Thread GitBox
ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-490941054 > One thing which needs changing: the error message. Currently it says "on

[GitHub] [hadoop] steveloughran commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-09 Thread GitBox
steveloughran commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-490934759 One thing which needs changing: the error message. Currently it says "on

[jira] [Updated] (HADOOP-16294) Enable access to context by DistCp subclasses

2019-05-09 Thread Andrew Olson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Olson updated HADOOP-16294: -- Summary: Enable access to context by DistCp subclasses (was: Enable access to input options

[jira] [Updated] (HADOOP-16294) Enable access to input options by DistCp subclasses

2019-05-09 Thread Andrew Olson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Olson updated HADOOP-16294: -- Description: In the DistCp class, the context is private with no getter method allowing

[GitHub] [hadoop] noslowerdna commented on issue #796: HADOOP-16294: Enable access to input options by DistCp subclasses

2019-05-09 Thread GitBox
noslowerdna commented on issue #796: HADOOP-16294: Enable access to input options by DistCp subclasses URL: https://github.com/apache/hadoop/pull/796#issuecomment-490924201 Thank you @steveloughran - I'm happy with this patch.

[GitHub] [hadoop] bshashikant commented on issue #793: HDDS-1224. Restructure code to validate the response from server in the Read path.

2019-05-09 Thread GitBox
bshashikant commented on issue #793: HDDS-1224. Restructure code to validate the response from server in the Read path. URL: https://github.com/apache/hadoop/pull/793#issuecomment-490915404 Closing this pull request, will create a new one to address the issue.

[GitHub] [hadoop] bshashikant opened a new pull request #806: HDDS-1224. Restructure code to validate the response from server in the Read path

2019-05-09 Thread GitBox
bshashikant opened a new pull request #806: HDDS-1224. Restructure code to validate the response from server in the Read path URL: https://github.com/apache/hadoop/pull/806 . This is an automated message from the Apache Git

[GitHub] [hadoop] steveloughran commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-09 Thread GitBox
steveloughran commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-490914575 > The change to add the annotation that labeled the parameters on the

[GitHub] [hadoop] steveloughran closed pull request #803: HADOOP-16085: S3Guard to use object version or etags (interim PR)

2019-05-09 Thread GitBox
steveloughran closed pull request #803: HADOOP-16085: S3Guard to use object version or etags (interim PR) URL: https://github.com/apache/hadoop/pull/803 This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] bshashikant commented on a change in pull request #793: HDDS-1224. Restructure code to validate the response from server in the Read path.

2019-05-09 Thread GitBox
bshashikant commented on a change in pull request #793: HDDS-1224. Restructure code to validate the response from server in the Read path. URL: https://github.com/apache/hadoop/pull/793#discussion_r282492499 ## File path:

[GitHub] [hadoop] bshashikant closed pull request #793: HDDS-1224. Restructure code to validate the response from server in the Read path.

2019-05-09 Thread GitBox
bshashikant closed pull request #793: HDDS-1224. Restructure code to validate the response from server in the Read path. URL: https://github.com/apache/hadoop/pull/793 This is an automated message from the Apache Git

[GitHub] [hadoop] steveloughran commented on issue #803: HADOOP-16085: S3Guard to use object version or etags (interim PR)

2019-05-09 Thread GitBox
steveloughran commented on issue #803: HADOOP-16085: S3Guard to use object version or etags (interim PR) URL: https://github.com/apache/hadoop/pull/803#issuecomment-490913845 thanks, I'll move onto that again with my ongoing work.

[GitHub] [hadoop] bshashikant opened a new pull request #805: HDDS-1509. TestBlockOutputStreamWithFailures#test2DatanodesFailure fails intermittently

2019-05-09 Thread GitBox
bshashikant opened a new pull request #805: HDDS-1509. TestBlockOutputStreamWithFailures#test2DatanodesFailure fails intermittently URL: https://github.com/apache/hadoop/pull/805 This is an automated message from the Apache

[GitHub] [hadoop] bshashikant commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file.

2019-05-09 Thread GitBox
bshashikant commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file. URL: https://github.com/apache/hadoop/pull/795#issuecomment-490846871 Thanks @hanishakoneru for working on this. The patch overall looks good to me. Some minor comments: 1.

[GitHub] [hadoop] mukul1987 merged pull request #801: HDDS-1500 : Allocate block failures in client should print exception trace.

2019-05-09 Thread GitBox
mukul1987 merged pull request #801: HDDS-1500 : Allocate block failures in client should print exception trace. URL: https://github.com/apache/hadoop/pull/801 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] mukul1987 commented on issue #801: HDDS-1500 : Allocate block failures in client should print exception trace.

2019-05-09 Thread GitBox
mukul1987 commented on issue #801: HDDS-1500 : Allocate block failures in client should print exception trace. URL: https://github.com/apache/hadoop/pull/801#issuecomment-490842428 Thanks for the updated patch @avijayanhwx . I will commit this now.

[jira] [Comment Edited] (HADOOP-16278) With S3A Filesystem, Long Running services End up Doing lot of GC and eventually die

2019-05-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836224#comment-16836224 ] Rajat Khandelwal edited comment on HADOOP-16278 at 5/9/19 9:16 AM: ---

[jira] [Commented] (HADOOP-16278) With S3A Filesystem, Long Running services End up Doing lot of GC and eventually die

2019-05-09 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836224#comment-16836224 ] Rajat Khandelwal commented on HADOOP-16278: --- [~ste...@apache.org] Yes, please link up with

[GitHub] [hadoop] elek commented on issue #801: HDDS-1500 : Allocate block failures in client should print exception trace.

2019-05-09 Thread GitBox
elek commented on issue #801: HDDS-1500 : Allocate block failures in client should print exception trace. URL: https://github.com/apache/hadoop/pull/801#issuecomment-490777899 /label ozone This is an automated message from

[jira] [Assigned] (HADOOP-16304) TestReadWriteDiskValidator fails intermittent

2019-05-09 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhu Joseph reassigned HADOOP-16304: -- Assignee: Prabhu Joseph > TestReadWriteDiskValidator fails intermittent >

[jira] [Assigned] (HADOOP-16303) TestDiskCheckerWithDiskIo testcases fails intermittent

2019-05-09 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhu Joseph reassigned HADOOP-16303: -- Assignee: Prabhu Joseph > TestDiskCheckerWithDiskIo testcases fails intermittent >

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-09 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836147#comment-16836147 ] Prabhu Joseph commented on HADOOP-16287: Test case failures are not related. Have reported

[jira] [Created] (HADOOP-16304) TestReadWriteDiskValidator fails intermittent

2019-05-09 Thread Prabhu Joseph (JIRA)
Prabhu Joseph created HADOOP-16304: -- Summary: TestReadWriteDiskValidator fails intermittent Key: HADOOP-16304 URL: https://issues.apache.org/jira/browse/HADOOP-16304 Project: Hadoop Common

[jira] [Created] (HADOOP-16303) TestDiskCheckerWithDiskIo testcases fails intermittent

2019-05-09 Thread Prabhu Joseph (JIRA)
Prabhu Joseph created HADOOP-16303: -- Summary: TestDiskCheckerWithDiskIo testcases fails intermittent Key: HADOOP-16303 URL: https://issues.apache.org/jira/browse/HADOOP-16303 Project: Hadoop Common

[GitHub] [hadoop] hadoop-yetus commented on issue #745: HDDS-1441. Remove usage of getRetryFailureException. (swagle)

2019-05-09 Thread GitBox
hadoop-yetus commented on issue #745: HDDS-1441. Remove usage of getRetryFailureException. (swagle) URL: https://github.com/apache/hadoop/pull/745#issuecomment-490766138 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836127#comment-16836127 ] Hadoop QA commented on HADOOP-16287: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] hadoop-yetus commented on issue #798: HDDS-1499. OzoneManager Cache.

2019-05-09 Thread GitBox
hadoop-yetus commented on issue #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#issuecomment-490762355 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 |

[jira] [Commented] (HADOOP-16299) [JDK 11] Build fails without specifying -Djavac.version=11

2019-05-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836108#comment-16836108 ] Hudson commented on HADOOP-16299: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16528 (See