[GitHub] [hadoop] susheel-gupta commented on a diff in pull request #5278: YARN-11408. Add a check of autoQueueCreation is disabled for emitDefaultUserLimitFactor method

2023-01-19 Thread GitBox
susheel-gupta commented on code in PR #5278: URL: https://github.com/apache/hadoop/pull/5278#discussion_r1071075406 ##

[jira] [Commented] (HADOOP-18598) maven site generation doesn't include javadocs

2023-01-19 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679013#comment-17679013 ] Masatake Iwasaki commented on HADOOP-18598: --- [~ste...@apache.org] [Downgrading

[jira] [Updated] (HADOOP-18598) maven site generation doesn't include javadocs

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18598: Labels: pull-request-available (was: ) > maven site generation doesn't include javadocs

[jira] [Commented] (HADOOP-18598) maven site generation doesn't include javadocs

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679012#comment-17679012 ] ASF GitHub Bot commented on HADOOP-18598: - iwasakims opened a new pull request, #5319: URL:

[GitHub] [hadoop] iwasakims opened a new pull request, #5319: HADOOP-18598. maven site generation doesn't include javadocs.

2023-01-19 Thread GitBox
iwasakims opened a new pull request, #5319: URL: https://github.com/apache/hadoop/pull/5319 https://issues.apache.org/jira/browse/HADOOP-18598 maven-site-plugin-3.11.0 is incompatible with maven-javadoc-plugin-3.0.1. Downgrading maven-site-plugin to 3.9.1 fixes missing javadocs in

[GitHub] [hadoop] hadoop-yetus commented on pull request #5302: YARN-11221. [Federation] Add replaceLabelsOnNodes, replaceLabelsOnNode REST APIs for Router.

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5302: URL: https://github.com/apache/hadoop/pull/5302#issuecomment-1397977798 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5284: YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router.

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5284: URL: https://github.com/apache/hadoop/pull/5284#issuecomment-1397969145 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] susheel-gupta commented on a diff in pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

2023-01-19 Thread GitBox
susheel-gupta commented on code in PR #5295: URL: https://github.com/apache/hadoop/pull/5295#discussion_r1082128599 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapred/TestTaskAttemptListenerImpl.java: ## @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5272: URL: https://github.com/apache/hadoop/pull/5272#issuecomment-1397907701 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5260: YARN-8900. [Follow Up] Fix FederationInterceptorREST#invokeConcurrent Inaccurate Order of Subclusters.

2023-01-19 Thread GitBox
slfan1989 commented on PR #5260: URL: https://github.com/apache/hadoop/pull/5260#issuecomment-1397817449 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] goiri merged pull request #5260: YARN-8900. [Follow Up] Fix FederationInterceptorREST#invokeConcurrent Inaccurate Order of Subclusters.

2023-01-19 Thread GitBox
goiri merged PR #5260: URL: https://github.com/apache/hadoop/pull/5260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] slfan1989 commented on pull request #5260: YARN-8900. [Follow Up] Fix FederationInterceptorREST#invokeConcurrent Inaccurate Order of Subclusters.

2023-01-19 Thread GitBox
slfan1989 commented on PR #5260: URL: https://github.com/apache/hadoop/pull/5260#issuecomment-1397727689 @goiri Can you help to merge this pr into the trunk branch? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678878#comment-17678878 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR #5315: URL:

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678877#comment-17678877 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR #5315: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-19 Thread GitBox
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081716267 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LogAdapter.java: ## @@ -17,61 +17,40 @@ */ package org.apache.hadoop.util; -import

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-19 Thread GitBox
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081715049 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java: ## @@ -340,22 +337,14 @@ public void doGet(HttpServletRequest request,

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678876#comment-17678876 ] ASF GitHub Bot commented on HADOOP-18399: - virajjasani commented on PR #5054: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-01-19 Thread GitBox
virajjasani commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1397617517 synced -- pulled latest trunk commits to the branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HADOOP-18599) Expose `listStatus(Path path, String startFrom)` on `AzureBlobFileSystem`

2023-01-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678873#comment-17678873 ] Steve Loughran commented on HADOOP-18599: - 1. AzureBlobFileSystemStore shouldn't be public at

[jira] [Assigned] (HADOOP-18208) Remove all the log4j reference in modules other than hadoop-logging

2023-01-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-18208: - Assignee: Viraj Jasani > Remove all the log4j reference in modules other than

[jira] [Assigned] (HADOOP-18207) Introduce a hadoop-logging module

2023-01-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-18207: - Assignee: Viraj Jasani > Introduce a hadoop-logging module >

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678858#comment-17678858 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on PR #5315: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-19 Thread GitBox
virajjasani commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1397489869 Javadoc warnings for common and spotbug warnings for mapreduce modules are not relevant to this change. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678856#comment-17678856 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR #5315: URL:

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678857#comment-17678857 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR #5315: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-19 Thread GitBox
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081718563 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -318,9 +316,9 @@ public class DataNode extends

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-19 Thread GitBox
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081718137 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LogAdapter.java: ## @@ -17,61 +17,40 @@ */ package org.apache.hadoop.util; -import

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678855#comment-17678855 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR #5315: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-19 Thread GitBox
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081715049 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java: ## @@ -340,22 +337,14 @@ public void doGet(HttpServletRequest request,

[jira] [Commented] (HADOOP-18599) Expose `listStatus(Path path, String startFrom)` on `AzureBlobFileSystem`

2023-01-19 Thread Thomas Newton (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678845#comment-17678845 ] Thomas Newton commented on HADOOP-18599: Admittedly the functionality I'm interested in is

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678832#comment-17678832 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on PR #5315: URL:

[jira] [Commented] (HADOOP-18599) Expose `listStatus(Path path, String startFrom)` on `AzureBlobFileSystem`

2023-01-19 Thread Thomas Newton (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678831#comment-17678831 ] Thomas Newton commented on HADOOP-18599: Thanks for the response though what you suggest is

[GitHub] [hadoop] virajjasani commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-19 Thread GitBox
virajjasani commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1397385744 bummer, we can't completely get rid of it as commons-configuration needs it, so we will have to keep the version in our classpath but we won't use it in the codebase. -- This is an

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678825#comment-17678825 ] ASF GitHub Bot commented on HADOOP-18073: - asfgit merged PR #5163: URL:

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678826#comment-17678826 ] ASF GitHub Bot commented on HADOOP-18073: - steveloughran commented on PR #5163: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

2023-01-19 Thread GitBox
steveloughran commented on PR #5163: URL: https://github.com/apache/hadoop/pull/5163#issuecomment-1397372151 merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] asfgit merged pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

2023-01-19 Thread GitBox
asfgit merged PR #5163: URL: https://github.com/apache/hadoop/pull/5163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678819#comment-17678819 ] ASF GitHub Bot commented on HADOOP-18206: - hadoop-yetus commented on PR #5315: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1397350094 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18599) Expose `listStatus(Path path, String startFrom)` on `AzureBlobFileSystem`

2023-01-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18599: Priority: Major (was: Minor) > Expose `listStatus(Path path, String startFrom)` on

[jira] [Updated] (HADOOP-18599) Expose `listStatus(Path path, String startFrom)` on `AzureBlobFileSystem`

2023-01-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18599: Issue Type: New Feature (was: Improvement) > Expose `listStatus(Path path, String

[jira] [Commented] (HADOOP-18599) Expose `listStatus(Path path, String startFrom)` on `AzureBlobFileSystem`

2023-01-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678817#comment-17678817 ] Steve Loughran commented on HADOOP-18599: - all public FS APIs need to go into hadoop-common

[jira] [Commented] (HADOOP-18600) Hadoop 2.x should support s3a committers

2023-01-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678810#comment-17678810 ] Steve Loughran commented on HADOOP-18600: - finally, why can't you upgrade? because if you want

[jira] [Resolved] (HADOOP-18600) Hadoop 2.x should support s3a committers

2023-01-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18600. - Resolution: Won't Fix > Hadoop 2.x should support s3a committers >

[jira] [Updated] (HADOOP-18600) Hadoop 2.x should support s3a committers

2023-01-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18600: Summary: Hadoop 2.x should support s3a committers (was: Hadoop 2.x should support s3a)

[jira] [Commented] (HADOOP-18600) Hadoop 2.x should support s3a

2023-01-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678807#comment-17678807 ] Steve Loughran commented on HADOOP-18600: - no. you want s3a features written in the past five

[GitHub] [hadoop] K0K0V0K commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-01-19 Thread GitBox
K0K0V0K commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1397239024 +1, non-binding -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (HADOOP-18596) Distcp -update between different cloud stores to use modification time while checking for file skip.

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678783#comment-17678783 ] ASF GitHub Bot commented on HADOOP-18596: - mehakmeet commented on code in PR #5308: URL:

[GitHub] [hadoop] mehakmeet commented on a diff in pull request #5308: HADOOP-18596. Distcp -update to use modification time while checking for file skip.

2023-01-19 Thread GitBox
mehakmeet commented on code in PR #5308: URL: https://github.com/apache/hadoop/pull/5308#discussion_r1081471243 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java: ## @@ -354,7 +354,14 @@ private boolean canSkip(FileSystem sourceFS,

[jira] [Commented] (HADOOP-18596) Distcp -update between different cloud stores to use modification time while checking for file skip.

2023-01-19 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678780#comment-17678780 ] Daniel Carl Jones commented on HADOOP-18596: {quote}What Mehakmeet proposes is possible,

[jira] [Commented] (HADOOP-18592) Sasl connection failure should log remote address

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678779#comment-17678779 ] ASF GitHub Bot commented on HADOOP-18592: - virajjasani commented on PR #5294: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5294: HADOOP-18592 Sasl connection failure should log remote address

2023-01-19 Thread GitBox
virajjasani commented on PR #5294: URL: https://github.com/apache/hadoop/pull/5294#issuecomment-1397191522 @steveloughran, updated the PR based on your latest review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (HADOOP-18596) Distcp -update between different cloud stores to use modification time while checking for file skip.

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678768#comment-17678768 ] ASF GitHub Bot commented on HADOOP-18596: - dannycjones commented on code in PR #5308: URL:

[GitHub] [hadoop] dannycjones commented on a diff in pull request #5308: HADOOP-18596. Distcp -update to use modification time while checking for file skip.

2023-01-19 Thread GitBox
dannycjones commented on code in PR #5308: URL: https://github.com/apache/hadoop/pull/5308#discussion_r1081452359 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java: ## @@ -354,7 +354,14 @@ private boolean canSkip(FileSystem sourceFS,

[GitHub] [hadoop] hadoop-yetus commented on pull request #5317: YARN-11420 Stabilize TestNMClient

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1397143914 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5317: YARN-11420 Stabilize TestNMClient

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1397143337 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5317: YARN-11420 Stabilize TestNMClient

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1397140540 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5318: YARN-11412 Concurrent user management

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5318: URL: https://github.com/apache/hadoop/pull/5318#issuecomment-1397089189 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678738#comment-17678738 ] ASF GitHub Bot commented on HADOOP-18206: - steveloughran commented on code in PR #5315: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-19 Thread GitBox
steveloughran commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081327340 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java: ## @@ -340,22 +337,14 @@ public void doGet(HttpServletRequest request,

[GitHub] [hadoop] hadoop-yetus commented on pull request #5318: YARN-11412 Concurrent user management

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5318: URL: https://github.com/apache/hadoop/pull/5318#issuecomment-1397073307 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5316: Yarn 11420

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5316: URL: https://github.com/apache/hadoop/pull/5316#issuecomment-1397008425 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] tomicooler commented on a diff in pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-01-19 Thread GitBox
tomicooler commented on code in PR #5311: URL: https://github.com/apache/hadoop/pull/5311#discussion_r1081262415 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleChannelHandler.java: ## @@ -0,0

[jira] [Updated] (HADOOP-18600) Hadoop 2.x should support s3a

2023-01-19 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Carl Jones updated HADOOP-18600: --- Component/s: fs/s3 > Hadoop 2.x should support s3a > -

[GitHub] [hadoop] hadoop-yetus commented on pull request #5317: YARN-11420 Stabilize TestNMClient

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1396932613 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

2023-01-19 Thread GitBox
szilard-nemeth commented on code in PR #5295: URL: https://github.com/apache/hadoop/pull/5295#discussion_r1081217771 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapred/TestTaskAttemptListenerImpl.java: ## @@

[jira] [Created] (HADOOP-18600) Hadoop 2.x should support s3a

2023-01-19 Thread KaiXinXIaoLei (Jira)
KaiXinXIaoLei created HADOOP-18600: -- Summary: Hadoop 2.x should support s3a Key: HADOOP-18600 URL: https://issues.apache.org/jira/browse/HADOOP-18600 Project: Hadoop Common Issue Type: New

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678670#comment-17678670 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on PR #3440: URL:

[GitHub] [hadoop] pranavsaxena-microsoft commented on pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-19 Thread GitBox
pranavsaxena-microsoft commented on PR #3440: URL: https://github.com/apache/hadoop/pull/3440#issuecomment-1396908517 @mukund-thakur , requesting you to kindly review the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5295: URL: https://github.com/apache/hadoop/pull/5295#issuecomment-1396908472 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-01-19 Thread GitBox
K0K0V0K commented on code in PR #5311: URL: https://github.com/apache/hadoop/pull/5311#discussion_r1081143805 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleChannelHandler.java: ## @@ -0,0 +1,715

[GitHub] [hadoop] hadoop-yetus commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1396860917 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678656#comment-17678656 ] Steve Loughran commented on HADOOP-17912: - I'm on vacation from this afternoon until feb. can

[GitHub] [hadoop] hadoop-yetus commented on pull request #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5312: URL: https://github.com/apache/hadoop/pull/5312#issuecomment-1396832513 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-16209) Create simple docker based pseudo-cluster for hdfs

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-16209: Labels: pull-request-available (was: ) > Create simple docker based pseudo-cluster for

[jira] [Commented] (HADOOP-16209) Create simple docker based pseudo-cluster for hdfs

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678642#comment-17678642 ] ASF GitHub Bot commented on HADOOP-16209: - hadoop-yetus commented on PR #650: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #650: HADOOP-16209. Create simple docker based pseudo-cluster for hdfs

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #650: URL: https://github.com/apache/hadoop/pull/650#issuecomment-1396825079 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexec

[GitHub] [hadoop] krishan1390 closed pull request #5314: Yarn-11411 Concurrent user management

2023-01-19 Thread GitBox
krishan1390 closed pull request #5314: Yarn-11411 Concurrent user management URL: https://github.com/apache/hadoop/pull/5314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] krishan1390 closed pull request #5313: YARN-11411 Encapsulating certain User Manager APIs by making it private

2023-01-19 Thread GitBox
krishan1390 closed pull request #5313: YARN-11411 Encapsulating certain User Manager APIs by making it private URL: https://github.com/apache/hadoop/pull/5313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] krishan1390 opened a new pull request, #5318: YARN-11412 Concurrent user management

2023-01-19 Thread GitBox
krishan1390 opened a new pull request, #5318: URL: https://github.com/apache/hadoop/pull/5318 JIRA: [YARN-11412](https://issues.apache.org/jira/browse/YARN-11412). Create a Concurrent Users Manager to enable thread safe concurrent resource usage tracking of user Low level

[GitHub] [hadoop] K0K0V0K opened a new pull request, #5317: YARN-11420 Stabilize TestNMClient

2023-01-19 Thread GitBox
K0K0V0K opened a new pull request, #5317: URL: https://github.com/apache/hadoop/pull/5317 ### Description of PR The TestNMClient test methods can stuck if the test container fails, while the test is expecting it running state. This can happen for example if the container fails due low

[GitHub] [hadoop] K0K0V0K closed pull request #5286: YARN-11410. Add default methods for StateMachine

2023-01-19 Thread GitBox
K0K0V0K closed pull request #5286: YARN-11410. Add default methods for StateMachine URL: https://github.com/apache/hadoop/pull/5286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] K0K0V0K closed pull request #5316: Yarn 11420

2023-01-19 Thread GitBox
K0K0V0K closed pull request #5316: Yarn 11420 URL: https://github.com/apache/hadoop/pull/5316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] K0K0V0K opened a new pull request, #5316: Yarn 11420

2023-01-19 Thread GitBox
K0K0V0K opened a new pull request, #5316: URL: https://github.com/apache/hadoop/pull/5316 ### Description of PR The TestNMClient test methods can stuck if the test container fails, while the test is expecting it running state. This can happen for example if the container fails due

[GitHub] [hadoop] hadoop-yetus commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1396671969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] susheel-gupta commented on a diff in pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

2023-01-19 Thread GitBox
susheel-gupta commented on code in PR #5295: URL: https://github.com/apache/hadoop/pull/5295#discussion_r1080982699 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapred/TestTaskAttemptListenerImpl.java: ## @@

[jira] [Commented] (HADOOP-17717) Update wildfly openssl to 1.1.3.Final

2023-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678569#comment-17678569 ] ASF GitHub Bot commented on HADOOP-17717: - hadoop-yetus commented on PR #5310: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5310: HADOOP-17717. Update wildfly openssl to 1.1.3.Final

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5310: URL: https://github.com/apache/hadoop/pull/5310#issuecomment-1396645743 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

2023-01-19 Thread GitBox
szilard-nemeth commented on code in PR #5295: URL: https://github.com/apache/hadoop/pull/5295#discussion_r1080950958 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapred/TestTaskAttemptListenerImpl.java: ## @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #5314: Yarn-11411 Concurrent user management

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5314: URL: https://github.com/apache/hadoop/pull/5314#issuecomment-1396610842 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5313: YARN-11411 Encapsulating certain User Manager APIs by making it private

2023-01-19 Thread GitBox
hadoop-yetus commented on PR #5313: URL: https://github.com/apache/hadoop/pull/5313#issuecomment-1396596316 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |