[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-02 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728919#comment-17728919 ] Viraj Jasani commented on HADOOP-18207: --- PR to fix the broken test:

[GitHub] [hadoop] virajjasani commented on pull request #5683: HDFS-17023. RBF: Record proxy time when call invokeConcurrent method.

2023-06-02 Thread via GitHub
virajjasani commented on PR #5683: URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1574652942 Fix for the broken test on PR: https://github.com/apache/hadoop/pull/5713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5694: HDFS-17028. RBF: Optimize debug logs of class ConnectionPool and other related class.

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5694: URL: https://github.com/apache/hadoop/pull/5694#issuecomment-1574651856 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-02 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728914#comment-17728914 ] Ayush Saxena commented on HADOOP-18207: --- [~weichiu] seems this tends to break the router test

[GitHub] [hadoop] ayushtkn commented on pull request #5683: HDFS-17023. RBF: Record proxy time when call invokeConcurrent method.

2023-06-02 Thread via GitHub
ayushtkn commented on PR #5683: URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1574640371 test failure doesn't look related, fails without patch as well https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5683/10/testReport/, Some assertions changed in

[GitHub] [hadoop] hadoop-yetus commented on pull request #5683: HDFS-17023. RBF: Record proxy time when call invokeConcurrent method.

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5683: URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1574635144 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728908#comment-17728908 ] ASF GitHub Bot commented on HADOOP-18207: - hadoop-yetus commented on PR #5713: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5713: HADOOP-18207. (ADDENDUM) Fix TestRouterNamenodeMonitoring

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5713: URL: https://github.com/apache/hadoop/pull/5713#issuecomment-1574599579 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728906#comment-17728906 ] ASF GitHub Bot commented on HADOOP-18207: - virajjasani commented on PR #5713: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5713: HADOOP-18207. (ADDENDUM) Fix TestRouterNamenodeMonitoring

2023-06-02 Thread via GitHub
virajjasani commented on PR #5713: URL: https://github.com/apache/hadoop/pull/5713#issuecomment-1574592698 @hchaverri @goiri could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728905#comment-17728905 ] ASF GitHub Bot commented on HADOOP-18207: - hadoop-yetus commented on PR #5503: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1574588816 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hfutatzhanghb commented on a diff in pull request #5694: HDFS-17028. RBF: Optimize debug logs of class ConnectionPool and other related class.

2023-06-02 Thread via GitHub
hfutatzhanghb commented on code in PR #5694: URL: https://github.com/apache/hadoop/pull/5694#discussion_r1215143515 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java: ## @@ -482,7 +482,7 @@ public void

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5694: HDFS-17028. RBF: Optimize debug logs of class ConnectionPool and other related class.

2023-06-02 Thread via GitHub
ayushtkn commented on code in PR #5694: URL: https://github.com/apache/hadoop/pull/5694#discussion_r1215139609 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java: ## @@ -482,7 +482,7 @@ public void run() {

[jira] [Commented] (HADOOP-18718) Fix several maven build warnings

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728901#comment-17728901 ] ASF GitHub Bot commented on HADOOP-18718: - ayushtkn commented on PR #5592: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #5592: HADOOP-18718. Fix several maven build warnings

2023-06-02 Thread via GitHub
ayushtkn commented on PR #5592: URL: https://github.com/apache/hadoop/pull/5592#issuecomment-1574579272 @dongjoon-hyun you marked this as draft, any further pointers, it was looking good enough to me atleast to merge -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728898#comment-17728898 ] ASF GitHub Bot commented on HADOOP-18207: - virajjasani commented on PR #5503: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module

2023-06-02 Thread via GitHub
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1574535578 Thank you @jojochuang @Apache9 `TestRouterNamenodeMonitoring` was recently updated and it is broken while resolving conflicts with this PR, here is the addendum PR to fix it:

[GitHub] [hadoop] virajjasani opened a new pull request, #5713: HADOOP-18207. (ADDENDUM) Fix TestRouterNamenodeMonitoring

2023-06-02 Thread via GitHub
virajjasani opened a new pull request, #5713: URL: https://github.com/apache/hadoop/pull/5713 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728897#comment-17728897 ] ASF GitHub Bot commented on HADOOP-18207: - virajjasani opened a new pull request, #5713: URL:

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728896#comment-17728896 ] ASF GitHub Bot commented on HADOOP-18207: - jojochuang merged PR #5503: URL:

[jira] [Updated] (HADOOP-18207) Introduce hadoop-logging module

2023-06-02 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-18207: - Fix Version/s: 3.4.0 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728895#comment-17728895 ] ASF GitHub Bot commented on HADOOP-18207: - jojochuang commented on PR #5503: URL:

[GitHub] [hadoop] jojochuang commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module

2023-06-02 Thread via GitHub
jojochuang commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1574517738 Thanks @Apache9 for the review. Agree with you. I'll go ahead and merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] jojochuang merged pull request #5503: HADOOP-18207. Introduce hadoop-logging module

2023-06-02 Thread via GitHub
jojochuang merged PR #5503: URL: https://github.com/apache/hadoop/pull/5503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5698: HDFS-17029. Support getECPolices API in WebHDFS

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5698: URL: https://github.com/apache/hadoop/pull/5698#issuecomment-1574366925 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri commented on pull request #5712: YARN-11425. [Addendum] Modify Expiration Time Unit error.

2023-06-02 Thread via GitHub
goiri commented on PR #5712: URL: https://github.com/apache/hadoop/pull/5712#issuecomment-1574239025 We usually call this addendum. Not really a hotfix going on here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728851#comment-17728851 ] ASF GitHub Bot commented on HADOOP-18207: - virajjasani commented on PR #5503: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module

2023-06-02 Thread via GitHub
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1574208866 Thank you @Apache9! WDYT @jojochuang @steveloughran ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] hadoop-yetus commented on pull request #5709: HDFS-17036. Limit pendingReconstruction size

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5709: URL: https://github.com/apache/hadoop/pull/5709#issuecomment-1574024911 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5710: HDFS-17036. Limit pendingReconstruction size

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5710: URL: https://github.com/apache/hadoop/pull/5710#issuecomment-1573986018 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18757) S3A Committer finalyzing the commits in a single thread

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728810#comment-17728810 ] ASF GitHub Bot commented on HADOOP-18757: - steveloughran commented on PR #5706: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5706: HADOOP-18757: Bump corePoolSize of HadoopThreadPoolExecutor in s3a committer

2023-06-02 Thread via GitHub
steveloughran commented on PR #5706: URL: https://github.com/apache/hadoop/pull/5706#issuecomment-1573977715 interesting failures...it's where having everyone test in their own config helps find many config-releated issues ## ITestS3AFileSystemStatistic ``` [ERROR] Tests

[GitHub] [hadoop] steveloughran commented on pull request #5689: HADOOP-18752. Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread via GitHub
steveloughran commented on PR #5689: URL: https://github.com/apache/hadoop/pull/5689#issuecomment-1573949366 safe when you don't have incompatible clients trying to write to the same directory tree, more specifically using rename and delete, which effectively means "hive, mapreduce, spark

[GitHub] [hadoop] hadoop-yetus commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1573933596 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728796#comment-17728796 ] ASF GitHub Bot commented on HADOOP-18207: - hadoop-yetus commented on PR #5503: URL:

[jira] [Commented] (HADOOP-18752) Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728794#comment-17728794 ] ASF GitHub Bot commented on HADOOP-18752: - steveloughran commented on code in PR #5689: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5689: HADOOP-18752. Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread via GitHub
steveloughran commented on code in PR #5689: URL: https://github.com/apache/hadoop/pull/5689#discussion_r1214527663 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/directory_markers.md: ## @@ -161,7 +176,7 @@ When a file is created under a path, the directory

[jira] [Commented] (HADOOP-18752) Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728793#comment-17728793 ] ASF GitHub Bot commented on HADOOP-18752: - steveloughran commented on code in PR #5689: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5689: HADOOP-18752. Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread via GitHub
steveloughran commented on code in PR #5689: URL: https://github.com/apache/hadoop/pull/5689#discussion_r1214526572 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/directory_markers.md: ## @@ -12,35 +12,40 @@ limitations under the License. See accompanying

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5705: YARN-11502. Refactor AMRMProxy#FederationInterceptor#registerApplicationMaster.

2023-06-02 Thread via GitHub
slfan1989 commented on code in PR #5705: URL: https://github.com/apache/hadoop/pull/5705#discussion_r1214487424 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #5712: YARN-11425. [Hotfix] Modify Expiration Time Unit error.

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5712: URL: https://github.com/apache/hadoop/pull/5712#issuecomment-1573866134 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5711: URL: https://github.com/apache/hadoop/pull/5711#issuecomment-1573846438 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5709: HDFS-17036. Limit pendingReconstruction size

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5709: URL: https://github.com/apache/hadoop/pull/5709#issuecomment-1573824284 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5711: URL: https://github.com/apache/hadoop/pull/5711#issuecomment-1573744187 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18757) S3A Committer finalyzing the commits in a single thread

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728739#comment-17728739 ] ASF GitHub Bot commented on HADOOP-18757: - modithah commented on PR #5706: URL:

[GitHub] [hadoop] modithah commented on pull request #5706: HADOOP-18757: Bump corePoolSize of HadoopThreadPoolExecutor in s3a committer

2023-06-02 Thread via GitHub
modithah commented on PR #5706: URL: https://github.com/apache/hadoop/pull/5706#issuecomment-1573718042 Tested in `us-east-1` same tests fail on the trunk (some due to my setup without sts). attaching the logs below

[GitHub] [hadoop] slfan1989 opened a new pull request, #5712: YARN-11425. [Hotfix] Modify Expiration Time Unit error.

2023-06-02 Thread via GitHub
slfan1989 opened a new pull request, #5712: URL: https://github.com/apache/hadoop/pull/5712 ### Description of PR YARN-11425. [Hotfix] Modify Expiration Time Unit error. During the completion of YARN-11425, the functionality of cleaning up expired sub-clusters was

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5708: HDFS-17035. FsVolumeImpl#getActualNonDfsUsed may return negative value.

2023-06-02 Thread via GitHub
hfutatzhanghb commented on PR #5708: URL: https://github.com/apache/hadoop/pull/5708#issuecomment-1573665781 The failed unit test was passed in my local. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] hadoop-yetus commented on pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5561: URL: https://github.com/apache/hadoop/pull/5561#issuecomment-1573625112 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] anujmodi2021 opened a new pull request, #5711: Hadoop 18759 linear retry for con timeout

2023-06-02 Thread via GitHub
anujmodi2021 opened a new pull request, #5711: URL: https://github.com/apache/hadoop/pull/5711 ### Description of PR Today when a request fails with connection timeout, it falls back into the loop for exponential retry. Unlike Azure Storage, there are no guarantees of success on

[jira] [Created] (HADOOP-18759) [ABFS}[Backoff-Optimization] Have a Linear retry policy for connection timeout failures

2023-06-02 Thread Anuj Modi (Jira)
Anuj Modi created HADOOP-18759: -- Summary: [ABFS}[Backoff-Optimization] Have a Linear retry policy for connection timeout failures Key: HADOOP-18759 URL: https://issues.apache.org/jira/browse/HADOOP-18759

[GitHub] [hadoop] hadoop-yetus commented on pull request #5708: HDFS-17035. FsVolumeImpl#getActualNonDfsUsed may return negative value.

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5708: URL: https://github.com/apache/hadoop/pull/5708#issuecomment-1573589003 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] LiuGuH opened a new pull request, #5710: HDFS-17036. Limit pendingReconstruction size

2023-06-02 Thread via GitHub
LiuGuH opened a new pull request, #5710: URL: https://github.com/apache/hadoop/pull/5710 ### Description of PR As describe in https://issues.apache.org/jira/browse/HDFS-17036 ### How was this patch tested? Add a new test case for it ### For code changes:

[GitHub] [hadoop] LiuGuH closed pull request #5709: HDFS-17036. Limit pendingReconstruction size

2023-06-02 Thread via GitHub
LiuGuH closed pull request #5709: HDFS-17036. Limit pendingReconstruction size URL: https://github.com/apache/hadoop/pull/5709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (HADOOP-18752) Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728686#comment-17728686 ] ASF GitHub Bot commented on HADOOP-18752: - dannycjones commented on PR #5689: URL:

[GitHub] [hadoop] dannycjones commented on pull request #5689: HADOOP-18752. Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread via GitHub
dannycjones commented on PR #5689: URL: https://github.com/apache/hadoop/pull/5689#issuecomment-1573525360 Sorry for jumping in at the last minute with these. Basically want to try and make sure users are able to reason as easily as possible about when its safe to flip over from

[jira] [Commented] (HADOOP-18752) Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728683#comment-17728683 ] ASF GitHub Bot commented on HADOOP-18752: - dannycjones commented on code in PR #5689: URL:

[GitHub] [hadoop] dannycjones commented on a diff in pull request #5689: HADOOP-18752. Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread via GitHub
dannycjones commented on code in PR #5689: URL: https://github.com/apache/hadoop/pull/5689#discussion_r1214208594 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/directory_markers.md: ## @@ -161,7 +176,7 @@ When a file is created under a path, the directory marker

[jira] [Commented] (HADOOP-18752) Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728679#comment-17728679 ] ASF GitHub Bot commented on HADOOP-18752: - dannycjones commented on code in PR #5689: URL:

[GitHub] [hadoop] dannycjones commented on a diff in pull request #5689: HADOOP-18752. Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread via GitHub
dannycjones commented on code in PR #5689: URL: https://github.com/apache/hadoop/pull/5689#discussion_r1214206939 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/directory_markers.md: ## @@ -12,35 +12,40 @@ limitations under the License. See accompanying

[GitHub] [hadoop] MayankSinghParmar commented on pull request #5497: HDFS-16959. RBF: State store cache loading metrics

2023-06-02 Thread via GitHub
MayankSinghParmar commented on PR #5497: URL: https://github.com/apache/hadoop/pull/5497#issuecomment-1573496151 > @MayankSinghParmar You need to share some more pointers, may be you can subscribe to hdfs-dev mailing list and drop a mail over there and folks would be able to help >

[jira] [Commented] (HADOOP-18752) Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728672#comment-17728672 ] ASF GitHub Bot commented on HADOOP-18752: - dannycjones commented on code in PR #5689: URL:

[GitHub] [hadoop] dannycjones commented on a diff in pull request #5689: HADOOP-18752. Change fs.s3a.directory.marker.retention to "keep"

2023-06-02 Thread via GitHub
dannycjones commented on code in PR #5689: URL: https://github.com/apache/hadoop/pull/5689#discussion_r1214190161 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/directory_markers.md: ## @@ -12,35 +12,40 @@ limitations under the License. See accompanying

[GitHub] [hadoop] LiuGuH opened a new pull request, #5709: HDFS-17036. Limit pendingReconstruction size

2023-06-02 Thread via GitHub
LiuGuH opened a new pull request, #5709: URL: https://github.com/apache/hadoop/pull/5709 ### Description of PR As describe in https://issues.apache.org/jira/browse/HDFS-17036 ### How was this patch tested? Add a new test case for it -- This is an

[GitHub] [hadoop] ayushtkn commented on pull request #5497: HDFS-16959. RBF: State store cache loading metrics

2023-06-02 Thread via GitHub
ayushtkn commented on PR #5497: URL: https://github.com/apache/hadoop/pull/5497#issuecomment-1573357545 @MayankSinghParmar You need to share some more pointers, may be you can subscribe to hdfs-dev mailing list and drop a mail over there and folks would be able to help

[GitHub] [hadoop] hadoop-yetus commented on pull request #5700: HDFS-17030. Limit wait time for getHAServiceState in ObserverReaderProxy

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5700: URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1573240209 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhtttylz commented on a diff in pull request #5698: HDFS-17029. Support getECPolices API in WebHDFS

2023-06-02 Thread via GitHub
zhtttylz commented on code in PR #5698: URL: https://github.com/apache/hadoop/pull/5698#discussion_r1213978842 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java: ## @@ -2291,6 +2291,36 @@ public void testFsStatus() throws Exception {

[GitHub] [hadoop] lfxy commented on a diff in pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-06-02 Thread via GitHub
lfxy commented on code in PR #5561: URL: https://github.com/apache/hadoop/pull/5561#discussion_r1213975421 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java: ## @@ -564,4 +566,113 @@ public void testConcatOnSameFile()

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5698: HDFS-17029. Support getECPolices API in WebHDFS

2023-06-02 Thread via GitHub
ayushtkn commented on code in PR #5698: URL: https://github.com/apache/hadoop/pull/5698#discussion_r1213973691 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java: ## @@ -2291,6 +2291,36 @@ public void testFsStatus() throws Exception {

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5698: HDFS-17029. Support getECPolices API in WebHDFS

2023-06-02 Thread via GitHub
ayushtkn commented on code in PR #5698: URL: https://github.com/apache/hadoop/pull/5698#discussion_r1213971976 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java: ## @@ -2291,6 +2291,36 @@ public void testFsStatus() throws Exception {

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-06-02 Thread via GitHub
ayushtkn commented on code in PR #5561: URL: https://github.com/apache/hadoop/pull/5561#discussion_r1213964431 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java: ## @@ -564,4 +566,113 @@ public void

[GitHub] [hadoop] hadoop-yetus commented on pull request #5671: HDFS-17019. Optimize the logic for reconfigure slow peer enable for Namenode"

2023-06-02 Thread via GitHub
hadoop-yetus commented on PR #5671: URL: https://github.com/apache/hadoop/pull/5671#issuecomment-1573201644 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |