[GitHub] [hadoop] zhuzilong2013 commented on pull request #5962: HDFS-16644.java.io.IOException Invalid token in javax.security.sasl.qop

2023-08-18 Thread via GitHub
zhuzilong2013 commented on PR #5962: URL: https://github.com/apache/hadoop/pull/5962#issuecomment-1684709101 Hi @Hexiaoqiao @haiyang1987 Could you help review this when you have time? Thanks a lot~ -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] slfan1989 commented on pull request #5945: YARN-10218. [GPG] Support HTTPS in GPG.

2023-08-18 Thread via GitHub
slfan1989 commented on PR #5945: URL: https://github.com/apache/hadoop/pull/5945#issuecomment-1684698778 @goiri Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] slfan1989 merged pull request #5945: YARN-10218. [GPG] Support HTTPS in GPG.

2023-08-18 Thread via GitHub
slfan1989 merged PR #5945: URL: https://github.com/apache/hadoop/pull/5945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] slfan1989 commented on pull request #5946: YARN-11154. Make router support proxy server.

2023-08-18 Thread via GitHub
slfan1989 commented on PR #5946: URL: https://github.com/apache/hadoop/pull/5946#issuecomment-1684698278 @zhengchenyu Thanks for your contribution! @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] slfan1989 merged pull request #5946: YARN-11154. Make router support proxy server.

2023-08-18 Thread via GitHub
slfan1989 merged PR #5946: URL: https://github.com/apache/hadoop/pull/5946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5963: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5963: URL: https://github.com/apache/hadoop/pull/5963#issuecomment-1684664925 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18837) Upgrade Okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756210#comment-17756210 ] ASF GitHub Bot commented on HADOOP-18837: - hadoop-yetus commented on PR #5961: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5961: HADOOP-18837. Upgrade okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5961: URL: https://github.com/apache/hadoop/pull/5961#issuecomment-1684643231 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18820) AWS SDK v2: make the v1 bridging support optional

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756209#comment-17756209 ] ASF GitHub Bot commented on HADOOP-18820: - hadoop-yetus commented on PR #5872: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1684630214 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5964: Bump org.apache.sshd:sshd-core from 1.6.0 to 2.7.0 in /hadoop-project

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5964: URL: https://github.com/apache/hadoop/pull/5964#issuecomment-1684489396 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5963: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5963: URL: https://github.com/apache/hadoop/pull/5963#issuecomment-1684423452 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] dependabot[bot] opened a new pull request, #5964: Bump org.apache.sshd:sshd-core from 1.6.0 to 2.7.0 in /hadoop-project

2023-08-18 Thread via GitHub
dependabot[bot] opened a new pull request, #5964: URL: https://github.com/apache/hadoop/pull/5964 Bumps [org.apache.sshd:sshd-core](https://github.com/apache/mina-sshd) from 1.6.0 to 2.7.0. Changelog Sourced from

[GitHub] [hadoop] hadoop-yetus commented on pull request #5962: HDFS-16644.java.io.IOException Invalid token in javax.security.sasl.qop

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5962: URL: https://github.com/apache/hadoop/pull/5962#issuecomment-1684387957 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5947: HDFS-17158. Show the rate of metrics in EC recovery task.

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5947: URL: https://github.com/apache/hadoop/pull/5947#issuecomment-1684218879 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] simbadzina commented on pull request #5963: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-08-18 Thread via GitHub
simbadzina commented on PR #5963: URL: https://github.com/apache/hadoop/pull/5963#issuecomment-1684207499 This is a backport of https://github.com/apache/hadoop/pull/5897 into branch-3.3. Can you please indicate how clean the backport was. -- This is an automated message from the

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-18 Thread via GitHub
simbadzina commented on code in PR #5959: URL: https://github.com/apache/hadoop/pull/5959#discussion_r1298654179 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java: ## @@ -64,6 +64,12 @@ * File {@link *

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-18 Thread via GitHub
simbadzina commented on code in PR #5959: URL: https://github.com/apache/hadoop/pull/5959#discussion_r1298654179 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java: ## @@ -64,6 +64,12 @@ * File {@link *

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-18 Thread via GitHub
simbadzina commented on code in PR #5959: URL: https://github.com/apache/hadoop/pull/5959#discussion_r1298654179 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java: ## @@ -64,6 +64,12 @@ * File {@link *

[GitHub] [hadoop] hchaverri opened a new pull request, #5963: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-08-18 Thread via GitHub
hchaverri opened a new pull request, #5963: URL: https://github.com/apache/hadoop/pull/5963 …che so tokens are updated frequently. ### Description of PR JIRA: [HDFS-17128](https://issues.apache.org/jira/browse/HDFS-17128). Updating SQLDelegationTokenSecretManager to use

[GitHub] [hadoop] hadoop-yetus commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1684125920 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18496) upgrade kotlin-stdlib due to CVEs

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756040#comment-17756040 ] ASF GitHub Bot commented on HADOOP-18496: - ashutoshcipher commented on PR #5139: URL:

[GitHub] [hadoop] ashutoshcipher commented on pull request #5139: HADOOP-18496. Upgrade okhttp3 and dependencies due to kotlin CVEs

2023-08-18 Thread via GitHub
ashutoshcipher commented on PR #5139: URL: https://github.com/apache/hadoop/pull/5139#issuecomment-1684117467 Hi I agree to what you are saying, but it's not really something I introduced but was already present before On Fri, 18 Aug, 2023, 4:52 pm PJ Fanning, ***@***.***>

[GitHub] [hadoop] pjfanning commented on pull request #5139: HADOOP-18496. Upgrade okhttp3 and dependencies due to kotlin CVEs

2023-08-18 Thread via GitHub
pjfanning commented on PR #5139: URL: https://github.com/apache/hadoop/pull/5139#issuecomment-1684113240 @ashutoshcipher this might be controversial but I think that Hadoop has too many lib dependencies. I think it would be better to use simpler dependencies like Apache HttpClient than to

[jira] [Commented] (HADOOP-18496) upgrade kotlin-stdlib due to CVEs

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756038#comment-17756038 ] ASF GitHub Bot commented on HADOOP-18496: - pjfanning commented on PR #5139: URL:

[jira] [Commented] (HADOOP-18496) upgrade kotlin-stdlib due to CVEs

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756036#comment-17756036 ] ASF GitHub Bot commented on HADOOP-18496: - pjfanning commented on PR #5139: URL:

[jira] [Commented] (HADOOP-18496) upgrade kotlin-stdlib due to CVEs

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756037#comment-17756037 ] ASF GitHub Bot commented on HADOOP-18496: - pjfanning closed pull request #5139: HADOOP-18496.

[GitHub] [hadoop] pjfanning closed pull request #5139: HADOOP-18496. Upgrade okhttp3 and dependencies due to kotlin CVEs

2023-08-18 Thread via GitHub
pjfanning closed pull request #5139: HADOOP-18496. Upgrade okhttp3 and dependencies due to kotlin CVEs URL: https://github.com/apache/hadoop/pull/5139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop] pjfanning commented on pull request #5139: HADOOP-18496. Upgrade okhttp3 and dependencies due to kotlin CVEs

2023-08-18 Thread via GitHub
pjfanning commented on PR #5139: URL: https://github.com/apache/hadoop/pull/5139#issuecomment-1684110678 This change wasn't working out. I'll close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-18850) Enable dual-layer server-side encryption with AWS KMS keys (DSSE-KMS)

2023-08-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756032#comment-17756032 ] Steve Loughran commented on HADOOP-18850: - aws sdk update goes in next week. nothing which

[jira] [Commented] (HADOOP-18837) Upgrade Okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756031#comment-17756031 ] ASF GitHub Bot commented on HADOOP-18837: - hadoop-yetus commented on PR #5961: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5961: HADOOP-18837. Upgrade okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5961: URL: https://github.com/apache/hadoop/pull/5961#issuecomment-1684102528 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18197) Update protobuf 3.7.1 to a version without CVE-2021-22569

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756029#comment-17756029 ] ASF GitHub Bot commented on HADOOP-18197: - janjwerner-confluent commented on PR #4418: URL:

[GitHub] [hadoop] janjwerner-confluent commented on pull request #4418: HADOOP-18197. Upgrade protobuf to 3.21.7 (through upgraded hadoop-shaded-protobuf jar)

2023-08-18 Thread via GitHub
janjwerner-confluent commented on PR #4418: URL: https://github.com/apache/hadoop/pull/4418#issuecomment-1684101336 @steveloughran The title states upgrade protobuf to 3.21.7 while the version downloaded is 3.21.1. hope you can bump it up whenever you'll get back to this. -- This is

[jira] [Commented] (HADOOP-18837) Upgrade Okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756028#comment-17756028 ] ASF GitHub Bot commented on HADOOP-18837: - steveloughran commented on PR #5961: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5961: HADOOP-18837. Upgrade okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread via GitHub
steveloughran commented on PR #5961: URL: https://github.com/apache/hadoop/pull/5961#issuecomment-1684097316 oh, i've merged without the test finishing -missed that, and #5139 implies there may be problems. i may have to revert this -- This is an automated message from the Apache Git

[jira] [Commented] (HADOOP-18496) upgrade kotlin-stdlib due to CVEs

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756026#comment-17756026 ] ASF GitHub Bot commented on HADOOP-18496: - steveloughran commented on PR #5139: URL:

[jira] [Commented] (HADOOP-18837) Upgrade Okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756027#comment-17756027 ] ASF GitHub Bot commented on HADOOP-18837: - rohit-kb opened a new pull request, #5961: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5139: HADOOP-18496. Upgrade okhttp3 and dependencies due to kotlin CVEs

2023-08-18 Thread via GitHub
steveloughran commented on PR #5139: URL: https://github.com/apache/hadoop/pull/5139#issuecomment-1684096208 i've just merged this in via #5961. should I revert? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HADOOP-18837) Upgrade Okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756023#comment-17756023 ] ASF GitHub Bot commented on HADOOP-18837: - steveloughran commented on PR #5961: URL:

[jira] [Commented] (HADOOP-18837) Upgrade Okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756024#comment-17756024 ] ASF GitHub Bot commented on HADOOP-18837: - steveloughran closed pull request #5961:

[jira] [Updated] (HADOOP-18837) Upgrade Okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18837: Fix Version/s: 3.3.9 > Upgrade Okio to 3.4.0 due to CVE-2023-3635 >

[GitHub] [hadoop] steveloughran closed pull request #5961: HADOOP-18837. Upgrade okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread via GitHub
steveloughran closed pull request #5961: HADOOP-18837. Upgrade okio to 3.4.0 due to CVE-2023-3635 URL: https://github.com/apache/hadoop/pull/5961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] steveloughran commented on pull request #5961: HADOOP-18837. Upgrade okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread via GitHub
steveloughran commented on PR #5961: URL: https://github.com/apache/hadoop/pull/5961#issuecomment-1684093577 manually merged each patch; github only does squashing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756016#comment-17756016 ] ASF GitHub Bot commented on HADOOP-18487: - steveloughran commented on PR #4996: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4996: HADOOP-18487. protobuf 2.5.0 marked as provided.

2023-08-18 Thread via GitHub
steveloughran commented on PR #4996: URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1684078261 tests are unrelated. # this pr is ready to go in, followed by one switching protobuf 2.5 to provided -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] zhuzilong2013 opened a new pull request, #5962: HDFS-16644.java.io.IOException Invalid token in javax.security.sasl.qop

2023-08-18 Thread via GitHub
zhuzilong2013 opened a new pull request, #5962: URL: https://github.com/apache/hadoop/pull/5962 ### Description of PR This change prevents qop values ​​from being overwritten with illegal values. JIRA: HDFS-16644 ### How was this patch tested? Test in a production environment

[jira] [Updated] (HADOOP-18854) add options to disable range merging of vectored io

2023-08-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18854: Parent: HADOOP-18855 Issue Type: Sub-task (was: Improvement) > add options to

[jira] [Created] (HADOOP-18855) VectorIO API tuning

2023-08-18 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18855: --- Summary: VectorIO API tuning Key: HADOOP-18855 URL: https://issues.apache.org/jira/browse/HADOOP-18855 Project: Hadoop Common Issue Type: Improvement

[GitHub] [hadoop] hadoop-yetus commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1684015987 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-18854) add options to disable range merging of vectored io

2023-08-18 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18854: --- Summary: add options to disable range merging of vectored io Key: HADOOP-18854 URL: https://issues.apache.org/jira/browse/HADOOP-18854 Project: Hadoop Common

[jira] [Commented] (HADOOP-18853) AWS SDK V2 - Integrate new transfer manager

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755985#comment-17755985 ] ASF GitHub Bot commented on HADOOP-18853: - hadoop-yetus commented on PR #5960: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5960: HADOOP-18853. Upgrades SDK version

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5960: URL: https://github.com/apache/hadoop/pull/5960#issuecomment-1683970534 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5881: Hadoop-18759: [ABFS][Backoff-Optimization] Have a Static retry policy for connection timeout.

2023-08-18 Thread via GitHub
steveloughran commented on code in PR #5881: URL: https://github.com/apache/hadoop/pull/5881#discussion_r1298441035 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -56,6 +56,7 @@ import

[jira] [Commented] (HADOOP-18845) Add ability to configure ConnectionTTL of http connections while creating S3 Client.

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755966#comment-17755966 ] ASF GitHub Bot commented on HADOOP-18845: - steveloughran commented on code in PR #5948: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5948: HADOOP-18845. Add ability to configure s3 connection ttl

2023-08-18 Thread via GitHub
steveloughran commented on code in PR #5948: URL: https://github.com/apache/hadoop/pull/5948#discussion_r1298437465 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java: ## @@ -156,10 +156,16 @@ private Constants() { public static final String

[jira] [Commented] (HADOOP-18853) AWS SDK V2 - Integrate new transfer manager

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755965#comment-17755965 ] ASF GitHub Bot commented on HADOOP-18853: - steveloughran commented on code in PR #5960: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5960: HADOOP-18853. Upgrades SDK version

2023-08-18 Thread via GitHub
steveloughran commented on code in PR #5960: URL: https://github.com/apache/hadoop/pull/5960#discussion_r1298431726 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -98,17 +99,25 @@ public S3AsyncClient createS3AsyncClient(

[jira] [Commented] (HADOOP-18851) AbstractDelegationTokenSecretManager- Performance improvement by optimising the synchronization context

2023-08-18 Thread Vikas Kumar (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755940#comment-17755940 ] Vikas Kumar commented on HADOOP-18851: -- Hello, I have made the changes and uploading the patch

[jira] [Updated] (HADOOP-18851) AbstractDelegationTokenSecretManager- Performance improvement by optimising the synchronization context

2023-08-18 Thread Vikas Kumar (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Kumar updated HADOOP-18851: - Attachment: 0001-HADOOP-18851-Perfm-improvement-for-ZKDT-management.patch >

[jira] [Commented] (HADOOP-18837) Upgrade Okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755939#comment-17755939 ] ASF GitHub Bot commented on HADOOP-18837: - rohit-kb opened a new pull request, #5961: URL:

[GitHub] [hadoop] rohit-kb opened a new pull request, #5961: HADOOP-18837. Upgrade okio to 3.4.0 due to CVE-2023-3635

2023-08-18 Thread via GitHub
rohit-kb opened a new pull request, #5961: URL: https://github.com/apache/hadoop/pull/5961 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[GitHub] [hadoop] hadoop-yetus commented on pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5959: URL: https://github.com/apache/hadoop/pull/5959#issuecomment-1683736877 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ahmarsuhail commented on pull request #5960: HADOOP-18853. Upgrades SDK version

2023-08-18 Thread via GitHub
ahmarsuhail commented on PR #5960: URL: https://github.com/apache/hadoop/pull/5960#issuecomment-1683736580 @steveloughran this updates the SDK version, so the Java async client has MPU again. Since Multipart operations are in the java async client now, and not the TM, we could consider

[jira] [Commented] (HADOOP-18853) AWS SDK V2 - Integrate new transfer manager

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755919#comment-17755919 ] ASF GitHub Bot commented on HADOOP-18853: - ahmarsuhail commented on PR #5960: URL:

[jira] [Updated] (HADOOP-18853) AWS SDK V2 - Integrate new transfer manager

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18853: Labels: pull-request-available (was: ) > AWS SDK V2 - Integrate new transfer manager >

[jira] [Commented] (HADOOP-18853) AWS SDK V2 - Integrate new transfer manager

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755901#comment-17755901 ] ASF GitHub Bot commented on HADOOP-18853: - ahmarsuhail opened a new pull request, #5960: URL:

[GitHub] [hadoop] ahmarsuhail opened a new pull request, #5960: HADOOP-18853. Upgrades SDK version

2023-08-18 Thread via GitHub
ahmarsuhail opened a new pull request, #5960: URL: https://github.com/apache/hadoop/pull/5960 ### Description of PR * Upgrades SDK Version so it has the new Java Async client with MPU support. * Configures java async client with MPU threshold and part size * Removes CRT

[GitHub] [hadoop] brumi1024 commented on pull request #5958: YARN-11551. RM format-conf-store should delete all the content of ZKConfigStore

2023-08-18 Thread via GitHub
brumi1024 commented on PR #5958: URL: https://github.com/apache/hadoop/pull/5958#issuecomment-1683674688 Thanks @ferdelyi @tomicooler for the review. Merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] brumi1024 merged pull request #5958: YARN-11551. RM format-conf-store should delete all the content of ZKConfigStore

2023-08-18 Thread via GitHub
brumi1024 merged PR #5958: URL: https://github.com/apache/hadoop/pull/5958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] LiuGuH commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-08-18 Thread via GitHub
LiuGuH commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1683622535 > If true, is it enough to make IBR and FBR asynchronously together and use only one thread? Thanks. I tried and I've given up. The reason are as follows: IBR and FBR are not on the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1683544752 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] flaming-archer commented on pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-18 Thread via GitHub
flaming-archer commented on PR #5959: URL: https://github.com/apache/hadoop/pull/5959#issuecomment-1683535756 @simbadzina Could you please help to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] flaming-archer opened a new pull request, #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-18 Thread via GitHub
flaming-archer opened a new pull request, #5959: URL: https://github.com/apache/hadoop/pull/5959 ### Description of PR Small doc fix. StateStoreService lacks an introduction to StateStoreFileSystemImpl and StateStoreMySQLImpl . ### How was this patch tested? No need

[jira] [Commented] (HADOOP-18820) AWS SDK v2: make the v1 bridging support optional

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755843#comment-17755843 ] ASF GitHub Bot commented on HADOOP-18820: - hadoop-yetus commented on PR #5872: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1683510272 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5591: HDFS-16991. fix testMkdirsRaceWithObserverRead

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5591: URL: https://github.com/apache/hadoop/pull/5591#issuecomment-1683472450 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18820) AWS SDK v2: make the v1 bridging support optional

2023-08-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755830#comment-17755830 ] ASF GitHub Bot commented on HADOOP-18820: - hadoop-yetus commented on PR #5872: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-18 Thread via GitHub
hadoop-yetus commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1683467969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |