[jira] [Commented] (HADOOP-17372) S3A AWS Credential provider loading gets confused with isolated classloaders

2023-11-20 Thread Antonio Murgia (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788308#comment-17788308 ] Antonio Murgia commented on HADOOP-17372: - Given the issue reported by [~brandonvin] , would

[PR] HDFS-17233. The conf dfs.datanode.lifeline.interval.seconds is not co… [hadoop]

2023-11-20 Thread via GitHub
eshwitha opened a new pull request, #6286: URL: https://github.com/apache/hadoop/pull/6286 …nsidering time unit seconds ### Description of PR The configuration dfs.datanode.lifeline.interval.seconds is not considering the time unit as seconds. Upon configuring the

Re: [PR] HADOOP-18872: [Backport to 3.3] [ABFS] [BugFix] Misreporting Retry Count for Sub-sequential and Parallel Operations [hadoop]

2023-11-20 Thread via GitHub
hadoop-yetus commented on PR #6284: URL: https://github.com/apache/hadoop/pull/6284#issuecomment-1820325936 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18872) ABFS: Misreporting Retry Count for Sub-sequential and Parallel Operations

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788273#comment-17788273 ] ASF GitHub Bot commented on HADOOP-18872: - hadoop-yetus commented on PR #6284: URL:

[jira] [Commented] (HADOOP-18874) ABFS: Adding Server returned request id in Exception method thrown to caller.

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788271#comment-17788271 ] ASF GitHub Bot commented on HADOOP-18874: - hadoop-yetus commented on PR #6285: URL:

Re: [PR] HADOOP-18874: [Backport to 3.3] [ABFS] Adding Server returned request id in Exception Message thrown to caller. [hadoop]

2023-11-20 Thread via GitHub
hadoop-yetus commented on PR #6285: URL: https://github.com/apache/hadoop/pull/6285#issuecomment-1820323305 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-20 Thread via GitHub
xinglin commented on code in PR #6183: URL: https://github.com/apache/hadoop/pull/6183#discussion_r1400039039 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1171,6 +1179,47 @@ public void

[PR] HADOOP-18874: [Backport to 3.3] [ABFS] Adding Server returned request id in Exception Message thrown to caller. [hadoop]

2023-11-20 Thread via GitHub
anujmodi2021 opened a new pull request, #6285: URL: https://github.com/apache/hadoop/pull/6285 Jira Ticket: https://issues.apache.org/jira/browse/HADOOP-18874 Trunk PR: https://github.com/apache/hadoop/pull/6004 Cherry-picked commit:

[jira] [Commented] (HADOOP-18874) ABFS: Adding Server returned request id in Exception method thrown to caller.

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788246#comment-17788246 ] ASF GitHub Bot commented on HADOOP-18874: - anujmodi2021 opened a new pull request, #6285: URL:

[jira] [Commented] (HADOOP-18872) ABFS: Misreporting Retry Count for Sub-sequential and Parallel Operations

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788243#comment-17788243 ] ASF GitHub Bot commented on HADOOP-18872: - anujmodi2021 opened a new pull request, #6284: URL:

[PR] HADOOP-18872: [Backport to 3.3] [ABFS] [BugFix] Misreporting Retry Count for Sub-sequential and Parallel Operations [hadoop]

2023-11-20 Thread via GitHub
anujmodi2021 opened a new pull request, #6284: URL: https://github.com/apache/hadoop/pull/6284 Jira Ticket: https://issues.apache.org/jira/browse/HADOOP-18872 Trunk PR: https://github.com/apache/hadoop/pull/6019 Cherry-picked commit:

Re: [PR] YARN-11485. [Federation] Router Supports Yarn Admin CLI Cmds. [hadoop]

2023-11-20 Thread via GitHub
goiri commented on code in PR #6265: URL: https://github.com/apache/hadoop/pull/6265#discussion_r1399917820 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java: ## @@ -1099,4 +1099,27 @@ public void

[jira] [Commented] (HADOOP-18959) Use builder for prefetch CachingBlockManager

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788201#comment-17788201 ] ASF GitHub Bot commented on HADOOP-18959: - hadoop-yetus commented on PR #6240: URL:

Re: [PR] HADOOP-18959 S3A : Use builder for prefetch CachingBlockManager [hadoop]

2023-11-20 Thread via GitHub
hadoop-yetus commented on PR #6240: URL: https://github.com/apache/hadoop/pull/6240#issuecomment-1820053567 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11485. [Federation] Router Supports Yarn Admin CLI Cmds. [hadoop]

2023-11-20 Thread via GitHub
hadoop-yetus commented on PR #6265: URL: https://github.com/apache/hadoop/pull/6265#issuecomment-1820022322 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18959) Use builder for prefetch CachingBlockManager

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788176#comment-17788176 ] ASF GitHub Bot commented on HADOOP-18959: - virajjasani commented on code in PR #6240: URL:

Re: [PR] HADOOP-18959 S3A : Use builder for prefetch CachingBlockManager [hadoop]

2023-11-20 Thread via GitHub
virajjasani commented on code in PR #6240: URL: https://github.com/apache/hadoop/pull/6240#discussion_r1399837597 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/BlockManagerParameters.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the

[jira] [Updated] (HADOOP-18985) "Reversed (or previously applied) patch detected" for hadoop-common-project/hadoop-common/dev-support/jdiff-workaround.patch

2023-11-20 Thread Xing Lin (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xing Lin updated HADOOP-18985: -- Summary: "Reversed (or previously applied) patch detected" for

[jira] [Updated] (HADOOP-18985) Reversed (or previously applied) patch detected for hadoop-common-project/hadoop-common/dev-support/jdiff-workaround.patch

2023-11-20 Thread Xing Lin (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xing Lin updated HADOOP-18985: -- Target Version/s: 3.4.0, 3.3.9 Affects Version/s: 3.4.0 > Reversed (or previously applied)

[jira] [Updated] (HADOOP-18985) Reversed (or previously applied) patch detected for hadoop-common-project/hadoop-common/dev-support/jdiff-workaround.patch

2023-11-20 Thread Xing Lin (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xing Lin updated HADOOP-18985: -- Description: tried to compile under Hadoop-common-project and noticed the following.  trunk: commit

[jira] [Created] (HADOOP-18985) Reversed (or previously applied) patch detected for hadoop-common-project/hadoop-common/dev-support/jdiff-workaround.patch

2023-11-20 Thread Xing Lin (Jira)
Xing Lin created HADOOP-18985: - Summary: Reversed (or previously applied) patch detected for hadoop-common-project/hadoop-common/dev-support/jdiff-workaround.patch Key: HADOOP-18985 URL:

[jira] [Commented] (HADOOP-18981) Move oncrpc/portmap from hadoop-nfs to hadoop-common

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788161#comment-17788161 ] ASF GitHub Bot commented on HADOOP-18981: - xinglin commented on PR #6280: URL:

Re: [PR] HADOOP-18981. moved oncrpc/portmap from hadoop-common-project/hadoop-nfs to hadoop-common-project/hadoop-common [hadoop]

2023-11-20 Thread via GitHub
xinglin commented on PR #6280: URL: https://github.com/apache/hadoop/pull/6280#issuecomment-1819853710 @goiri / @ZanderXu, can I get a review? thanks, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-18980) S3A credential provider remapping: make extensible

2023-11-20 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788128#comment-17788128 ] Viraj Jasani commented on HADOOP-18980: --- {quote}exactly; though i'd expect the remapping to be

[jira] [Comment Edited] (HADOOP-18980) S3A credential provider remapping: make extensible

2023-11-20 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788128#comment-17788128 ] Viraj Jasani edited comment on HADOOP-18980 at 11/20/23 6:44 PM: - In

[jira] [Updated] (HADOOP-18972) Bug in SaslPropertiesResolver allows mutation of internal state

2023-11-20 Thread Charles Connell (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles Connell updated HADOOP-18972: - Description: When {{SaslDataTransferServer}} or {{SaslDataTranferClient}} want to get

[jira] [Commented] (HADOOP-18957) Use StandardCharsets.UTF_8 constant

2023-11-20 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788119#comment-17788119 ] Ayush Saxena commented on HADOOP-18957: --- Committed to trunk. Thanx [~pj.fanning] for the

[jira] [Commented] (HADOOP-18957) Use StandardCharsets.UTF_8 constant

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788118#comment-17788118 ] ASF GitHub Bot commented on HADOOP-18957: - ayushtkn commented on PR #6231: URL:

[jira] [Resolved] (HADOOP-18957) Use StandardCharsets.UTF_8 constant

2023-11-20 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HADOOP-18957. --- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > Use

Re: [PR] HADOOP-18957. Use StandardCharsets.UTF_8 [hadoop]

2023-11-20 Thread via GitHub
ayushtkn commented on PR #6231: URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1819576205 Failed test passes locally ``` [INFO] --- [INFO] T E S T S [INFO] ---

[jira] [Commented] (HADOOP-18957) Use StandardCharsets.UTF_8 constant

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788117#comment-17788117 ] ASF GitHub Bot commented on HADOOP-18957: - ayushtkn merged PR #6231: URL:

[jira] [Assigned] (HADOOP-18957) Use StandardCharsets.UTF_8 constant

2023-11-20 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned HADOOP-18957: - Assignee: PJ Fanning > Use StandardCharsets.UTF_8 constant >

Re: [PR] HADOOP-18957. Use StandardCharsets.UTF_8 [hadoop]

2023-11-20 Thread via GitHub
ayushtkn merged PR #6231: URL: https://github.com/apache/hadoop/pull/6231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18931) FileSystem.getFileSystemClass() to log at debug the jar the .class came from

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788110#comment-17788110 ] ASF GitHub Bot commented on HADOOP-18931: - virajjasani commented on PR #6197: URL:

Re: [PR] HADOOP-18931. FileSystem.getFileSystemClass() to log at debug the jar the .class came from [hadoop]

2023-11-20 Thread via GitHub
virajjasani commented on PR #6197: URL: https://github.com/apache/hadoop/pull/6197#issuecomment-1819539985 It is assertj: `org.assertj.core.api.Assertions` (unless i misinterpreted something) -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (HADOOP-18984) S3A: Support dynamic region resolution

2023-11-20 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18984: --- Summary: S3A: Support dynamic region resolution Key: HADOOP-18984 URL: https://issues.apache.org/jira/browse/HADOOP-18984 Project: Hadoop Common Issue

[jira] [Created] (HADOOP-18983) S3A: remove @deprecated tags where no longer needed

2023-11-20 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18983: --- Summary: S3A: remove @deprecated tags where no longer needed Key: HADOOP-18983 URL: https://issues.apache.org/jira/browse/HADOOP-18983 Project: Hadoop Common

Re: [PR] YARN-11617. Remove noisy log in SingleConstraintAppPlacementAllocator [hadoop]

2023-11-20 Thread via GitHub
hadoop-yetus commented on PR #6283: URL: https://github.com/apache/hadoop/pull/6283#issuecomment-1819088870 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11577. Improve FederationInterceptorREST Method Result. [hadoop]

2023-11-20 Thread via GitHub
slfan1989 commented on PR #6190: URL: https://github.com/apache/hadoop/pull/6190#issuecomment-1819015330 @goiri Thank you very much for your help reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] YARN-11577. Improve FederationInterceptorREST Method Result. [hadoop]

2023-11-20 Thread via GitHub
slfan1989 merged PR #6190: URL: https://github.com/apache/hadoop/pull/6190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11617. Remove noisy log in SingleConstraintAppPlacementAllocator [hadoop]

2023-11-20 Thread via GitHub
slfan1989 commented on code in PR #6283: URL: https://github.com/apache/hadoop/pull/6283#discussion_r1399159027 ##

[jira] [Commented] (HADOOP-18959) Use builder for prefetch CachingBlockManager

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787983#comment-17787983 ] ASF GitHub Bot commented on HADOOP-18959: - ahmarsuhail commented on code in PR #6240: URL:

Re: [PR] HADOOP-18959 Use builder for prefetch CachingBlockManager [hadoop]

2023-11-20 Thread via GitHub
ahmarsuhail commented on code in PR #6240: URL: https://github.com/apache/hadoop/pull/6240#discussion_r1399090061 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/BlockManagerParameters.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the

Re: [PR] HDFS-17218. NameNode should process time out excess redundancy blocks [hadoop]

2023-11-20 Thread via GitHub
hadoop-yetus commented on PR #6176: URL: https://github.com/apache/hadoop/pull/6176#issuecomment-1818909919 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18975) AWS SDK v2: extend support for FIPS endpoints

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787963#comment-17787963 ] ASF GitHub Bot commented on HADOOP-18975: - ahmarsuhail commented on PR #6277: URL:

Re: [PR] HADOOP-18975. AWS SDK v2: extend support for FIPS endpoints [hadoop]

2023-11-20 Thread via GitHub
ahmarsuhail commented on PR #6277: URL: https://github.com/apache/hadoop/pull/6277#issuecomment-1818889613 It's[ here](https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AEndpointRegion.java#L221) in ITestS3AEndpointRegion.java

[jira] [Commented] (HADOOP-18975) AWS SDK v2: extend support for FIPS endpoints

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787957#comment-17787957 ] ASF GitHub Bot commented on HADOOP-18975: - steveloughran commented on PR #6277: URL:

[jira] [Commented] (HADOOP-18969) S3A: AbstractS3ACostTest to clear bucket fs.s3a.create.performance flag

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787959#comment-17787959 ] ASF GitHub Bot commented on HADOOP-18969: - steveloughran commented on PR #6264: URL:

Re: [PR] HADOOP-18969. S3A: AbstractS3ACostTest to clear bucket fs.s3a.create.performance [hadoop]

2023-11-20 Thread via GitHub
steveloughran commented on PR #6264: URL: https://github.com/apache/hadoop/pull/6264#issuecomment-1818874863 Can I get a quick review of this @mukund-thakur @ahmarsuhail @HarshitGupta11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] HDFS-17250. EditLogTailer#triggerActiveLogRoll should handle thread Interrupted [hadoop]

2023-11-20 Thread via GitHub
haiyang1987 commented on PR #6266: URL: https://github.com/apache/hadoop/pull/6266#issuecomment-1818874038 > `InterruptedIOException` is a subClass of `IOException`. In the try_catch block in `getActiveNodeProxy`, we do catch for `IOException`. So, interruptedIOException will be captured

Re: [PR] HADOOP-18975. AWS SDK v2: extend support for FIPS endpoints [hadoop]

2023-11-20 Thread via GitHub
steveloughran commented on PR #6277: URL: https://github.com/apache/hadoop/pull/6277#issuecomment-1818873757 i'll say ok to those tests, we just need to make sure that they work/can be disabled during third-party testing. proposed 1. add some test.fips.bucket and test.fips.region

Re: [PR] HDFS-17250. EditLogTailer#triggerActiveLogRoll should handle thread Interrupted [hadoop]

2023-11-20 Thread via GitHub
haiyang1987 commented on PR #6266: URL: https://github.com/apache/hadoop/pull/6266#issuecomment-1818872859 Thanks @xinglin @ZanderXu for your detailed review. > > when we submit a task to an executorService and later on we cancel it due to timeout, and we don't capture interrupted

[jira] [Commented] (HADOOP-18980) S3A credential provider remapping: make extensible

2023-11-20 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787914#comment-17787914 ] Steve Loughran commented on HADOOP-18980: - exactly; though i'd expect the remapping to be from

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-20 Thread via GitHub
hadoop-yetus commented on PR #6183: URL: https://github.com/apache/hadoop/pull/6183#issuecomment-1818691838 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11616. Fast fail for NodeConstraintParser when having multi attribute kvs [hadoop]

2023-11-20 Thread via GitHub
hadoop-yetus commented on PR #6282: URL: https://github.com/apache/hadoop/pull/6282#issuecomment-1818647088 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18981) Move oncrpc/portmap from hadoop-nfs to hadoop-common

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787901#comment-17787901 ] ASF GitHub Bot commented on HADOOP-18981: - hadoop-yetus commented on PR #6280: URL:

Re: [PR] HADOOP-18981. moved oncrpc/portmap from hadoop-common-project/hadoop-nfs to hadoop-common-project/hadoop-common [hadoop]

2023-11-20 Thread via GitHub
hadoop-yetus commented on PR #6280: URL: https://github.com/apache/hadoop/pull/6280#issuecomment-1818574211 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] YARN-11617. Remove noisy log in SingleConstraintAppPlacementAllocator [hadoop]

2023-11-20 Thread via GitHub
zuston opened a new pull request, #6283: URL: https://github.com/apache/hadoop/pull/6283 ### Description of PR Too many noisy log in SingleConstraintAppPlacementAllocator like that: ``` 2023-11-20 15:14:30,493 INFO

[jira] [Commented] (HADOOP-18959) Use builder for prefetch CachingBlockManager

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787881#comment-17787881 ] ASF GitHub Bot commented on HADOOP-18959: - hadoop-yetus commented on PR #6240: URL:

Re: [PR] HADOOP-18959 Use builder for prefetch CachingBlockManager [hadoop]

2023-11-20 Thread via GitHub
hadoop-yetus commented on PR #6240: URL: https://github.com/apache/hadoop/pull/6240#issuecomment-1818459112 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11616. Fast fail for NodeConstraintParser when having multi attribute kvs [hadoop]

2023-11-20 Thread via GitHub
zuston commented on PR #6282: URL: https://github.com/apache/hadoop/pull/6282#issuecomment-1818425405 Could you help review this ? @slfan1989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] YARN-11616. Fast fail for NodeConstraintParser when having multi attribute kvs [hadoop]

2023-11-20 Thread via GitHub
zuston opened a new pull request, #6282: URL: https://github.com/apache/hadoop/pull/6282 ### Description of PR In the `NodeConstraintParser`, it won't throw exception when multiple attribute kvs are specified. It will return incorrect placement constraint, which will mislead users.