[ 
https://issues.apache.org/jira/browse/HADOOP-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788118#comment-17788118
 ] 

ASF GitHub Bot commented on HADOOP-18957:
-----------------------------------------

ayushtkn commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1819576205

   Failed test passes locally
   ```
   [INFO] -------------------------------------------------------
   [INFO]  T E S T S
   [INFO] -------------------------------------------------------
   [INFO] Running 
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
   [INFO] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.9 
s - in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
   [INFO] 
   [INFO] Results:
   [INFO] 
   [INFO] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0
   ```




> Use StandardCharsets.UTF_8 constant
> -----------------------------------
>
>                 Key: HADOOP-18957
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18957
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: PJ Fanning
>            Assignee: PJ Fanning
>            Priority: Major
>              Labels: pull-request-available
>
> * there are some places in the code that have to check for 
> UnsupportedCharsetException when explicitly using the charset name "UTF-8"
> * using StandardCharsets.UTF_8 is more efficient because the Java libs 
> usually have to look up the charsets when you provide it as String param 
> instead
> * also stop using Guava Charsets and use StandardCharsets



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to