Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-05 Thread via GitHub
anmolanmol1234 commented on code in PR #6275: URL: https://github.com/apache/hadoop/pull/6275#discussion_r1416851730 ## hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh: ## @@ -69,6 +69,10 @@

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-05 Thread via GitHub
anmolanmol1234 commented on code in PR #6275: URL: https://github.com/apache/hadoop/pull/6275#discussion_r1416850390 ## hadoop-project/pom.xml: ## @@ -1288,10 +1288,22 @@ jackson-dataformat-cbor ${jackson2.version} + +org.mockito +

Re: [PR] HDFS-16740 backport mini cluster flakiness fixes to 3.3 [hadoop]

2023-12-05 Thread via GitHub
hadoop-yetus commented on PR #6325: URL: https://github.com/apache/hadoop/pull/6325#issuecomment-1842161709 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-14444) New implementation of ftp and sftp filesystems

2023-12-05 Thread melin (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793522#comment-17793522 ] melin commented on HADOOP-1: SFTPInputStream Support seek? > New implementation of ftp and sftp

Re: [PR] HDFS-17262 Fixed the verbose log.warn in DFSUtil.addTransferRateMetric(). [hadoop]

2023-12-05 Thread via GitHub
xinglin commented on PR #6290: URL: https://github.com/apache/hadoop/pull/6290#issuecomment-1842128634 That is a good catch. Did not notice there are two builds after my latest commit. Let's wait for a new build. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] HDFS-16740 backport mini cluster flakiness fixes to 3.3 [hadoop]

2023-12-05 Thread via GitHub
mccormickt12 commented on PR #6325: URL: https://github.com/apache/hadoop/pull/6325#issuecomment-1842087346 These 3 files had conflicts, they all seemed pretty simple to resolve (all related to imports) ``` both modified:

Re: [PR] HDFS-17262 Fixed the verbose log.warn in DFSUtil.addTransferRateMetric(). [hadoop]

2023-12-05 Thread via GitHub
Hexiaoqiao commented on PR #6290: URL: https://github.com/apache/hadoop/pull/6290#issuecomment-1842087055 LGTM. But some unit tests failed at last time, I try to trigger CI manually, let's wait what it will say this time. Thanks. -- This is an automated message from the Apache Git

[PR] HDFS-16740 backport mini cluster flakiness fixes to 3.3 [hadoop]

2023-12-05 Thread via GitHub
mccormickt12 opened a new pull request, #6325: URL: https://github.com/apache/hadoop/pull/6325 ### Description of PR backport mini cluster flakiness fixes to 3.3 ### How was this patch tested? Testing needs to be done via github checks to ensure they pass / improve

Re: [PR] HADOOP-17912. ABFS: Support for Encryption Context [hadoop]

2023-12-05 Thread via GitHub
saxenapranav commented on PR #6221: URL: https://github.com/apache/hadoop/pull/6221#issuecomment-1842079704 Hi @steveloughran , kind reminder for the merge of the PR. Kindly let me please know if you see any probable issue with the merge. Thank you very much. -- This is an automated

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793504#comment-17793504 ] ASF GitHub Bot commented on HADOOP-17912: - saxenapranav commented on PR #6221: URL:

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-12-05 Thread via GitHub
mccormickt12 commented on PR #6196: URL: https://github.com/apache/hadoop/pull/6196#issuecomment-1842026956 closing since this was successfully backported https://github.com/apache/hadoop/pull/6262 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-12-05 Thread via GitHub
mccormickt12 closed pull request #6196: Add getEnclosingRoot API to FileSystem interface and all implementations URL: https://github.com/apache/hadoop/pull/6196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDFS-17262 Fixed the verbose log.warn in DFSUtil.addTransferRateMetric(). [hadoop]

2023-12-05 Thread via GitHub
hadoop-yetus commented on PR #6290: URL: https://github.com/apache/hadoop/pull/6290#issuecomment-1841795440 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19004) S3A: Move to a new HttpSigner for S3Express

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793449#comment-17793449 ] ASF GitHub Bot commented on HADOOP-19004: - hadoop-yetus commented on PR #6324: URL:

Re: [PR] HADOOP-19004. S3A: Support Authentication through HttpSigner API [hadoop]

2023-12-05 Thread via GitHub
hadoop-yetus commented on PR #6324: URL: https://github.com/apache/hadoop/pull/6324#issuecomment-1841740293 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17262 Fixed the verbose log.warn in DFSUtil.addTransferRateMetric(). [hadoop]

2023-12-05 Thread via GitHub
xinglin commented on PR #6290: URL: https://github.com/apache/hadoop/pull/6290#issuecomment-1841737318 @Hexiaoqiao, could you take another look and push this PR into trunk? Thanks, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HADOOP-19004. S3A: Support Authentication through HttpSigner API [hadoop]

2023-12-05 Thread via GitHub
steveloughran commented on PR #6324: URL: https://github.com/apache/hadoop/pull/6324#issuecomment-1841556582 This patch is from @HarshitGupta11; I've added my wrapping changes to it so its going to have yetus and steve happy -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (HADOOP-19004) S3A: Move to a new HttpSigner for S3Express

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793423#comment-17793423 ] ASF GitHub Bot commented on HADOOP-19004: - steveloughran commented on PR #6324: URL:

[jira] [Commented] (HADOOP-19004) S3A: Move to a new HttpSigner for S3Express

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793422#comment-17793422 ] ASF GitHub Bot commented on HADOOP-19004: - steveloughran opened a new pull request, #6324: URL:

[jira] [Updated] (HADOOP-19004) S3A: Move to a new HttpSigner for S3Express

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19004: Labels: pull-request-available (was: ) > S3A: Move to a new HttpSigner for S3Express >

Re: [PR] YARN-11619. [Federation] Router CLI Supports List SubClusters. [hadoop]

2023-12-05 Thread via GitHub
hadoop-yetus commented on PR #6304: URL: https://github.com/apache/hadoop/pull/6304#issuecomment-1841538384 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18924. Upgrade to grpc 1.53.0 due to CVEs (#6161). [hadoop]

2023-12-05 Thread via GitHub
ayushtkn merged PR #6313: URL: https://github.com/apache/hadoop/pull/6313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-19002) Delete invalid code logic

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793398#comment-17793398 ] ASF GitHub Bot commented on HADOOP-19002: - hadoop-yetus commented on PR #6323: URL:

Re: [PR] HADOOP-19002. Delete invalid code logic [hadoop]

2023-12-05 Thread via GitHub
hadoop-yetus commented on PR #6323: URL: https://github.com/apache/hadoop/pull/6323#issuecomment-1841434963 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-19004) S3A: Move to a new HttpSigner for S3Express

2023-12-05 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19004: --- Summary: S3A: Move to a new HttpSigner for S3Express Key: HADOOP-19004 URL: https://issues.apache.org/jira/browse/HADOOP-19004 Project: Hadoop Common

[jira] [Resolved] (HADOOP-18955) AWS SDK v2: add path capability probe "fs.s3a.capability.aws.v2"

2023-12-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18955. - Fix Version/s: 3.4.0 Resolution: Fixed Fixed in HADOOP-18996 > AWS SDK v2: add

[jira] [Resolved] (HADOOP-18961) S3A: add s3guard command "bucket" to create buckets

2023-12-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18961. - Fix Version/s: 3.4.0 Resolution: Fixed Fixed in HADOOP-18996 > S3A: add

[jira] [Updated] (HADOOP-18997) S3A: Add option fs.s3a.s3express.create.session to enable/disable CreateSession

2023-12-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18997: Summary: S3A: Add option fs.s3a.s3express.create.session to enable/disable CreateSession

[jira] [Commented] (HADOOP-18997) S3A: add way to turn off CreateSession API

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793343#comment-17793343 ] ASF GitHub Bot commented on HADOOP-18997: - hadoop-yetus commented on PR #6316: URL:

Re: [PR] HADOOP-18997. S3A: make createSession optional when working with S3Express buckets [hadoop]

2023-12-05 Thread via GitHub
hadoop-yetus commented on PR #6316: URL: https://github.com/apache/hadoop/pull/6316#issuecomment-1841108235 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11613. [Federation] Router CLI Supports Delete SubClusterPolicyConfiguration Of Queues. [hadoop]

2023-12-05 Thread via GitHub
slfan1989 commented on PR #6295: URL: https://github.com/apache/hadoop/pull/6295#issuecomment-1841032635 @goiri Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] YARN-11613. [Federation] Router CLI Supports Delete SubClusterPolicyConfiguration Of Queues. [hadoop]

2023-12-05 Thread via GitHub
slfan1989 merged PR #6295: URL: https://github.com/apache/hadoop/pull/6295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-15413. add dfs.client.read.striped.datanode.max.attempts to fix read ecfile timeout [hadoop]

2023-12-05 Thread via GitHub
hadoop-yetus commented on PR #5829: URL: https://github.com/apache/hadoop/pull/5829#issuecomment-1840975664 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Assigned] (HADOOP-18708) AWS SDK V2 - Implement CSE

2023-12-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-18708: --- Assignee: Ahmar Suhail > AWS SDK V2 - Implement CSE > --

[jira] [Commented] (HADOOP-19003) S3A Assume role tests failing against S3Express stores

2023-12-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793310#comment-17793310 ] Steve Loughran commented on HADOOP-19003: - {code} [ERROR]

[jira] [Created] (HADOOP-19003) S3A Assume role tests failing against S3Express stores

2023-12-05 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19003: --- Summary: S3A Assume role tests failing against S3Express stores Key: HADOOP-19003 URL: https://issues.apache.org/jira/browse/HADOOP-19003 Project: Hadoop Common

[jira] [Commented] (HADOOP-18997) S3A: add way to turn off CreateSession API

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793306#comment-17793306 ] ASF GitHub Bot commented on HADOOP-18997: - steveloughran commented on PR #6316: URL:

[jira] [Commented] (HADOOP-18997) S3A: add way to turn off CreateSession API

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793307#comment-17793307 ] ASF GitHub Bot commented on HADOOP-18997: - steveloughran commented on PR #6316: URL:

Re: [PR] HADOOP-18997. S3A: make createSession optional when working with S3Express buckets [hadoop]

2023-12-05 Thread via GitHub
steveloughran commented on PR #6316: URL: https://github.com/apache/hadoop/pull/6316#issuecomment-1840930612 @HarshitGupta11 @ahmarsuhail can I get this looked at? thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HADOOP-18997. S3A: make createSession optional when working with S3Express buckets [hadoop]

2023-12-05 Thread via GitHub
steveloughran commented on PR #6316: URL: https://github.com/apache/hadoop/pull/6316#issuecomment-1840929387 tested s3express us-west. all the role tests are failing, but not in createsession; some other issue which I won't address here. ITestS3ACommitterFactory seems unrelated; the

[jira] [Updated] (HADOOP-19002) Delete invalid code logic

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19002: Labels: pull-request-available (was: ) > Delete invalid code logic >

[jira] [Commented] (HADOOP-19002) Delete invalid code logic

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793297#comment-17793297 ] ASF GitHub Bot commented on HADOOP-19002: - zzccctv opened a new pull request, #6323: URL:

[jira] [Updated] (HADOOP-19002) Delete invalid code logic

2023-12-05 Thread zhangzhanchang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangzhanchang updated HADOOP-19002: Description: There is invalid logical processing in the namenode format process >

[PR] HADOOP-19002. Delete invalid code logic [hadoop]

2023-12-05 Thread via GitHub
zzccctv opened a new pull request, #6323: URL: https://github.com/apache/hadoop/pull/6323 There is invalid logical processing in the namenode format process,It needs to be deleted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (HADOOP-19002) Delete invalid code logic

2023-12-05 Thread zhangzhanchang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangzhanchang updated HADOOP-19002: Issue Type: Improvement (was: Bug) Priority: Minor (was: Major) > Delete invalid

[jira] [Created] (HADOOP-19002) Delete invalid code logic

2023-12-05 Thread zhangzhanchang (Jira)
zhangzhanchang created HADOOP-19002: --- Summary: Delete invalid code logic Key: HADOOP-19002 URL: https://issues.apache.org/jira/browse/HADOOP-19002 Project: Hadoop Common Issue Type: Bug

Re: [PR] HDFS-17241. avoid doing checkpoint and triggering roll edit log at the same time. [hadoop]

2023-12-05 Thread via GitHub
shuaiqig closed pull request #6236: HDFS-17241. avoid doing checkpoint and triggering roll edit log at the same time. URL: https://github.com/apache/hadoop/pull/6236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] HDFS-17262 Fixed the verbose log.warn in DFSUtil.addTransferRateMetric(). [hadoop]

2023-12-05 Thread via GitHub
bbeaudreault commented on PR #6290: URL: https://github.com/apache/hadoop/pull/6290#issuecomment-1840702278 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-05 Thread via GitHub
hadoop-yetus commented on PR #6319: URL: https://github.com/apache/hadoop/pull/6319#issuecomment-1840689287 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-05 Thread via GitHub
hadoop-yetus commented on PR #6319: URL: https://github.com/apache/hadoop/pull/6319#issuecomment-1840589906 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18924. Upgrade to grpc 1.53.0 due to CVEs (#6161). [hadoop]

2023-12-05 Thread via GitHub
hadoop-yetus commented on PR #6313: URL: https://github.com/apache/hadoop/pull/6313#issuecomment-1840577269 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-05 Thread via GitHub
steveloughran commented on code in PR #6275: URL: https://github.com/apache/hadoop/pull/6275#discussion_r1414157394 ## hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh: ## @@ -69,6 +69,10 @@

[jira] [Updated] (HADOOP-18997) S3A: add way to turn off CreateSession API

2023-12-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18997: Description: add a way to disable the need to use the createsession call, so as to allow

Re: [PR] HDFS-17273. Change the way of computing some local variables duration for better debugging [hadoop]

2023-12-05 Thread via GitHub
hfutatzhanghb commented on code in PR #6321: URL: https://github.com/apache/hadoop/pull/6321#discussion_r1415353197 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -934,14 +936,14 @@ void waitForAckedSeqno(long seqno)

[jira] [Updated] (HADOOP-18968) S3A FileSystem does not correctly list empty directories after HADOOP-17199

2023-12-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18968: Component/s: fs/s3 > S3A FileSystem does not correctly list empty directories after

Re: [PR] YARN-11498 backport jettison exclusions [hadoop]

2023-12-05 Thread via GitHub
pjfanning commented on PR #6063: URL: https://github.com/apache/hadoop/pull/6063#issuecomment-1840488770 @steveloughran @ayushtkn @slfan1989 do you think that is ok to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] YARN-11420 Stabilize TestNMClient [hadoop]

2023-12-05 Thread via GitHub
brumi1024 merged PR #5317: URL: https://github.com/apache/hadoop/pull/5317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11420 Stabilize TestNMClient [hadoop]

2023-12-05 Thread via GitHub
brumi1024 commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1840473904 Thanks @K0K0V0K @susheelgupta7 for the patch, @szilard-nemeth @p-szucs @tomicooler for the reviews. Merging to trunk. -- This is an automated message from the Apache Git Service. To

Re: [PR] YARN-11420 Stabilize TestNMClient [hadoop]

2023-12-05 Thread via GitHub
bteke commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1840473426 Thanks @K0K0V0K @susheelgupta7 for the patch, @szilard-nemeth @p-szucs @tomicooler for the reviews. Merging to trunk. -- This is an automated message from the Apache Git Service. To

Re: [PR] YARN-11621: Fix intermittently failing unit test: TestAMRMProxy.testAMRMProxyTokenRenewal [hadoop]

2023-12-05 Thread via GitHub
brumi1024 merged PR #6310: URL: https://github.com/apache/hadoop/pull/6310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11621: Fix intermittently failing unit test: TestAMRMProxy.testAMRMProxyTokenRenewal [hadoop]

2023-12-05 Thread via GitHub
brumi1024 commented on PR #6310: URL: https://github.com/apache/hadoop/pull/6310#issuecomment-1840463808 Thanks @susheelgupta7 for the patch, @p-szucs and @slfan1989 for the review. Merging to trunk. @susheelgupta7 can you please check if this is applicable for branch-3.3/3.2? -- This

Re: [PR] YARN-11621: Fix intermittently failing unit test: TestAMRMProxy.testAMRMProxyTokenRenewal [hadoop]

2023-12-05 Thread via GitHub
bteke commented on PR #6310: URL: https://github.com/apache/hadoop/pull/6310#issuecomment-1840462103 Thanks @susheelgupta7 for the patch, @p-szucs and @slfan1989 for the review. Merging to trunk. @susheelgupta7 can you please check if this is applicable for branch-3.3/3.2? -- This is an

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-05 Thread via GitHub
lfxy commented on code in PR #6319: URL: https://github.com/apache/hadoop/pull/6319#discussion_r1415304496 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java: ## @@ -1346,9 +1376,9 @@ void printResults() { class

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-05 Thread via GitHub
ayushtkn commented on code in PR #6319: URL: https://github.com/apache/hadoop/pull/6319#discussion_r1415282795 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java: ## @@ -1346,9 +1376,9 @@ void printResults() {