steveloughran commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1414157394
##########
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##########
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-template.conf$"
allowed_expr+="|^jetty-dir.css$"
# Snappy java is native library. We cannot relocate it to under
org/apache/hadoop.
allowed_expr+="|^org/xerial/"
+allowed_expr+="|^win32-x86/$"
+allowed_expr+="|^win32-x86/attach_hotspot_windows.dll$"
Review Comment:
yes, these seem android related. if we keep the android dependencies out,
we don't need these
##########
hadoop-client-modules/hadoop-client-check-test-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##########
@@ -58,6 +58,10 @@
allowed_expr+="|^org.apache.hadoop.application-classloader.properties$"
allowed_expr+="|^java.policy$"
# * Used by javax.annotation
allowed_expr+="|^jndi.properties$"
+allowed_expr+="|^win32-x86/$"
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
