anmolanmol1234 commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1416850390
##########
hadoop-project/pom.xml:
##########
@@ -1288,10 +1288,22 @@
<artifactId>jackson-dataformat-cbor</artifactId>
<version>${jackson2.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-bom</artifactId>
+ <version>${mockito.version}</version>
+ <type>pom</type>
Review Comment:
I agree with the decision to remove the 'mockito-bom' dependency. However,
I've encountered an issue where the DLL files are not being included due to the
removal of this dependency. The DLL files are originally included as part of
the 'byte-buddy-agent' POM, and 'mockito-core' has a dependency on this module.
Despite setting the value of 'mockito-core' as optional in
'hadoop-minicluster,' the transitive dependency is still affecting
'hadoop-client-check-test-invariants,' resulting in an error during the check
for jar contents due to disallowed DLL values. Consequently, I've addressed
this by adding the necessary expressions to allow these DLL files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
