[jira] [Commented] (HADOOP-8152) Expand public APIs for security library classes

2012-04-18 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257156#comment-13257156 ] Eli Collins commented on HADOOP-8152: - I agree the UGI methods should be annotated

[jira] [Commented] (HADOOP-8152) Expand public APIs for security library classes

2012-04-18 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257164#comment-13257164 ] Eli Collins commented on HADOOP-8152: - @Allen, these projects started using these

[jira] [Commented] (HADOOP-8282) start-all.sh refers incorrectly start-dfs.sh existence for starting start-yarn.sh

2012-04-16 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255237#comment-13255237 ] Eli Collins commented on HADOOP-8282: - +1 looks good start-all.sh

[jira] [Commented] (HADOOP-8209) Add option to relax build-version check for branch-1

2012-04-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252230#comment-13252230 ] Eli Collins commented on HADOOP-8209: - Ran all the tests. There are 5 MR failures on

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

2012-04-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252557#comment-13252557 ] Eli Collins commented on HADOOP-8144: - Per discussion on HDFS-3258 the other bug

[jira] [Commented] (HADOOP-8209) Add option to relax build-version check for branch-1

2012-04-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252727#comment-13252727 ] Eli Collins commented on HADOOP-8209: - Thanks for the feedback Tom. Looked at this

[jira] [Commented] (HADOOP-8209) Add option to relax build-version check for branch-1

2012-04-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252734#comment-13252734 ] Eli Collins commented on HADOOP-8209: - Forgot to mention, leaving VersionInfo as is

[jira] [Commented] (HADOOP-8209) Add option to relax build-version check for branch-1

2012-04-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252850#comment-13252850 ] Eli Collins commented on HADOOP-8209: - Thanks Tom, re-ran test-patch and the tests.

[jira] [Commented] (HADOOP-8198) Support multiple network interfaces

2012-04-11 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251709#comment-13251709 ] Eli Collins commented on HADOOP-8198: - @Nathan, thanks for chiming in, answers

[jira] [Commented] (HADOOP-8270) hadoop-daemon.sh stop action is not LSB compliant

2012-04-11 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252062#comment-13252062 ] Eli Collins commented on HADOOP-8270: - +1 looks good, the test failure is unrelated,

[jira] [Commented] (HADOOP-8144) pseudoSortByDistance in NetworkTopology doesn't work properly if no local node and first node is local rack node

2012-04-11 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252080#comment-13252080 ] Eli Collins commented on HADOOP-8144: - Hey Junping, Thanks for contributing! Looks

[jira] [Commented] (HADOOP-8209) Add option to enable DN and TT rolling upgrades in branch-1

2012-04-11 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252085#comment-13252085 ] Eli Collins commented on HADOOP-8209: - Thanks ATM. Will fix the spelling misstake,

[jira] [Commented] (HADOOP-8198) Support multiple network interfaces

2012-04-10 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251292#comment-13251292 ] Eli Collins commented on HADOOP-8198: - Use case 2 is the primary motivation,as you

[jira] [Commented] (HADOOP-8257) Auto-HA: TestZKFailoverControllerStress occasionally fails with Mockito error

2012-04-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248903#comment-13248903 ] Eli Collins commented on HADOOP-8257: - +1 pending jenkins, good catch

[jira] [Commented] (HADOOP-8260) Auto-HA: Replace ClientBaseWithFixes with our own modified copy of the class

2012-04-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249100#comment-13249100 ] Eli Collins commented on HADOOP-8260: - Agree this makes sense. +1 patch looks good

[jira] [Commented] (HADOOP-8249) invalid hadoop-auth cookies should trigger authentication if info is avail before returning HTTP 401

2012-04-05 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247293#comment-13247293 ] Eli Collins commented on HADOOP-8249: - +1 looks good Style nit: the catch and else

[jira] [Commented] (HADOOP-8007) HA: use substitution token for fencing argument

2012-04-04 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246080#comment-13246080 ] Eli Collins commented on HADOOP-8007: - +1 looks great HA: use

[jira] [Commented] (HADOOP-8198) Support multiple network interfaces

2012-04-04 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246487#comment-13246487 ] Eli Collins commented on HADOOP-8198: - I should clarify that host-level bonding works

[jira] [Commented] (HADOOP-8198) Support multiple network interfaces

2012-04-02 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244278#comment-13244278 ] Eli Collins commented on HADOOP-8198: - This proposal enables host-level bonding (as

[jira] [Commented] (HADOOP-8236) haadmin should have configurable timeouts for failover commands

2012-03-31 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243220#comment-13243220 ] Eli Collins commented on HADOOP-8236: - Todd, These timeouts look reasonable to me.

[jira] [Commented] (HADOOP-8211) Update commons-net version to 3.1

2012-03-31 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243631#comment-13243631 ] Eli Collins commented on HADOOP-8211: - I took a stab at restoring HADOOP-6119, I got

[jira] [Commented] (HADOOP-8217) Edge case split-brain race in ZK-based auto-failover

2012-03-30 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242797#comment-13242797 ] Eli Collins commented on HADOOP-8217: - I think the sequence number approach makes

[jira] [Commented] (HADOOP-8149) cap space usage of default log4j rolling policy

2012-03-29 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241313#comment-13241313 ] Eli Collins commented on HADOOP-8149: - Also, mind chiming in wrt what testing you've

[jira] [Commented] (HADOOP-8210) Common side of HDFS-3148

2012-03-27 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239953#comment-13239953 ] Eli Collins commented on HADOOP-8210: - HDFS-3148, which this jira tracks the common

[jira] [Commented] (HADOOP-8131) FsShell put doesn't correctly handle a non-existent dir

2012-03-26 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238632#comment-13238632 ] Eli Collins commented on HADOOP-8131: - I like the new behavior as well, and I suppose

[jira] [Commented] (HADOOP-8216) address log4j.properties inconsistencies btw main and template dirs

2012-03-26 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238917#comment-13238917 ] Eli Collins commented on HADOOP-8216: - I think we should just use the values from

[jira] [Commented] (HADOOP-8210) Common side of HDFS-3148

2012-03-26 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238941#comment-13238941 ] Eli Collins commented on HADOOP-8210: - Why would the local client interface used

[jira] [Commented] (HADOOP-8149) cap space usage of default log4j rolling policy

2012-03-25 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237980#comment-13237980 ] Eli Collins commented on HADOOP-8149: - @Kihwal, does the above sound good to you?

[jira] [Commented] (HADOOP-8210) Common side of HDFS-3148

2012-03-25 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238024#comment-13238024 ] Eli Collins commented on HADOOP-8210: - Think the change to bump commons-net in

[jira] [Commented] (HADOOP-8211) Update commons-net version to 3.1

2012-03-25 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238094#comment-13238094 ] Eli Collins commented on HADOOP-8211: - Arg, I guess changes hadoop-project/pom.xml

[jira] [Commented] (HADOOP-8131) FsShell put doesn't correctly handle a non-existent dir

2012-03-23 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237392#comment-13237392 ] Eli Collins commented on HADOOP-8131: - Hey Daryn, Should we restore the old behavior

[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies

2012-03-22 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235900#comment-13235900 ] Eli Collins commented on HADOOP-8159: - Not sure what's up with Jenkins. It claims The

[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies

2012-03-22 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236030#comment-13236030 ] Eli Collins commented on HADOOP-8159: - Ah, I missed that the test was in HDFS, Colin,

[jira] [Commented] (HADOOP-8149) cap space usage of default log4j rolling policy

2012-03-22 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236101#comment-13236101 ] Eli Collins commented on HADOOP-8149: - Pat and I sync up wrt Kihwal's point about

[jira] [Commented] (HADOOP-8195) Backport FileContext to branch-1

2012-03-21 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234836#comment-13234836 ] Eli Collins commented on HADOOP-8195: - This would get the client side but not the

[jira] [Commented] (HADOOP-8149) cap space usage of default log4j rolling policy

2012-03-21 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234846#comment-13234846 ] Eli Collins commented on HADOOP-8149: - If you don't purge logs then eventually the

[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies

2012-03-20 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233620#comment-13233620 ] Eli Collins commented on HADOOP-8159: - The 1st, 3rd, and 4th bullets still need

[jira] [Commented] (HADOOP-6924) Build fails with non-Sun JREs due to different pathing to the operating system architecture shared libraries

2012-03-19 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232912#comment-13232912 ] Eli Collins commented on HADOOP-6924: - @Devaraj, works for me. Nit: If it works, I'd

[jira] [Commented] (HADOOP-6924) Build fails with non-Sun JREs due to different pathing to the operating system architecture shared libraries

2012-03-19 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232925#comment-13232925 ] Eli Collins commented on HADOOP-6924: - Makes sense. +1 to your latest patch

[jira] [Commented] (HADOOP-6924) Build fails with non-Sun JREs due to different pathing to the operating system architecture shared libraries

2012-03-19 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232929#comment-13232929 ] Eli Collins commented on HADOOP-6924: - Btw on my install (build 2.4, JRE 1.6.0 IBM J9

[jira] [Commented] (HADOOP-6924) Build fails with non-Sun JREs due to different pathing to the operating system architecture shared libraries

2012-03-18 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232338#comment-13232338 ] Eli Collins commented on HADOOP-6924: - bq. the first libjvm.so should be considered

[jira] [Commented] (HADOOP-6924) Build fails with non-Sun JREs due to different pathing to the operating system architecture shared libraries

2012-03-18 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232427#comment-13232427 ] Eli Collins commented on HADOOP-6924: - IMO we should do something simple here (just

[jira] [Commented] (HADOOP-8174) Remove confusing comment in Path#isAbsolute()

2012-03-15 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230481#comment-13230481 ] Eli Collins commented on HADOOP-8174: - The confusion is because there are two

[jira] [Commented] (HADOOP-4885) Try to restore failed replicas of Name Node storage (at checkpoint time)

2012-03-15 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230483#comment-13230483 ] Eli Collins commented on HADOOP-4885: - Ah, that makes sense. Thanks for the

[jira] [Commented] (HADOOP-8174) Remove confusing comment in Path#isAbsolute()

2012-03-15 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230745#comment-13230745 ] Eli Collins commented on HADOOP-8174: - @Suresh, looks good. How about removing the

[jira] [Commented] (HADOOP-6924) Build fails with non-Sun JREs due to different pathing to the operating system architecture shared libraries

2012-03-15 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230892#comment-13230892 ] Eli Collins commented on HADOOP-6924: - Is the first libjvm.so found always the right

[jira] [Commented] (HADOOP-8149) cap space usage of default log4j rolling policy

2012-03-14 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229428#comment-13229428 ] Eli Collins commented on HADOOP-8149: - bq. Have you noticed cases of data loss

[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies

2012-03-14 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229662#comment-13229662 ] Eli Collins commented on HADOOP-8159: - - Why report the entire topology as json in

[jira] [Commented] (HADOOP-4885) Try to restore failed replicas of Name Node storage (at checkpoint time)

2012-03-14 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229774#comment-13229774 ] Eli Collins commented on HADOOP-4885: - bq. I didn't get your seco- nd question: my

[jira] [Commented] (HADOOP-8149) cap space usage of default log4j rolling policy

2012-03-13 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228910#comment-13228910 ] Eli Collins commented on HADOOP-8149: - How about we add back the DRFA section in the

[jira] [Commented] (HADOOP-4885) Try to restore failed replicas of Name Node storage (at checkpoint time)

2012-03-13 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228915#comment-13228915 ] Eli Collins commented on HADOOP-4885: - - In the trunk patch we're also adding

[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies

2012-03-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226696#comment-13226696 ] Eli Collins commented on HADOOP-8159: - Patch for trunk and test case in

[jira] [Commented] (HADOOP-8154) DNS#getIPs shouldn't silently return the local host IP for bogus interface names

2012-03-08 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225585#comment-13225585 ] Eli Collins commented on HADOOP-8154: - bq. I suspect the current behavior was

[jira] [Commented] (HADOOP-8134) DNS claims to return a hostname but returns a PTR record in some cases

2012-03-08 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225673#comment-13225673 ] Eli Collins commented on HADOOP-8134: - I investigated and think we can remove the

[jira] [Commented] (HADOOP-8154) DNS#getIPs shouldn't silently return the local host IP for bogus interface names

2012-03-08 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225700#comment-13225700 ] Eli Collins commented on HADOOP-8154: - bq. Under what circumstances would the

[jira] [Commented] (HADOOP-8149) cap space usage of default log4j rolling policy

2012-03-08 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225706#comment-13225706 ] Eli Collins commented on HADOOP-8149: - Kihwal, Good point. Given that the 23.x

[jira] [Commented] (HADOOP-8157) TestRPCCallBenchmark#testBenchmarkWithWritable fails with RTE

2012-03-08 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225830#comment-13225830 ] Eli Collins commented on HADOOP-8157: - Full stacktrace: {noformat}

[jira] [Commented] (HADOOP-8149) cap space usage of default log4j rolling policy

2012-03-07 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224924#comment-13224924 ] Eli Collins commented on HADOOP-8149: - +1 Great change, and the patch looks good.

[jira] [Commented] (HADOOP-7940) method clear() in org.apache.hadoop.io.Text does not work

2012-02-28 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218333#comment-13218333 ] Eli Collins commented on HADOOP-7940: - Hi Csaba, Thanks for contributing! Mind

[jira] [Commented] (HADOOP-8116) HA: RetriableCommand is using RetryPolicy incorrectly after HADOOP-7896

2012-02-28 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218342#comment-13218342 ] Eli Collins commented on HADOOP-8116: - +1 looks great Nit, the line where you pull

[jira] [Commented] (HADOOP-8104) Inconsistent Jackson versions

2012-02-28 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218464#comment-13218464 ] Eli Collins commented on HADOOP-8104: - +1 to HADOOP-8104.patch

[jira] [Commented] (HADOOP-8104) Inconsistent Jackson versions

2012-02-28 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218469#comment-13218469 ] Eli Collins commented on HADOOP-8104: - Oops, wrong patch name, I meant

[jira] [Commented] (HADOOP-8079) Proposal for enhancements to Hadoop for Windows Server and Windows Azure development and runtime environments

2012-02-26 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216999#comment-13216999 ] Eli Collins commented on HADOOP-8079: - Why not do this trunk first like we do with

[jira] [Commented] (HADOOP-8105) FilterFileSystem should delegate initialize rather than use super

2012-02-22 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214297#comment-13214297 ] Eli Collins commented on HADOOP-8105: - Here's the particular problem you'll see, we

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

2012-02-16 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209556#comment-13209556 ] Eli Collins commented on HADOOP-8074: - Agree. Let's knock out your (Daryn's)

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

2012-02-15 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208810#comment-13208810 ] Eli Collins commented on HADOOP-8074: - Forgot to mention, Colin tried to add a test

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

2012-02-15 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208866#comment-13208866 ] Eli Collins commented on HADOOP-8074: - bq. -1 tests included. Waiting on HDFS-2038.

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

2012-02-15 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208968#comment-13208968 ] Eli Collins commented on HADOOP-8074: - Hey Daryn, Sorry, missed your comment in the

[jira] [Commented] (HADOOP-8069) Enable TCP_NODELAY by default for IPC

2012-02-13 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207565#comment-13207565 ] Eli Collins commented on HADOOP-8069: - +1 nice Enable TCP_NODELAY

[jira] [Commented] (HADOOP-8070) Add standalone benchmark of protobuf IPC

2012-02-13 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207568#comment-13207568 ] Eli Collins commented on HADOOP-8070: - +1 looks great. Nit, remove the commented

[jira] [Commented] (HADOOP-8051) HttpFS documentation it is not wired to the generated site

2012-02-10 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205884#comment-13205884 ] Eli Collins commented on HADOOP-8051: - Nevermind, I missed that the 1st site.xml

[jira] [Commented] (HADOOP-7557) Make IPC header be extensible

2012-02-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204783#comment-13204783 ] Eli Collins commented on HADOOP-7557: - +1 on this as well. (RpcEngine is a small

[jira] [Commented] (HADOOP-8051) HttpFS documentation it is not wired to the generated site

2012-02-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204882#comment-13204882 ] Eli Collins commented on HADOOP-8051: - Why is the change to site.xml necessary?

[jira] [Commented] (HADOOP-7761) Improve performance of raw comparisons

2012-02-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201815#comment-13201815 ] Eli Collins commented on HADOOP-7761: - I've merged this to branch-23.

[jira] [Commented] (HADOOP-8027) Out of the box, visiting /jmx on the NN gives a whole lot of errors in logs.

2012-02-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201908#comment-13201908 ] Eli Collins commented on HADOOP-8027: - +1 pending jenkins Out of

[jira] [Commented] (HADOOP-8012) hadoop-daemon.sh and yarn-daemon.sh are trying to mkdir and chow log/pid dirs which can fail

2012-02-02 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199080#comment-13199080 ] Eli Collins commented on HADOOP-8012: - I've committed this and merged to 23. Thanks

[jira] [Commented] (HADOOP-7991) HA: the FailoverController should check the standby is ready before failing over

2012-02-02 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199108#comment-13199108 ] Eli Collins commented on HADOOP-7991: - Yea, I tested putting the SBN in SM, failover,

[jira] [Commented] (HADOOP-7991) HA: the FailoverController should check the standby is ready before failing over

2012-02-02 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199124#comment-13199124 ] Eli Collins commented on HADOOP-7991: - I've committed this. Thanks for the review

[jira] [Commented] (HADOOP-8010) hadoop-config.sh spews error message when HADOOP_HOME_WARN_SUPPRESS is set to true and HADOOP_HOME is present

2012-02-01 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13198002#comment-13198002 ] Eli Collins commented on HADOOP-8010: - We use == elsewhere in bin/hadoop* shouldn't

[jira] [Commented] (HADOOP-8010) hadoop-config.sh spews error message when HADOOP_HOME_WARN_SUPPRESS is set to true and HADOOP_HOME is present

2012-02-01 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13198044#comment-13198044 ] Eli Collins commented on HADOOP-8010: - Right, but both the daemons explicitly specify

[jira] [Commented] (HADOOP-8012) hadoop-daemon.sh and yarn-daemon.sh are trying to mkdir and chow log/pid dirs which can fail

2012-02-01 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13198155#comment-13198155 ] Eli Collins commented on HADOOP-8012: - +1 looks great

[jira] [Commented] (HADOOP-8010) hadoop-config.sh spews error message when HADOOP_HOME_WARN_SUPPRESS is set to true and HADOOP_HOME is present

2012-01-31 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13197558#comment-13197558 ] Eli Collins commented on HADOOP-8010: - I think this is because you're using sh (or

[jira] [Commented] (HADOOP-8010) hadoop-config.sh spews error message when HADOOP_HOME_WARN_SUPPRESS is set to true and HADOOP_HOME is present

2012-01-31 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13197561#comment-13197561 ] Eli Collins commented on HADOOP-8010: - Adding env bash to hadoop-config.sh should fix

[jira] [Commented] (HADOOP-7997) SequenceFile.createWriter(...createParent...) no longer works on existing file

2012-01-26 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13194324#comment-13194324 ] Eli Collins commented on HADOOP-7997: - Can't seem to kick jenkins. Ran the tests

[jira] [Commented] (HADOOP-7938) HA: the FailoverController should optionally fence the active during failover

2012-01-24 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13192621#comment-13192621 ] Eli Collins commented on HADOOP-7938: - Forgot to mention, the failover state machine

[jira] [Commented] (HADOOP-6795) FsShell 'hadoop fs -text' does not work with other file systems

2012-01-24 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13192655#comment-13192655 ] Eli Collins commented on HADOOP-6795: - Hey Brian, Your patch looks great. Mind

[jira] [Commented] (HADOOP-7982) UserGroupInformation fails to login if thread's context classloader can't load HadoopLoginModule

2012-01-19 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189493#comment-13189493 ] Eli Collins commented on HADOOP-7982: - +1 to the trunk patch. javadoc warnings are

[jira] [Commented] (HADOOP-7982) UserGroupInformation fails to login if thread's context classloader can't load HadoopLoginModule

2012-01-18 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188947#comment-13188947 ] Eli Collins commented on HADOOP-7982: - +1 to the branch-1 patch

[jira] [Commented] (HADOOP-7956) Remove duplicate definition of default config values

2012-01-15 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186446#comment-13186446 ] Eli Collins commented on HADOOP-7956: - I like #2 as well. We can verify that the

[jira] [Commented] (HADOOP-7974) TestViewFsTrash incorrectly determines the user's home directory

2012-01-15 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186447#comment-13186447 ] Eli Collins commented on HADOOP-7974: - +1 javadoc failures are unrelated

[jira] [Commented] (HADOOP-7975) Add entry to XML defaults for new LZ4 codec

2012-01-14 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186306#comment-13186306 ] Eli Collins commented on HADOOP-7975: - +1 Add entry to XML defaults

[jira] [Commented] (HADOOP-7920) Remove Avro RPC

2012-01-12 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185425#comment-13185425 ] Eli Collins commented on HADOOP-7920: - What branch? I don't see this on trunk or 23.

[jira] [Commented] (HADOOP-7970) All HAServiceProtocol methods have to throw IOException since they are invoked over the network

2012-01-11 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184479#comment-13184479 ] Eli Collins commented on HADOOP-7970: - +1, this would make some of the code in the

[jira] [Commented] (HADOOP-7966) Add back in the older -getmerge addnl param and add a test case for the new -nl param.

2012-01-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182699#comment-13182699 ] Eli Collins commented on HADOOP-7966: - Why is it OK to break existing Hadoop scripts?

[jira] [Commented] (HADOOP-7966) Add back in the older -getmerge addnl param and add a test case for the new -nl param.

2012-01-09 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182717#comment-13182717 ] Eli Collins commented on HADOOP-7966: - What incompatibilities did the FsShell

[jira] [Commented] (HADOOP-7348) Modify the option of FsShell getmerge from [addnl] to [-nl] for more comprehensive

2012-01-08 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182333#comment-13182333 ] Eli Collins commented on HADOOP-7348: - This breaks a public API, why not preserve it

[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs and friends from Hadoop 1.x

2012-01-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181471#comment-13181471 ] Eli Collins commented on HADOOP-7937: - bq. I see what you mean about reducing the

[jira] [Commented] (HADOOP-7961) HA: fencing mechanism

2012-01-06 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181722#comment-13181722 ] Eli Collins commented on HADOOP-7961: - Thanks Todd, I've committed this.

[jira] [Commented] (HADOOP-7956) Remove duplicate definition of default config values

2012-01-05 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13180692#comment-13180692 ] Eli Collins commented on HADOOP-7956: - How about: #1 Generating the default.xml files

[jira] [Commented] (HADOOP-7924) 
FailoverController for client-based configuration

2012-01-05 Thread Eli Collins (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13180845#comment-13180845 ] Eli Collins commented on HADOOP-7924: - And filed HADOOP-7958 to require both services

  1   2   >