[jira] [Commented] (HADOOP-8148) Zero-copy ByteBuffer-based compressor / decompressor API

2012-04-19 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257987#comment-13257987 ] Todd Lipcon commented on HADOOP-8148: - Duplicating my comment from HADOOP-8258:

[jira] [Commented] (HADOOP-8247) Auto-HA: add a config to enable auto-HA, which disables manual FC

2012-04-13 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253885#comment-13253885 ] Todd Lipcon commented on HADOOP-8247: - bq. The problem of this jira is that it makes

[jira] [Commented] (HADOOP-8279) Auto-HA: Allow manual failover to be invoked from zkfc.

2012-04-13 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253887#comment-13253887 ] Todd Lipcon commented on HADOOP-8279: - Thanks for filing this, Mingjie. I plan to

[jira] [Commented] (HADOOP-8271) PowerPc Build error.

2012-04-12 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252603#comment-13252603 ] Todd Lipcon commented on HADOOP-8271: - Patch looks good. Can you please make a patch

[jira] [Commented] (HADOOP-8198) Support multiple network interfaces

2012-04-11 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251892#comment-13251892 ] Todd Lipcon commented on HADOOP-8198: - I agree with the above comments that tokens

[jira] [Commented] (HADOOP-8198) Support multiple network interfaces

2012-04-11 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251926#comment-13251926 ] Todd Lipcon commented on HADOOP-8198: - bq. Are we going to confine yarn/MR services

[jira] [Commented] (HADOOP-8269) Fix some javadoc warnings on branch-1

2012-04-11 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251990#comment-13251990 ] Todd Lipcon commented on HADOOP-8269: - +1 Fix some javadoc warnings

[jira] [Commented] (HADOOP-8262) Between mapper and reducer, Hadoop inserts spaces into my string

2012-04-09 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249942#comment-13249942 ] Todd Lipcon commented on HADOOP-8262: -

[jira] [Commented] (HADOOP-8152) Expand public APIs for security library classes

2012-04-09 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250163#comment-13250163 ] Todd Lipcon commented on HADOOP-8152: - I generally agree that the static loginUser

[jira] [Commented] (HADOOP-8248) Clarify bylaws about review-then-commit policy

2012-04-09 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250176#comment-13250176 ] Todd Lipcon commented on HADOOP-8248: - bq. For a join work of multiple committers,

[jira] [Commented] (HADOOP-8248) Clarify bylaws about review-then-commit policy

2012-04-09 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250179#comment-13250179 ] Todd Lipcon commented on HADOOP-8248: - To add a little more: I think the requirement

[jira] [Commented] (HADOOP-8247) Auto-HA: add a config to enable auto-HA, which disables manual FC

2012-04-09 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250271#comment-13250271 ] Todd Lipcon commented on HADOOP-8247: - Hi Hari. That's specifically the point of the

[jira] [Commented] (HADOOP-8247) Auto-HA: add a config to enable auto-HA, which disables manual FC

2012-04-09 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250272#comment-13250272 ] Todd Lipcon commented on HADOOP-8247: - P.S. if you'd like I'd be happy to rename it

[jira] [Commented] (HADOOP-8248) Clarify bylaws about review-then-commit policy

2012-04-09 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250291#comment-13250291 ] Todd Lipcon commented on HADOOP-8248: - bq. Which above policy? Branches can use RTC,

[jira] [Commented] (HADOOP-8247) Auto-HA: add a config to enable auto-HA, which disables manual FC

2012-04-09 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250294#comment-13250294 ] Todd Lipcon commented on HADOOP-8247: - I also ran the manual tests again. Here's the

[jira] [Commented] (HADOOP-8247) Auto-HA: add a config to enable auto-HA, which disables manual FC

2012-04-09 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250307#comment-13250307 ] Todd Lipcon commented on HADOOP-8247: - bq. There are always admins who disregard

[jira] [Commented] (HADOOP-8152) Expand public APIs for security library classes

2012-04-08 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249662#comment-13249662 ] Todd Lipcon commented on HADOOP-8152: - Looking at HBase, it seems like it's also

[jira] [Commented] (HADOOP-8261) Har file system doesn't deal with FS URIs with a host but no port

2012-04-08 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249663#comment-13249663 ] Todd Lipcon commented on HADOOP-8261: - Nit: spurious 'a' here at the end of the

[jira] [Commented] (HADOOP-8247) Auto-HA: add a config to enable auto-HA, which disables manual FC

2012-04-06 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248746#comment-13248746 ] Todd Lipcon commented on HADOOP-8247: - I added a struct because I figured we may want

[jira] [Commented] (HADOOP-8247) Auto-HA: add a config to enable auto-HA, which disables manual FC

2012-04-06 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248918#comment-13248918 ] Todd Lipcon commented on HADOOP-8247: - Hi Hari. JIRA doesn't support cross-project

[jira] [Commented] (HADOOP-8257) Auto-HA: TestZKFailoverControllerStress occasionally fails with Mockito error

2012-04-06 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248928#comment-13248928 ] Todd Lipcon commented on HADOOP-8257: - Jenkins won't run on this since it's on a

[jira] [Commented] (HADOOP-8258) Add interfaces for compression codecs to use direct byte buffers

2012-04-06 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249035#comment-13249035 ] Todd Lipcon commented on HADOOP-8258: - In current versions of Hadoop, the read path

[jira] [Commented] (HADOOP-8258) Add interfaces for compression codecs to use direct byte buffers

2012-04-06 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249086#comment-13249086 ] Todd Lipcon commented on HADOOP-8258: - Ah, thanks, sorry I missed that. Do you think

[jira] [Commented] (HADOOP-8247) Auto-HA: add a config to enable auto-HA, which disables manual FC

2012-04-06 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249097#comment-13249097 ] Todd Lipcon commented on HADOOP-8247: - bq. Can we make this simpler by not supporting

[jira] [Commented] (HADOOP-8086) KerberosName silently sets defaultRealm to if the Kerberos config is not found, it should log a WARN

2012-04-05 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247410#comment-13247410 ] Todd Lipcon commented on HADOOP-8086: - This patch seems to use slf4j, whereas we use

[jira] [Commented] (HADOOP-8086) KerberosName silently sets defaultRealm to if the Kerberos config is not found, it should log a WARN

2012-04-05 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247488#comment-13247488 ] Todd Lipcon commented on HADOOP-8086: - OK. I will pretend that that makes sense, and

[jira] [Commented] (HADOOP-6941) Support non-SUN JREs in UserGroupInformation

2012-04-05 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248011#comment-13248011 ] Todd Lipcon commented on HADOOP-6941: - Looks like this patch broke the original

[jira] [Commented] (HADOOP-8251) SecurityUtil.fetchServiceTicket broken after HADOOP-6941

2012-04-05 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248012#comment-13248012 ] Todd Lipcon commented on HADOOP-8251: - The bug was simple -- the string used for the

[jira] [Commented] (HADOOP-8247) Auto-HA: add a config to enable auto-HA, which disables manual FC

2012-04-05 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248019#comment-13248019 ] Todd Lipcon commented on HADOOP-8247: - I should of course note that this is only the

[jira] [Commented] (HADOOP-7211) Security uses proprietary Sun APIs

2012-04-05 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248032#comment-13248032 ] Todd Lipcon commented on HADOOP-7211: - HADOOP-6941 fixed compilation on the IBM JDK

[jira] [Commented] (HADOOP-8251) SecurityUtil.fetchServiceTicket broken after HADOOP-6941

2012-04-05 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248054#comment-13248054 ] Todd Lipcon commented on HADOOP-8251: - Hey Devaraj. Sorry, I already committed this,

[jira] [Commented] (HADOOP-8251) SecurityUtil.fetchServiceTicket broken after HADOOP-6941

2012-04-05 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248078#comment-13248078 ] Todd Lipcon commented on HADOOP-8251: - bq. Please have at least one simple test that

[jira] [Commented] (HADOOP-7211) Security uses proprietary Sun APIs

2012-04-05 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248081#comment-13248081 ] Todd Lipcon commented on HADOOP-7211: - bq. This jira is incorporated by the patches

[jira] [Commented] (HADOOP-7211) Security uses proprietary Sun APIs

2012-04-05 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248084#comment-13248084 ] Todd Lipcon commented on HADOOP-7211: - I don't think this JIRA should be marked as

[jira] [Commented] (HADOOP-8007) HA: use substitution token for fencing argument

2012-04-04 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246113#comment-13246113 ] Todd Lipcon commented on HADOOP-8007: - bq.

[jira] [Commented] (HADOOP-8215) Security support for ZK Failover controller

2012-04-03 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245892#comment-13245892 ] Todd Lipcon commented on HADOOP-8215: - I'll commit this momentarily to the branch

[jira] [Commented] (HADOOP-8245) Fix flakiness in TestZKFailoverController

2012-04-03 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245991#comment-13245991 ] Todd Lipcon commented on HADOOP-8245: - For problem #1, the solution is the same as is

[jira] [Commented] (HADOOP-8210) Common side of HDFS-3148

2012-04-02 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244403#comment-13244403 ] Todd Lipcon commented on HADOOP-8210: - +1 Common side of HDFS-3148

[jira] [Commented] (HADOOP-8243) Security support broken in CLI (manual) failover controller

2012-04-02 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244625#comment-13244625 ] Todd Lipcon commented on HADOOP-8243: - I should note I also ran TestDFSHAAdmin and

[jira] [Commented] (HADOOP-8215) Security support for ZK Failover controller

2012-04-02 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244654#comment-13244654 ] Todd Lipcon commented on HADOOP-8215: - I'm starting to work on this. Here's the plan:

[jira] [Commented] (HADOOP-8215) Security support for ZK Failover controller

2012-04-02 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244875#comment-13244875 ] Todd Lipcon commented on HADOOP-8215: - Because coverage of security is hard to

[jira] [Commented] (HADOOP-8211) Update commons-net version to 3.1

2012-03-31 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243587#comment-13243587 ] Todd Lipcon commented on HADOOP-8211: - +1, assuming you've done a full build locally

[jira] [Commented] (HADOOP-8210) Common side of HDFS-3148

2012-03-31 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243597#comment-13243597 ] Todd Lipcon commented on HADOOP-8210: - {code} +LinkedHashSetInetAddress addrs =

[jira] [Commented] (HADOOP-8220) ZKFailoverController doesn't handle failure to become active correctly

2012-03-30 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242664#comment-13242664 ] Todd Lipcon commented on HADOOP-8220: - bq. Any reason we shouldn't make

[jira] [Commented] (HADOOP-8228) Auto HA: Refactor tests and add stress tests

2012-03-30 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242677#comment-13242677 ] Todd Lipcon commented on HADOOP-8228: - bq. One question: are you positive that the

[jira] [Commented] (HADOOP-8217) Edge case split-brain race in ZK-based auto-failover

2012-03-30 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242855#comment-13242855 ] Todd Lipcon commented on HADOOP-8217: - bq. 3. ZKFC2 tries to do transitionToStandby()

[jira] [Commented] (HADOOP-8217) Edge case split-brain race in ZK-based auto-failover

2012-03-30 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242880#comment-13242880 ] Todd Lipcon commented on HADOOP-8217: - bq. Can you please point me to the existing HA

[jira] [Commented] (HADOOP-8202) stopproxy() is not closing the proxies correctly

2012-03-30 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242895#comment-13242895 ] Todd Lipcon commented on HADOOP-8202: - This patch also introduced the following bug:

[jira] [Commented] (HADOOP-8217) Edge case split-brain race in ZK-based auto-failover

2012-03-30 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242944#comment-13242944 ] Todd Lipcon commented on HADOOP-8217: - bq. I would like to question the value of FC2

[jira] [Commented] (HADOOP-8212) Improve ActiveStandbyElector's behavior when session expires

2012-03-29 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241832#comment-13241832 ] Todd Lipcon commented on HADOOP-8212: - Thanks for reviewing the addendum, and for

[jira] [Commented] (HADOOP-8220) ZKFailoverController doesn't handle failure to become active correctly

2012-03-29 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241935#comment-13241935 ] Todd Lipcon commented on HADOOP-8220: - Actually moving the error handling code to the

[jira] [Commented] (HADOOP-8217) Edge case split-brain race in ZK-based auto-failover

2012-03-28 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240237#comment-13240237 ] Todd Lipcon commented on HADOOP-8217: - Suresh: we've already had a meeting ostensibly

[jira] [Commented] (HADOOP-8220) ZKFailoverController doesn't handle failure to become active correctly

2012-03-28 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240776#comment-13240776 ] Todd Lipcon commented on HADOOP-8220: - Yep, your updated description of the tight

[jira] [Commented] (HADOOP-8212) Improve ActiveStandbyElector's behavior when session expires

2012-03-27 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239631#comment-13239631 ] Todd Lipcon commented on HADOOP-8212: - bq. I think we want to added similar handling

[jira] [Commented] (HADOOP-8220) ZKFailoverController doesn't handle failure to become active correctly

2012-03-27 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239641#comment-13239641 ] Todd Lipcon commented on HADOOP-8220: - I'll add a new test to the

[jira] [Commented] (HADOOP-8218) RPC.closeProxy shouldn't throw error when closing a mock

2012-03-27 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239685#comment-13239685 ] Todd Lipcon commented on HADOOP-8218: - I'm fine with that, too. Suresh/Tom? Pick your

[jira] [Commented] (HADOOP-8220) ZKFailoverController doesn't handle failure to become active correctly

2012-03-27 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239957#comment-13239957 ] Todd Lipcon commented on HADOOP-8220: - bq. Ah. Now I get it. The elector should be

[jira] [Commented] (HADOOP-8218) RPC.closeProxy shouldn't throw error when closing a mock

2012-03-27 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240162#comment-13240162 ] Todd Lipcon commented on HADOOP-8218: - Since the patch is up, and people seem OK with

[jira] [Commented] (HADOOP-8202) stopproxy() is not closing the proxies correctly

2012-03-26 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238125#comment-13238125 ] Todd Lipcon commented on HADOOP-8202: - Instead of adding the instanceof check

[jira] [Commented] (HADOOP-8202) stopproxy() is not closing the proxies correctly

2012-03-26 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238597#comment-13238597 ] Todd Lipcon commented on HADOOP-8202: - Sure, go ahead and commit. Thanks.

[jira] [Commented] (HADOOP-8131) FsShell put doesn't correctly handle a non-existent dir

2012-03-26 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238646#comment-13238646 ] Todd Lipcon commented on HADOOP-8131: - If it's not too huge a pain, I'd be in favor

[jira] [Commented] (HADOOP-8131) FsShell put doesn't correctly handle a non-existent dir

2012-03-26 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238677#comment-13238677 ] Todd Lipcon commented on HADOOP-8131: - bq. Just to confirm: you mean a real conf key,

[jira] [Commented] (HADOOP-8212) Improve ActiveStandbyElector's behavior when session expires

2012-03-26 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238748#comment-13238748 ] Todd Lipcon commented on HADOOP-8212: - Sure, happy to address post-commit. Sorry for

[jira] [Commented] (HADOOP-8217) Edge case split-brain race in ZK-based auto-failover

2012-03-26 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238915#comment-13238915 ] Todd Lipcon commented on HADOOP-8217: - My thinking for the solution is the following:

[jira] [Commented] (HADOOP-8206) Common portion of ZK-based failover controller

2012-03-26 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238982#comment-13238982 ] Todd Lipcon commented on HADOOP-8206: - bq. Makes sense to me. One question, though -

[jira] [Commented] (HADOOP-8202) stopproxy() is not closing the proxies correctly

2012-03-26 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239120#comment-13239120 ] Todd Lipcon commented on HADOOP-8202: - This broke TestZKFailoverController, since

[jira] [Commented] (HADOOP-8218) RPC.closeProxy shouldn't throw error when closing a mock

2012-03-26 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239121#comment-13239121 ] Todd Lipcon commented on HADOOP-8218: - I see three options: 1) Anywhere we call

[jira] [Commented] (HADOOP-8218) RPC.closeProxy shouldn't throw error when closing a mock

2012-03-26 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239171#comment-13239171 ] Todd Lipcon commented on HADOOP-8218: - bq. Todd, can the mock object implement a new

[jira] [Commented] (HADOOP-8220) ZKFailoverController doesn't handle failure to become active correctly

2012-03-26 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239184#comment-13239184 ] Todd Lipcon commented on HADOOP-8220: - Tests failing due to HADOOP-8218

[jira] [Commented] (HADOOP-8207) createproxy() in TestHealthMonitor is throwing NPE

2012-03-25 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237788#comment-13237788 ] Todd Lipcon commented on HADOOP-8207: - I think this is dup of HADOOP-8204

[jira] [Commented] (HADOOP-8208) Disallow self failover

2012-03-25 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237979#comment-13237979 ] Todd Lipcon commented on HADOOP-8208: - Looks good. I just reverted HADOOP-8193 since

[jira] [Commented] (HADOOP-8202) stopproxy() is not closing the proxies correctly

2012-03-24 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237720#comment-13237720 ] Todd Lipcon commented on HADOOP-8202: - I think maintaining the ability to support

[jira] [Commented] (HADOOP-8163) Improve ActiveStandbyElector to provide hooks for fencing old active

2012-03-23 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236934#comment-13236934 ] Todd Lipcon commented on HADOOP-8163: - Hi Bikas. I think your ideas have some merit,

[jira] [Commented] (HADOOP-8060) Add a capability to use of consistent checksums for append and copy

2012-03-23 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236965#comment-13236965 ] Todd Lipcon commented on HADOOP-8060: - Doing shallow conf comparison as part of the

[jira] [Commented] (HADOOP-8163) Improve ActiveStandbyElector to provide hooks for fencing old active

2012-03-23 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236970#comment-13236970 ] Todd Lipcon commented on HADOOP-8163: - bq. In my experience API's once made are hard

[jira] [Commented] (HADOOP-8193) Refactor FailoverController/HAAdmin code to add an abstract class for target services

2012-03-23 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236984#comment-13236984 ] Todd Lipcon commented on HADOOP-8193: - Also ran findbugs on common and HDFS, there

[jira] [Commented] (HADOOP-8163) Improve ActiveStandbyElector to provide hooks for fencing old active

2012-03-22 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235937#comment-13235937 ] Todd Lipcon commented on HADOOP-8163: - Hi Bikas. To be clear, I did not remove any of

[jira] [Commented] (HADOOP-8060) Add a capability to use of consistent checksums for append and copy

2012-03-22 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235984#comment-13235984 ] Todd Lipcon commented on HADOOP-8060: - Hi Kihwal. What about making the checksum type

[jira] [Commented] (HADOOP-8163) Improve ActiveStandbyElector to provide hooks for fencing old active

2012-03-22 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236116#comment-13236116 ] Todd Lipcon commented on HADOOP-8163: - bq. Am I missing something, or are

[jira] [Commented] (HADOOP-8163) Improve ActiveStandbyElector to provide hooks for fencing old active

2012-03-22 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236213#comment-13236213 ] Todd Lipcon commented on HADOOP-8163: - ilePath. zkMostRecentFilePath is open to being

[jira] [Commented] (HADOOP-8163) Improve ActiveStandbyElector to provide hooks for fencing old active

2012-03-22 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236276#comment-13236276 ] Todd Lipcon commented on HADOOP-8163: - bq. So paranoid admin deletes the lock hoping

[jira] [Commented] (HADOOP-8157) TestRPCCallBenchmark#testBenchmarkWithWritable fails with RTE

2012-03-21 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235019#comment-13235019 ] Todd Lipcon commented on HADOOP-8157: - I think I understand this bug. It's probably

[jira] [Commented] (HADOOP-8163) Improve ActiveStandbyElector to provide hooks for fencing old active

2012-03-20 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233638#comment-13233638 ] Todd Lipcon commented on HADOOP-8163: - Hi Hari. I like your ideas about using this

[jira] [Commented] (HADOOP-8183) Stop using mapred.used.genericoptionsparser to avoid unnecessary warnings

2012-03-19 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232777#comment-13232777 ] Todd Lipcon commented on HADOOP-8183: - +1 Stop using

[jira] [Commented] (HADOOP-8151) Error handling in snappy decompressor throws invalid exceptions

2012-03-18 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232225#comment-13232225 ] Todd Lipcon commented on HADOOP-8151: - +1, patch looks good to me. Please upload a

[jira] [Commented] (HADOOP-8163) Improve ActiveStandbyElector to provide hooks for fencing old active

2012-03-14 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229589#comment-13229589 ] Todd Lipcon commented on HADOOP-8163: - bq. The question I had was how is the info

[jira] [Commented] (HADOOP-8163) Improve ActiveStandbyElector to provide hooks for fencing old active

2012-03-12 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228043#comment-13228043 ] Todd Lipcon commented on HADOOP-8163: - The design here is pretty simple: *In ZK*: -

[jira] [Commented] (HADOOP-7788) HA: Simple HealthMonitor class to watch an HAService

2012-03-12 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228100#comment-13228100 ] Todd Lipcon commented on HADOOP-7788: - Oh, sorry, I also left in the main() method.

[jira] [Commented] (HADOOP-8154) DNS#getIPs shouldn't silently return the local host IP for bogus interface names

2012-03-08 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225587#comment-13225587 ] Todd Lipcon commented on HADOOP-8154: - Under what circumstances would the following

[jira] [Commented] (HADOOP-7806) [DNS] Support binding to sub-interfaces

2012-03-08 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225768#comment-13225768 ] Todd Lipcon commented on HADOOP-7806: - +1 pending results on new patch

[jira] [Commented] (HADOOP-8157) TestRPCCallBenchmark#testBenchmarkWithWritable fails with RTE

2012-03-08 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225873#comment-13225873 ] Todd Lipcon commented on HADOOP-8157: - This failure is super-goofy. My hunch is it's

[jira] [Commented] (HADOOP-8151) Error handling in snappy decompressor throws invalid exceptions

2012-03-07 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224848#comment-13224848 ] Todd Lipcon commented on HADOOP-8151: - This bug seems to occur in lz4 as well. It

[jira] [Commented] (HADOOP-8153) Fail to submit mapred job on a secured-HA-HDFS: logic URI cannot be picked up by job submission.

2012-03-07 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224908#comment-13224908 ] Todd Lipcon commented on HADOOP-8153: - Looks like we need to override

[jira] [Commented] (HADOOP-8135) Add ByteBufferReadable interface to FSDataInputStream

2012-03-02 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221334#comment-13221334 ] Todd Lipcon commented on HADOOP-8135: - {code} + * @return - the number of bytes

[jira] [Commented] (HADOOP-8104) Inconsistent Jackson versions

2012-02-22 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214192#comment-13214192 ] Todd Lipcon commented on HADOOP-8104: - Will this now break HBase or other projects

[jira] [Commented] (HADOOP-8097) TestRPCCallBenchmark failing w/ port in use -handling badly

2012-02-21 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212751#comment-13212751 ] Todd Lipcon commented on HADOOP-8097: - I'm not sure this is the best fix (relying on

[jira] [Commented] (HADOOP-8093) HadoopRpcRequestProto should not be serialize twice

2012-02-20 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212307#comment-13212307 ] Todd Lipcon commented on HADOOP-8093: - This seems like a dup of HADOOP-8084, but the

[jira] [Commented] (HADOOP-8066) The full docs build intermittently fails

2012-02-15 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208684#comment-13208684 ] Todd Lipcon commented on HADOOP-8066: - This is a regression, right? Any chance we

[jira] [Commented] (HADOOP-8069) Enable TCP_NODELAY by default for IPC

2012-02-15 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209012#comment-13209012 ] Todd Lipcon commented on HADOOP-8069: - Hi Daryn. Your above descriptions sound right,

[jira] [Commented] (HADOOP-8069) Enable TCP_NODELAY by default for IPC

2012-02-15 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209150#comment-13209150 ] Todd Lipcon commented on HADOOP-8069: - My hunch is that it's pretty small. I think

  1   2   >