amahussein commented on pull request #2581:
URL: https://github.com/apache/hadoop/pull/2581#issuecomment-757950935
> Thanks for the update, @amahussein. +1.
Thanks for the review @iwasakims and @goiri
This is an
amahussein commented on pull request #2581:
URL: https://github.com/apache/hadoop/pull/2581#issuecomment-756533357
I did an experiment on the original `TestDistributedShell`
if you run
```bash
mvn test -Dtest=TestDistributedShell#testDSShellWithoutDomainV1_5;
mvn test
amahussein commented on pull request #2581:
URL: https://github.com/apache/hadoop/pull/2581#issuecomment-756531850
@iwasakims and @goiri Do you have insights what could the problem be ?
When you run TestDSTimelineV10 -> then TestDSTimelineV20. things will be
successful.
Only
amahussein commented on pull request #2581:
URL: https://github.com/apache/hadoop/pull/2581#issuecomment-756530407
> The latest commit seemed to introduce errors.
>
> ```
> $ mvn test -Dtest='TestDS*'
> ...
> [ERROR] Errors:
> [ERROR]
amahussein commented on pull request #2581:
URL: https://github.com/apache/hadoop/pull/2581#issuecomment-756136730
> Thank for working on this, @amahussein. LGTM overall pending some nits.
>
> While it is too late here, it is hard to follow which part of the
TestDistributedShell is
amahussein commented on pull request #2581:
URL: https://github.com/apache/hadoop/pull/2581#issuecomment-756134654
> > * The implementation has lots of code redundancy.
> > * It is inefficient in the setup and tearing down. The large percentage
of time execution is exhausted by starting
amahussein commented on pull request #2581:
URL: https://github.com/apache/hadoop/pull/2581#issuecomment-756132738
> Thank for working on this, @amahussein. LGTM overall pending some nits.
>
> While it is too late here, it is hard to follow which part of the
TestDistributedShell is
amahussein commented on pull request #2581:
URL: https://github.com/apache/hadoop/pull/2581#issuecomment-755797255
> > @goiri the code changes fix {{testDSShellWithEnforceExecutionType}}.
> > The problem with the test was that it launches two containers executing
cmd `date`. Apparently
amahussein commented on pull request #2581:
URL: https://github.com/apache/hadoop/pull/2581#issuecomment-755767916
CC: @iwasakims . This includes a fix to `testDSShellWithEnforceExecutionType`
This is an automated message
amahussein commented on pull request #2581:
URL: https://github.com/apache/hadoop/pull/2581#issuecomment-755765315
@goiri the code changes fix {{testDSShellWithOpportunisticContainers}}.
The problem with the test was that it launches two containers executing cmd
`date`. Apparently the
10 matches
Mail list logo
