[GitHub] [hadoop] bshashikant commented on a change in pull request #2165: HDFS-15481. Ordered snapshot deletion: garbage collect deleted snapshots

2020-07-30 Thread GitBox
bshashikant commented on a change in pull request #2165: URL: https://github.com/apache/hadoop/pull/2165#discussion_r462750158 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java ## @@ -7166,6 +7178,30 @@ void

[GitHub] [hadoop] bshashikant commented on a change in pull request #2165: HDFS-15481. Ordered snapshot deletion: garbage collect deleted snapshots

2020-07-29 Thread GitBox
bshashikant commented on a change in pull request #2165: URL: https://github.com/apache/hadoop/pull/2165#discussion_r461996564 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java ## @@ -382,6 +395,14

[GitHub] [hadoop] bshashikant commented on a change in pull request #2165: HDFS-15481. Ordered snapshot deletion: garbage collect deleted snapshots

2020-07-27 Thread GitBox
bshashikant commented on a change in pull request #2165: URL: https://github.com/apache/hadoop/pull/2165#discussion_r460737232 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java ## @@ -1284,6 +1288,7 @@ void