[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852353#comment-16852353
]
Hudson commented on HADOOP-13656:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16636 (See
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852325#comment-16852325
]
Shweta commented on HADOOP-13656:
-
[~jojochuang], thank you for the commit .
> fs -expunge to take a
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852154#comment-16852154
]
Wei-Chiu Chuang commented on HADOOP-13656:
--
Committing this now, will take care of the
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846219#comment-16846219
]
Hadoop QA commented on HADOOP-13656:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846049#comment-16846049
]
Shweta commented on HADOOP-13656:
-
[~liuml07] Good catch. Uploaded patchv008 to add the space as
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845570#comment-16845570
]
Hadoop QA commented on HADOOP-13656:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845417#comment-16845417
]
Mingliang Liu commented on HADOOP-13656:
{{226 "[-immediate] [-" + OPTION_FILESYSTEM + "]";}}
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845398#comment-16845398
]
Shweta commented on HADOOP-13656:
-
Thank you [~ste...@apache.org] for the review.
I have fixed the
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843855#comment-16843855
]
Steve Loughran commented on HADOOP-13656:
-
Tests LGTM; the HDFS test failures are clearly
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842633#comment-16842633
]
Hadoop QA commented on HADOOP-13656:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842369#comment-16842369
]
Shweta commented on HADOOP-13656:
-
Thank you [~ste...@apache.org] for your review.
I have posted a
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833810#comment-16833810
]
Steve Loughran commented on HADOOP-13656:
-
h2. Production code
LGTM
h2. docs
bq. If the
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832798#comment-16832798
]
Shweta commented on HADOOP-13656:
-
Will upload patch for checkstyle, whitespace and unit tests fixes in
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832144#comment-16832144
]
Hadoop QA commented on HADOOP-13656:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832007#comment-16832007
]
Shweta commented on HADOOP-13656:
-
As per suggestions in the previous comments, I have added two more
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795032#comment-16795032
]
Adam Antal commented on HADOOP-13656:
-
Thanks for the patch [~shwetayakkali].
I agree with what
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793948#comment-16793948
]
Siyao Meng commented on HADOOP-13656:
-
[~liuml07] Thanks for the comment.
[~shwetayakkali]
1.
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793951#comment-16793951
]
Hadoop QA commented on HADOOP-13656:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793909#comment-16793909
]
Mingliang Liu commented on HADOOP-13656:
Committer can use {{git apply --whitespace=fix <>}}
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793897#comment-16793897
]
Siyao Meng commented on HADOOP-13656:
-
[~shwetayakkali]
3. There's an extra whitespace after line
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793893#comment-16793893
]
Shweta commented on HADOOP-13656:
-
Thanks [~smeng] for the review.
1. The new command "-fs" takes a
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793153#comment-16793153
]
Siyao Meng commented on HADOOP-13656:
-
Thanks for the patch. Some suggestions:
1. Line 238: I
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792234#comment-16792234
]
Hadoop QA commented on HADOOP-13656:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792187#comment-16792187
]
Shweta commented on HADOOP-13656:
-
Uploaded patch v003 to fix review and checkstyle. The patch still
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791274#comment-16791274
]
Hadoop QA commented on HADOOP-13656:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790939#comment-16790939
]
Shweta commented on HADOOP-13656:
-
Thank you [~jojochuang] for the review. Uploaded patch 002 to
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789287#comment-16789287
]
Adam Antal commented on HADOOP-13656:
-
Looks like {{-expunge}} gets improved recently a lot, but
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788794#comment-16788794
]
Daniel Templeton commented on HADOOP-13656:
---
I would also add that the test isn't actually
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788554#comment-16788554
]
Wei-Chiu Chuang commented on HADOOP-13656:
--
Thanks for the patch [~shwetayakkali]
{code}
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781975#comment-16781975
]
Shweta commented on HADOOP-13656:
-
Yes [~sodonnell], I am working on this issue but got stalled due to
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781859#comment-16781859
]
Stephen O'Donnell commented on HADOOP-13656:
[~shwetayakkali] Are you planning to work on
[
https://issues.apache.org/jira/browse/HADOOP-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558705#comment-16558705
]
Steve Loughran commented on HADOOP-13656:
-
Moved this to 3.3. Watchers: you clearly need this
32 matches
Mail list logo
