[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451036#comment-16451036
]
Hudson commented on HADOOP-14768:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187990#comment-16187990
]
Steve Loughran commented on HADOOP-14768:
-
yes, though I think there's been some toe-stamping
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185930#comment-16185930
]
Hadoop QA commented on HADOOP-14768:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185887#comment-16185887
]
Steve Loughran commented on HADOOP-14768:
-
{code}
[ERROR]
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185848#comment-16185848
]
Hadoop QA commented on HADOOP-14768:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185753#comment-16185753
]
Steve Loughran commented on HADOOP-14768:
-
just noticed that MockWasbAuthorizerImpl.java changes
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184689#comment-16184689
]
Hudson commented on HADOOP-14768:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12990 (See
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184655#comment-16184655
]
Steve Loughran commented on HADOOP-14768:
-
+1
committed to trunk.
Leaving open so you can do a
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184312#comment-16184312
]
Hadoop QA commented on HADOOP-14768:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184226#comment-16184226
]
Varada Hemeswari commented on HADOOP-14768:
---
Thanks [~ste...@apache.org] for the review.
I
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184223#comment-16184223
]
Hadoop QA commented on HADOOP-14768:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182523#comment-16182523
]
Steve Loughran commented on HADOOP-14768:
-
overall, code looks good. I'm relying on Thomas to
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182360#comment-16182360
]
Varada Hemeswari commented on HADOOP-14768:
---
I ran all the tests against azure storage account
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182352#comment-16182352
]
Steve Loughran commented on HADOOP-14768:
-
which Azure endpoint did you run *all* the
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180157#comment-16180157
]
Varada Hemeswari commented on HADOOP-14768:
---
Thanks [~tmarquardt] for the review.
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179886#comment-16179886
]
Thomas Marquardt commented on HADOOP-14768:
---
+1, thanks for removing the risk from the change.
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178954#comment-16178954
]
Hadoop QA commented on HADOOP-14768:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176913#comment-16176913
]
Thomas Marquardt commented on HADOOP-14768:
---
I had two goals: 1) reduce risk and 2) allow you
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176862#comment-16176862
]
Varada Hemeswari commented on HADOOP-14768:
---
[~tmarquardt] The code when auth is not enabled
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176798#comment-16176798
]
Thomas Marquardt commented on HADOOP-14768:
---
I opened HADOOP-14768.005.patch and still see
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176725#comment-16176725
]
Varada Hemeswari commented on HADOOP-14768:
---
[~ste...@apache.org]Intrestingly it doesnt fail
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176689#comment-16176689
]
Steve Loughran commented on HADOOP-14768:
-
bq. the test failure
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176491#comment-16176491
]
Varada Hemeswari commented on HADOOP-14768:
---
[~tmarquardt], i have submitted
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176260#comment-16176260
]
Hadoop QA commented on HADOOP-14768:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176235#comment-16176235
]
Hadoop QA commented on HADOOP-14768:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175178#comment-16175178
]
Thomas Marquardt commented on HADOOP-14768:
---
Yes, lets make it so if "fs.azure.authorization"
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175142#comment-16175142
]
Varada Hemeswari commented on HADOOP-14768:
---
[~tmarq], I agree to the risk of performance and
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175083#comment-16175083
]
Thomas Marquardt commented on HADOOP-14768:
---
I think the risk of regression is medium, on a
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174321#comment-16174321
]
Varada Hemeswari commented on HADOOP-14768:
---
Thanks [~ste...@apache.org].
[~tmarquardt],
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173206#comment-16173206
]
Hadoop QA commented on HADOOP-14768:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173143#comment-16173143
]
Steve Loughran commented on HADOOP-14768:
-
To submit a patch you need to
# add a new file: the
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172839#comment-16172839
]
Varada Hemeswari commented on HADOOP-14768:
---
Thanks [~tmarquardt] for the review comments.
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172143#comment-16172143
]
Thomas Marquardt commented on HADOOP-14768:
---
Looks good overall, but does not fully implement
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170064#comment-16170064
]
Hadoop QA commented on HADOOP-14768:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168255#comment-16168255
]
Hadoop QA commented on HADOOP-14768:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168252#comment-16168252
]
Steve Loughran commented on HADOOP-14768:
-
see testing_hadoop.md for the process for running
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167901#comment-16167901
]
Hadoop QA commented on HADOOP-14768:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167444#comment-16167444
]
Varada Hemeswari commented on HADOOP-14768:
---
All the tests have passed in hadoop-azure in both
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167341#comment-16167341
]
Hadoop QA commented on HADOOP-14768:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167285#comment-16167285
]
Hadoop QA commented on HADOOP-14768:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166525#comment-16166525
]
Steve Loughran commented on HADOOP-14768:
-
#. Press the submit button for the precommit checks
#
[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146593#comment-16146593
]
Varada Hemeswari commented on HADOOP-14768:
---
[~ste...@apache.org], Can you please review the
42 matches
Mail list logo
