ayushtkn commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1819576205
Failed test passes locally
```
[INFO] ---
[INFO] T E S T S
[INFO] ---
ayushtkn merged PR #6231:
URL: https://github.com/apache/hadoop/pull/6231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1817828183
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
pjfanning commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1817543679
The list of 11 checkstyle issues are largely pre-existing issues With the
indentation issues, the highlighted lines match the surrounding lines in terms
of style. With the `charsetUTF8`
ayushtkn commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1817535488
There is a link with the checkstyle warnings, just click on it
https://github.com/apache/hadoop/assets/25608848/a3a6a1b3-d616-47ab-8b79-7d5330b2bd2a;>
Some 11 lines
pjfanning commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1817533605
> yetus reports some checksyle warnings
@ayushtkn do you have tips and tricks for how to find checkstyle issues
caused by a PR?
This PR is pretty big touching 100s of files
ayushtkn commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1817500126
yetus reports some checksyle warnings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hadoop-yetus commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1817472686
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
pjfanning commented on code in PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#discussion_r1397322918
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/web/ServletUtils.java:
##
@@ -24,14 +24,15 @@
import
ayushtkn commented on code in PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#discussion_r1397307869
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/web/ServletUtils.java:
##
@@ -24,14 +24,15 @@
import
pjfanning commented on code in PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#discussion_r1397293839
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/web/ServletUtils.java:
##
@@ -24,14 +24,15 @@
import
ayushtkn commented on code in PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#discussion_r1397278741
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/web/ServletUtils.java:
##
@@ -24,14 +24,15 @@
import
ayushtkn commented on code in PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#discussion_r1397278368
##
pom.xml:
##
@@ -225,6 +225,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/x
pjfanning commented on code in PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#discussion_r1397275697
##
pom.xml:
##
@@ -225,6 +225,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/x
ayushtkn commented on code in PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#discussion_r1397266601
##
pom.xml:
##
@@ -225,6 +225,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/x
hadoop-yetus commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1812093013
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
pjfanning commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1810173668
> Quick Pass & mostly looks good, can we have some restrictions to prevent
future usage of these? Something like this or better?
https://github.com/apache/hadoop/blob/trunk/pom.xml#L194
ayushtkn commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1806669003
I will be back by end of next week, if nobody volunteers by then, I can take
of this :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please
pjfanning commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1805425049
@steveloughran @ayushtkn @slfan1989 Would any of you have time to look at
this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
hadoop-yetus commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1786746913
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1784022857
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1783767669
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
22 matches
Mail list logo
