[GitHub] [hadoop] hadoop-yetus commented on pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4764: URL: https://github.com/apache/hadoop/pull/4764#issuecomment-1231217808 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4823: HADOOP-18429. fix infinite loop in MutableGaugeFloat#incr(float)

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4823: URL: https://github.com/apache/hadoop/pull/4823#issuecomment-1231196586 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18429) MutableGaugeFloat#incr(float) get stuck in an infinite loop

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597568#comment-17597568 ] ASF GitHub Bot commented on HADOOP-18429: - hadoop-yetus commented on PR #4823: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4783: YARN-11274. Impove Nodemanager#NodeStatusUpdaterImpl Log.

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4783: URL: https://github.com/apache/hadoop/pull/4783#issuecomment-1231277128 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4353: HDFS-16593. Correct the BlocksRemoved metric on DataNode side

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4353: URL: https://github.com/apache/hadoop/pull/4353#issuecomment-1231301299 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ashutoshcipher commented on pull request #4773: YARN-11270. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice-hbase-client

2022-08-30 Thread GitBox
ashutoshcipher commented on PR #4773: URL: https://github.com/apache/hadoop/pull/4773#issuecomment-1231319138 @aajisaka - Please help in reviewing the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] leijianchun opened a new pull request, #4825: JUST ADD SOME FUNCTION

2022-08-30 Thread GitBox
leijianchun opened a new pull request, #4825: URL: https://github.com/apache/hadoop/pull/4825 JUST ADD SOME FUNCTION -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] ashutoshcipher commented on pull request #4772: YARN-11265. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-sharedcachemanager

2022-08-30 Thread GitBox
ashutoshcipher commented on PR #4772: URL: https://github.com/apache/hadoop/pull/4772#issuecomment-1231319296 @aajisaka - Please help in reviewing the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ashutoshcipher commented on pull request #4776: YARN-11264. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-tests

2022-08-30 Thread GitBox
ashutoshcipher commented on PR #4776: URL: https://github.com/apache/hadoop/pull/4776#issuecomment-1231318743 @aajisaka - Please help in reviewing the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ashutoshcipher commented on pull request #4775: YARN-11260. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice

2022-08-30 Thread GitBox
ashutoshcipher commented on PR #4775: URL: https://github.com/apache/hadoop/pull/4775#issuecomment-1231318894 @aajisaka - Please help in reviewing the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ashutoshcipher commented on pull request #4774: YARN-11271. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice-hbase-common

2022-08-30 Thread GitBox
ashutoshcipher commented on PR #4774: URL: https://github.com/apache/hadoop/pull/4774#issuecomment-1231319003 @aajisaka - Please help in reviewing the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ashutoshcipher commented on pull request #4717: YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-08-30 Thread GitBox
ashutoshcipher commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1231322486 @aajisaka - Please help in reviewing the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] aajisaka merged pull request #4778: YARN-11245. Upgrade JUnit from 4 to 5 in hadoop-yarn-csi

2022-08-30 Thread GitBox
aajisaka merged PR #4778: URL: https://github.com/apache/hadoop/pull/4778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] wangwx27 opened a new pull request, #4827: add method comments

2022-08-30 Thread GitBox
wangwx27 opened a new pull request, #4827: URL: https://github.com/apache/hadoop/pull/4827 add method comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] slfan1989 commented on pull request #4457: HADOOP-18302. Remove WhiteBox in hadoop-common module.

2022-08-30 Thread GitBox
slfan1989 commented on PR #4457: URL: https://github.com/apache/hadoop/pull/4457#issuecomment-1231356248 @aajisaka Please help me to review the code again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] slfan1989 commented on pull request #4828: YARN-11287. Fix NoClassDefFoundError After YARN-10793(#4603)

2022-08-30 Thread GitBox
slfan1989 commented on PR #4828: URL: https://github.com/apache/hadoop/pull/4828#issuecomment-1231407994 I think when upgrading junit test 4 to 5, we should consider global unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4703: YARN-11241. Add uncleaning option for local app log file with log-aggregation enabled

2022-08-30 Thread GitBox
ashutoshcipher commented on code in PR #4703: URL: https://github.com/apache/hadoop/pull/4703#discussion_r958307863 ##

[GitHub] [hadoop] slfan1989 commented on pull request #4824: YARN-11286. Make AsyncDispatcher#printEventDetailsExecutor thread pool parameter configurable.

2022-08-30 Thread GitBox
slfan1989 commented on PR #4824: URL: https://github.com/apache/hadoop/pull/4824#issuecomment-1231495365 @ayushtkn Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (HADOOP-18375) Fix failure of shelltest for hadoop_add_ldlibpath

2022-08-30 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-18375: -- Fix Version/s: 3.2.5 > Fix failure of shelltest for hadoop_add_ldlibpath >

[GitHub] [hadoop] wangwx27 opened a new pull request, #4826: Update README.txt

2022-08-30 Thread GitBox
wangwx27 opened a new pull request, #4826: URL: https://github.com/apache/hadoop/pull/4826 add some comments ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-30 Thread GitBox
slfan1989 commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r957975795 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:

[GitHub] [hadoop] leijianchun closed pull request #4825: JUST ADD SOME FUNCTION

2022-08-30 Thread GitBox
leijianchun closed pull request #4825: JUST ADD SOME FUNCTION URL: https://github.com/apache/hadoop/pull/4825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hadoop] slfan1989 opened a new pull request, #4828: YARN-11287. Fix NoClassDefFoundError After YARN-10793(https://github.com/apache/hadoop/pull/4603)

2022-08-30 Thread GitBox
slfan1989 opened a new pull request, #4828: URL: https://github.com/apache/hadoop/pull/4828 JIRA: YARN-11287. Fix NoClassDefFoundError: org/junit/platform/launcher/core/LauncherFactory After YARN-10793. After executing the yarn-project global unit test, I found the following error:

[jira] [Updated] (HADOOP-18375) Fix failure of shelltest for hadoop_add_ldlibpath

2022-08-30 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-18375: -- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed

[jira] [Commented] (HADOOP-18375) Fix failure of shelltest for hadoop_add_ldlibpath

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597742#comment-17597742 ] ASF GitHub Bot commented on HADOOP-18375: - iwasakims merged PR #4652: URL:

[GitHub] [hadoop] uynaug opened a new pull request, #4829: add some comments

2022-08-30 Thread GitBox
uynaug opened a new pull request, #4829: URL: https://github.com/apache/hadoop/pull/4829 add some comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (HADOOP-18375) Fix failure of shelltest for hadoop_add_ldlibpath

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597743#comment-17597743 ] ASF GitHub Bot commented on HADOOP-18375: - iwasakims commented on PR #4652: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4828: YARN-11287. Fix NoClassDefFoundError After YARN-10793(#4603)

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4828: URL: https://github.com/apache/hadoop/pull/4828#issuecomment-1231515820 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4746: URL: https://github.com/apache/hadoop/pull/4746#issuecomment-1231457010 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4703: YARN-11241. Add uncleaning option for local app log file with log-aggregation enabled

2022-08-30 Thread GitBox
ashutoshcipher commented on code in PR #4703: URL: https://github.com/apache/hadoop/pull/4703#discussion_r958312471 ##

[jira] [Updated] (HADOOP-18375) Fix failure of shelltest for hadoop_add_ldlibpath

2022-08-30 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-18375: -- Fix Version/s: 3.3.9 > Fix failure of shelltest for hadoop_add_ldlibpath >

[jira] [Commented] (HADOOP-18302) Remove WhiteBox in hadoop-common module.

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597684#comment-17597684 ] ASF GitHub Bot commented on HADOOP-18302: - slfan1989 commented on PR #4457: URL:

[GitHub] [hadoop] aajisaka commented on a diff in pull request #4703: YARN-11241. Add uncleaning option for local app log file with log-aggregation enabled

2022-08-30 Thread GitBox
aajisaka commented on code in PR #4703: URL: https://github.com/apache/hadoop/pull/4703#discussion_r958178418 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #4825: JUST ADD SOME FUNCTION

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4825: URL: https://github.com/apache/hadoop/pull/4825#issuecomment-1231389373 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4828: YARN-11287. Fix NoClassDefFoundError After YARN-10793(#4603)

2022-08-30 Thread GitBox
slfan1989 commented on PR #4828: URL: https://github.com/apache/hadoop/pull/4828#issuecomment-1231405949 @ashutoshcipher @aajisaka I found that after YARN-10793 Upgrade Junit from 4 to 5 in hadoop-yarn-server-applicationhistoryservice, Junit Test under the entire module of Yarn will have

[GitHub] [hadoop] ashutoshcipher commented on pull request #4777: YARN-11261. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-web-proxy

2022-08-30 Thread GitBox
ashutoshcipher commented on PR #4777: URL: https://github.com/apache/hadoop/pull/4777#issuecomment-1231318644 @aajisaka - Please help in reviewing the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] aajisaka commented on pull request #4778: YARN-11245. Upgrade JUnit from 4 to 5 in hadoop-yarn-csi

2022-08-30 Thread GitBox
aajisaka commented on PR #4778: URL: https://github.com/apache/hadoop/pull/4778#issuecomment-1231327492 @slfan1989 @ashutoshcipher Thank you for the discussion > I feel community is already busy with so many things. I am atleast personally not expecting from someone to sit and write

[GitHub] [hadoop] hadoop-yetus commented on pull request #4826: Update README.txt

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4826: URL: https://github.com/apache/hadoop/pull/4826#issuecomment-1231341431 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] aajisaka commented on a diff in pull request #4703: YARN-11241. Add uncleaning option for local app log file with log-aggregation enabled

2022-08-30 Thread GitBox
aajisaka commented on code in PR #4703: URL: https://github.com/apache/hadoop/pull/4703#discussion_r958182732 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4817: URL: https://github.com/apache/hadoop/pull/4817#issuecomment-1231419615 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4703: YARN-11241. Add uncleaning option for local app log file with log-aggregation enabled

2022-08-30 Thread GitBox
ashutoshcipher commented on code in PR #4703: URL: https://github.com/apache/hadoop/pull/4703#discussion_r958308369 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml: ## @@ -1548,6 +1548,13 @@ 60 + +Whether to clean

[GitHub] [hadoop] iwasakims commented on pull request #4652: HADOOP-18375. Fix failure of shelltest for hadoop_add_ldlibpath.

2022-08-30 Thread GitBox
iwasakims commented on PR #4652: URL: https://github.com/apache/hadoop/pull/4652#issuecomment-1231480516 Thanks, @ashutoshcipher and @aajisaka. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4703: YARN-11241. Add uncleaning option for local app log file with log-aggregation enabled

2022-08-30 Thread GitBox
ashutoshcipher commented on code in PR #4703: URL: https://github.com/apache/hadoop/pull/4703#discussion_r958308526 ##

[GitHub] [hadoop] iwasakims merged pull request #4652: HADOOP-18375. Fix failure of shelltest for hadoop_add_ldlibpath.

2022-08-30 Thread GitBox
iwasakims merged PR #4652: URL: https://github.com/apache/hadoop/pull/4652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] snmvaughan opened a new pull request, #4835: HDFS-16740. Mini cluster test flakiness

2022-08-30 Thread GitBox
snmvaughan opened a new pull request, #4835: URL: https://github.com/apache/hadoop/pull/4835 ### Description of PR Mini clusters used during HDFS unit tests are reporting test failures that do not appear to be directly related to submitted changes. The failures are the result of

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1232142798 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598062#comment-17598062 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1232144304 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Commented] (HADOOP-18430) Refactor CallerContext's constructor to eliminate duplicate code

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598087#comment-17598087 ] ASF GitHub Bot commented on HADOOP-18430: - hadoop-yetus commented on PR #4832: URL:

[jira] [Commented] (HADOOP-18186) s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598088#comment-17598088 ] ASF GitHub Bot commented on HADOOP-18186: - hadoop-yetus commented on PR #4796: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4796: HADOOP-18186. s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4796: URL: https://github.com/apache/hadoop/pull/4796#issuecomment-1232211085 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1232254758 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598007#comment-17598007 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4457: HADOOP-18302. Remove WhiteBox in hadoop-common module.

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4457: URL: https://github.com/apache/hadoop/pull/4457#issuecomment-1232019703 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18302) Remove WhiteBox in hadoop-common module.

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598008#comment-17598008 ] ASF GitHub Bot commented on HADOOP-18302: - hadoop-yetus commented on PR #4457: URL:

[jira] [Created] (HADOOP-18431) Unit test can fail due to unexpected host resolution

2022-08-30 Thread Steve Vaughan (Jira)
Steve Vaughan created HADOOP-18431: -- Summary: Unit test can fail due to unexpected host resolution Key: HADOOP-18431 URL: https://issues.apache.org/jira/browse/HADOOP-18431 Project: Hadoop Common

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598064#comment-17598064 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4832: HADOOP-18430. Refactor CallerContext's constructor to eliminate duplicate code

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4832: URL: https://github.com/apache/hadoop/pull/4832#issuecomment-1232210642 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4831: YARN-11256. Remove redundant params from the buildCommandExecutor

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4831: URL: https://github.com/apache/hadoop/pull/4831#issuecomment-1232086678 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598105#comment-17598105 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1232255759 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598106#comment-17598106 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765: URL:

[jira] [Commented] (HADOOP-18417) Upgrade Maven Surefire plugin to 3.0.0-M7

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598118#comment-17598118 ] ASF GitHub Bot commented on HADOOP-18417: - snmvaughan commented on PR #4807: URL:

[jira] [Commented] (HADOOP-18186) s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598128#comment-17598128 ] ASF GitHub Bot commented on HADOOP-18186: - virajjasani commented on PR #4796: URL:

[GitHub] [hadoop] virajjasani commented on pull request #4796: HADOOP-18186. s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-30 Thread GitBox
virajjasani commented on PR #4796: URL: https://github.com/apache/hadoop/pull/4796#issuecomment-1232361230 With `scale` ``` [INFO] --- maven-surefire-plugin:3.0.0-M1:test (default-test) @ hadoop-aws --- [INFO] [INFO] ---

[jira] [Commented] (HADOOP-18302) Remove WhiteBox in hadoop-common module.

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598015#comment-17598015 ] ASF GitHub Bot commented on HADOOP-18302: - hadoop-yetus commented on PR #4457: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4457: HADOOP-18302. Remove WhiteBox in hadoop-common module.

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4457: URL: https://github.com/apache/hadoop/pull/4457#issuecomment-1232031365 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] pjfanning commented on pull request #761: HADOOP-13386 Upgrade avro version in Hadoop

2022-08-30 Thread GitBox
pjfanning commented on PR #761: URL: https://github.com/apache/hadoop/pull/761#issuecomment-1232096823 @VidhiBhansali this PR is not maintained and is now out of date. There is a JIRA open - maybe you could watch that issue instead. https://issues.apache.org/jira/browse/HADOOP-18342 - that

[GitHub] [hadoop] goiri commented on a diff in pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

2022-08-30 Thread GitBox
goiri commented on code in PR #4765: URL: https://github.com/apache/hadoop/pull/4765#discussion_r958919024 ## dev-support/Jenkinsfile: ## @@ -71,7 +71,7 @@ pipeline { checkout([ $class: 'GitSCM', branches:

[jira] [Commented] (HADOOP-18186) s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598113#comment-17598113 ] ASF GitHub Bot commented on HADOOP-18186: - hadoop-yetus commented on PR #4796: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4796: HADOOP-18186. s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4796: URL: https://github.com/apache/hadoop/pull/4796#issuecomment-1232212855 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18186) s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598089#comment-17598089 ] ASF GitHub Bot commented on HADOOP-18186: - hadoop-yetus commented on PR #4796: URL:

[GitHub] [hadoop] snmvaughan opened a new pull request, #4834: HDFS-16753. WebHDFSHandler should reject non-compliant requests

2022-08-30 Thread GitBox
snmvaughan opened a new pull request, #4834: URL: https://github.com/apache/hadoop/pull/4834 ### Description of PR When the nnId is not provided to the WebHDFSClient, the request uses null to generate a URI using a host name of "null" to construct a DFSClient instance. In

[GitHub] [hadoop] slfan1989 commented on pull request #4781: YARN-11272. Federation StateStore: Support storage/retrieval of Reservations With Zk.

2022-08-30 Thread GitBox
slfan1989 commented on PR #4781: URL: https://github.com/apache/hadoop/pull/4781#issuecomment-1232252531 @goiri Can you help to merge this pr into trunk branch? I will continue to follow up on [YARN-11273](https://issues.apache.org/jira/browse/YARN-11273), which requires part of the pr

[GitHub] [hadoop] hadoop-yetus commented on pull request #4796: HADOOP-18186. s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4796: URL: https://github.com/apache/hadoop/pull/4796#issuecomment-1232294409 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1232348452 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598126#comment-17598126 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765: URL:

[jira] [Commented] (HADOOP-18186) s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598129#comment-17598129 ] ASF GitHub Bot commented on HADOOP-18186: - virajjasani commented on PR #4796: URL:

[GitHub] [hadoop] virajjasani commented on pull request #4796: HADOOP-18186. s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-08-30 Thread GitBox
virajjasani commented on PR #4796: URL: https://github.com/apache/hadoop/pull/4796#issuecomment-1232362050 Addressed review comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (HADOOP-13386) Upgrade Avro to 1.9.2

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598036#comment-17598036 ] ASF GitHub Bot commented on HADOOP-13386: - pjfanning commented on PR #761: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1232018625 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18431) Unit test can fail due to unexpected host resolution

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598022#comment-17598022 ] ASF GitHub Bot commented on HADOOP-18431: - snmvaughan opened a new pull request, #4833: URL:

[jira] [Updated] (HADOOP-18431) Unit test can fail due to unexpected host resolution

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18431: Labels: pull-request-available (was: ) > Unit test can fail due to unexpected host

[GitHub] [hadoop] snmvaughan opened a new pull request, #4833: HADOOP-18431. Unit test can fail due to unexpected host resolution

2022-08-30 Thread GitBox
snmvaughan opened a new pull request, #4833: URL: https://github.com/apache/hadoop/pull/4833 ### Description of PR Tests that want to use an unresolvable address may actually resolve in some environments. Replacing host names like "bogus" with a IETF RFC 2606 domain name avoids the

[jira] [Updated] (HADOOP-18342) Upgrade to Avro 1.11.1

2022-08-30 Thread PJ Fanning (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PJ Fanning updated HADOOP-18342: Summary: Upgrade to Avro 1.11.1 (was: Upgrade to Avro 1.11.0) > Upgrade to Avro 1.11.1 >

[jira] [Commented] (HADOOP-18159) Certificate doesn't match any of the subject alternative names: [*.s3.amazonaws.com, s3.amazonaws.com]

2022-08-30 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-18159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598093#comment-17598093 ] Esteban AvendaƱo commented on HADOOP-18159: --- Do you have release date for 3.4 release ? I

[GitHub] [hadoop] hadoop-yetus commented on pull request #4835: HDFS-16740. Mini cluster test flakiness

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4835: URL: https://github.com/apache/hadoop/pull/4835#issuecomment-1232346110 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-13386) Upgrade Avro to 1.9.2

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598024#comment-17598024 ] ASF GitHub Bot commented on HADOOP-13386: - VidhiBhansali commented on PR #761: URL:

[GitHub] [hadoop] VidhiBhansali commented on pull request #761: HADOOP-13386 Upgrade avro version in Hadoop

2022-08-30 Thread GitBox
VidhiBhansali commented on PR #761: URL: https://github.com/apache/hadoop/pull/761#issuecomment-1232064192 Hi team, The most recent version `3.3.4` of hadoop-common is using Avro version `1.7.7` which is using more than one vulnerable 3rd party packages and has about 6 CVEs -

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598069#comment-17598069 ] ASF GitHub Bot commented on HADOOP-18133: - goiri commented on code in PR #4765: URL:

[GitHub] [hadoop] snmvaughan commented on pull request #4807: HADOOP-18417. Upgrade to M7 of surefire plugin

2022-08-30 Thread GitBox
snmvaughan commented on PR #4807: URL: https://github.com/apache/hadoop/pull/4807#issuecomment-1232315233 The builds aren't really providing any feedback, and local runs work as expected. The 1st build failed due to what appears to be a memory issue (exit code 137). The 2nd build failed

[GitHub] [hadoop] hadoop-yetus commented on pull request #4834: HDFS-16753. WebHDFSHandler should reject non-compliant requests

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4834: URL: https://github.com/apache/hadoop/pull/4834#issuecomment-1232333079 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] Samrat002 opened a new pull request, #4831: YARN-11256. Remove redundant params from the function defination

2022-08-30 Thread GitBox
Samrat002 opened a new pull request, #4831: URL: https://github.com/apache/hadoop/pull/4831 ### Description of PR [YARN-11256](https://issues.apache.org/jira/browse/YARN-11256) ### How was this patch tested? ### For code changes: - [x] Does the title or

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1231978014 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Commented] (HADOOP-18429) MutableGaugeFloat#incr(float) get stuck in an infinite loop

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597998#comment-17597998 ] ASF GitHub Bot commented on HADOOP-18429: - hadoop-yetus commented on PR #4823: URL:

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597997#comment-17597997 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4823: HADOOP-18429. fix infinite loop in MutableGaugeFloat#incr(float)

2022-08-30 Thread GitBox
hadoop-yetus commented on PR #4823: URL: https://github.com/apache/hadoop/pull/4823#issuecomment-1231978655 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-18430) Refactor CallerContext's constructor to eliminate duplicate code

2022-08-30 Thread Yu Wang (Jira)
Yu Wang created HADOOP-18430: Summary: Refactor CallerContext's constructor to eliminate duplicate code Key: HADOOP-18430 URL: https://issues.apache.org/jira/browse/HADOOP-18430 Project: Hadoop Common

[GitHub] [hadoop] yuw1 commented on pull request #4832: HADOOP-18430. Refactor CallerContext's constructor to eliminate duplicate code

2022-08-30 Thread GitBox
yuw1 commented on PR #4832: URL: https://github.com/apache/hadoop/pull/4832#issuecomment-1231995179 Refactor CallerContext's constructor to eliminate duplicate code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18430) Refactor CallerContext's constructor to eliminate duplicate code

2022-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598000#comment-17598000 ] ASF GitHub Bot commented on HADOOP-18430: - yuw1 opened a new pull request, #4832: URL:

  1   2   >