[GitHub] [hadoop] hadoop-yetus commented on pull request #5248: HADOOP-18581 : Handle Server KDC re-login when Server and Client run …

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5248: URL: https://github.com/apache/hadoop/pull/5248#issuecomment-1370905767 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18581) Handle Server KDC re-login when Server and Client run in same JVM.

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654464#comment-17654464 ] ASF GitHub Bot commented on HADOOP-18581: - hadoop-yetus commented on PR #5248: URL:

[jira] [Commented] (HADOOP-17377) ABFS: MsiTokenProvider doesn't retry HTTP 429 from the Instance Metadata Service

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654474#comment-17654474 ] ASF GitHub Bot commented on HADOOP-17377: - hadoop-yetus commented on PR #5273: URL:

[jira] [Commented] (HADOOP-17377) ABFS: MsiTokenProvider doesn't retry HTTP 429 from the Instance Metadata Service

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654475#comment-17654475 ] ASF GitHub Bot commented on HADOOP-17377: - hadoop-yetus commented on PR #5273: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5273: HADOOP-17377: Add retry for HTTP 429 and HTTP 410

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1370942634 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5273: HADOOP-17377: Add retry for HTTP 429 and HTTP 410

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1370943150 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5062: [Testing] Jenkins for Hadoop on Windows

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5062: URL: https://github.com/apache/hadoop/pull/5062#issuecomment-1371085611 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[GitHub] [hadoop] hadoop-yetus commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1371028638 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] neshkeev commented on pull request #5267: Fix "the the" and friends typos

2023-01-04 Thread GitBox
neshkeev commented on PR #5267: URL: https://github.com/apache/hadoop/pull/5267#issuecomment-1371092728 @ayushtkn , I didn't touch the names of the issues that are in the release notes, only the commentaries to the releases, so I believe no problems should arise here -- This is an

[GitHub] [hadoop] goiri commented on a diff in pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-04 Thread GitBox
goiri commented on code in PR #5147: URL: https://github.com/apache/hadoop/pull/5147#discussion_r1061664359 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreZooKeeperImpl.java: ## @@ -192,22 +255,45 @@

[GitHub] [hadoop] slfan1989 commented on pull request #5260: YARN-8900. [Follow Up] Fix FederationInterceptorREST#invokeConcurrent Inaccurate Order of Subclusters.

2023-01-04 Thread GitBox
slfan1989 commented on PR #5260: URL: https://github.com/apache/hadoop/pull/5260#issuecomment-1371154062 @goiri Can you help review this PR? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] howzi commented on a diff in pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-04 Thread GitBox
howzi commented on code in PR #5147: URL: https://github.com/apache/hadoop/pull/5147#discussion_r1061436260 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreZooKeeperImpl.java: ## @@ -63,8 +72,17 @@ public

[GitHub] [hadoop] goiri commented on a diff in pull request #5262: HDFS-16880. RBF: modify invokeSingleXXX interface in order to pass actual file src to namenode.

2023-01-04 Thread GitBox
goiri commented on code in PR #5262: URL: https://github.com/apache/hadoop/pull/5262#discussion_r1061651607 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java: ## @@ -687,7 +687,7 @@ T

[GitHub] [hadoop] sauraank opened a new pull request, #5274: HADOOP-18351. Reduce excess logging of errors during S3A prefetching reads

2023-01-04 Thread GitBox
sauraank opened a new pull request, #5274: URL: https://github.com/apache/hadoop/pull/5274 ### Description of PR Logged the errors at the info level with just the message. Added the stack at the Debug level. Not made any changes where error stack was not present and had only the

[jira] [Commented] (HADOOP-18351) S3A prefetching: Error logging during reads

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654508#comment-17654508 ] ASF GitHub Bot commented on HADOOP-18351: - sauraank opened a new pull request, #5274: URL:

[jira] [Updated] (HADOOP-18351) S3A prefetching: Error logging during reads

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18351: Labels: pull-request-available (was: ) > S3A prefetching: Error logging during reads >

[GitHub] [hadoop] goiri commented on a diff in pull request #5200: HDFS-16865. RBF: The source path is always / after RBF proxied the complete, addBlock and getAdditionalDatanode RPC.

2023-01-04 Thread GitBox
goiri commented on code in PR #5200: URL: https://github.com/apache/hadoop/pull/5200#discussion_r1061660594 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java: ## @@ -979,7 +979,10 @@ public boolean complete(String

[GitHub] [hadoop] slfan1989 commented on pull request #5193: YARN-11374. [Federation] Support refreshSuperUserGroupsConfiguration、refreshUserToGroupsMappings API's for Federation.

2023-01-04 Thread GitBox
slfan1989 commented on PR #5193: URL: https://github.com/apache/hadoop/pull/5193#issuecomment-1371155322 @goiri Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] hadoop-yetus commented on pull request #5062: [Testing] Jenkins for Hadoop on Windows

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5062: URL: https://github.com/apache/hadoop/pull/5062#issuecomment-1371241333 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[GitHub] [hadoop] cnauroth commented on a diff in pull request #5248: HADOOP-18581 : Handle Server KDC re-login when Server and Client run …

2023-01-04 Thread GitBox
cnauroth commented on code in PR #5248: URL: https://github.com/apache/hadoop/pull/5248#discussion_r1061900219 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -153,6 +154,13 @@ public abstract class Server { private

[jira] [Commented] (HADOOP-18581) Handle Server KDC re-login when Server and Client run in same JVM.

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654651#comment-17654651 ] ASF GitHub Bot commented on HADOOP-18581: - cnauroth commented on code in PR #5248: URL:

[jira] [Commented] (HADOOP-18587) upgrade to jettison 1.5.2 due to security issue

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654568#comment-17654568 ] ASF GitHub Bot commented on HADOOP-18587: - hadoop-yetus commented on PR #5270: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5270: HADOOP-18587: upgrade to jettison 1.5.2 due to cve

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5270: URL: https://github.com/apache/hadoop/pull/5270#issuecomment-1371229906 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] pjfanning commented on pull request #5270: HADOOP-18587: upgrade to jettison 1.5.2 due to cve

2023-01-04 Thread GitBox
pjfanning commented on PR #5270: URL: https://github.com/apache/hadoop/pull/5270#issuecomment-1371305171 @cnauroth there are test failures and some of them seem to relate to jettison changes. I'm not sure how semver applies when they make breaking changes in a patch level release. I'll

[GitHub] [hadoop] hadoop-yetus commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1371251060 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5268: HDFS-16881. Warn if AccessControlEnforcer runs for a long time to check permission.

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5268: URL: https://github.com/apache/hadoop/pull/5268#issuecomment-1371266019 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18587) upgrade to jettison 1.5.2 due to security issue

2023-01-04 Thread PJ Fanning (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PJ Fanning updated HADOOP-18587: Description: [https://github.com/advisories/GHSA-x27m-9w8j-5vcw]  

[jira] [Commented] (HADOOP-18351) S3A prefetching: Error logging during reads

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654612#comment-17654612 ] ASF GitHub Bot commented on HADOOP-18351: - hadoop-yetus commented on PR #5274: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5274: HADOOP-18351. Reduce excess logging of errors during S3A prefetching reads

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5274: URL: https://github.com/apache/hadoop/pull/5274#issuecomment-1371331426 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18587) upgrade to jettison 1.5.2 due to security issue

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654601#comment-17654601 ] ASF GitHub Bot commented on HADOOP-18587: - pjfanning commented on PR #5270: URL:

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5200: HDFS-16865. RBF: The source path is always / after RBF proxied the complete, addBlock and getAdditionalDatanode RPC.

2023-01-04 Thread GitBox
ayushtkn commented on code in PR #5200: URL: https://github.com/apache/hadoop/pull/5200#discussion_r1061936677 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -465,6 +465,24 @@ public void

[GitHub] [hadoop] neshkeev commented on pull request #5267: Fix "the the" and friends typos

2023-01-04 Thread GitBox
neshkeev commented on PR #5267: URL: https://github.com/apache/hadoop/pull/5267#issuecomment-1371499135 @ayushtkn , I restored everything in the `hadoop-common-project/hadoop-common/src/site/markdown/release` directory back to what it was before my changes, please take a look -- This is

[GitHub] [hadoop] ayushtkn commented on pull request #5267: Fix "the the" and friends typos

2023-01-04 Thread GitBox
ayushtkn commented on PR #5267: URL: https://github.com/apache/hadoop/pull/5267#issuecomment-1371491518 Those commentaries aren't written explicitly written, they are fetched from the jira itself, it is there in the release notes column of the Jira.

[GitHub] [hadoop] ayushtkn merged pull request #5271: HDFS-16883. Duplicate field name in hdfs-default.xml

2023-01-04 Thread GitBox
ayushtkn merged PR #5271: URL: https://github.com/apache/hadoop/pull/5271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5267: Fix "the the" and friends typos

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5267: URL: https://github.com/apache/hadoop/pull/5267#issuecomment-1371567319 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] szetszwo merged pull request #5268: HDFS-16881. Warn if AccessControlEnforcer runs for a long time to check permission.

2023-01-04 Thread GitBox
szetszwo merged PR #5268: URL: https://github.com/apache/hadoop/pull/5268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] ayushtkn commented on pull request #5266: Bump jettison from 1.5.1 to 1.5.2 in /hadoop-project

2023-01-04 Thread GitBox
ayushtkn commented on PR #5266: URL: https://github.com/apache/hadoop/pull/5266#issuecomment-1371493618 Getting chased at #5270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] ayushtkn closed pull request #5266: Bump jettison from 1.5.1 to 1.5.2 in /hadoop-project

2023-01-04 Thread GitBox
ayushtkn closed pull request #5266: Bump jettison from 1.5.1 to 1.5.2 in /hadoop-project URL: https://github.com/apache/hadoop/pull/5266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] dependabot[bot] commented on pull request #5266: Bump jettison from 1.5.1 to 1.5.2 in /hadoop-project

2023-01-04 Thread GitBox
dependabot[bot] commented on PR #5266: URL: https://github.com/apache/hadoop/pull/5266#issuecomment-1371493650 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

[GitHub] [hadoop] szetszwo commented on pull request #5268: HDFS-16881. Warn if AccessControlEnforcer runs for a long time to check permission.

2023-01-04 Thread GitBox
szetszwo commented on PR #5268: URL: https://github.com/apache/hadoop/pull/5268#issuecomment-1371632593 @cnauroth , thanks a lot for reviewing this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop] LennonChin commented on a diff in pull request #4435: YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread

2023-01-04 Thread GitBox
LennonChin commented on code in PR #4435: URL: https://github.com/apache/hadoop/pull/4435#discussion_r1062171496 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #5273: HADOOP-17377: Add retry for HTTP 429 and HTTP 410

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1371873722 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ZanderXu commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-04 Thread GitBox
ZanderXu commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1371846633 @howzi It seems the failed UT `hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver` is not caused by this PR, but can you fix it in a new PR? --

[GitHub] [hadoop] LennonChin commented on pull request #4435: YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread

2023-01-04 Thread GitBox
LennonChin commented on PR #4435: URL: https://github.com/apache/hadoop/pull/4435#issuecomment-1371858309 I have made two commits to perform your suggestions, @slfan1989 please cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5217: YARN-11320. [Federation] Add getSchedulerInfo REST APIs for Router.

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5217: URL: https://github.com/apache/hadoop/pull/5217#issuecomment-1371884437 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17377) ABFS: MsiTokenProvider doesn't retry HTTP 429 from the Instance Metadata Service

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654820#comment-17654820 ] ASF GitHub Bot commented on HADOOP-17377: - hadoop-yetus commented on PR #5273: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5273: HADOOP-17377: Add retry for HTTP 429 and HTTP 410

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1371868477 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17377) ABFS: MsiTokenProvider doesn't retry HTTP 429 from the Instance Metadata Service

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654831#comment-17654831 ] ASF GitHub Bot commented on HADOOP-17377: - hadoop-yetus commented on PR #5273: URL:

[GitHub] [hadoop] pranavsaxena-microsoft commented on pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on PR #3440: URL: https://github.com/apache/hadoop/pull/3440#issuecomment-1371769564 yetus run for commit 0cd8c8c https://github.com/apache/hadoop/pull/5261#issuecomment-1368669330

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654727#comment-17654727 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on PR #3440: URL:

[GitHub] [hadoop] pranavsaxena-microsoft commented on pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on PR #3440: URL: https://github.com/apache/hadoop/pull/3440#issuecomment-1371771533 HNS-OAuth [INFO] Results: [INFO] [ERROR] Failures: [ERROR]

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062127740 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -779,6 +787,18 @@ public AbfsInputStream

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654748#comment-17654748 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654747#comment-17654747 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654749#comment-17654749 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654750#comment-17654750 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062128269 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -794,13 +814,13 @@ public AbfsInputStream

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062127976 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -779,6 +787,18 @@ public AbfsInputStream

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654755#comment-17654755 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654757#comment-17654757 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062133476 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/ConfigurationKeys.java: ## @@ -188,8 +188,14 @@ public final class

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062132903 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -1856,6 +1906,35 @@ public String

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654773#comment-17654773 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062139995 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -64,10 +66,11 @@ import

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654776#comment-17654776 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654781#comment-17654781 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654780#comment-17654780 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-18320) Improve S3A delegations token documentation

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654782#comment-17654782 ] ASF GitHub Bot commented on HADOOP-18320: - mukund-thakur commented on code in PR #4499: URL:

[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

2023-01-04 Thread GitBox
mukund-thakur commented on code in PR #4499: URL: https://github.com/apache/hadoop/pull/4499#discussion_r1062124836 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md: ## @@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062145845 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java: ## @@ -494,17 +499,26 @@ public synchronized

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062146112 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/EncryptionType.java: ## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654787#comment-17654787 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654786#comment-17654786 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654795#comment-17654795 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654796#comment-17654796 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654797#comment-17654797 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062148768 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654798#comment-17654798 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062149184 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCreate.java: ## @@ -25,6 +25,7 @@ import

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654752#comment-17654752 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062129524 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -855,6 +876,15 @@ public OutputStream

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062129895 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -1616,16 +1647,39 @@ private void

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654763#comment-17654763 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654762#comment-17654762 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062134581 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/ABFSKey.java: ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062134396 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/ABFSKey.java: ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654766#comment-17654766 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654764#comment-17654764 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062134873 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncodingHelper.java: ## @@ -0,0 +1,43 @@ +/** + * Licensed to the

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654765#comment-17654765 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062135054 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncodingHelper.java: ## @@ -0,0 +1,43 @@ +/** + * Licensed to the

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062137284 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncryptionAdapter.java: ## @@ -0,0 +1,87 @@ +/** + * Licensed to the

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654771#comment-17654771 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654772#comment-17654772 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062137547 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncryptionAdapter.java: ## @@ -0,0 +1,87 @@ +/** + * Licensed to the

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654775#comment-17654775 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062142574 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -228,16 +231,65 @@ List createDefaultHeaders() {

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654791#comment-17654791 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062146937 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062146779 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the

  1   2   >