[GitHub] [hadoop] bshashikant commented on issue #846: HDDS-1555. Disable install snapshot for ContainerStateMachine.

bshashikant commented on issue #846: HDDS-1555. Disable install snapshot for ContainerStateMachine. URL: https://github.com/apache/hadoop/pull/846#issuecomment-497213904 Thanks @swagle for working on this. The changes look good. I have just one point to make here: Add a

[jira] [Commented] (HADOOP-15183) S3Guard store becomes inconsistent after partial failure of rename

[ https://issues.apache.org/jira/browse/HADOOP-15183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851518#comment-16851518 ] Aaron Fabbri commented on HADOOP-15183: --- Looking good [~ste...@apache.org]. A lot of nice

[GitHub] [hadoop] ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#discussion_r288854348 ## File path:

[GitHub] [hadoop] ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#discussion_r288790499 ## File path:

[GitHub] [hadoop] ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#discussion_r288790196 ## File path:

[GitHub] [hadoop] ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#discussion_r288847579 ## File path:

[GitHub] [hadoop] ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#discussion_r288854508 ## File path:

[GitHub] [hadoop] ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#discussion_r288854779 ## File path:

[GitHub] [hadoop] ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

ajfabbri commented on a change in pull request #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#discussion_r288855378 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#issuecomment-497196689 Last commit change is moved all the classes to package named bucket under request/response.

[GitHub] [hadoop] bharatviswa504 commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#issuecomment-497193840 /retest This is an automated message from

[GitHub] [hadoop] hadoop-yetus commented on issue #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

hadoop-yetus commented on issue #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#issuecomment-497193667 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime |

[jira] [Updated] (HADOOP-16334) Fix yetus-wrapper not working when HADOOP_YETUS_VERSION greater or equal than 0.9.0

[ https://issues.apache.org/jira/browse/HADOOP-16334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-16334: --- Status: Patch Available (was: Open) > Fix yetus-wrapper not working when

[GitHub] [hadoop] infraio opened a new pull request #873: HADOOP-16337 Start the CLI MiniCluster failed because the default for…

infraio opened a new pull request #873: HADOOP-16337 Start the CLI MiniCluster failed because the default for… URL: https://github.com/apache/hadoop/pull/873 …mat option is false This is an automated message from the Apache

[GitHub] [hadoop] dineshchitlangia commented on issue #872: HDDS-1581. Atleast one of the metadata dir config property must be tagged as REQUIRED

dineshchitlangia commented on issue #872: HDDS-1581. Atleast one of the metadata dir config property must be tagged as REQUIRED URL: https://github.com/apache/hadoop/pull/872#issuecomment-497184181 @xiaoyuyao Please help to review/commit. Thanks for guidance.

[GitHub] [hadoop] dineshchitlangia opened a new pull request #872: HDDS-1581. Atleast one of the metadata dir config property must be tagged as REQUIRED

dineshchitlangia opened a new pull request #872: HDDS-1581. Atleast one of the metadata dir config property must be tagged as REQUIRED URL: https://github.com/apache/hadoop/pull/872 Added REQUIRED tag on fallback property and updated description of other configs as needed.

[jira] [Commented] (HADOOP-16302) Fix typo on Hadoop Site Help dropdown menu

[ https://issues.apache.org/jira/browse/HADOOP-16302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851480#comment-16851480 ] Dinesh Chitlangia commented on HADOOP-16302: [~elek] :) Thanks for checking! I was

[jira] [Updated] (HADOOP-16337) Start the CLI MiniCluster failed because the default format option is false

[ https://issues.apache.org/jira/browse/HADOOP-16337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HADOOP-16337: Affects Version/s: 2.8.4 2.9.2 2.8.5 >

[jira] [Created] (HADOOP-16337) Start the CLI MiniCluster failed because the default format option is false

Guanghao Zhang created HADOOP-16337: --- Summary: Start the CLI MiniCluster failed because the default format option is false Key: HADOOP-16337 URL: https://issues.apache.org/jira/browse/HADOOP-16337

[GitHub] [hadoop] hadoop-yetus commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hadoop-yetus commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#issuecomment-497172980 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16334) Fix yetus-wrapper not working when HADOOP_YETUS_VERSION greater or equal than 0.9.0

[ https://issues.apache.org/jira/browse/HADOOP-16334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851457#comment-16851457 ] Wanqiang Ji commented on HADOOP-16334: -- Hi [~aajisaka], can u take some time to help review? >

[GitHub] [hadoop] hadoop-yetus commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hadoop-yetus commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#issuecomment-497172105 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] xiaoyuyao commented on issue #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

xiaoyuyao commented on issue #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#issuecomment-497169505 @ajayydv, half of the test failures are related. Can you fix them?

[GitHub] [hadoop] hadoop-yetus commented on issue #871: HDDS-1579. Create OMDoubleBuffer metrics.

hadoop-yetus commented on issue #871: HDDS-1579. Create OMDoubleBuffer metrics. URL: https://github.com/apache/hadoop/pull/871#issuecomment-497164591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hadoop] hadoop-yetus commented on issue #871: HDDS-1579. Create OMDoubleBuffer metrics.

hadoop-yetus commented on issue #871: HDDS-1579. Create OMDoubleBuffer metrics. URL: https://github.com/apache/hadoop/pull/871#issuecomment-497162182 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288814519 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#issuecomment-497153823 /retest This is an automated message from

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288813544 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288813544 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#issuecomment-497152646 Thank You @hanishakoneru for the review. I have addressed the review comments. For some of the questions,

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288814908 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288814783 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288814660 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288814608 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288814519 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288814215 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288814271 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288814047 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288813640 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288813760 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288813640 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288813431 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288813544 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288727105 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288809976 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288810202 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288800930 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288809062 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288808597 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288804803 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288721948 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hadoop-yetus commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#issuecomment-497148116 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288802440 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288722111 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288791912 ## File path:

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hanishakoneru commented on a change in pull request #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#discussion_r288807522 ## File path:

[jira] [Commented] (HADOOP-16314) Make sure all end point URL is covered by the same AuthenticationFilter

[ https://issues.apache.org/jira/browse/HADOOP-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851399#comment-16851399 ] Hadoop QA commented on HADOOP-16314: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] bharatviswa504 opened a new pull request #871: HDDS-1579. Create OMDoubleBuffer metrics.

bharatviswa504 opened a new pull request #871: HDDS-1579. Create OMDoubleBuffer metrics. URL: https://github.com/apache/hadoop/pull/871 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] hadoop-yetus commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hadoop-yetus commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#issuecomment-497142393 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16314) Make sure all end point URL is covered by the same AuthenticationFilter

[ https://issues.apache.org/jira/browse/HADOOP-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851384#comment-16851384 ] Hadoop QA commented on HADOOP-16314: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] xiaoyuyao merged pull request #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options.

xiaoyuyao merged pull request #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options. URL: https://github.com/apache/hadoop/pull/830 This is an automated message from the

[GitHub] [hadoop] xiaoyuyao commented on issue #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options.

xiaoyuyao commented on issue #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options. URL: https://github.com/apache/hadoop/pull/830#issuecomment-497138201 +1, I will merge/commit this shortly.

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options.

xiaoyuyao commented on a change in pull request #830: HDDS-1530. Freon support big files larger than 2GB and add --bufferSize and --validateWrites options. URL: https://github.com/apache/hadoop/pull/830#discussion_r288799644 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hadoop-yetus commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#issuecomment-497134161 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

hadoop-yetus commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#issuecomment-497128592 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] xiaoyuyao commented on issue #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

xiaoyuyao commented on issue #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#issuecomment-497123569 +1, pending Jekens. This is an

[GitHub] [hadoop] hadoop-yetus commented on issue #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

hadoop-yetus commented on issue #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#issuecomment-497122435 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime |

[GitHub] [hadoop] hadoop-yetus commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

hadoop-yetus commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#issuecomment-497118740 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…

bharatviswa504 commented on issue #850: HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf… URL: https://github.com/apache/hadoop/pull/850#issuecomment-497108920 /retest This is an automated message from

[jira] [Updated] (HADOOP-16336) finish variable is unused in ZStandardCompressor

[ https://issues.apache.org/jira/browse/HADOOP-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated HADOOP-16336: -- Summary: finish variable is unused in ZStandardCompressor (was: finish valiable is

[jira] [Created] (HADOOP-16336) finish valiable is unused in ZStandardCompressor

Daniel Templeton created HADOOP-16336: - Summary: finish valiable is unused in ZStandardCompressor Key: HADOOP-16336 URL: https://issues.apache.org/jira/browse/HADOOP-16336 Project: Hadoop Common

[GitHub] [hadoop] anuengineer commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

anuengineer commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288762291 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

anuengineer commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288762165 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

anuengineer commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288761616 ## File path:

[GitHub] [hadoop] anuengineer merged pull request #870: HDDS-1542. Create Radix tree to support ozone prefix ACLs. Contribute…

anuengineer merged pull request #870: HDDS-1542. Create Radix tree to support ozone prefix ACLs. Contribute… URL: https://github.com/apache/hadoop/pull/870 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288756288 ## File path:

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288756235 ## File path:

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288756168 ## File path:

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288756124 ## File path:

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288755580 ## File path:

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288755528 ## File path:

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288755156 ## File path:

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288755097 ## File path:

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288755189 ## File path:

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288755011 ## File path:

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288754975 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #868: HDDS-1568 : Add RocksDB metrics to OM.

hadoop-yetus commented on issue #868: HDDS-1568 : Add RocksDB metrics to OM. URL: https://github.com/apache/hadoop/pull/868#issuecomment-497091130 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hadoop] hadoop-yetus commented on issue #870: HDDS-1542. Create Radix tree to support ozone prefix ACLs. Contribute…

hadoop-yetus commented on issue #870: HDDS-1542. Create Radix tree to support ozone prefix ACLs. Contribute… URL: https://github.com/apache/hadoop/pull/870#issuecomment-497088055 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #868: HDDS-1568 : Add RocksDB metrics to OM.

avijayanhwx commented on a change in pull request #868: HDDS-1568 : Add RocksDB metrics to OM. URL: https://github.com/apache/hadoop/pull/868#discussion_r288741003 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/DBStoreBuilder.java ## @@ -187,7

[GitHub] [hadoop] anuengineer commented on issue #829: HDDS-1550. MiniOzoneCluster is not shutting down all the threads during shutdown. Contributed by Mukul Kumar Singh.

anuengineer commented on issue #829: HDDS-1550. MiniOzoneCluster is not shutting down all the threads during shutdown. Contributed by Mukul Kumar Singh. URL: https://github.com/apache/hadoop/pull/829#issuecomment-497083934 I am also +1, but I really agree with @bharatviswa504 , we probably

[GitHub] [hadoop] anuengineer commented on a change in pull request #861: HDDS-1596. Create service endpoint to download configuration from SCM

anuengineer commented on a change in pull request #861: HDDS-1596. Create service endpoint to download configuration from SCM URL: https://github.com/apache/hadoop/pull/861#discussion_r288733426 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #861: HDDS-1596. Create service endpoint to download configuration from SCM

anuengineer commented on a change in pull request #861: HDDS-1596. Create service endpoint to download configuration from SCM URL: https://github.com/apache/hadoop/pull/861#discussion_r288734823 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #861: HDDS-1596. Create service endpoint to download configuration from SCM

anuengineer commented on a change in pull request #861: HDDS-1596. Create service endpoint to download configuration from SCM URL: https://github.com/apache/hadoop/pull/861#discussion_r288732873 ## File path:

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288734357 ## File path:

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #868: HDDS-1568 : Add RocksDB metrics to OM.

avijayanhwx commented on a change in pull request #868: HDDS-1568 : Add RocksDB metrics to OM. URL: https://github.com/apache/hadoop/pull/868#discussion_r288731790 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/RocksDBStoreMBean.java ## @@ -41,13

[GitHub] [hadoop] hadoop-yetus commented on issue #806: HDDS-1224. Restructure code to validate the response from server in the Read path

hadoop-yetus commented on issue #806: HDDS-1224. Restructure code to validate the response from server in the Read path URL: https://github.com/apache/hadoop/pull/806#issuecomment-497075978 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288730176 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #868: HDDS-1568 : Add RocksDB metrics to OM.

anuengineer commented on a change in pull request #868: HDDS-1568 : Add RocksDB metrics to OM. URL: https://github.com/apache/hadoop/pull/868#discussion_r288727594 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/RocksDBStoreMBean.java ## @@ -41,13

[GitHub] [hadoop] ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl, removeAcl, setAcl, getAcl for Volume. Contributed Ajay Kumar.

ajayydv commented on a change in pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288729707 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #868: HDDS-1568 : Add RocksDB metrics to OM.

anuengineer commented on a change in pull request #868: HDDS-1568 : Add RocksDB metrics to OM. URL: https://github.com/apache/hadoop/pull/868#discussion_r288728813 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/DBStoreBuilder.java ## @@ -187,7

  1   2   >