[GitHub] [hadoop] hadoop-yetus commented on pull request #4488: HDFS-16640. RBF: Show datanode IP list when click DN histogram in Router

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4488: URL: https://github.com/apache/hadoop/pull/4488#issuecomment-1165211795 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4488: HDFS-16640. RBF: Show datanode IP list when click DN histogram in Router

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4488: URL: https://github.com/apache/hadoop/pull/4488#issuecomment-1165207837 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] wzhallright commented on pull request #4488: HDFS-16640. RBF: Show datanode IP list when click DN histogram in Router

2022-06-23 Thread GitBox
wzhallright commented on PR #4488: URL: https://github.com/apache/hadoop/pull/4488#issuecomment-1165167793 @ayushtkn Add histogram-hostip.js, after modified the screenshots. Please take a review, Thanks! RBF.

[jira] [Work logged] (HADOOP-18044) Hadoop - Upgrade to JQuery 3.6.0

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18044?focusedWorklogId=784405=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784405 ] ASF GitHub Bot logged work on HADOOP-18044: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4495: HADOOP-18044. Hadoop - Upgrade to jQuery 3.6.0 (#3791)

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4495: URL: https://github.com/apache/hadoop/pull/4495#issuecomment-1165155367 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4406: HDFS-16619. Fix HttpHeaders.Values And HttpHeaders.Names Deprecated Import

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4406: URL: https://github.com/apache/hadoop/pull/4406#issuecomment-1165151975 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] wzhallright commented on pull request #4488: HDFS-16640. RBF: Show datanode IP list when click DN histogram in Router

2022-06-23 Thread GitBox
wzhallright commented on PR #4488: URL: https://github.com/apache/hadoop/pull/4488#issuecomment-1165134491 > I'm not good at JS... But I can try to modify -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Work logged] (HADOOP-18303) Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18303?focusedWorklogId=784395=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784395 ] ASF GitHub Bot logged work on HADOOP-18303: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

2022-06-23 Thread GitBox
virajjasani commented on PR #4461: URL: https://github.com/apache/hadoop/pull/4461#issuecomment-1165109458 Even if HADOOP-18033 had not excluded javax.ws.rs-api from shading, as [mentioned here](https://github.com/apache/hadoop/pull/4461#pullrequestreview-1012678699), we would have

[jira] [Work logged] (HADOOP-18303) Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18303?focusedWorklogId=784392=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784392 ] ASF GitHub Bot logged work on HADOOP-18303: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

2022-06-23 Thread GitBox
virajjasani commented on PR #4461: URL: https://github.com/apache/hadoop/pull/4461#issuecomment-1165107308 While HADOOP-18033 is released in 3.3.2, HADOOP-18178 has also made it's way to 3.3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (HADOOP-18290) Fix some compatibility issues with 3.3.3 release notes

2022-06-23 Thread JiangHua Zhu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558284#comment-17558284 ] JiangHua Zhu commented on HADOOP-18290: --- I appreciate your suggestion, [~ste...@apache.org].

[jira] [Work logged] (HADOOP-18254) Add in configuration option to enable prefetching

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18254?focusedWorklogId=784390=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784390 ] ASF GitHub Bot logged work on HADOOP-18254: --- Author: ASF GitHub Bot

[GitHub] [hadoop] ashutoshcipher commented on pull request #4469: HADOOP-18254. Disable prefetching by default.

2022-06-23 Thread GitBox
ashutoshcipher commented on PR #4469: URL: https://github.com/apache/hadoop/pull/4469#issuecomment-1165100507 LGTM +1(non-binding) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-06-23 Thread GitBox
ashutoshcipher commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r905654385 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/MultipleOutputs.java: ## @@

[jira] [Work logged] (HADOOP-18309) Upgrade bundled Tomcat to 8.5.76 or higher

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18309?focusedWorklogId=784386=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784386 ] ASF GitHub Bot logged work on HADOOP-18309: --- Author: ASF GitHub Bot

[GitHub] [hadoop] aajisaka commented on pull request #4479: HADOOP-18309.Upgrade bundled Tomcat to 8.5.81

2022-06-23 Thread GitBox
aajisaka commented on PR #4479: URL: https://github.com/apache/hadoop/pull/4479#issuecomment-1165034064 Thank you @ashutoshcipher for the contribution and thank you @iwasakims for testing and merging the PR. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Work logged] (HADOOP-18303) Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18303?focusedWorklogId=784376=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784376 ] ASF GitHub Bot logged work on HADOOP-18303: --- Author: ASF GitHub Bot

[GitHub] [hadoop] ayushtkn commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

2022-06-23 Thread GitBox
ayushtkn commented on PR #4461: URL: https://github.com/apache/hadoop/pull/4461#issuecomment-116433 Yeps, if people let us do that, that jira is already in a released version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Work logged] (HADOOP-18310) Add option and make 400 bad request retryable

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18310?focusedWorklogId=784372=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784372 ] ASF GitHub Bot logged work on HADOOP-18310: --- Author: ASF GitHub Bot

[GitHub] [hadoop] mukund-thakur commented on pull request #4483: HADOOP-18310 Add option and make 400 bad request retryable

2022-06-23 Thread GitBox
mukund-thakur commented on PR #4483: URL: https://github.com/apache/hadoop/pull/4483#issuecomment-1164984485 Do we really need to introduce this config? Seems like an overkill. I think 400 Bad Request are supposed to be non retry-able. -- This is an automated message from the Apache

[jira] [Work logged] (HADOOP-18306) Warnings should not be shown on cli console when linux user not present on client

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18306?focusedWorklogId=784363=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784363 ] ASF GitHub Bot logged work on HADOOP-18306: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-18215) Enhance WritableName to be able to return aliases for classes that use serializers

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18215?focusedWorklogId=784364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784364 ] ASF GitHub Bot logged work on HADOOP-18215: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4215: HADOOP-18215. Enhance WritableName to be able to return aliases for classes that use serializers

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4215: URL: https://github.com/apache/hadoop/pull/4215#issuecomment-1164971314 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4474: HADOOP-18306: Warnings should not be shown on cli console when linux user not present on client

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4474: URL: https://github.com/apache/hadoop/pull/4474#issuecomment-1164971077 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4464: YARN-11169. Support moveApplicationAcrossQueues, getQueueInfo API's for Federation.

2022-06-23 Thread GitBox
slfan1989 commented on PR #4464: URL: https://github.com/apache/hadoop/pull/4464#issuecomment-1164896098 @goiri Please help me to review the code, Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] hadoop-yetus commented on pull request #4155: HDFS-16533. COMPOSITE_CRC failed between replicated file and striped …

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4155: URL: https://github.com/apache/hadoop/pull/4155#issuecomment-1164882298 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18303) Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18303?focusedWorklogId=784342=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784342 ] ASF GitHub Bot logged work on HADOOP-18303: --- Author: ASF GitHub Bot

[GitHub] [hadoop] sunchao commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

2022-06-23 Thread GitBox
sunchao commented on PR #4461: URL: https://github.com/apache/hadoop/pull/4461#issuecomment-1164795939 In that case should we consider reverting it for now until we are ready to upgrade both jersey and jackson together at some point? -- This is an automated message from the Apache Git

[jira] [Work logged] (HADOOP-18044) Hadoop - Upgrade to JQuery 3.6.0

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18044?focusedWorklogId=784341=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784341 ] ASF GitHub Bot logged work on HADOOP-18044: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #4495: HADOOP-18044. Hadoop - Upgrade to jQuery 3.6.0 (#3791)

2022-06-23 Thread GitBox
steveloughran commented on PR #4495: URL: https://github.com/apache/hadoop/pull/4495#issuecomment-1164783134 merged. doesn't need yetus to validate it fully as its a cherrypick and i'd verified this branch built correctly -- This is an automated message from the Apache Git Service. To

[jira] [Work logged] (HADOOP-18044) Hadoop - Upgrade to JQuery 3.6.0

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18044?focusedWorklogId=784340=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784340 ] ASF GitHub Bot logged work on HADOOP-18044: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran merged pull request #4495: HADOOP-18044. Hadoop - Upgrade to jQuery 3.6.0 (#3791)

2022-06-23 Thread GitBox
steveloughran merged PR #4495: URL: https://github.com/apache/hadoop/pull/4495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Work logged] (HADOOP-18215) Enhance WritableName to be able to return aliases for classes that use serializers

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18215?focusedWorklogId=784339=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784339 ] ASF GitHub Bot logged work on HADOOP-18215: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-18303) Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18303?focusedWorklogId=784338=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784338 ] ASF GitHub Bot logged work on HADOOP-18303: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4215: HADOOP-18215. Enhance WritableName to be able to return aliases for classes that use serializers

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4215: URL: https://github.com/apache/hadoop/pull/4215#issuecomment-1164781759 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

2022-06-23 Thread GitBox
ayushtkn commented on PR #4461: URL: https://github.com/apache/hadoop/pull/4461#issuecomment-1164781602 Both shading and the issue that I am talking about are due to HADOOP-18033 Jackson upgrade added a rs-api jar which is not shaded and which all cause conflicts in Tez jsr311 jar

[jira] [Work logged] (HADOOP-18311) Upgrade dependencies to address several CVEs

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18311?focusedWorklogId=784335=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784335 ] ASF GitHub Bot logged work on HADOOP-18311: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #4491: HADOOP-18311. Upgrade dependencies to address several CVEs

2022-06-23 Thread GitBox
steveloughran commented on PR #4491: URL: https://github.com/apache/hadoop/pull/4491#issuecomment-1164763274 sorry, i confused jetty with jersey. don't know how jetty is on branch 3.3. it is not quite as bad as that jersey thing. -- This is an automated message from the Apache Git

[jira] [Work logged] (HADOOP-18303) Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18303?focusedWorklogId=784332=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784332 ] ASF GitHub Bot logged work on HADOOP-18303: --- Author: ASF GitHub Bot

[GitHub] [hadoop] sunchao commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

2022-06-23 Thread GitBox
sunchao commented on PR #4461: URL: https://github.com/apache/hadoop/pull/4461#issuecomment-1164752328 > @sunchao It doesn't, that is what I was saying, even if we sort the shading issue, the Tez issue is gonna stay because it doesn't use the shaded Jar and gets both these jars in

[jira] [Work logged] (HADOOP-18215) Enhance WritableName to be able to return aliases for classes that use serializers

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18215?focusedWorklogId=784308=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784308 ] ASF GitHub Bot logged work on HADOOP-18215: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4215: HADOOP-18215. Enhance WritableName to be able to return aliases for classes that use serializers

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4215: URL: https://github.com/apache/hadoop/pull/4215#issuecomment-1164645318 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4450: YARN-11183. Federation: Remove outdated ApplicationHomeSubCluster in …

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4450: URL: https://github.com/apache/hadoop/pull/4450#issuecomment-1164643178 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-06-23 Thread GitBox
steveloughran commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r905241976 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/MultipleOutputs.java: ## @@

[GitHub] [hadoop] PrabhuJoseph merged pull request #4487: YARN-9874.Remove unnecessary LevelDb write call in LeveldbConfigurationStore#confirmMutation

2022-06-23 Thread GitBox
PrabhuJoseph merged PR #4487: URL: https://github.com/apache/hadoop/pull/4487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] PrabhuJoseph merged pull request #4486: YARN-10320.Replace FSDataInputStream#read with readFully in Log Aggregation

2022-06-23 Thread GitBox
PrabhuJoseph merged PR #4486: URL: https://github.com/apache/hadoop/pull/4486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] PrabhuJoseph commented on pull request #4486: YARN-10320.Replace FSDataInputStream#read with readFully in Log Aggregation

2022-06-23 Thread GitBox
PrabhuJoseph commented on PR #4486: URL: https://github.com/apache/hadoop/pull/4486#issuecomment-1164625426 Latest Patch looks good, +1. Will commit it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] hadoop-yetus commented on pull request #4464: YARN-11169. Support moveApplicationAcrossQueues, getQueueInfo API's for Federation.

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4464: URL: https://github.com/apache/hadoop/pull/4464#issuecomment-1164612891 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4493: [Do not commit] Testing cross platform builds

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4493: URL: https://github.com/apache/hadoop/pull/4493#issuecomment-1164571030 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18246) Remove lower limit on s3a prefetching/caching block size

2022-06-23 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558139#comment-17558139 ] Daniel Carl Jones commented on HADOOP-18246: I think it'd be reasonable to allow a block

[jira] [Assigned] (HADOOP-18246) Remove lower limit on s3a prefetching/caching block size

2022-06-23 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Carl Jones reassigned HADOOP-18246: -- Assignee: Daniel Carl Jones > Remove lower limit on s3a prefetching/caching

[GitHub] [hadoop] ZanderXu commented on pull request #4480: HDFS-16638. Add isDebugEnabled check for debug blockLogs in BlockManager

2022-06-23 Thread GitBox
ZanderXu commented on PR #4480: URL: https://github.com/apache/hadoop/pull/4480#issuecomment-1164537396 you can also refer to [logging_performance](https://www.slf4j.org/faq.html#logging_performance). -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] ZanderXu commented on pull request #4480: HDFS-16638. Add isDebugEnabled check for debug blockLogs in BlockManager

2022-06-23 Thread GitBox
ZanderXu commented on PR #4480: URL: https://github.com/apache/hadoop/pull/4480#issuecomment-1164531835 Thanks @cxzl25 for your comment. [HDFS-14103](https://issues.apache.org/jira/browse/HDFS-14103) is getting rid of the call of LOG.isDebugEnabled() by SLF4J API, can you take a look?

[jira] [Work logged] (HADOOP-13126) Add Brotli compression codec

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13126?focusedWorklogId=784249=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784249 ] ASF GitHub Bot logged work on HADOOP-13126: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2723: HADOOP-13126 Add BrotliCodec based on Brotli4j library

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #2723: URL: https://github.com/apache/hadoop/pull/2723#issuecomment-1164492256 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18304) Improve S3A committers documentation clarity

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?focusedWorklogId=784246=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784246 ] ASF GitHub Bot logged work on HADOOP-18304: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4478: HADOOP-18304. Improve user-facing S3A committers documentation

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4478: URL: https://github.com/apache/hadoop/pull/4478#issuecomment-1164488192 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] cxzl25 commented on pull request #4480: HDFS-16638. Add isDebugEnabled check for debug blockLogs in BlockManager

2022-06-23 Thread GitBox
cxzl25 commented on PR #4480: URL: https://github.com/apache/hadoop/pull/4480#issuecomment-1164455182 > Thanks @cxzl25 for your patch. I have a question about it and looking forward your feedback. Can this change improve the namenode performance? I see that some places specially remove

[jira] [Commented] (HADOOP-17725) Improve error message for token providers in ABFS

2022-06-23 Thread Carl (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558102#comment-17558102 ] Carl commented on HADOOP-17725: --- The changes related to this ticket force to set optional fields and

[GitHub] [hadoop] hadoop-yetus commented on pull request #4493: [Do not commit] Testing cross platform builds

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4493: URL: https://github.com/apache/hadoop/pull/4493#issuecomment-1164424317 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18311) Upgrade dependencies to address several CVEs

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18311?focusedWorklogId=784220=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784220 ] ASF GitHub Bot logged work on HADOOP-18311: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #4491: HADOOP-18311. Upgrade dependencies to address several CVEs

2022-06-23 Thread GitBox
steveloughran commented on PR #4491: URL: https://github.com/apache/hadoop/pull/4491#issuecomment-1164417288 (you are going to hate me here. sorry) First, please let's not have "update a few dependency" patches. Is it not a useful title and by updating multiple dependencies

[jira] [Work logged] (HADOOP-18044) Hadoop - Upgrade to JQuery 3.6.0

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18044?focusedWorklogId=784214=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784214 ] ASF GitHub Bot logged work on HADOOP-18044: --- Author: ASF GitHub Bot

[GitHub] [hadoop] ashutoshcipher commented on pull request #4495: HADOOP-18044. Hadoop - Upgrade to jQuery 3.6.0 (#3791)

2022-06-23 Thread GitBox
ashutoshcipher commented on PR #4495: URL: https://github.com/apache/hadoop/pull/4495#issuecomment-1164401081 LGTM +1 (Jenkins pending) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Work logged] (HADOOP-18304) Improve S3A committers documentation clarity

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?focusedWorklogId=784210=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784210 ] ASF GitHub Bot logged work on HADOOP-18304: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4478: HADOOP-18304. Improve user-facing S3A committers documentation

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4478: URL: https://github.com/apache/hadoop/pull/4478#issuecomment-1164395425 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18305) Release Hadoop 3.3.4: minor update of hadoop-3.3.3

2022-06-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558054#comment-17558054 ] Steve Loughran commented on HADOOP-18305: - HADOOP-18044 is now part of the changes of this

[jira] [Updated] (HADOOP-18044) Hadoop - Upgrade to JQuery 3.6.0

2022-06-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18044: Fix Version/s: 3.3.4 (was: 3.3.9) > Hadoop - Upgrade to JQuery

[GitHub] [hadoop] hadoop-yetus commented on pull request #4494: fix bug for MAPREDUCE-7392 bug for GzipCodec in native task

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4494: URL: https://github.com/apache/hadoop/pull/4494#issuecomment-1164353778 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-13126) Add Brotli compression codec

2022-06-23 Thread Martin Tzvetanov Grigorov (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558037#comment-17558037 ] Martin Tzvetanov Grigorov commented on HADOOP-13126: [~ste...@apache.org] Rebased

[GitHub] [hadoop] hadoop-yetus commented on pull request #4486: YARN-10320.Replace FSDataInputStream#read with readFully in Log Aggregation

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4486: URL: https://github.com/apache/hadoop/pull/4486#issuecomment-1164319691 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18304) Improve S3A committers documentation clarity

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?focusedWorklogId=784159=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784159 ] ASF GitHub Bot logged work on HADOOP-18304: --- Author: ASF GitHub Bot

[GitHub] [hadoop] dannycjones commented on pull request #4478: HADOOP-18304. Improve user-facing S3A committers documentation

2022-06-23 Thread GitBox
dannycjones commented on PR #4478: URL: https://github.com/apache/hadoop/pull/4478#issuecomment-1164304062 @ahmarsuhail, I've updated based on your feedback. Thanks for reviewing it with such detail. I've put the changes for things like missing `.` in separate commit

[jira] [Work logged] (HADOOP-18258) Merging of S3A Audit Logs

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18258?focusedWorklogId=784156=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784156 ] ASF GitHub Bot logged work on HADOOP-18258: --- Author: ASF GitHub Bot

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-06-23 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r904912305 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/AuditTool.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Work logged] (HADOOP-18304) Improve S3A committers documentation clarity

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?focusedWorklogId=784154=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784154 ] ASF GitHub Bot logged work on HADOOP-18304: --- Author: ASF GitHub Bot

[GitHub] [hadoop] dannycjones commented on a diff in pull request #4478: HADOOP-18304. Improve user-facing S3A committers documentation

2022-06-23 Thread GitBox
dannycjones commented on code in PR #4478: URL: https://github.com/apache/hadoop/pull/4478#discussion_r904911780 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/committers.md: ## @@ -474,7 +466,7 @@ files which do not contain relevant data. What the partitioned

[jira] [Work logged] (HADOOP-18304) Improve S3A committers documentation clarity

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?focusedWorklogId=784149=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784149 ] ASF GitHub Bot logged work on HADOOP-18304: --- Author: ASF GitHub Bot

[GitHub] [hadoop] dannycjones commented on a diff in pull request #4478: HADOOP-18304. Improve user-facing S3A committers documentation

2022-06-23 Thread GitBox
dannycjones commented on code in PR #4478: URL: https://github.com/apache/hadoop/pull/4478#discussion_r904905036 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/committers.md: ## @@ -165,6 +165,7 @@ that the network has partitioned and that they must abort their

[GitHub] [hadoop] hadoop-yetus commented on pull request #4493: [Do not commit] Testing cross platform builds

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4493: URL: https://github.com/apache/hadoop/pull/4493#issuecomment-1164285346 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-17461) Add thread-level IOStatistics Context

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17461?focusedWorklogId=784144=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784144 ] ASF GitHub Bot logged work on HADOOP-17461: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4352: HADOOP-17461. Thread-level IOStatistics in S3A

2022-06-23 Thread GitBox
hadoop-yetus commented on PR #4352: URL: https://github.com/apache/hadoop/pull/4352#issuecomment-1164284637 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18044) Hadoop - Upgrade to JQuery 3.6.0

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18044?focusedWorklogId=784139=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784139 ] ASF GitHub Bot logged work on HADOOP-18044: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-18304) Improve S3A committers documentation clarity

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?focusedWorklogId=784140=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784140 ] ASF GitHub Bot logged work on HADOOP-18304: --- Author: ASF GitHub Bot

[GitHub] [hadoop] dannycjones commented on a diff in pull request #4478: HADOOP-18304. Improve user-facing S3A committers documentation

2022-06-23 Thread GitBox
dannycjones commented on code in PR #4478: URL: https://github.com/apache/hadoop/pull/4478#discussion_r904894123 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/committers.md: ## @@ -283,40 +281,37 @@ new data to an existing partitioned directory tree is a common

[GitHub] [hadoop] steveloughran opened a new pull request, #4495: HADOOP-18044. Hadoop - Upgrade to jQuery 3.6.0 (#3791)

2022-06-23 Thread GitBox
steveloughran opened a new pull request, #4495: URL: https://github.com/apache/hadoop/pull/4495 Co-authored-by: luoyuan (cherry picked from commit e2d620192aa0b712d05e4092eb63ef2ccdcd8220) -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Work logged] (HADOOP-18304) Improve S3A committers documentation clarity

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?focusedWorklogId=784138=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784138 ] ASF GitHub Bot logged work on HADOOP-18304: --- Author: ASF GitHub Bot

[GitHub] [hadoop] dannycjones commented on a diff in pull request #4478: HADOOP-18304. Improve user-facing S3A committers documentation

2022-06-23 Thread GitBox
dannycjones commented on code in PR #4478: URL: https://github.com/apache/hadoop/pull/4478#discussion_r904893346 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/committers.md: ## @@ -492,18 +484,19 @@ was written. With the policy of `append`, the new file would

[jira] [Work logged] (HADOOP-18304) Improve S3A committers documentation clarity

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?focusedWorklogId=784137=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784137 ] ASF GitHub Bot logged work on HADOOP-18304: --- Author: ASF GitHub Bot

[GitHub] [hadoop] dannycjones commented on a diff in pull request #4478: HADOOP-18304. Improve user-facing S3A committers documentation

2022-06-23 Thread GitBox
dannycjones commented on code in PR #4478: URL: https://github.com/apache/hadoop/pull/4478#discussion_r904889810 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/committers.md: ## @@ -650,7 +639,14 @@ Conflict management is left to the execution engine itself.

[GitHub] [hadoop] ZanderXu commented on pull request #4480: HDFS-16638. Add isDebugEnabled check for debug blockLogs in BlockManager

2022-06-23 Thread GitBox
ZanderXu commented on PR #4480: URL: https://github.com/apache/hadoop/pull/4480#issuecomment-1164270092 Thanks @cxzl25 for your patch. I have a question about it and looking forward your feedback. Can this change improve the namenode performance? I see that some places specially remove

[jira] [Work logged] (HADOOP-18304) Improve S3A committers documentation clarity

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?focusedWorklogId=784134=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784134 ] ASF GitHub Bot logged work on HADOOP-18304: --- Author: ASF GitHub Bot

[GitHub] [hadoop] dannycjones commented on a diff in pull request #4478: HADOOP-18304. Improve user-facing S3A committers documentation

2022-06-23 Thread GitBox
dannycjones commented on code in PR #4478: URL: https://github.com/apache/hadoop/pull/4478#discussion_r904883423 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/committers.md: ## @@ -530,18 +527,22 @@ performance. ### Enabling the committer +Set the committer

[GitHub] [hadoop] cfg1234 opened a new pull request, #4494: fix bug for MAPREDUCE-7392 bug for GzipCodec in native task

2022-06-23 Thread GitBox
cfg1234 opened a new pull request, #4494: URL: https://github.com/apache/hadoop/pull/4494 I found that inflateReset is not called after inflate return Z_STREAM_END.When Z_STREAM_END is returned after an inflate() method is called,the next inflate() call does not consume any input data and

[GitHub] [hadoop] ayushtkn commented on pull request #4488: HDFS-16640. RBF: Show datanode IP list when click DN histogram in Router

2022-06-23 Thread GitBox
ayushtkn commented on PR #4488: URL: https://github.com/apache/hadoop/pull/4488#issuecomment-1164231208 >it would be good to extract some if this common code. Not an expert with Javascript either, but I feel this should be possible. If we extract all these common methods into some

[jira] [Work logged] (HADOOP-18304) Improve S3A committers documentation clarity

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?focusedWorklogId=784113=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784113 ] ASF GitHub Bot logged work on HADOOP-18304: --- Author: ASF GitHub Bot

[GitHub] [hadoop] ahmarsuhail commented on a diff in pull request #4478: HADOOP-18304. Improve user-facing S3A committers documentation

2022-06-23 Thread GitBox
ahmarsuhail commented on code in PR #4478: URL: https://github.com/apache/hadoop/pull/4478#discussion_r902757105 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/committers.md: ## @@ -88,17 +88,17 @@ proportional to the amount of data created. It still can't

[GitHub] [hadoop] ashutoshcipher commented on pull request #4486: YARN-10320.Replace FSDataInputStream#read with readFully in Log Aggregation

2022-06-23 Thread GitBox
ashutoshcipher commented on PR #4486: URL: https://github.com/apache/hadoop/pull/4486#issuecomment-1164222830 > Thanks @ashutoshcipher for the patch. There is one more reference to read() at 804. Can you validate that as well. > > ` int actualLength =

[jira] [Work logged] (HADOOP-18292) s3a storage class reduced redundancy breaks s3 select tests

2022-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18292?focusedWorklogId=784109=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784109 ] ASF GitHub Bot logged work on HADOOP-18292: --- Author: ASF GitHub Bot

  1   2   >