[GitHub] [hadoop] hadoop-yetus commented on pull request #4814: YARN-11284. [Federation] Improve UnmanagedAMPoolManager WithoutBlock ServiceStop

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4814: URL: https://github.com/apache/hadoop/pull/4814#issuecomment-1231150099 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] PrabhuJoseph merged pull request #4742: YARN-11196. NUMA support in DCE

2022-08-29 Thread GitBox
PrabhuJoseph merged PR #4742: URL: https://github.com/apache/hadoop/pull/4742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18391) Improve VectoredReadUtils

2022-08-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597520#comment-17597520 ] ASF GitHub Bot commented on HADOOP-18391: - hadoop-yetus commented on PR #4787: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4787: HADOOP-18391. Improvements in VectoredReadUtils#readVectored() for direct buffers

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4787: URL: https://github.com/apache/hadoop/pull/4787#issuecomment-1231131204 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4810: YARN-6667. Handle containerId duplicate without failing the heartbeat in Federation Interceptor.

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4810: URL: https://github.com/apache/hadoop/pull/4810#issuecomment-1231126792 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r957975795 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r957975795 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r957975795 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r957972961 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r957972465 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r957969979 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/client/impl/pb/YARNDelegationTokenIdentifierPBImpl.java: ## @@ -0,0

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4814: YARN-11284. [Federation] Improve UnmanagedAMPoolManager WithoutBlock ServiceStop

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4814: URL: https://github.com/apache/hadoop/pull/4814#discussion_r957953877 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/uam/UnmanagedAMPoolManager.java: ## @@

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4814: YARN-11284. [Federation] Improve UnmanagedAMPoolManager WithoutBlock ServiceStop

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4814: URL: https://github.com/apache/hadoop/pull/4814#discussion_r957953877 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/uam/UnmanagedAMPoolManager.java: ## @@

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4764: URL: https://github.com/apache/hadoop/pull/4764#discussion_r957947734 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:

[GitHub] [hadoop] ZanderXu commented on pull request #4813: HDFS-16748. DFSClient should uniquely identify writing files by namespace id and iNodeId via RBF

2022-08-29 Thread GitBox
ZanderXu commented on PR #4813: URL: https://github.com/apache/hadoop/pull/4813#issuecomment-1231069442 @tomscut @ayushtkn @Hexiaoqiao Hi, masters, can you help me review this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4764: URL: https://github.com/apache/hadoop/pull/4764#discussion_r957946915 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4764: URL: https://github.com/apache/hadoop/pull/4764#discussion_r957946401 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4810: YARN-6667. Handle containerId duplicate without failing the heartbeat in Federation Interceptor.

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4810: URL: https://github.com/apache/hadoop/pull/4810#discussion_r957943343 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4810: YARN-6667. Handle containerId duplicate without failing the heartbeat in Federation Interceptor.

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4810: URL: https://github.com/apache/hadoop/pull/4810#discussion_r957943189 ##

[GitHub] [hadoop] tomscut commented on a diff in pull request #4821: HDFS-16750. NameNode should use NameNode.getRemoteUser() to log audit event to avoid possible NPE

2022-08-29 Thread GitBox
tomscut commented on code in PR #4821: URL: https://github.com/apache/hadoop/pull/4821#discussion_r957937885 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -1439,7 +1440,7 @@ private void checkSuperuserPrivilege()

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4821: HDFS-16750. NameNode should use NameNode.getRemoteUser() to log audit event to avoid possible NPE

2022-08-29 Thread GitBox
ZanderXu commented on code in PR #4821: URL: https://github.com/apache/hadoop/pull/4821#discussion_r957930476 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -1439,7 +1440,7 @@ private void checkSuperuserPrivilege()

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4821: HDFS-16750. NameNode should use NameNode.getRemoteUser() to log audit event to avoid possible NPE

2022-08-29 Thread GitBox
ZanderXu commented on code in PR #4821: URL: https://github.com/apache/hadoop/pull/4821#discussion_r957930476 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -1439,7 +1440,7 @@ private void checkSuperuserPrivilege()

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4821: HDFS-16750. NameNode should use NameNode.getRemoteUser() to log audit event to avoid possible NPE

2022-08-29 Thread GitBox
ZanderXu commented on code in PR #4821: URL: https://github.com/apache/hadoop/pull/4821#discussion_r957930476 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -1439,7 +1440,7 @@ private void checkSuperuserPrivilege()

[GitHub] [hadoop] hadoop-yetus commented on pull request #4824: YARN-11286. Make AsyncDispatcher#printEventDetailsExecutor thread pool parameter configurable.

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4824: URL: https://github.com/apache/hadoop/pull/4824#issuecomment-1231030004 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] tomscut commented on a diff in pull request #4821: HDFS-16750. NameNode should use NameNode.getRemoteUser() to log audit event to avoid possible NPE

2022-08-29 Thread GitBox
tomscut commented on code in PR #4821: URL: https://github.com/apache/hadoop/pull/4821#discussion_r957913810 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -1439,7 +1440,7 @@ private void checkSuperuserPrivilege()

[GitHub] [hadoop] omalley commented on a diff in pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

2022-08-29 Thread GitBox
omalley commented on code in PR #4311: URL: https://github.com/apache/hadoop/pull/4311#discussion_r957851531 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java: ## @@ -37,8 +37,17 @@ @InterfaceStability.Evolving public class

[jira] [Commented] (HADOOP-18391) Improve VectoredReadUtils

2022-08-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597430#comment-17597430 ] ASF GitHub Bot commented on HADOOP-18391: - hadoop-yetus commented on PR #4787: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4787: HADOOP-18391. Improvements in VectoredReadUtils#readVectored() for direct buffers

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4787: URL: https://github.com/apache/hadoop/pull/4787#issuecomment-1230966537 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 opened a new pull request, #4824: YARN-11286. Make AsyncDispatcher#printEventDetailsExecutor thread pool parameter configurable.

2022-08-29 Thread GitBox
slfan1989 opened a new pull request, #4824: URL: https://github.com/apache/hadoop/pull/4824 JIRA: YARN-11286. Make AsyncDispatcher#printEventDetailsExecutor thread pool parameter configurable. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] hadoop-yetus commented on pull request #4784: HDFS-16737. Fix number of threads in FsDatasetAsyncDiskService#addExecutorForVolume

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4784: URL: https://github.com/apache/hadoop/pull/4784#issuecomment-1230901326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4814: YARN-11284. [Federation] Improve UnmanagedAMPoolManager WithoutBlock ServiceStop

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4814: URL: https://github.com/apache/hadoop/pull/4814#discussion_r957817189 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/uam/UnmanagedAMPoolManager.java: ## @@

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4814: YARN-11284. [Federation] Improve UnmanagedAMPoolManager WithoutBlock ServiceStop

2022-08-29 Thread GitBox
slfan1989 commented on code in PR #4814: URL: https://github.com/apache/hadoop/pull/4814#discussion_r957817304 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/uam/TestUnmanagedApplicationManager.java:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4353: HDFS-16593. Correct the BlocksRemoved metric on DataNode side

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4353: URL: https://github.com/apache/hadoop/pull/4353#issuecomment-1230822376 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4821: HDFS-16750. NameNode should use NameNode.getRemoteUser() to log audit event to avoid possible NPE

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4821: URL: https://github.com/apache/hadoop/pull/4821#issuecomment-1230718403 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4817: URL: https://github.com/apache/hadoop/pull/4817#issuecomment-1230645244 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17458) S3A to treat "SdkClientException: Data read has a different length than the expected" as EOFException

2022-08-29 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597298#comment-17597298 ] Prabhu Joseph commented on HADOOP-17458: [~ste...@apache.org] A flink job which reads data from

[GitHub] [hadoop] goiri commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-29 Thread GitBox
goiri commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r957557488 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/client/impl/pb/YARNDelegationTokenIdentifierPBImpl.java: ## @@ -0,0

[GitHub] [hadoop] goiri commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-29 Thread GitBox
goiri commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r957556044 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:

[GitHub] [hadoop] goiri commented on a diff in pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

2022-08-29 Thread GitBox
goiri commented on code in PR #4764: URL: https://github.com/apache/hadoop/pull/4764#discussion_r957553830 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:

[GitHub] [hadoop] goiri commented on a diff in pull request #4814: YARN-11284. [Federation] Improve UnmanagedAMPoolManager WithoutBlock ServiceStop

2022-08-29 Thread GitBox
goiri commented on code in PR #4814: URL: https://github.com/apache/hadoop/pull/4814#discussion_r957551298 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/uam/UnmanagedAMPoolManager.java: ## @@ -501,4

[GitHub] [hadoop] goiri commented on a diff in pull request #4810: YARN-6667. Handle containerId duplicate without failing the heartbeat in Federation Interceptor.

2022-08-29 Thread GitBox
goiri commented on code in PR #4810: URL: https://github.com/apache/hadoop/pull/4810#discussion_r957544974 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.java:

[GitHub] [hadoop] goiri commented on a diff in pull request #4820: BPServiceActor to provide new thread to handle IBR

2022-08-29 Thread GitBox
goiri commented on code in PR #4820: URL: https://github.com/apache/hadoop/pull/4820#discussion_r957541656 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java: ## @@ -135,6 +142,10 @@ static enum RunningState {

[jira] [Commented] (HADOOP-18429) MutableGaugeFloat#incr(float) get stuck in an infinite loop

2022-08-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597253#comment-17597253 ] ASF GitHub Bot commented on HADOOP-18429: - hadoop-yetus commented on PR #4823: URL:

[jira] [Updated] (HADOOP-18429) MutableGaugeFloat#incr(float) get stuck in an infinite loop

2022-08-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18429: Labels: pull-request-available (was: ) > MutableGaugeFloat#incr(float) get stuck in an

[GitHub] [hadoop] hadoop-yetus commented on pull request #4823: HADOOP-18429. fix infinite loop in MutableGaugeFloat#incr(float)

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4823: URL: https://github.com/apache/hadoop/pull/4823#issuecomment-1230470576 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-29 Thread GitBox
slfan1989 commented on PR #4746: URL: https://github.com/apache/hadoop/pull/4746#issuecomment-1230414220 @goiri Please help to review the code again, Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] slfan1989 commented on pull request #4810: YARN-6667. Handle containerId duplicate without failing the heartbeat in Federation Interceptor.

2022-08-29 Thread GitBox
slfan1989 commented on PR #4810: URL: https://github.com/apache/hadoop/pull/4810#issuecomment-1230413309 @goiri Please help to review the code again, Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] slfan1989 commented on pull request #4781: YARN-11272. Federation StateStore: Support storage/retrieval of Reservations With Zk.

2022-08-29 Thread GitBox
slfan1989 commented on PR #4781: URL: https://github.com/apache/hadoop/pull/4781#issuecomment-1230410501 @goiri Can you help to merge this pr into trunk branch? I will continue to follow up on YARN-11273, which requires part of the pr junit test. Thank you very much! -- This is an

[GitHub] [hadoop] hadoop-yetus commented on pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4817: URL: https://github.com/apache/hadoop/pull/4817#issuecomment-1230403358 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ZanderXu commented on pull request #4784: HDFS-16737. Fix number of threads in FsDatasetAsyncDiskService#addExecutorForVolume

2022-08-29 Thread GitBox
ZanderXu commented on PR #4784: URL: https://github.com/apache/hadoop/pull/4784#issuecomment-1230394854 @ayushtkn Thanks for your review. About [HDFS-16386](https://issues.apache.org/jira/browse/HDFS-16386), the increased memory maybe caused by the stacked async deletion takes, increasing

[jira] [Commented] (HADOOP-16674) TestDNS.testRDNS can fail with ServiceUnavailableException

2022-08-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597210#comment-17597210 ] ASF GitHub Bot commented on HADOOP-16674: - ashutoshcipher commented on PR #4802: URL:

[GitHub] [hadoop] ashutoshcipher commented on pull request #4802: HADOOP-16674. Fix when TestDNS.testRDNS can fail with ServiceUnavailableException

2022-08-29 Thread GitBox
ashutoshcipher commented on PR #4802: URL: https://github.com/apache/hadoop/pull/4802#issuecomment-1230362653 @ayushtkn, Please help in reviewing the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-08-29 Thread GitBox
ashutoshcipher commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r957377566 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/MultipleOutputs.java: ## @@ -527,9

[GitHub] [hadoop] ashutoshcipher commented on pull request #4816: MAPREDUCE-7409. Make shuffle key length configurable

2022-08-29 Thread GitBox
ashutoshcipher commented on PR #4816: URL: https://github.com/apache/hadoop/pull/4816#issuecomment-1230349203 @9uapaw - Please help in reviewing this PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] hadoop-yetus commented on pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4817: URL: https://github.com/apache/hadoop/pull/4817#issuecomment-1230296943 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Comment Edited] (HADOOP-18159) Certificate doesn't match any of the subject alternative names: [*.s3.amazonaws.com, s3.amazonaws.com]

2022-08-29 Thread comet (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597190#comment-17597190 ] comet edited comment on HADOOP-18159 at 8/29/22 1:11 PM: - can I confirm anyone

[jira] [Comment Edited] (HADOOP-18159) Certificate doesn't match any of the subject alternative names: [*.s3.amazonaws.com, s3.amazonaws.com]

2022-08-29 Thread comet (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597190#comment-17597190 ] comet edited comment on HADOOP-18159 at 8/29/22 1:11 PM: - can I confirm anyone

[jira] [Commented] (HADOOP-18159) Certificate doesn't match any of the subject alternative names: [*.s3.amazonaws.com, s3.amazonaws.com]

2022-08-29 Thread comet (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597190#comment-17597190 ] comet commented on HADOOP-18159: can I confirm anyone successfully overcome the issue after changed to

[jira] [Assigned] (HADOOP-18429) MutableGaugeFloat#incr(float) get stuck in an infinite loop

2022-08-29 Thread groot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] groot reassigned HADOOP-18429: -- Assignee: groot > MutableGaugeFloat#incr(float) get stuck in an infinite loop >

[GitHub] [hadoop] hadoop-yetus commented on pull request #4822: DN should notify NN when client requests a missing block1

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4822: URL: https://github.com/apache/hadoop/pull/4822#issuecomment-1230220477 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4820: BPServiceActor to provide new thread to handle IBR

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4820: URL: https://github.com/apache/hadoop/pull/4820#issuecomment-1230209603 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4820: BPServiceActor to provide new thread to handle IBR

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4820: URL: https://github.com/apache/hadoop/pull/4820#issuecomment-1230183395 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18395) Performance improvement in org.apache.hadoop.io.Text#find

2022-08-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597163#comment-17597163 ] ASF GitHub Bot commented on HADOOP-18395: - huxinqiu opened a new pull request, #4823: URL:

[GitHub] [hadoop] huxinqiu opened a new pull request, #4823: HADOOP-18395. fix infinite loop in MutableGaugeFloat#incr(float)

2022-08-29 Thread GitBox
huxinqiu opened a new pull request, #4823: URL: https://github.com/apache/hadoop/pull/4823 ### Description of PR JIRA - [HADOOP-18429](https://issues.apache.org/jira/browse/HADOOP-18429) The Unit Test get stuck in an infinite loop ```java public void testMutableGaugeFloat() {

[GitHub] [hadoop] tomglliu opened a new pull request, #4822: DN should notify NN when client requests a missing block1

2022-08-29 Thread GitBox
tomglliu opened a new pull request, #4822: URL: https://github.com/apache/hadoop/pull/4822 DN should notify NN when client requests a missing block1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HADOOP-18429) MutableGaugeFloat#incr(float) get stuck in an infinite loop

2022-08-29 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18429: --- Description: The current implementation converts the value from int to float, causing the

[jira] [Created] (HADOOP-18429) MutableGaugeFloat#incr(float) get stuck in an infinite loop

2022-08-29 Thread xinqiu.hu (Jira)
xinqiu.hu created HADOOP-18429: -- Summary: MutableGaugeFloat#incr(float) get stuck in an infinite loop Key: HADOOP-18429 URL: https://issues.apache.org/jira/browse/HADOOP-18429 Project: Hadoop Common

[GitHub] [hadoop] tomglliu closed pull request #4819: DN should notify NN when client requests a missing block

2022-08-29 Thread GitBox
tomglliu closed pull request #4819: DN should notify NN when client requests a missing block URL: https://github.com/apache/hadoop/pull/4819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HADOOP-18391) Improve VectoredReadUtils

2022-08-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597151#comment-17597151 ] ASF GitHub Bot commented on HADOOP-18391: - steveloughran commented on code in PR #4787: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4787: HADOOP-18391. Improvements in VectoredReadUtils#readVectored() for direct buffers

2022-08-29 Thread GitBox
steveloughran commented on code in PR #4787: URL: https://github.com/apache/hadoop/pull/4787#discussion_r957189351 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/Function4RaisingIOE.java: ## @@ -0,0 +1,8 @@ +package

[GitHub] [hadoop] ZanderXu opened a new pull request, #4821: HDFS-16750. NameNode should use NameNode.getRemoteUser() to log audit event to avoid possible NPE

2022-08-29 Thread GitBox
ZanderXu opened a new pull request, #4821: URL: https://github.com/apache/hadoop/pull/4821 ### Description of PR NameNode should use NameNode.getRemoteUser() to log audit event to avoid possible NPE. The relate code is: ``` private void logAuditEvent(boolean succeeded,

[GitHub] [hadoop] tomglliu opened a new pull request, #4820: BPServiceActor to provide new thread to handle IBR

2022-08-29 Thread GitBox
tomglliu opened a new pull request, #4820: URL: https://github.com/apache/hadoop/pull/4820 BPServiceActor to provide new thread to handle IBR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4817: URL: https://github.com/apache/hadoop/pull/4817#issuecomment-1230121429 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] tomglliu opened a new pull request, #4819: DN should notify NN when client requests a missing block

2022-08-29 Thread GitBox
tomglliu opened a new pull request, #4819: URL: https://github.com/apache/hadoop/pull/4819 DN should notify NN when client requests a missing block -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HADOOP-18414) Replace Sets#newHashSet() and newTreeSet() with constructors directly hadoop-mapreduce

2022-08-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597066#comment-17597066 ] ASF GitHub Bot commented on HADOOP-18414: - hadoop-yetus commented on PR #4804: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4804: HADOOP-18414. Replace Sets.newHashSet() with java constructor in hadoop-map-reduce module

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4804: URL: https://github.com/apache/hadoop/pull/4804#issuecomment-1229992590 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4817: URL: https://github.com/apache/hadoop/pull/4817#issuecomment-1229906201 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18426) Improve the accuracy of MutableStat mean

2022-08-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597018#comment-17597018 ] ASF GitHub Bot commented on HADOOP-18426: - Hexiaoqiao commented on code in PR #4811: URL:

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #4811: HADOOP-18426. Improve the accuracy of MutableStat mean.

2022-08-29 Thread GitBox
Hexiaoqiao commented on code in PR #4811: URL: https://github.com/apache/hadoop/pull/4811#discussion_r956979425 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/util/SampleStat.java: ## @@ -91,7 +91,7 @@ public SampleStat add(long nSamples, double

[jira] [Commented] (HADOOP-18408) [ABFS]: Set correct value of requireRenameResilience for NonHNS-SharedKey configuration

2022-08-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597009#comment-17597009 ] ASF GitHub Bot commented on HADOOP-18408: - sreeb-msft commented on PR #4758: URL:

[GitHub] [hadoop] sreeb-msft commented on pull request #4758: HADOOP-18408. ABFS: Setting correct value of requireRenameResilience for nonHNS configuration

2022-08-29 Thread GitBox
sreeb-msft commented on PR #4758: URL: https://github.com/apache/hadoop/pull/4758#issuecomment-1229873405 > looks good. have you tested it with a hierachical fs to make sure all is good there? Yes, tested and it passes for HNS settings too. -- This is an automated message from the

[GitHub] [hadoop] tomglliu commented on pull request #4818: Branch 2.7.2

2022-08-29 Thread GitBox
tomglliu commented on PR #4818: URL: https://github.com/apache/hadoop/pull/4818#issuecomment-1229832951 DN should notify NN whene client requests a missing block -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] tomglliu commented on pull request #4818: Branch 2.7.2

2022-08-29 Thread GitBox
tomglliu commented on PR #4818: URL: https://github.com/apache/hadoop/pull/4818#issuecomment-1229832881 DN should notify NN whene client requests a missing block -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] tomglliu closed pull request #4818: Branch 2.7.2

2022-08-29 Thread GitBox
tomglliu closed pull request #4818: Branch 2.7.2 URL: https://github.com/apache/hadoop/pull/4818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] tomglliu opened a new pull request, #4818: Branch 2.7.2

2022-08-29 Thread GitBox
tomglliu opened a new pull request, #4818: URL: https://github.com/apache/hadoop/pull/4818 HADOOP-11908 .DN should notify NN whene client requests a missing block -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4314: YARN-11153. Make proxy server support YARN federation.

2022-08-29 Thread GitBox
hadoop-yetus commented on PR #4314: URL: https://github.com/apache/hadoop/pull/4314#issuecomment-122982 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 opened a new pull request, #4817: YARN-11273. [RESERVATION] Federation StateStore: Support storage/retrieval of Reservations With SQL.

2022-08-29 Thread GitBox
slfan1989 opened a new pull request, #4817: URL: https://github.com/apache/hadoop/pull/4817 JIRA: YARN-11273. [RESERVATION] Federation StateStore: Support storage/retrieval of Reservations With SQL. -- This is an automated message from the Apache Git Service. To respond to the message,