[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397341#comment-15397341
]
Stephen O'Donnell commented on HADOOP-13263:
[~arpitagarwal] Looks good to me.
> Reload
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396673#comment-15396673
]
Arpit Agarwal commented on HADOOP-13263:
[~sodonnell] can you please review the release note for
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351417#comment-15351417
]
Hudson commented on HADOOP-13263:
-
SUCCESS: Integrated in Hadoop-trunk-Commit #10021 (See
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351323#comment-15351323
]
Arpit Agarwal commented on HADOOP-13263:
+1 for the v7 patch. Thanks for working through the
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349816#comment-15349816
]
Hadoop QA commented on HADOOP-13263:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348695#comment-15348695
]
Wei-Chiu Chuang commented on HADOOP-13263:
--
Thanks for the quick response.
Re: metrics
Thanks
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348631#comment-15348631
]
Stephen O'Donnell commented on HADOOP-13263:
[~jojochuang] Thanks for the review.
{quote}
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348581#comment-15348581
]
Wei-Chiu Chuang commented on HADOOP-13263:
--
Thanks [~sodonnell] this is a good idea, and thanks
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345587#comment-15345587
]
Arpit Agarwal commented on HADOOP-13263:
Hi [~sodonnell], I will review the updated patch.
bq.
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344271#comment-15344271
]
Stephen O'Donnell commented on HADOOP-13263:
[~arpitagarwal] I got the style issues sorted,
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344210#comment-15344210
]
Hadoop QA commented on HADOOP-13263:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342983#comment-15342983
]
Hadoop QA commented on HADOOP-13263:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340554#comment-15340554
]
Hadoop QA commented on HADOOP-13263:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340131#comment-15340131
]
Arpit Agarwal commented on HADOOP-13263:
Hi [~sodonnell], the v3 patch lgtm.
Can you please fix
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337145#comment-15337145
]
Hadoop QA commented on HADOOP-13263:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336992#comment-15336992
]
Stephen O'Donnell commented on HADOOP-13263:
Thanks for the further review [~arpitagarwal].
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336819#comment-15336819
]
Hadoop QA commented on HADOOP-13263:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336748#comment-15336748
]
Arpit Agarwal commented on HADOOP-13263:
Thank you for the updated patch [~sodonnell]. This is
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334734#comment-15334734
]
Stephen O'Donnell commented on HADOOP-13263:
[~arpitagarwal] I have attached a version 2 of
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332594#comment-15332594
]
Arpit Agarwal commented on HADOOP-13263:
Yes they can be private members of the Groups class,
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332575#comment-15332575
]
Stephen O'Donnell commented on HADOOP-13263:
Thanks for the review. I have implemented 1 -
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330817#comment-15330817
]
Arpit Agarwal commented on HADOOP-13263:
The patch looks good, thanks for contributing it.
A
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330214#comment-15330214
]
Stephen O'Donnell commented on HADOOP-13263:
??So the difference in behavior is that after
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330167#comment-15330167
]
Arpit Agarwal commented on HADOOP-13263:
Thanks for the explanation. So the difference in
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330018#comment-15330018
]
Stephen O'Donnell commented on HADOOP-13263:
[~arpitagarwal] I looked into this a bit
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328465#comment-15328465
]
Arpit Agarwal commented on HADOOP-13263:
bq. I wonder if we totally expired keys when the LDAP
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328379#comment-15328379
]
Stephen O'Donnell commented on HADOOP-13263:
I have uploaded a first cut of these changes
[
https://issues.apache.org/jira/browse/HADOOP-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328292#comment-15328292
]
Arpit Agarwal commented on HADOOP-13263:
Hi [~sodonnell], this sounds like a great idea. We
28 matches
Mail list logo
