[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525976#comment-16525976
]
Hudson commented on HADOOP-14313:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14493 (See
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525954#comment-16525954
]
Vikas Vishwakarma commented on HADOOP-14313:
Thanks [~ajisakaa] !
> Replace/improve
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501417#comment-16501417
]
Akira Ajisaka commented on HADOOP-14313:
LGTM, +1
> Replace/improve Hadoop's byte[] comparator
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445360#comment-16445360
]
genericqa commented on HADOOP-14313:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293387#comment-16293387
]
genericqa commented on HADOOP-14313:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104363#comment-16104363
]
Hadoop QA commented on HADOOP-14313:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024771#comment-16024771
]
Steve Loughran commented on HADOOP-14313:
-
Not been reviewing anything for the last fortnight,
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019148#comment-16019148
]
Vikas Vishwakarma commented on HADOOP-14313:
[~busbey] [~steve_l] do let me know if there
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004226#comment-16004226
]
Vikas Vishwakarma commented on HADOOP-14313:
[~busbey] [~steve_l] updated the patch for
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002615#comment-16002615
]
Hadoop QA commented on HADOOP-14313:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002506#comment-16002506
]
Hadoop QA commented on HADOOP-14313:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002040#comment-16002040
]
Hadoop QA commented on HADOOP-14313:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989818#comment-15989818
]
Vikas Vishwakarma commented on HADOOP-14313:
[~busbey] added the LICENSE/NOTICE info in
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989810#comment-15989810
]
Hadoop QA commented on HADOOP-14313:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989794#comment-15989794
]
Hadoop QA commented on HADOOP-14313:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989055#comment-15989055
]
Sean Busbey commented on HADOOP-14313:
--
We should update LICENSE/NOTICE about copying this from
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988802#comment-15988802
]
Hadoop QA commented on HADOOP-14313:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988626#comment-15988626
]
Hadoop QA commented on HADOOP-14313:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988619#comment-15988619
]
Vikas Vishwakarma commented on HADOOP-14313:
[~busbey] did not find ByteBuffer version in
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981377#comment-15981377
]
Sean Busbey commented on HADOOP-14313:
--
I don't suppose it has a ByteBuffer version or the like?
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981374#comment-15981374
]
Sean Busbey commented on HADOOP-14313:
--
definitely no copying of arrays just so we can use the
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981047#comment-15981047
]
Vikas Vishwakarma commented on HADOOP-14313:
[~busbey] [~ste...@apache.org] was looking at
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979767#comment-15979767
]
Vikas Vishwakarma commented on HADOOP-14313:
yep will go through all the compare calls
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978676#comment-15978676
]
Steve Loughran commented on HADOOP-14313:
-
if there's work in comparing array offsets, assume
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978048#comment-15978048
]
Vikas Vishwakarma commented on HADOOP-14313:
[~busbey] I was looking at the changes to
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977299#comment-15977299
]
Sean Busbey commented on HADOOP-14313:
--
I'd favor moving to the Guava one. It's not flagged Beta,
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973581#comment-15973581
]
Steve Loughran commented on HADOOP-14313:
-
Looking at the hadoop code, that was lifted from
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972904#comment-15972904
]
Vikas Vishwakarma commented on HADOOP-14313:
I have updated the microbenchmark result table
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972781#comment-15972781
]
Sean Busbey commented on HADOOP-14313:
--
I meant how the microbenchmark did, but 10-15% on a macro
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972668#comment-15972668
]
Vikas Vishwakarma commented on HADOOP-14313:
[~busbey] In test (ycsb, local tests) we are
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971048#comment-15971048
]
Sean Busbey commented on HADOOP-14313:
--
What's the comparison look like after the patch?
Why don't
[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970603#comment-15970603
]
Vikas Vishwakarma commented on HADOOP-14313:
These microbenchmarks are calculated using JMH,
32 matches
Mail list logo
