mukund-thakur commented on a change in pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#discussion_r427053193
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestAbfsStatistics.java
##
@@ -23,9 +23,16 @@
import
mukund-thakur commented on a change in pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#discussion_r427053540
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestAbfsStatistics.java
##
@@ -34,33 +41,24 @@ public
mukund-thakur commented on a change in pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#discussion_r427052492
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##
@@ -133,59 +159,48 @@ public void
mukund-thakur commented on a change in pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#discussion_r427052757
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##
@@ -200,41 +215,29 @@ public void
mukund-thakur commented on a change in pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#discussion_r427052835
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##
@@ -249,32 +252,44 @@ public void
mehakmeet commented on a change in pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#discussion_r427058041
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##
@@ -32,10 +32,54 @@
public class
mehakmeet commented on a change in pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#discussion_r427058232
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##
@@ -133,59 +159,48 @@ public void
mehakmeet commented on a change in pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#discussion_r427058316
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestAbfsStatistics.java
##
@@ -34,33 +41,24 @@ public
mukund-thakur commented on a change in pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#discussion_r427051819
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##
@@ -32,10 +32,54 @@
public class
aajisaka commented on pull request #2018:
URL: https://github.com/apache/hadoop/pull/2018#issuecomment-630708532
LGTM, +1 pending Jenkins.
In the precommit job, docker build failed due to unstable internet
connection.
```
17:31:24 Reading package lists...
17:31:24 [91mW:
[
https://issues.apache.org/jira/browse/HADOOP-17049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akira Ajisaka reassigned HADOOP-17049:
--
Assignee: Akira Ajisaka
> javax.activation-api and jakarta.activation-api define
[
https://issues.apache.org/jira/browse/HADOOP-17049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akira Ajisaka updated HADOOP-17049:
---
Status: Patch Available (was: Open)
> javax.activation-api and jakarta.activation-api
aajisaka opened a new pull request #2027:
URL: https://github.com/apache/hadoop/pull/2027
JIRA: https://issues.apache.org/jira/browse/HADOOP-17049
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/HADOOP-17049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110943#comment-17110943
]
Akira Ajisaka commented on HADOOP-17049:
Thank you for your information, [~weichiu].
It seems
hadoop-yetus commented on pull request #2018:
URL: https://github.com/apache/hadoop/pull/2018#issuecomment-630670815
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HADOOP-17049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111041#comment-17111041
]
Akira Ajisaka commented on HADOOP-17049:
bq. it was required to support JDK11
Yes, I think
hadoop-yetus commented on pull request #2018:
URL: https://github.com/apache/hadoop/pull/2018#issuecomment-630748032
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 22m
hadoop-yetus commented on pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#issuecomment-630766152
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 22m
hadoop-yetus commented on pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#issuecomment-630796004
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
snvijaya commented on a change in pull request #1898:
URL: https://github.com/apache/hadoop/pull/1898#discussion_r427276891
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java
##
@@ -0,0 +1,433 @@
+/**
+ *
snvijaya commented on a change in pull request #1898:
URL: https://github.com/apache/hadoop/pull/1898#discussion_r427276747
##
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManager.java
##
@@ -289,6 +298,27 @@ private
snvijaya commented on pull request #1898:
URL: https://github.com/apache/hadoop/pull/1898#issuecomment-630795958
> things aren't building because the change made to the abfs constructor is
breaking it. Sorry. That refactoring was done to try and reduce change conflict
in future.
>
snvijaya commented on a change in pull request #1898:
URL: https://github.com/apache/hadoop/pull/1898#discussion_r427277296
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java
##
@@ -0,0 +1,433 @@
+/**
+ *
snvijaya commented on pull request #1898:
URL: https://github.com/apache/hadoop/pull/1898#issuecomment-630797537
Tests rerun:
HNS
[INFO] Tests run: 69, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 432, Failures: 0, Errors: 0, Skipped: 74
WARNING] Tests run:
snvijaya commented on pull request #1898:
URL: https://github.com/apache/hadoop/pull/1898#issuecomment-630797418
> looked at, tests look good, little bit of some logic in the production
code I'm querying
>
> Is there any way to avoid a 30s delay on every test run for the timeouts?
steveloughran commented on pull request #1950:
URL: https://github.com/apache/hadoop/pull/1950#issuecomment-630920463
thanks
+1 from me
This is an automated message from the Apache Git Service.
To respond to the
steveloughran commented on a change in pull request #1978:
URL: https://github.com/apache/hadoop/pull/1978#discussion_r427427472
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestTextFileBasedIdentityHandler.java
##
@@ -0,0
hadoop-yetus commented on pull request #2021:
URL: https://github.com/apache/hadoop/pull/2021#issuecomment-630927850
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
steveloughran commented on pull request #2026:
URL: https://github.com/apache/hadoop/pull/2026#issuecomment-630928501
way beyond my area of expertise, i'm afraid
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/HADOOP-16852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111253#comment-17111253
]
Hadoop QA commented on HADOOP-16852:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
hadoop-yetus commented on pull request #1898:
URL: https://github.com/apache/hadoop/pull/1898#issuecomment-630880793
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 33m
steveloughran commented on pull request #1944:
URL: https://github.com/apache/hadoop/pull/1944#issuecomment-630945785
ok i'll get this through checkstyle and merge in
This is an automated message from the Apache Git Service.
leosunli edited a comment on pull request #1885:
URL: https://github.com/apache/hadoop/pull/1885#issuecomment-630822616
Thank @jojochuang for taking your time to review.
i have added description of performance improvement on jira.
snvijaya commented on pull request #2021:
URL: https://github.com/apache/hadoop/pull/2021#issuecomment-630900690
Thanks @DadanielZ . Have resolved conflicts and updated PR.
This is an automated message from the Apache
mpryahin commented on a change in pull request #1999:
URL: https://github.com/apache/hadoop/pull/1999#discussion_r427436515
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/sftp/SFTPInputStream.java
##
@@ -15,86 +15,113 @@
* See the
leosunli commented on pull request #1885:
URL: https://github.com/apache/hadoop/pull/1885#issuecomment-630822616
Thank @jojochuang for taking your time to review.
This is an automated message from the Apache Git Service.
To
leosunli edited a comment on pull request #1885:
URL: https://github.com/apache/hadoop/pull/1885#issuecomment-630822616
Thank @jojochuang for taking your time to review.
i will add description of performance improvement on jira.
steveloughran commented on a change in pull request #1999:
URL: https://github.com/apache/hadoop/pull/1999#discussion_r427433664
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/sftp/SFTPInputStream.java
##
@@ -15,86 +15,113 @@
* See the
steveloughran commented on a change in pull request #1999:
URL: https://github.com/apache/hadoop/pull/1999#discussion_r427437660
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/sftp/SFTPContract.java
##
@@ -0,0 +1,108 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/HADOOP-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111308#comment-17111308
]
Mikhail Pryakhin commented on HADOOP-14566:
---
Hey [~ste...@apache.org], I'm just writing to
hadoop-yetus commented on pull request #2026:
URL: https://github.com/apache/hadoop/pull/2026#issuecomment-631039936
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
jojochuang commented on a change in pull request #1885:
URL: https://github.com/apache/hadoop/pull/1885#discussion_r427541701
##
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
##
@@ -181,25 +182,49 @@
[
https://issues.apache.org/jira/browse/HADOOP-16852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111370#comment-17111370
]
Hadoop QA commented on HADOOP-16852:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
chliang71 commented on a change in pull request #2019:
URL: https://github.com/apache/hadoop/pull/2019#discussion_r427493135
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
##
@@ -965,12 +978,25 @@ public int
hadoop-yetus commented on pull request #2021:
URL: https://github.com/apache/hadoop/pull/2021#issuecomment-631033125
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m
[
https://issues.apache.org/jira/browse/HADOOP-17015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sneha Vijayarajan updated HADOOP-17015:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> ABFS: Make
hadoop-yetus commented on pull request #1982:
URL: https://github.com/apache/hadoop/pull/1982#issuecomment-630963353
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 22m
Gaurangi94 opened a new pull request #2028:
URL: https://github.com/apache/hadoop/pull/2028
Change-Id: I59a467a49d417aa76548fb8e00f1582b09b9e041
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request
snvijaya commented on pull request #1898:
URL: https://github.com/apache/hadoop/pull/1898#issuecomment-630980316
@steveloughran - Could you please help complete review and commit.
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/HADOOP-17015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111481#comment-17111481
]
Hudson commented on HADOOP-17015:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18276 (See
hadoop-yetus commented on pull request #2011:
URL: https://github.com/apache/hadoop/pull/2011#issuecomment-630965465
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
hadoop-yetus commented on pull request #1898:
URL: https://github.com/apache/hadoop/pull/1898#issuecomment-630965943
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
hadoop-yetus commented on pull request #1885:
URL: https://github.com/apache/hadoop/pull/1885#issuecomment-630965128
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
hadoop-yetus commented on pull request #1944:
URL: https://github.com/apache/hadoop/pull/1944#issuecomment-630992307
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 22m
DadanielZ merged pull request #2021:
URL: https://github.com/apache/hadoop/pull/2021
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
DadanielZ commented on pull request #2021:
URL: https://github.com/apache/hadoop/pull/2021#issuecomment-631034337
LGTM, +1. Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please
jojochuang closed pull request #1884:
URL: https://github.com/apache/hadoop/pull/1884
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mpryahin commented on a change in pull request #1999:
URL: https://github.com/apache/hadoop/pull/1999#discussion_r427475649
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/sftp/SFTPContract.java
##
@@ -0,0 +1,108 @@
+/*
+ *
hadoop-yetus commented on pull request #2028:
URL: https://github.com/apache/hadoop/pull/2028#issuecomment-631113063
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m
hadoop-yetus commented on pull request #1999:
URL: https://github.com/apache/hadoop/pull/1999#issuecomment-631133646
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
mpryahin commented on a change in pull request #1999:
URL: https://github.com/apache/hadoop/pull/1999#discussion_r427613230
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/sftp/SFTPContract.java
##
@@ -0,0 +1,108 @@
+/*
+ *
mpryahin commented on a change in pull request #1999:
URL: https://github.com/apache/hadoop/pull/1999#discussion_r427468540
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/sftp/SFTPFileSystem.java
##
@@ -516,16 +515,14 @@ public
hadoop-yetus commented on pull request #1963:
URL: https://github.com/apache/hadoop/pull/1963#issuecomment-631069895
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 25m
mpryahin commented on a change in pull request #1999:
URL: https://github.com/apache/hadoop/pull/1999#discussion_r427468540
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/sftp/SFTPFileSystem.java
##
@@ -516,16 +515,14 @@ public
mpryahin commented on a change in pull request #1999:
URL: https://github.com/apache/hadoop/pull/1999#discussion_r427482114
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/sftp/SFTPContract.java
##
@@ -0,0 +1,108 @@
+/*
+ *
iwasakims merged pull request #1950:
URL: https://github.com/apache/hadoop/pull/1950
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
leosunli commented on a change in pull request #1885:
URL: https://github.com/apache/hadoop/pull/1885#discussion_r427698174
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java
##
@@ -910,4 +912,94 @@
[
https://issues.apache.org/jira/browse/HADOOP-17047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111686#comment-17111686
]
Mingliang Liu commented on HADOOP-17047:
Thanks [~rungroj] for providing a patch for the 2nd
amarnathkarthik commented on a change in pull request #1978:
URL: https://github.com/apache/hadoop/pull/1978#discussion_r427707651
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestTextFileBasedIdentityHandler.java
##
@@ -0,0
[
https://issues.apache.org/jira/browse/HADOOP-16586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111626#comment-17111626
]
Hudson commented on HADOOP-16586:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18277 (See
hadoop-yetus commented on pull request #1978:
URL: https://github.com/apache/hadoop/pull/1978#issuecomment-631219117
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
iwasakims commented on pull request #1950:
URL: https://github.com/apache/hadoop/pull/1950#issuecomment-631146958
Thanks. I merged this.
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/HADOOP-16586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Masatake Iwasaki updated HADOOP-16586:
--
Fix Version/s: 3.4.0
Hadoop Flags: Reviewed
Resolution: Fixed
[
https://issues.apache.org/jira/browse/HADOOP-17047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu reassigned HADOOP-17047:
--
Assignee: Rungroj Maipradit
> TODO comments exist in trunk while the related issues
[
https://issues.apache.org/jira/browse/HADOOP-17047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111702#comment-17111702
]
Akira Ajisaka commented on HADOOP-17047:
For the first case, now 'compile time dependency' is
[
https://issues.apache.org/jira/browse/HADOOP-17047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111702#comment-17111702
]
Akira Ajisaka edited comment on HADOOP-17047 at 5/20/20, 2:49 AM:
--
amarnathkarthik commented on a change in pull request #1978:
URL: https://github.com/apache/hadoop/pull/1978#discussion_r427707065
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestTextFileBasedIdentityHandler.java
##
@@ -0,0
77 matches
Mail list logo
