svn commit: r388727 - in /jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite: EvictorLender.java IdleEvictorLender.java InvalidEvictorLender.java
Author: sandymac
Date: Sat Mar 25 00:01:42 2006
New Revision: 388727
URL: http://svn.apache.org/viewcvs?rev=388727view=rev
Log:
Made idle object eviction synchronize on just the one idle object and not on
the whole pool.
Modified:
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/EvictorLender.java
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/IdleEvictorLender.java
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/InvalidEvictorLender.java
Modified:
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/EvictorLender.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/EvictorLender.java?rev=388727r1=388726r2=388727view=diff
==
---
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/EvictorLender.java
(original)
+++
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/EvictorLender.java
Sat Mar 25 00:01:42 2006
@@ -60,8 +60,10 @@
final EvictorReference ref = (EvictorReference)super.borrow();
Object obj = null;
if (ref != null) {
-obj = ref.get();
-ref.clear();
+synchronized (ref) {
+obj = ref.get();
+ref.clear();
+}
}
return obj;
}
@@ -92,7 +94,7 @@
final Iterator iter = super.listIterator();
while (iter.hasNext()) {
final EvictorReference ref = (EvictorReference)iter.next();
-if (ref.get() == null) {
+if (ref != null ref.get() == null) {
iter.remove();
}
}
@@ -124,6 +126,9 @@
/**
* This is designed to mimick the [EMAIL PROTECTED] Reference} api.
* The only reason a [EMAIL PROTECTED] Reference} subclass isn't used is
there is no StrongReference implementation.
+ * Because evictors run in a different thread, implementations must be
thread safe and callers need to
+ * synchronize on the codeEvictorReference/code if they need to call
more than one method in a thread
+ * safe manner.
*/
protected interface EvictorReference extends LenderReference {
/**
Modified:
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/IdleEvictorLender.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/IdleEvictorLender.java?rev=388727r1=388726r2=388727view=diff
==
---
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/IdleEvictorLender.java
(original)
+++
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/IdleEvictorLender.java
Sat Mar 25 00:01:42 2006
@@ -100,15 +100,19 @@
}
public Object get() {
-return referant;
+synchronized (this) {
+return referant;
+}
}
public void clear() {
-task.cancel();
-if (referant instanceof EvictorReference) {
-((EvictorReference)referant).clear();
+synchronized (this) {
+task.cancel();
+if (referant instanceof EvictorReference) {
+((EvictorReference)referant).clear();
+}
+referant = null;
}
-referant = null;
}
/**
@@ -120,8 +124,8 @@
* Evict the idle object.
*/
public void run() {
-synchronized(getObjectPool().getPool()) {
-referant = null;
+synchronized(IdleEvictorReference.this) {
+clear();
}
}
}
Modified:
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/InvalidEvictorLender.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/InvalidEvictorLender.java?rev=388727r1=388726r2=388727view=diff
==
---
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/InvalidEvictorLender.java
(original)
+++
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/InvalidEvictorLender.java
Sat Mar 25 00:01:42 2006
@@ -113,15 +113,19 @@
}
public Object get() {
-return referant;
+synchronized (this) {
+return referant;
+}
}
public void clear() {
-task.cancel();
-if (referant instanceof
svn commit: r388728 - in /jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool: composite/TestCompositeObjectPool.java impl/TestSoftRefOutOfMemory.java
Author: sandymac
Date: Sat Mar 25 00:27:52 2006
New Revision: 388728
URL: http://svn.apache.org/viewcvs?rev=388728view=rev
Log:
Improve robustness of memory pressure tests.
Modified:
jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestCompositeObjectPool.java
jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftRefOutOfMemory.java
Modified:
jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestCompositeObjectPool.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestCompositeObjectPool.java?rev=388728r1=388727r2=388728view=diff
==
---
jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestCompositeObjectPool.java
(original)
+++
jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestCompositeObjectPool.java
Sat Mar 25 00:27:52 2006
@@ -421,7 +421,11 @@
List garbage = new LinkedList();
Runtime runtime = Runtime.getRuntime();
while (pool.getNumIdle() 0) {
-garbage.add(new byte[Math.min(1024 * 1024,
(int)runtime.freeMemory()/4)]);
+try {
+garbage.add(new byte[Math.min(1024 * 1024,
(int)runtime.freeMemory()/2)]);
+} catch (OutOfMemoryError oome) {
+System.gc();
+}
System.gc();
}
garbage.clear();
Modified:
jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftRefOutOfMemory.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftRefOutOfMemory.java?rev=388728r1=388727r2=388728view=diff
==
---
jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftRefOutOfMemory.java
(original)
+++
jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftRefOutOfMemory.java
Sat Mar 25 00:27:52 2006
@@ -62,7 +62,11 @@
final List garbage = new LinkedList();
final Runtime runtime = Runtime.getRuntime();
while (pool.getNumIdle() 0) {
-garbage.add(new byte[Math.min(1024 * 1024,
(int)runtime.freeMemory()/4)]);
+try {
+garbage.add(new byte[Math.min(1024 * 1024,
(int)runtime.freeMemory()/2)]);
+} catch (OutOfMemoryError oome) {
+System.gc();
+}
System.gc();
}
garbage.clear();
@@ -93,7 +97,11 @@
final List garbage = new LinkedList();
final Runtime runtime = Runtime.getRuntime();
while (pool.getNumIdle() 0) {
-garbage.add(new byte[Math.min(1024 * 1024,
(int)runtime.freeMemory()/4)]);
+try {
+garbage.add(new byte[Math.min(1024 * 1024,
(int)runtime.freeMemory()/2)]);
+} catch (OutOfMemoryError oome) {
+System.gc();
+}
System.gc();
}
garbage.clear();
@@ -120,7 +128,11 @@
final List garbage = new LinkedList();
final Runtime runtime = Runtime.getRuntime();
while (pool.getNumIdle() 0) {
-garbage.add(new byte[Math.min(1024 * 1024,
(int)runtime.freeMemory()/4)]);
+try {
+garbage.add(new byte[Math.min(1024 * 1024,
(int)runtime.freeMemory()/2)]);
+} catch (OutOfMemoryError oome) {
+System.gc();
+}
System.gc();
}
garbage.clear();
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r388729 - /jakarta/commons/proper/pool/tags/POOL_1_3_RC3/
Author: sandymac Date: Sat Mar 25 00:30:54 2006 New Revision: 388729 URL: http://svn.apache.org/viewcvs?rev=388729view=rev Log: Tagging 1.3-rc3 Added: jakarta/commons/proper/pool/tags/POOL_1_3_RC3/ - copied from r388728, jakarta/commons/proper/pool/branches/1_3_RELEASE_BRANCH/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [poll] [pool] picking descriptive class names
Sandy McArthur wrote: The main behavior of the composite pools are configured via four type-safe enum types. I'll describe what each type controls and then suggest name variants. Let me know which one you think is the most self-evident and user friendly. Feel free to suggest new names. We use the suffix Type for all enums at work. It seems to work well. The suffix strategy implies that the class actually does real calculations or business logic IMO. The behaviour suffix is yucky. The policy suffix could be OK. Stephen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [pool] Announcing Release Candidate 3 for Pool 1.3
Sandy McArthur wrote: I've prepared Pool 1.3-rc3 at http://people.apache.org/~sandymac/pool/1.3-rc3/ I'd appreciate it if interested parties reviewed it and tested it with their setup. For the release I would like to see the published date and version in the header line as per most other commons projects. Change project.properties: From maven.xdoc.date=bottom To maven.xdoc.date=left For the release I would also like to see API Documentation renamed to Javadoc in the left navigation. For HEAD, I would like to make some other website changes - add a Support section on the home page, re-order and rename the navigation menu, etc. to bring the site in line with other sites. Let me know if I can do this. Stephen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-chain (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-chain has an issue affecting its community integration. This issue affects 16 projects, and has been outstanding for 31 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-chain : GoF Chain of Responsibility pattern - commons-jelly-tags-quartz : Commons Jelly - fulcrum-quartz : Services Framework - jakarta-tomcat-5 : Servlet 2.4 and JSP 2.0 Reference Implementation - jakarta-velocity-tools : Velocity-Tools project - myfaces : JavaServer(tm) Faces implementation - portals-bridges-frameworks : Support for JSR168 compliant Portlet development - portals-bridges-jsf : Support for JSR168 compliant Portlet development - portals-bridges-struts : Support for JSR168 compliant Portlet development - portals-bridges-velocity : Support for JSR168 compliant Portlet development - quartz : Job Scheduler - struts-action : Model 2 Model-View-Controller framework for Servlets and JSP - struts-el : Model 2 Model-View-Controller framework for Servlets and JSP - struts-sslext : The Struts SSL Extension for HTTP/HTTPS switching - struts-taglib : Model 2 Model-View-Controller framework for Servlets and JSP - struts-tiles : Model 2 Model-View-Controller framework for Servlets and JSP Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-chain/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-chain-25032006.jar] identifier set to project name -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons/commons-chain/gump_work/build_jakarta-commons_commons-chain.html Work Name: build_jakarta-commons_commons-chain (Type: Build) Work ended in a state of : Failed Elapsed: 18 secs Command Line: java -Djava.awt.headless=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-chain-25032006 -f build.xml jar [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/chain] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/chain/target/classes:/usr/local/gump/public/workspace/jakarta-commons/chain/target/test-classes:/usr/local/gump/packages/jsf-1_1_01/lib/jsf-api.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-25032006.jar:/usr/local/gump/public/workspace/portals-pluto-1.0/api/target/portlet-api-1.0.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar - [junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 0.278 sec [junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 0.278 sec [junit] Testcase: testPristine took 0.039 sec [junit] Testcase: testReadOnly took 0.003 sec [junit] Testcase: testReadWrite took 0.002 sec [junit] Testcase: testWriteOnly took 0 sec [junit] Testcase: testAttributes took 0.001 sec [junit] Testcase: testContains took 0.001 sec [junit] Testcase: testEquals took 0.011 sec [junit] Testcase: testKeySet took 0.001 sec [junit] Testcase: testPutAll took 0.001 sec [junit] Testcase: testSeriaization took 0.049 sec [junit] Running org.apache.commons.chain.web.ChainResourcesTestCase [junit] Testsuite: org.apache.commons.chain.web.ChainResourcesTestCase
[EMAIL PROTECTED]: Project commons-chain (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-chain has an issue affecting its community integration. This issue affects 16 projects, and has been outstanding for 31 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-chain : GoF Chain of Responsibility pattern - commons-jelly-tags-quartz : Commons Jelly - fulcrum-quartz : Services Framework - jakarta-tomcat-5 : Servlet 2.4 and JSP 2.0 Reference Implementation - jakarta-velocity-tools : Velocity-Tools project - myfaces : JavaServer(tm) Faces implementation - portals-bridges-frameworks : Support for JSR168 compliant Portlet development - portals-bridges-jsf : Support for JSR168 compliant Portlet development - portals-bridges-struts : Support for JSR168 compliant Portlet development - portals-bridges-velocity : Support for JSR168 compliant Portlet development - quartz : Job Scheduler - struts-action : Model 2 Model-View-Controller framework for Servlets and JSP - struts-el : Model 2 Model-View-Controller framework for Servlets and JSP - struts-sslext : The Struts SSL Extension for HTTP/HTTPS switching - struts-taglib : Model 2 Model-View-Controller framework for Servlets and JSP - struts-tiles : Model 2 Model-View-Controller framework for Servlets and JSP Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-chain/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-chain-25032006.jar] identifier set to project name -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons/commons-chain/gump_work/build_jakarta-commons_commons-chain.html Work Name: build_jakarta-commons_commons-chain (Type: Build) Work ended in a state of : Failed Elapsed: 18 secs Command Line: java -Djava.awt.headless=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-chain-25032006 -f build.xml jar [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/chain] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/chain/target/classes:/usr/local/gump/public/workspace/jakarta-commons/chain/target/test-classes:/usr/local/gump/packages/jsf-1_1_01/lib/jsf-api.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-25032006.jar:/usr/local/gump/public/workspace/portals-pluto-1.0/api/target/portlet-api-1.0.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar - [junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 0.278 sec [junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 0.278 sec [junit] Testcase: testPristine took 0.039 sec [junit] Testcase: testReadOnly took 0.003 sec [junit] Testcase: testReadWrite took 0.002 sec [junit] Testcase: testWriteOnly took 0 sec [junit] Testcase: testAttributes took 0.001 sec [junit] Testcase: testContains took 0.001 sec [junit] Testcase: testEquals took 0.011 sec [junit] Testcase: testKeySet took 0.001 sec [junit] Testcase: testPutAll took 0.001 sec [junit] Testcase: testSeriaization took 0.049 sec [junit] Running org.apache.commons.chain.web.ChainResourcesTestCase [junit] Testsuite: org.apache.commons.chain.web.ChainResourcesTestCase
[EMAIL PROTECTED]: Project commons-jelly-tags-xml-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-xml-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 37 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-xml-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/gump_work/build_commons-jelly_commons-jelly-tags-xml-test.html Work Name: build_commons-jelly_commons-jelly-tags-xml-test (Type: Build) Work ended in a state of : Failed Elapsed: 29 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-25032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testSetSingleNodeAndAsString(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:294:81: x:set You must define an attribute called 'select' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:294:81: x:set You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.SetTag.doTag(SetTag.java:86) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testSetStringLists(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:339:82: x:set You must define an attribute called 'select' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:339:82: x:set You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.SetTag.doTag(SetTag.java:86) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testEntities(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit]
[EMAIL PROTECTED]: Project commons-jelly-tags-xml-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-xml-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 37 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-xml-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/gump_work/build_commons-jelly_commons-jelly-tags-xml-test.html Work Name: build_commons-jelly_commons-jelly-tags-xml-test (Type: Build) Work ended in a state of : Failed Elapsed: 29 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-25032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testSetSingleNodeAndAsString(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:294:81: x:set You must define an attribute called 'select' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:294:81: x:set You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.SetTag.doTag(SetTag.java:86) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testSetStringLists(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:339:82: x:set You must define an attribute called 'select' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:339:82: x:set You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.SetTag.doTag(SetTag.java:86) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testEntities(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit]
[EMAIL PROTECTED]: Project commons-latka (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-latka has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 37 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-latka : Functional Testing Suite Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-latka/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-latka.jar] identifier set to project name -DEBUG- Dependency on jaxen exists, no need to add for property jaxen.jar. -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/latka/target/classes] -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/latka/target/test-classes] -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons/commons-latka/gump_work/build_jakarta-commons_commons-latka.html Work Name: build_jakarta-commons_commons-latka (Type: Build) Work ended in a state of : Failed Elapsed: 10 secs Command Line: java -Djava.awt.headless=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/build/serializer.jar:/usr/local/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Djaxen.jar=/usr/local/gump/public/workspace/jaxen/target/jaxen-25032006.jar dist [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/latka] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/latka/target/classes:/usr/local/gump/public/workspace/jakarta-commons/latka/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-commons/httpclient/dist/commons-httpclient.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/codec/dist/commons-codec-25032006.jar:/usr/local/gump/public/workspace/logging-log4j/dist/lib/log4j-25032006.jar:/usr/local/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-25032006.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/public/workspace/jdom/build/jdom.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/lang/dist/commons-lang-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-25032006.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-25032006.jar - [javac] ^ [javac] /x1/gump/public/workspace/jakarta-commons/latka/src/java/org/apache/commons/latka/servlet/ViewResponseServlet.java:44: warning: [deprecation] getInstance(java.lang.Class) in org.apache.log4j.Category has been deprecated [javac] public static final Category _log = Category.getInstance( [javac] ^ [javac] /x1/gump/public/workspace/jakarta-commons/latka/src/java/org/apache/commons/latka/validators/BaseValidator.java:35: warning: [deprecation] getInstance(java.lang.Class) in org.apache.log4j.Category has been deprecated [javac] protected final Category _log = Category.getInstance(BaseValidator.class);
[EMAIL PROTECTED]: Project commons-latka (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-latka has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 37 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-latka : Functional Testing Suite Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-latka/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-latka.jar] identifier set to project name -DEBUG- Dependency on jaxen exists, no need to add for property jaxen.jar. -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/latka/target/classes] -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/latka/target/test-classes] -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons/commons-latka/gump_work/build_jakarta-commons_commons-latka.html Work Name: build_jakarta-commons_commons-latka (Type: Build) Work ended in a state of : Failed Elapsed: 10 secs Command Line: java -Djava.awt.headless=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/build/serializer.jar:/usr/local/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Djaxen.jar=/usr/local/gump/public/workspace/jaxen/target/jaxen-25032006.jar dist [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/latka] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/latka/target/classes:/usr/local/gump/public/workspace/jakarta-commons/latka/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-commons/httpclient/dist/commons-httpclient.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/codec/dist/commons-codec-25032006.jar:/usr/local/gump/public/workspace/logging-log4j/dist/lib/log4j-25032006.jar:/usr/local/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-25032006.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/public/workspace/jdom/build/jdom.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/lang/dist/commons-lang-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-25032006.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-25032006.jar - [javac] ^ [javac] /x1/gump/public/workspace/jakarta-commons/latka/src/java/org/apache/commons/latka/servlet/ViewResponseServlet.java:44: warning: [deprecation] getInstance(java.lang.Class) in org.apache.log4j.Category has been deprecated [javac] public static final Category _log = Category.getInstance( [javac] ^ [javac] /x1/gump/public/workspace/jakarta-commons/latka/src/java/org/apache/commons/latka/validators/BaseValidator.java:35: warning: [deprecation] getInstance(java.lang.Class) in org.apache.log4j.Category has been deprecated [javac] protected final Category _log = Category.getInstance(BaseValidator.class);
svn commit: r388747 - /jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/EmailException.java
Author: scolebourne Date: Sat Mar 25 04:55:11 2006 New Revision: 388747 URL: http://svn.apache.org/viewcvs?rev=388747view=rev Log: Avoid javadoc warning Modified: jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/EmailException.java Modified: jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/EmailException.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/EmailException.java?rev=388747r1=388746r2=388747view=diff == --- jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/EmailException.java (original) +++ jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/EmailException.java Sat Mar 25 04:55:11 2006 @@ -24,7 +24,7 @@ * p * Supports nesting, emulating JDK 1.4 behavior if necessary. * p - * Adapted from [EMAIL PROTECTED] org.apache.commons.collections.FunctorException}. + * Adapted from FunctorException in Commons Collections. * * @author jakarta-commons * @since 1.0 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-html has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 37 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-html : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-html-25032006.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build) Work ended in a state of : Failed Elapsed: 12 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-25032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-html has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 37 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-html : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-html-25032006.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build) Work ended in a state of : Failed Elapsed: 12 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-25032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 37 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-25032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:102) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 37 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-25032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:102) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78) [junit] at
svn commit: r388748 - /jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/MultiPartEmail.java
Author: scolebourne
Date: Sat Mar 25 05:08:42 2006
New Revision: 388748
URL: http://svn.apache.org/viewcvs?rev=388748view=rev
Log:
Javadoc
Modified:
jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/MultiPartEmail.java
Modified:
jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/MultiPartEmail.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/MultiPartEmail.java?rev=388748r1=388747r2=388748view=diff
==
---
jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/MultiPartEmail.java
(original)
+++
jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/MultiPartEmail.java
Sat Mar 25 05:08:42 2006
@@ -482,9 +482,10 @@
}
/**
- * Method that can be overridden if you don't
- * want to create a MimeBodyPart.
- * @return
+ * Creates a body part object.
+ * Can be overridden if you don't want to create a BodyPart.
+ *
+ * @return the created body part
*/
protected BodyPart createBodyPart()
{
@@ -492,8 +493,9 @@
return bodyPart;
}
/**
+ * Creates a mime multipart object.
*
- * @return
+ * @return the created mime part
*/
protected MimeMultipart createMimeMultipart()
{
@@ -502,7 +504,9 @@
}
/**
- * @return boolHasAttachments
+ * Checks whether there are attachments.
+ *
+ * @return true if there are attachments
* @since 1.0
*/
public boolean isBoolHasAttachments()
@@ -511,7 +515,9 @@
}
/**
- * @param b boolHasAttachments
+ * Sets whether there are attachments.
+ *
+ * @param b the attachments flag
* @since 1.0
*/
public void setBoolHasAttachments(boolean b)
@@ -520,8 +526,9 @@
}
/**
+ * Checks if this object is initialized.
*
- * @return
+ * @return true if initialized
*/
protected boolean isInitialized()
{
@@ -529,8 +536,9 @@
}
/**
+ * Sets the initialized status of this object.
*
- * @param b
+ * @param b the initialized status flag
*/
protected void setInitialized(boolean b)
{
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-define-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 37 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-define-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build) Work ended in a state of : Failed Elapsed: 14 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-25032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:118) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208) [junit] at junit.framework.TestSuite.run(TestSuite.java:203) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536) [junit] Mar 25, 2006 5:15:01 AM org.apache.commons.jelly.expression.xpath.XPathExpression evaluate [junit] SEVERE: Error constructing xpath [junit] org.jaxen.XPathSyntaxException: Node-set expected [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:131) [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:156) [junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101) [junit] at org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78) [junit] at org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] at junit.framework.TestCase.runBare(TestCase.java:127) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-define-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 37 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-define-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build) Work ended in a state of : Failed Elapsed: 14 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-25032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-25032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-25032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:118) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208) [junit] at junit.framework.TestSuite.run(TestSuite.java:203) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536) [junit] Mar 25, 2006 5:15:01 AM org.apache.commons.jelly.expression.xpath.XPathExpression evaluate [junit] SEVERE: Error constructing xpath [junit] org.jaxen.XPathSyntaxException: Node-set expected [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:131) [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:156) [junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101) [junit] at org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78) [junit] at org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] at junit.framework.TestCase.runBare(TestCase.java:127) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at
svn commit: r388751 - in /jakarta/commons/proper/email/trunk: ./ xdocs/
Author: scolebourne
Date: Sat Mar 25 05:24:50 2006
New Revision: 388751
URL: http://svn.apache.org/viewcvs?rev=388751view=rev
Log:
Enhance website and remove commons-build dependency
Added:
jakarta/commons/proper/email/trunk/xdocs/building.xml (with props)
jakarta/commons/proper/email/trunk/xdocs/cvs-usage.xml (with props)
jakarta/commons/proper/email/trunk/xdocs/issue-tracking.xml (with props)
jakarta/commons/proper/email/trunk/xdocs/release_1_0.xml (with props)
jakarta/commons/proper/email/trunk/xdocs/userguide.xml
- copied, changed from r388741,
jakarta/commons/proper/email/trunk/xdocs/examples.xml
Removed:
jakarta/commons/proper/email/trunk/xdocs/downloads.xml
jakarta/commons/proper/email/trunk/xdocs/examples.xml
Modified:
jakarta/commons/proper/email/trunk/maven.xml
jakarta/commons/proper/email/trunk/project.properties
jakarta/commons/proper/email/trunk/project.xml
jakarta/commons/proper/email/trunk/xdocs/changes.xml
jakarta/commons/proper/email/trunk/xdocs/index.xml
jakarta/commons/proper/email/trunk/xdocs/navigation.xml
Modified: jakarta/commons/proper/email/trunk/maven.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/maven.xml?rev=388751r1=388750r2=388751view=diff
==
--- jakarta/commons/proper/email/trunk/maven.xml (original)
+++ jakarta/commons/proper/email/trunk/maven.xml Sat Mar 25 05:24:50 2006
@@ -21,37 +21,6 @@
xmlns:j=jelly:core
default=jar:jar
- !-- == --
- !-- START : C O M M O N S - B U I L D --
- !-- == --
- !-- Required: Look and Feel for documentation within distributions --
- !-- == --
- preGoal name=xdoc:init
- ant:available type=dir property=commons.basedir.available
file=${basedir}/../commons-build /
- j:if test=${context.getVariable('commons.basedir.available') == null}
-fail
---
-| if you want to build xdocs or the site, you must
-| check out the 'commons-build' module from
-| http://svn.apache.org/repos/asf/jakarta/commons/proper/commons-build/trunk/
-| and put it in a directory next to commons-email
---
-/fail
- /j:if
- /preGoal
-
- postGoal name=xdoc:copy-resources
-copy todir=${basedir}/target/docs/style/ failonerror=false
- fileset dir=${basedir}/../commons-build/xdocs/style
- include name='**/*'/
- exclude name='**/CVS/**'/
- /fileset
-/copy
- /postGoal
- !-- == --
- !-- END: C O M M O N S - B U I L D --
- !-- == --
-
!-- Ensures that the conf directory and NOTICE.txt are included in the
source distro.
--
Modified: jakarta/commons/proper/email/trunk/project.properties
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/project.properties?rev=388751r1=388750r2=388751view=diff
==
--- jakarta/commons/proper/email/trunk/project.properties (original)
+++ jakarta/commons/proper/email/trunk/project.properties Sat Mar 25 05:24:50
2006
@@ -46,12 +46,12 @@
maven.checkstyle.header.file=conf/HEADER.txt
# Standard settings
-maven.xdoc.jsl=../commons-build/commons-site.jsl
maven.xdoc.date=left
-maven.xdoc.poweredby.image=maven-feather.png
+maven.xdoc.version=${pom.currentVersion}
maven.xdoc.developmentProcessUrl=http://jakarta.apache.org/commons/charter.html
+maven.xdoc.poweredby.image=maven-feather.png
# used to generate the download page
-maven.xdoc.distributionUrl=http://www.apache.org/dist/java-repository/commons-email/jars
+#maven.xdoc.distributionUrl=http://www.apache.org/dist/java-repository/commons-email/jars
# Compiler settings - we are targetting JDK 1.3 as minimum runtime requirement
maven.compile.source=1.3
Modified: jakarta/commons/proper/email/trunk/project.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/project.xml?rev=388751r1=388750r2=388751view=diff
==
--- jakarta/commons/proper/email/trunk/project.xml (original)
+++ jakarta/commons/proper/email/trunk/project.xml Sat Mar 25 05:24:50 2006
@@ -1,6 +1,6 @@
?xml version=1.0 encoding=UTF-8?
!--
- Copyright 2001-2005 The Apache Software Foundation
+ Copyright 2001-2006 The Apache Software Foundation
Licensed under the Apache License, Version 2.0 (the License);
you may not use this file except in compliance with the License.
@@
svn commit: r388755 - /jakarta/commons/proper/io/trunk/xdocs/navigation.xml
Author: scolebourne Date: Sat Mar 25 05:41:50 2006 New Revision: 388755 URL: http://svn.apache.org/viewcvs?rev=388755view=rev Log: Tidy website title and user guide link name Modified: jakarta/commons/proper/io/trunk/xdocs/navigation.xml Modified: jakarta/commons/proper/io/trunk/xdocs/navigation.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/io/trunk/xdocs/navigation.xml?rev=388755r1=388754r2=388755view=diff == --- jakarta/commons/proper/io/trunk/xdocs/navigation.xml (original) +++ jakarta/commons/proper/io/trunk/xdocs/navigation.xml Sat Mar 25 05:41:50 2006 @@ -1,8 +1,8 @@ ?xml version=1.0 encoding=ISO-8859-1? !DOCTYPE org.apache.commons.menus SYSTEM 'http://jakarta.apache.org/commons/build/maven-build.dtd' -project name=IO +project name=Commons IO - titleIO/title + titleCommons IO/title body links @@ -12,7 +12,7 @@ menu name=Commons IO item name=Overview href=/index.html/ item name=Download href=http://jakarta.apache.org/site/downloads/downloads_commons-io.cgi/ - item name=Users guide href=/description.html/ + item name=User guide href=/description.html/ item name=Best practices href=/bestpractices.html/ !--item name=History href=/history.html/-- item name=Javadoc (1.2 release) href=api-release/index.html/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r388762 - in /jakarta/commons/proper/collections/trunk/xdocs: compatibility.xml history.xml index.xml navigation.xml pick.xml proposal.xml tasks.xml userguide.xml
Author: scolebourne Date: Sat Mar 25 05:56:26 2006 New Revision: 388762 URL: http://svn.apache.org/viewcvs?rev=388762view=rev Log: Tidy website title and user guide link name Modified: jakarta/commons/proper/collections/trunk/xdocs/compatibility.xml jakarta/commons/proper/collections/trunk/xdocs/history.xml jakarta/commons/proper/collections/trunk/xdocs/index.xml jakarta/commons/proper/collections/trunk/xdocs/navigation.xml jakarta/commons/proper/collections/trunk/xdocs/pick.xml jakarta/commons/proper/collections/trunk/xdocs/proposal.xml jakarta/commons/proper/collections/trunk/xdocs/tasks.xml jakarta/commons/proper/collections/trunk/xdocs/userguide.xml Modified: jakarta/commons/proper/collections/trunk/xdocs/compatibility.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/collections/trunk/xdocs/compatibility.xml?rev=388762r1=388761r2=388762view=diff == --- jakarta/commons/proper/collections/trunk/xdocs/compatibility.xml (original) +++ jakarta/commons/proper/collections/trunk/xdocs/compatibility.xml Sat Mar 25 05:56:26 2006 @@ -18,7 +18,7 @@ document properties - titleCommons Collections - Compatibility/title + titleCompatibility/title author email=commons-dev@jakarta.apache.orgCommons Documentation Team/author /properties Modified: jakarta/commons/proper/collections/trunk/xdocs/history.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/collections/trunk/xdocs/history.xml?rev=388762r1=388761r2=388762view=diff == --- jakarta/commons/proper/collections/trunk/xdocs/history.xml (original) +++ jakarta/commons/proper/collections/trunk/xdocs/history.xml Sat Mar 25 05:56:26 2006 @@ -18,7 +18,7 @@ document properties - titleCommons Collections - History/title + titleHistory/title author email=commons-dev@jakarta.apache.orgCommons Documentation Team/author /properties Modified: jakarta/commons/proper/collections/trunk/xdocs/index.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/collections/trunk/xdocs/index.xml?rev=388762r1=388761r2=388762view=diff == --- jakarta/commons/proper/collections/trunk/xdocs/index.xml (original) +++ jakarta/commons/proper/collections/trunk/xdocs/index.xml Sat Mar 25 05:56:26 2006 @@ -16,7 +16,7 @@ -- document properties - titleCommons Collections/title + titleHome/title author email=commons-dev@jakarta.apache.orgCommons Documentation Team/author /properties body Modified: jakarta/commons/proper/collections/trunk/xdocs/navigation.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/collections/trunk/xdocs/navigation.xml?rev=388762r1=388761r2=388762view=diff == --- jakarta/commons/proper/collections/trunk/xdocs/navigation.xml (original) +++ jakarta/commons/proper/collections/trunk/xdocs/navigation.xml Sat Mar 25 05:56:26 2006 @@ -15,9 +15,9 @@ limitations under the License. -- !DOCTYPE org.apache.commons.menus SYSTEM 'http://jakarta.apache.org/commons/build/maven-build.dtd' -project name=Collections +project name=Commons Collections - titleCollections/title + titleCommons Collections/title body links @@ -27,7 +27,7 @@ menu name=Commons Collections item name=Overview href=/index.html/ item name=Download href=http://jakarta.apache.org/site/downloads/downloads_commons-collections.cgi/ - item name=Users guide href=/userguide.html/ + item name=User guide href=/userguide.html/ item name=History href=/history.html/ item name=Javadoc (3.1 release) href=api-release/index.html/ /menu Modified: jakarta/commons/proper/collections/trunk/xdocs/pick.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/collections/trunk/xdocs/pick.xml?rev=388762r1=388761r2=388762view=diff == --- jakarta/commons/proper/collections/trunk/xdocs/pick.xml (original) +++ jakarta/commons/proper/collections/trunk/xdocs/pick.xml Sat Mar 25 05:56:26 2006 @@ -18,7 +18,7 @@ document properties - titleCommons Collections - Choosing a collection/title + titleChoosing a collection/title author email=commons-dev@jakarta.apache.orgCommons Documentation Team/author /properties Modified: jakarta/commons/proper/collections/trunk/xdocs/proposal.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/collections/trunk/xdocs/proposal.xml?rev=388762r1=388761r2=388762view=diff == --- jakarta/commons/proper/collections/trunk/xdocs/proposal.xml (original) +++ jakarta/commons/proper/collections/trunk/xdocs/proposal.xml Sat Mar 25 05:56:26 2006 @@ -1,6 +1,6 @@
DO NOT REPLY [Bug 38939] - [email] Errors when sending MultiPartEmail with another email as an attachment
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38939. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38939 --- Additional Comments From [EMAIL PROTECTED] 2006-03-25 15:17 --- Is there an ETA for the fix? My client deliverable is fast approaching -- I need to know if I need to write a work-around... No rush, I just need to know the situation... -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: anyone working on comments and layout preservation in .properties files item of v1.3 ?
please prefix the subject with the name of the component - robert On Fri, 2006-03-24 at 11:07 +, Horaci Macias wrote: Hi all, I recently wrote custom code to read/write properties file while preserving comments and I've just noticed this is part of one of the items on the roadmap for v1.3. Just wanted to know if anyone else is already working on this to avoid duplication of efforts. If not then I'll try suggesting patches shortly. thanks, Horaci Information contained in this e-mail and any attachments are intended for the use of the addressee only, and may contain confidential information of Ubiquity Software Corporation. All unauthorized use, disclosure or distribution is strictly prohibited. If you are not the addressee, please notify the sender immediately and destroy all copies of this email. Unless otherwise expressly agreed in writing signed by an officer of Ubiquity Software Corporation, nothing in this communication shall be deemed to be legally binding. Thank you. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [pool] Announcing Release Candidate 3 for Pool 1.3
On 3/25/06, Stephen Colebourne [EMAIL PROTECTED] wrote: Sandy McArthur wrote: I've prepared Pool 1.3-rc3 at http://people.apache.org/~sandymac/pool/1.3-rc3/ I'd appreciate it if interested parties reviewed it and tested it with their setup. For the release I would like to see the published date and version in the header line as per most other commons projects. Change project.properties: From maven.xdoc.date=bottom To maven.xdoc.date=left For the release I would also like to see API Documentation renamed to Javadoc in the left navigation. For HEAD, I would like to make some other website changes - add a Support section on the home page, re-order and rename the navigation menu, etc. to bring the site in line with other sites. Let me know if I can do this. Go for it. -- Sandy McArthur He who dares not offend cannot be honest. - Thomas Paine - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [poll] [pool] picking descriptive class names
Hello: FWIW, we use Enum as a postfix, for example JmsPropertyEnum. To me, a type, is an interface or a class, or a data-type. Type does not convey to me the idea that the object has a limited pre-defined set of values. Gary -Original Message- From: Stephen Colebourne [mailto:[EMAIL PROTECTED] Sent: Saturday, March 25, 2006 2:47 AM To: Jakarta Commons Developers List Subject: Re: [poll] [pool] picking descriptive class names Sandy McArthur wrote: The main behavior of the composite pools are configured via four type-safe enum types. I'll describe what each type controls and then suggest name variants. Let me know which one you think is the most self-evident and user friendly. Feel free to suggest new names. We use the suffix Type for all enums at work. It seems to work well. The suffix strategy implies that the class actually does real calculations or business logic IMO. The behaviour suffix is yucky. The policy suffix could be OK. Stephen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Release Validator 1.3.0 based on RC3
On Fri, 2006-03-24 at 12:44 +, Niall Pemberton wrote: P.S. Oliver isn't on the Jakarta whoweare page, although he was voted on to the PMC in January. sounds like it's time for oliver to add himself... - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[logging] redux: include jdk logger in API jar?
remy ran a regression test for RC6 (thanks :) we no long ship the jdk logger in API jar. however, tomcat uses jdk logger as it's default. so, by excluding the jdk logger, JCL 1.1 is no longer a drop in replacement at least for tomcat. so, i thought it'd be a good time to reconsider the decision to exclude the jdk logger. opinions? - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38853] - [collections] ReferenceMap clears bindings too early
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38853. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38853 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO --- Additional Comments From [EMAIL PROTECTED] 2006-03-25 19:20 --- Thanks for the report. Unfortunately, it hasn't helper me understand the issue particularly. I can reproduce the trace you supply (note that log_jre is missing from the zip). However, this doesn't help me understand what is going on. For a start, I can't even find the piece of code where the commons ReferenceMap is being created. I can't see what sequence of operations is being called, etc. This is a general problem with aspects - they break so much of what programmers expect from Java. In fact, I believe that this is just a special example of not correctly synchronizing the ReferenceMap implementation. For example, here is the javadoc of the purge mathod: /** * Purges stale mappings from this map. * p * Note that this method is not synchronized! Special * care must be taken if, for instance, you want stale * mappings to be removed on a periodic basis by some * background thread. */ And the javadoc from the top of the class: * This implementation is not synchronized. * You can use [EMAIL PROTECTED] java.util.Collections#synchronizedMap} to * provide synchronized access to a codeReferenceMap/code. Basically, ReferenceMap has no synchronization, and no thread handling. Its only interaction with threads is via the standard JDK API on a ReferenceQueue. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [logging] redux: include jdk logger in API jar?
I am in favor of putting it back (don't consider this binding though). Being able to be a drop in replacement of previous versions is pretty important for logging I think.. Mvgr, Martin robert burrell donkin wrote: remy ran a regression test for RC6 (thanks :) we no long ship the jdk logger in API jar. however, tomcat uses jdk logger as it's default. so, by excluding the jdk logger, JCL 1.1 is no longer a drop in replacement at least for tomcat. so, i thought it'd be a good time to reconsider the decision to exclude the jdk logger. opinions? - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[net] time for a new MVSFTPFileNameParser.java ?
Hi List,
This is my first post to this list ...
I have been chasing some problems when using the optional ant task FTP to
access a MVS type host.
Part of the problem is the MVSFTPEntryParser.java seems to be only halfway
implemented.
Here is a updated version of
org/apache/commons/net/ftp/parser/MVSFTPEntryParser.java
for review, note there is a lot of debug info, and further note, I am not
really a java programmer but are willing to learn, so just shoot on whatever
is moving ...
looking forward to hear your comments.
Henrik
/*
* Copyright 2005 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.net.ftp.parser;
import java.util.List;
import java.util.StringTokenizer;
import org.apache.commons.net.ftp.FTPClientConfig;
import org.apache.commons.net.ftp.FTPFile;
/**
* Implementation of FTPFileEntryParser and FTPFileListParser for IBM MVS Systems.
*
* @author a href=[EMAIL PROTECTED]Jeff Nadler/a
* @author a href=[EMAIL PROTECTED]William Noto/a
* @version $Id$
* @see org.apache.commons.net.ftp.FTPFileEntryParser FTPFileEntryParser (for usage instructions)
*/
public class MVSFTPEntryParser extends ConfigurableFTPFileEntryParserImpl
{
/**
* This is the regular expression used by this parser.
*/
private static final String REGEX = (.*)\\s+([^\\s]+)\\s*;
/**
* Although this parser is now ignoring dates, someone may someday
* figure out a way to accomodate this and this appears to be the
* format used. For now, it won't be used.
* SMC 2005/04/08
*/
static final String DEFAULT_DATE_FORMAT
= /MM/dd; // 2001/11/09
// This is not at all the tightest possible regexp for MVS LIST
// output, but I'm not a mainframe guru so I have little idea what the
// range of valid values are. I just needed to get the filename (Dsname);
// note that no other FTPFile fields can be filled in with the results of
// a LIST on MVS. The 'Referred' date seems to be 'last accessed date'
// and not 'last modified date' so I didn't bother parsing it.
//
// Of course it works perfectly as-is and it distinguishes header lines from
// file results so that's the important thing.
//
// This parser should be used when SYST returns:
// 'MVS is the operating system of this server. FTP Server is running on z/OS.'
//
// Also note that there is no concept of directories in MVS, just datasets,
// which have names composed of four dot separated names of up to 8 chars.
// As a result, FTPFile.FILE_TYPE is always used. -JN 6/2004 jnadleratsrcgincdotcom
// Sample LIST results from MVS:
//
//Volume UnitReferred Ext Used Recfm Lrecl BlkSz Dsorg Dsname
//FPFS42 3390 2004/06/23 11 FB 128 6144 PS INCOMING.RPTBM023.D061704
//FPFS41 3390 2004/06/23 11 FB 128 6144 PS INCOMING.RPTBM056.D061704
//FPFS25 3390 2004/06/23 11 FB 128 6144 PS INCOMING.WTM204.D061704
/* Format of ZOS files:
*
Volume UnitReferred Ext Used Recfm Lrecl BlkSz Dsorg Dsname
B10142 3390 2006/03/20 2 31 F 8080 PS CMN.CREF.WORK
ARCIVE Not Direct Access Device NI.NI6860.ERROR.PL.UNITTEST
B1N231 3390 2006/03/20 1 15 VB 256 27998 PO PLU
B1N192 3390 2006/03/03 1 10 U13680 13680 PS RZ1.A74A7198.BACKUP
B11298 3390 2006/03/20 11 FB 150 6000 PS RZ1.BRODCAST.DATA
B11199 3390 2006/03/03 1 10 U13680 13680 PS RZ1.ISR8062.BACKUP
ARCIVE Not Direct Access Device SQLXPLR.CNTL
B11256 3390 2006/03/17 1 62 FB 80 27920 PO TBOX.TABLES
ARCIVE Not Direct Access Device WOK.NI.NI6860.EXCEL.DIFFER
*
*/
// last two tokens describe file:
// 'PS': sequential file
// 'PO': PDS
// 'PO-E': PDS Library
// ' ': unknown, probably archived.
/*
* Format of a PDS
*0 12 34 5 6 7 8
* Name VV.MM Created Changed Size Init Mod Id
TBSHELF 01.03 2002/09/12 2002/10/11 09:371111 0 A338692
TBTOOL01.12 2002/09/12 2004/11/26 19:545128 0 A338692
*
*/
/**
* The sole constructor for a MVSFTPEntryParser object.
*
* @exception IllegalArgumentException
* Thrown if the regular expression is unparseable. Should not be seen
* under normal
svn commit: r388844 - /jakarta/commons/proper/daemon/trunk/src/native/unix/native/jsvc-unix.c
Author: jfclere
Date: Sat Mar 25 14:09:50 2006
New Revision: 388844
URL: http://svn.apache.org/viewcvs?rev=388844view=rev
Log:
Start fixing PR 36050
Modified:
jakarta/commons/proper/daemon/trunk/src/native/unix/native/jsvc-unix.c
Modified: jakarta/commons/proper/daemon/trunk/src/native/unix/native/jsvc-unix.c
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/daemon/trunk/src/native/unix/native/jsvc-unix.c?rev=388844r1=388843r2=388844view=diff
==
--- jakarta/commons/proper/daemon/trunk/src/native/unix/native/jsvc-unix.c
(original)
+++ jakarta/commons/proper/daemon/trunk/src/native/unix/native/jsvc-unix.c Sat
Mar 25 14:09:50 2006
@@ -33,6 +33,12 @@
#endif
#include time.h
+#ifdef OS_CYGWIN
+#include sys/fcntl.h
+#define F_ULOCK 0 /* Unlock a previously locked region */
+#define F_LOCK 1 /* Lock a region for exclusive use */
+#endif
+
extern char **environ;
static mode_t envmask; /* mask to create the files */
@@ -43,6 +49,33 @@
static void (*handler_int)(int)=NULL;
static void (*handler_hup)(int)=NULL;
static void (*handler_trm)(int)=NULL;
+
+#ifdef OS_CYGWIN
+/*
+ * File locking routine
+ */
+static int lockf(int fildes, int function, off_t size)
+{
+struct flock buf;
+
+switch (function) {
+case F_LOCK:
+buf.l_type = F_WRLCK;
+break;
+case F_ULOCK:
+buf.l_type = F_UNLCK;
+break;
+default:
+return -1;
+}
+buf.l_whence = 0;
+buf.l_start = 0;
+buf.l_len = size;
+
+return fcntl(fildes, F_SETLK, buf);
+}
+
+#endif
static void handler(int sig) {
switch (sig) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [poll] [pool] picking descriptive class names
On 3/25/06, Sandy McArthur [EMAIL PROTECTED] wrote: snip/ The main behavior of the composite pools are configured via four type-safe enum types. I'll describe what each type controls and then suggest name variants. Let me know which one you think is the most self-evident and user friendly. Feel free to suggest new names. 1. Specifies the how objects are borrowed and returned to the pool. a) BorrowType b) BorrowStrategy c) BorrowPolicy d) BorrowBehavior 2. Specifies the behavior of the pool when the pool is out of idle objects. a) ExhaustionPolicy b) ExhaustionBehavior c) ExhaustionType d) ExhaustionStrategy 3. Specifies the behavior of when there is a limit on the number of concurrently borrowed objects. a) LimitStrategy b) LimitPolicy c) LimitBehavior d) LimitType 4. Specifies how active objects are tracked while they are borrowed from the pool. a) TrackingBehavior b) TrackingType c) TrackingStrategy d) TrackingPolicy The enums above don't actually specify any implementation, they describe desired features of a pool. The actual implementation isn't broken down into four parts like that so try not to confuse how you would implement that feature with how you would request that feature. snap/ Why isn't it broken down like that? IMO, such enum types have limited use, unless we can guarantee reasonable (ideally, full) closure. Often, it is not possible to enumerate all the types / strategies / policies that may make sense for the varying use cases that we only attempt to foresee. In many cases, such as this one, my personal preference is to leave things pluggable, rather than enumerable. We should instead, if you and others agree, define the contracts between a pool and each of the four behaviors that you list above. We can supply (n) out-of-the-box implementations, but leave it open for a user to *easily* define a (n+1)th should such a need arise (and I believe it will, sooner or later). As a concrete example, for [scxml], we define a SCXMLExecutor (the state machine engine) accompanied by a SCXMLSemantics interface [1]. The basic modus operandi for an engine is simple - when an event is triggered, figure out which (if any) transition(s) to follow, and transit to the new set of states executing any specified actions along the way. However, there are numerous points of contention along the way. Lets take dispute resolution for example -- when more than one outbound transitions from a single state holds true. Which path do we take? The default implementation available in the distro is puristic, it will throw a ModelException. However, a user may want: * The transition defined closest to the document root to be followed * The transition defined farthest from the document root to be followed * The transition whose origin and target have the lowest common ancestor to be followed * The transition whose origin and target have the highest common ancestor to be followed Even after one of above dispute resolution algorithms is applied, if we end up with more than one candidate transitions, the user may want: * A ModelException to be thrown * The transition that appears first in document order to be followed * The transition that appears last in document order to be followed To implement any of the above choices, the user may simply extend the default SCXMLSemantics implementation, override the filterTransitionsSet() method, and use the new semantics while instantiating the SCXMLExecutor. This approach means: * We don't have to forsee all dispute resolution algorithms, and provide implementations * Users don't have to convince anyone that the algorithm they need is useful, they can just implement it if they need it * We don't even have to contend that the default puristic behavior that doesn't tolerate any non-determinism is the most common or the most useful one, it is just one that is chosen as default (because I personally believe it leads to better proof of correctness arguments). Since we're talking about Pool 2.0 and beyond, perhaps a focus on similar extensibility is justified, and maybe we should revisit the enumeration approach, even before we get to names. -Rahul (long, possibly fragmented URL below) [1] http://svn.apache.org/viewcvs.cgi/jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/SCXMLSemantics.java?view=markup - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r388846 - in /jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml: ./ env/ env/jsp/ io/ semantics/
Author: rahul
Date: Sat Mar 25 14:19:21 2006
New Revision: 388846
URL: http://svn.apache.org/viewcvs?rev=388846view=rev
Log:
Long overdue:
* Rename BuiltinFunctionWrapper to BuiltinFunctionMapper (it is a function
mapper, not a wrapper, that was just a typo)
* Remove static logs
Modified:
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/SCXMLExecutor.java
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/SimpleContext.java
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/SimpleDispatcher.java
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/URLResolver.java
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/jsp/ELEvaluator.java
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/jsp/RootContext.java
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/io/SCXMLDigester.java
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/semantics/SCXMLSemanticsImpl.java
Modified:
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/SCXMLExecutor.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/SCXMLExecutor.java?rev=388846r1=388845r2=388846view=diff
==
---
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/SCXMLExecutor.java
(original)
+++
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/SCXMLExecutor.java
Sat Mar 25 14:19:21 2006
@@ -47,7 +47,7 @@
/**
* The Logger for the SCXMLExecutor.
*/
-private static Log log = LogFactory.getLog(SCXMLExecutor.class);
+private Log log = LogFactory.getLog(SCXMLExecutor.class);
/**
* The stateMachine being executed.
Modified:
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/SimpleContext.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/SimpleContext.java?rev=388846r1=388845r2=388846view=diff
==
---
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/SimpleContext.java
(original)
+++
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/SimpleContext.java
Sat Mar 25 14:19:21 2006
@@ -31,7 +31,7 @@
public class SimpleContext implements Context {
/** Implementation independent log category. */
-protected static final Log LOG = LogFactory.getLog(Context.class);
+protected Log log = LogFactory.getLog(Context.class);
/** The parent Context to this Context. */
private Context parent;
/** The Map of variables and their values in this Context. */
@@ -159,8 +159,8 @@
*/
public void setLocal(final String name, final Object value) {
vars.put(name, value);
-if (LOG.isDebugEnabled() !name.equals(_ALL_STATES)) {
-LOG.debug(name + = + String.valueOf(value));
+if (log.isDebugEnabled() !name.equals(_ALL_STATES)) {
+log.debug(name + = + String.valueOf(value));
}
}
Modified:
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/SimpleDispatcher.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/SimpleDispatcher.java?rev=388846r1=388845r2=388846view=diff
==
---
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/SimpleDispatcher.java
(original)
+++
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/SimpleDispatcher.java
Sat Mar 25 14:19:21 2006
@@ -1,6 +1,6 @@
/*
*
- * Copyright 2005 The Apache Software Foundation.
+ * Copyright 2005-2006 The Apache Software Foundation.
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
@@ -32,7 +32,7 @@
public final class SimpleDispatcher implements EventDispatcher {
/** Implementation independent log category. */
- private static Log log = LogFactory.getLog(EventDispatcher.class);
+ private Log log = LogFactory.getLog(EventDispatcher.class);
/**
* Constructor.
Modified:
jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/URLResolver.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/scxml/trunk/src/main/java/org/apache/commons/scxml/env/URLResolver.java?rev=388846r1=388845r2=388846view=diff
==
---
svn commit: r388870 - /jakarta/commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/FractionFormatTest.java
Author: psteitz
Date: Sat Mar 25 18:33:49 2006
New Revision: 388870
URL: http://svn.apache.org/viewcvs?rev=388870view=rev
Log:
Removed jdk 1.4 dependency in FractionFormatTest.
Modified:
jakarta/commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/FractionFormatTest.java
Modified:
jakarta/commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/FractionFormatTest.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/FractionFormatTest.java?rev=388870r1=388869r2=388870view=diff
==
---
jakarta/commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/FractionFormatTest.java
(original)
+++
jakarta/commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/FractionFormatTest.java
Sat Mar 25 18:33:49 2006
@@ -231,13 +231,15 @@
public void testNumeratorFormat() {
NumberFormat old = properFormat.getNumeratorFormat();
- NumberFormat nf = NumberFormat.getIntegerInstance();
+NumberFormat nf = NumberFormat.getInstance();
+nf.setParseIntegerOnly(true);
properFormat.setNumeratorFormat(nf);
assertEquals(nf, properFormat.getNumeratorFormat());
properFormat.setNumeratorFormat(old);
old = improperFormat.getNumeratorFormat();
- nf = NumberFormat.getIntegerInstance();
+nf = NumberFormat.getInstance();
+nf.setParseIntegerOnly(true);
improperFormat.setNumeratorFormat(nf);
assertEquals(nf, improperFormat.getNumeratorFormat());
improperFormat.setNumeratorFormat(old);
@@ -245,13 +247,15 @@
public void testDenominatorFormat() {
NumberFormat old = properFormat.getDenominatorFormat();
- NumberFormat nf = NumberFormat.getIntegerInstance();
+NumberFormat nf = NumberFormat.getInstance();
+nf.setParseIntegerOnly(true);
properFormat.setDenominatorFormat(nf);
assertEquals(nf, properFormat.getDenominatorFormat());
properFormat.setDenominatorFormat(old);
old = improperFormat.getDenominatorFormat();
- nf = NumberFormat.getIntegerInstance();
+nf = NumberFormat.getInstance();
+nf.setParseIntegerOnly(true);
improperFormat.setDenominatorFormat(nf);
assertEquals(nf, improperFormat.getDenominatorFormat());
improperFormat.setDenominatorFormat(old);
@@ -261,7 +265,8 @@
ProperFractionFormat format = (ProperFractionFormat)properFormat;
NumberFormat old = format.getWholeFormat();
- NumberFormat nf = NumberFormat.getIntegerInstance();
+NumberFormat nf = NumberFormat.getInstance();
+nf.setParseIntegerOnly(true);
format.setWholeFormat(nf);
assertEquals(nf, format.getWholeFormat());
format.setWholeFormat(old);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39043] - [math] FractionFormatTest doesn't compile under JDK 1.3
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39043. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39043 --- Additional Comments From [EMAIL PROTECTED] 2006-03-26 03:54 --- Patch to fix compile error applied. Thanks! The ComplexUtils test failure does not happen on Sun Linux jdk 1.3.1_18 (which is what the 1.1 release was created with). This is disturbing, since the test is there to verify documented behavior. Looks to me like a bug in the windows 1.3 JDK, since what it causing the failures is that Math.cos(Double.POSITIVE_INFINITY) is returning a non-NAN value, which according to the API docs, it should not. The only remedy that I can think of for this is to conditionally skip the failing tests if the OS is windows. Not nice. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r388872 - in /jakarta/commons/sandbox/scxml/trunk: project.properties xdocs/navigation.xml
Author: rahul
Date: Sat Mar 25 19:11:20 2006
New Revision: 388872
URL: http://svn.apache.org/viewcvs?rev=388872view=rev
Log:
- Minor site improvements
- Stopped using clover a while back
- Readability whitespace adjustments for navigation.xml
Modified:
jakarta/commons/sandbox/scxml/trunk/project.properties
jakarta/commons/sandbox/scxml/trunk/xdocs/navigation.xml
Modified: jakarta/commons/sandbox/scxml/trunk/project.properties
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/scxml/trunk/project.properties?rev=388872r1=388871r2=388872view=diff
==
--- jakarta/commons/sandbox/scxml/trunk/project.properties (original)
+++ jakarta/commons/sandbox/scxml/trunk/project.properties Sat Mar 25 19:11:20
2006
@@ -13,7 +13,7 @@
# limitations under the License.
maven.xdoc.jsl=../commons-build/commons-site.jsl
-maven.xdoc.date=bottom
+maven.xdoc.date=left
maven.xdoc.poweredby.image=maven-feather.png
maven.xdoc.version=${pom.currentVersion}
maven.xdoc.developmentProcessUrl=http://jakarta.apache.org/commons/charter.html
@@ -32,8 +32,6 @@
maven.changelog.factory=org.apache.maven.svnlib.SvnChangeLogFactory
#maven.username=
-
-#maven.clover.license.path=
maven.checkstyle.properties=scxml-checks.xml
maven.checkstyle.header.file=scxml-asl-header.txt
Modified: jakarta/commons/sandbox/scxml/trunk/xdocs/navigation.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/scxml/trunk/xdocs/navigation.xml?rev=388872r1=388871r2=388872view=diff
==
--- jakarta/commons/sandbox/scxml/trunk/xdocs/navigation.xml (original)
+++ jakarta/commons/sandbox/scxml/trunk/xdocs/navigation.xml Sat Mar 25
19:11:20 2006
@@ -16,8 +16,20 @@
--
!DOCTYPE org.apache.commons.menus SYSTEM
'../../commons-build/menus/menus.dtd'
project name=Commons SCXML
+
titleCommons SCXML/title
+
body
+
+links
+ item name=Apache
+href=http://www.apache.org/
+ item name=Jakarta
+href=http://jakarta.apache.org/
+ item name=Commons
+href=http://jakarta.apache.org/commons//
+/links
+
menu name=Commons SCXML Resources
item name=Overview
@@ -94,4 +106,5 @@
common-menus;
/body
+
/project
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39044] - [dbutils] NPE in QueryRunner.batch() with a null array
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39044. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39044 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2006-03-26 04:16 --- Passing null violates the contract for batch() so receiving a NPE is valid behavior. It makes no sense to pass in null arrays for a batch. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [pool] why the composite pool implementation isn't plugable [was: picking descriptive class names]
On 3/25/06, Rahul Akolkar [EMAIL PROTECTED] wrote: On 3/25/06, Sandy McArthur [EMAIL PROTECTED] wrote: snip/ The main behavior of the composite pools are configured via four type-safe enum types. I'll describe what each type controls and then suggest name variants. Let me know which one you think is the most self-evident and user friendly. Feel free to suggest new names. 1. Specifies the how objects are borrowed and returned to the pool. a) BorrowType b) BorrowStrategy c) BorrowPolicy d) BorrowBehavior 2. Specifies the behavior of the pool when the pool is out of idle objects. a) ExhaustionPolicy b) ExhaustionBehavior c) ExhaustionType d) ExhaustionStrategy 3. Specifies the behavior of when there is a limit on the number of concurrently borrowed objects. a) LimitStrategy b) LimitPolicy c) LimitBehavior d) LimitType 4. Specifies how active objects are tracked while they are borrowed from the pool. a) TrackingBehavior b) TrackingType c) TrackingStrategy d) TrackingPolicy The enums above don't actually specify any implementation, they describe desired features of a pool. The actual implementation isn't broken down into four parts like that so try not to confuse how you would implement that feature with how you would request that feature. snap/ Why isn't it broken down like that? Because there are fundamentally three parts to a pool's behavior. 1. How objects are treated while they are in the idle object pool. 2. How objects are added/removed from the idle object pool. 3. How objects are treated while they are out of the pool, aka: active. I choose to map these three aspects to four types of behavior because that made the most sense in balancing the usability of the public interface and allowing the functionality to expand in new ways. Expressing all possible combinations with three enum created too many permutations of enum choices to remain usable. Splitting the choices like I did across four enum types groups them into logical chunks and means the programmer only has to consider a handful of choices at a time instead of dozens of choices at a time. IMO, such enum types have limited use, unless we can guarantee reasonable (ideally, full) closure. Often, it is not possible to enumerate all the types / strategies / policies that may make sense for the varying use cases that we only attempt to foresee. In many cases, such as this one, my personal preference is to leave things pluggable, rather than enumerable. The composite pool is already plugable, you must give it a PoolableObjectFactory. :-) We should instead, if you and others agree, define the contracts between a pool and each of the four behaviors that you list above. We can supply (n) out-of-the-box implementations, but leave it open for a user to *easily* define a (n+1)th should such a need arise (and I believe it will, sooner or later). We already provide a number of out of the box implementations: GenericObjectPool, StackObjectPool, SoftReferenceObjectPool, and soon a Composite ObjectPool. (There are also similar KeyedObjectPools) Not everything is made better because it's made plugable (or subclassable). Anything that you expose as public or protected you cannot change without risking compatibility. By making all of the implementation details private you can completely change the implementation without worrying about breaking compatibility. Also, because the composite pool implementation is so separated from the way it configured it allows for internal optimizations. The composite pool factory currently optimizes the created pool in a number of ways, including: * detecting when the idle pool will never grow over a conservatively tweaked internal threshold and chooses an ArrayList over a LinkedList because the worst case performance of an ArrayList with the size of ~15 is still better than the best case performance of a LinkedList with a size greater than zero. * detecting when a configured expression of a pool can be more efficiently expressed as a different configuration and still have the same behavior. * detecting a pool with a self-contradictory configuration and preventing the creation of a broken pool. I also have some more intrusive optimizations planned that may not be available with a more exposed implementation. The largest performance killer of the composite pool code right now is serialization due to synchronization, not the java.io.Serialize type. Different configurations need different amounts of synchronization to remain thread-safe and correct. Currently the composite pool code synchronizes more than is needed for the default and most common configuration. When I have time I'll add another optimization that figures out what is the narrowest amount of synchronization needed to remain thread-safe and maintain correct behavior. I'm pretty sure other optimizations will be made available when the composite pool can depend on Java 1.5 and take
svn commit: r388880 - in /jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite: CompositeObjectPool.java GrowManager.java
Author: sandymac
Date: Sat Mar 25 23:13:22 2006
New Revision: 30
URL: http://svn.apache.org/viewcvs?rev=30view=rev
Log:
Detect when making new objects is relatively slow or expensive.
When it is, try to anticipate demand and create idle objects
while allowing concurrent pool access. The idea came from a
discussion with Peter Steijn on ways to reduce pool latency.
Modified:
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/CompositeObjectPool.java
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/GrowManager.java
Modified:
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/CompositeObjectPool.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/CompositeObjectPool.java?rev=30r1=388879r2=30view=diff
==
---
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/CompositeObjectPool.java
(original)
+++
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/CompositeObjectPool.java
Sat Mar 25 23:13:22 2006
@@ -179,10 +179,10 @@
*/
public void addObject() throws Exception {
assertOpen();
+final Object obj = factory.makeObject();
+factory.passivateObject(obj);
synchronized (pool) {
-final Object obj = factory.makeObject();
-factory.passivateObject(obj);
-// if the pool is closed, discard returned objects
+// if the pool was closed between the asserOpen and the
synchronize then discard returned objects
if (isOpen()) {
manager.returnToPool(obj);
} else {
Modified:
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/GrowManager.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/GrowManager.java?rev=30r1=388879r2=30view=diff
==
---
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/GrowManager.java
(original)
+++
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/GrowManager.java
Sat Mar 25 23:13:22 2006
@@ -19,6 +19,8 @@
import org.apache.commons.pool.PoolableObjectFactory;
import java.io.Serializable;
+import java.util.TimerTask;
+import java.util.Timer;
/**
* Grows the pool automatically when it is exhausted.
@@ -33,6 +35,11 @@
final class GrowManager extends AbstractManager implements Serializable {
private static final long serialVersionUID = 1225746308358794900L;
+private static final Timer PREFILL_TIMER =
CompositeObjectPool.COMPOSITE_TIMER;
+
+private final Object avgLock = new Object();
+private long activateAvg = 0;
+private long makeAvg = 0;
/**
* Retreives the next object from the pool, creating new objects if the
pool has been exhausted.
@@ -43,6 +50,8 @@
public Object nextFromPool() throws Exception {
assert Thread.holdsLock(objectPool.getPool());
Object obj = null;
+
+final long startActivateTime = System.currentTimeMillis();
// Drain until good or empty
while (objectPool.getLender().size() 0 obj == null) {
obj = objectPool.getLender().borrow();
@@ -65,10 +74,15 @@
}
}
}
-
-if (obj == null) {
+if (obj != null) {
+updateActivateTimings(startActivateTime,
System.currentTimeMillis());
+} else {
+final long startMakeTime = System.currentTimeMillis();
obj = objectPool.getFactory().makeObject();
+updateMakeTimings(startMakeTime, System.currentTimeMillis());
}
+
+schedulePrefill();
return obj;
}
@@ -93,7 +107,74 @@
return obj;
}
+/**
+ * Update the moving average of how long it takes to activate and validate
idle objects.
+ * @param start start of activation and validation
+ * @param end end of activation and validation
+ */
+private void updateActivateTimings(final long start, final long end) {
+final long elapsed = end - start;
+if (elapsed 0L) {
+synchronized (avgLock) {
+activateAvg = (activateAvg * 9L + elapsed) / 10L;
+}
+}
+}
+
+/**
+ * Update the moving average of how long it takes to make a new objects.
+ * @param start start of makeObject
+ * @param end end of makeObject
+ */
+private void updateMakeTimings(final long start, final long end) {
+final long elapsed = end - start;
+if (elapsed 0L) {
+synchronized (avgLock) {
+makeAvg = (makeAvg * 9L + elapsed) / 10L;
+}
+}
+}
+
+/**
+ *
