[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12426974
]
Henri Yandell commented on IO-86:
-
On Mario's VFS comment:
I suspect we'll never have IO depending on VFS - it's lower level
architectually; but having Finder dependen
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12423207
]
Stephen Colebourne commented on IO-86:
--
One role for FileFinder would be if it had lots of set methods to setup the
file filters to use. I'm not sure how viable th
Simon Kitching wrote:
I'm with Stephen here; simple is good. Javadoc isn't expected to be
processed by anything other than the javadoc tool, and that handles
as a separator fine, so why clutter things with ?
Just to clarify my POV - if I was writing a web page inmy day job, I
would use XHTML.
On Sun, 2006-07-23 at 21:30 -0700, Henri Yandell wrote:
> On 7/23/06, Stephen Colebourne <[EMAIL PROTECTED]> wrote:
> > The concept that XML (XHTML in this case) is human readable is highly
> > dubious, and has
> > become accepted wisdom far too easily.
>
> Agreed, a .properties file is far more
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12423131
]
Niall Pemberton commented on IO-86:
---
I've deleted the FileFinder implementation and re-named FileFinderTestCase to
DirectoryWalkerTestCase.
I've also made the follow
On 7/23/06, Stephen Colebourne <[EMAIL PROTECTED]> wrote:
The concept that XML (XHTML in this case) is human readable is highly dubious,
and has
become accepted wisdom far too easily.
Agreed, a .properties file is far more readable but that's not in
question here. Bad HTML is less readable tha
The concept that XML (XHTML in this case) is human readable is highly dubious,
and has become accepted wisdom far too easily.
The first point is that it isn't 'bad' HTML, its just normal HTML. Every HTML
tool going has to be able to cope with this sort of layout so any tool
arguments fail pre
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12422927
]
Mario Ivankovits commented on IO-86:
Hmmm ... I liked the idea to have a separate component like finder which can
become a complicated piece of code. Later I though
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12422926
]
Niall Pemberton commented on IO-86:
---
I'm happy with the changes you made, except for a couple of minor points wrt to
DirectoryWalker:
1) I think the handleDirectoryE
Ugh. The bad html makes it less readable as source for me (and I'm
using vim so definitely a target for the more readableness I think).
Definitely minor - but the correct solution would be to use
instead of , I believe. That achieves what is wanted in this
javadoc (a break) without it becoming
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12422902
]
Stephen Colebourne commented on IO-86:
--
I've committed a more radical change to the finder. If people don't like it,
then it can be backed out.
FileFinder was suf
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12422896
]
Stephen Colebourne commented on IO-86:
--
Hold off any patches for now, I'm working on it...
> Add FileFinder back into Commons IO
>
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12422889
]
Stephen Colebourne commented on IO-86:
--
Its only a small addition to [io] and appears to make sense now.
One minor nit is that the most of the [io] code doesn't us
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12422871
]
Niall Pemberton commented on IO-86:
---
OK I've commited this with the following changes:
- changed method names from doXxxx to handleXxxx
- made handleDirectory() method
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12422868
]
Henri Yandell commented on IO-86:
-
I like the API - a nice simplification on the Observer pattern stuff I had. I'd
rename the FileCleaner example to something else - we
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12422867
]
Henri Yandell commented on IO-86:
-
Looking in the code - tags in the javadoc need to be correct XHTML.
> Add FileFinder back into Commons IO
>
16 matches
Mail list logo
