[PATCH 11/12] wifi: Set the interface on listening to P2P once a service is added

The interface will periodically listen to P2P frames and thus will be able to reply to a P2P scan and advertize its P2P services as well. --- plugins/wifi.c | 8 1 file changed, 8 insertions(+) diff --git a/plugins/wifi.c b/plugins/wifi.c index b63814c..0632ba0 100644 --- a/plugins/wifi.

[PATCH 06/12] main: Handle core's peer_service (de)initialization relevantly

Now enabling core's peer_service initialization and deinitialization at proper places. Also setting the peer driver from peer's core. --- src/main.c | 2 ++ src/peer.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/main.c b/src/main.c index 7cf6c9a..c401bc4 100644 --- a/src/main.c +++

[PATCH 08/12] wifi: Support Peer Service registration and unregistration

Finally linking gsupplicant logic into wifi plugin to implement peer's driver register_service and unregister_service function thus connman's core peer_service.c will be fully functional. --- plugins/wifi.c | 147 + 1 file changed, 147 insert

[PATCH 12/12] client: Adding a very basic support for (un)registering peer services

This is useful for testing only, since connmanctl does not really serve anything. bjr_query/bjr_response are byte arrays, represented as a string with every bytes as decimals separated by a ':'. upnp_service takes the upnp URI string and upnp_version a positive number. --- client/commands.c |

[PATCH 07/12] manager: Implement Peer Service DBus API related methods

Now it is possible to call Manager's methods: - RegisterPeerService - UnregisterPeerService --- src/manager.c | 116 ++ 1 file changed, 116 insertions(+) diff --git a/src/manager.c b/src/manager.c index b31ab4c..95b2be7 100644 --- a/src/mana

[PATCH 10/12] gsupplicant: Add a functiont to start listening to P2P frames

This will let the interface being discoverable and replying to P2P frames. It will be useful once we have, at least, one p2p service to advertize about without the will to be a standalone GO. --- gsupplicant/gsupplicant.h | 3 +++ gsupplicant/supplicant.c | 38 +++

[PATCH 02/12] doc: Update manager API about peer service un/registration

The specification of the peer service needs to follow what's documented in peer API. --- doc/manager-api.txt | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index a2ebea0..8bf31ad 100644 --- a/doc/manager-api.txt +++

[PATCH 04/12] peer: Add a service registration function to the peer driver

Such function will have to be provided by the wifi plugin so it will be possible to register P2P services. --- include/peer.h | 12 1 file changed, 12 insertions(+) diff --git a/include/peer.h b/include/peer.h index 2463066..5e1795f 100644 --- a/include/peer.h +++ b/include/peer.h @@

[PATCH 03/12] gsupplicant: Add helpers for adding/removing P2P services

These are meant to be used by wifi plugin when registering or unregistering Peer services. --- gsupplicant/gsupplicant.h | 19 +++ gsupplicant/supplicant.c | 126 ++ 2 files changed, 145 insertions(+) diff --git a/gsupplicant/gsupplicant.h b/gsupp

[PATCH 09/12] gsupplicant: Call p2p support callback in relevant places

At the time we detect p2p support, interface might not be related to any wifi plugin structure. When this was not a problem before, it becomes one now that peer_service.c is in use: as soon as the peer driver is set, it will try to register all existing peer services to the interfaces, and without

[PATCH 01/12] doc: Update peer api documentation about Peer Services

A Peer object has to provide a pre-parsed description of the peer services. --- doc/peer-api.txt | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/doc/peer-api.txt b/doc/peer-api.txt index 59a3351..0700e92 100644 --- a/doc/peer-api.txt +++

[PATCH 05/12] peer: Add the core implemetation of Peer service API

ConnMan will accept any (un)registration even if p2p technology and the proper peer service driver are not present. It might happen that the user will plug a p2p enabled device at some point, trigger the real registration then. Only in the case when the technology and driver are present, it will wa

[PATCH 00/12] Peer Service (un)registration API

frames. Please review, Tomasz Bursztyka (12): doc: Update peer api documentation about Peer Services doc: Update manager API about peer service un/registration gsupplicant: Add helpers for adding/removing P2P services peer: Add a service registration function to the peer driver peer: Add the

Re: [PATCH 0/2] Clean group interface and mapping

Hi Eduardo, ACK on this patch-set Thanks, Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] client: Detach threads since they are never joined

Hi, This is for pacrunner. If a patch is for pacrunner, specify it in the subject of the patch [PATCH pacrunnre] ... Commit message should have patch explanations only. Thanks, Tomasz ___ connman mailing list connman@connman.net https://lists.con

[PATCH 6/6] client: Support agent incoming Peer authorization request

Thus it is possible to accept or reject an incoming peer connection. --- client/agent.c | 52 1 file changed, 52 insertions(+) diff --git a/client/agent.c b/client/agent.c index 5a1b944..d020889 100644 --- a/client/agent.c +++ b/client/agent.c

[PATCH 3/6] agent: Fix Peer authorization reply WPS choice handling logic

If WPS details were not requested, whatever valid reply is a valid choice for accepting the request. --- src/agent-connman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/agent-connman.c b/src/agent-connman.c index f3d1bc4..b2049a3 100644 --- a/src/agent-connman.c +++ b/s

[PATCH 0/6 v2] P2P Incoming connection support

Tomasz Bursztyka (6): gsupplicant: Regroup a function for readability gsupplicant: Add GONegociationRequest signal handler agent: Fix Peer authorization reply WPS choice handling logic peer: Add a function forward incoming connection to the agent wifi: Forward the incoming P2P connection

[PATCH 1/6] gsupplicant: Regroup a function for readability

Just a minor issue, g_supplicant_interface_is_p2p_finding() was not declared along with other g_supplicant_interface_* functions. --- gsupplicant/gsupplicant.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 28cfe10..f

[PATCH 4/6] peer: Add a function forward incoming connection to the agent

This let's the incoming connection being handled through the agent. If no agent is present, nothing will happen and the incoming connection request will be ignored. --- include/peer.h | 1 + src/peer.c | 11 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/include/pe

[PATCH 5/6] wifi: Forward the incoming P2P connection request to the core

Thus the core will be able to call the Agent and the user, finally, will have the choice to accept or decline the incoming connection. --- plugins/wifi.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/plugins/wifi.c b/plugins/wifi.c index f5af702..be58bf6 100644 --- a/plu

[PATCH 2/6] gsupplicant: Add GONegociationRequest signal handler

This will be necessary to handle incoming connection request. Wifi plugin will have to bring the necessary callback to forward this request to the core Peer Agent API where the user will be able to accept or reject the connection. --- gsupplicant/gsupplicant.h | 1 + gsupplicant/supplicant.c | 3

[PATCH 2/5 v2] gsupplicant: Add GONegociationRequest signal handler

This will be necessary to handle incoming connection request. Wifi plugin will have to bring the necessary callback to forward this request to the core Peer Agent API where the user will be able to accept or reject the connection. --- gsupplicant/gsupplicant.h | 1 + gsupplicant/supplicant.c | 3

[PATCH 3/5] agent: Fix Peer authorization reply WPS choice handling logic

If WPS details were not requested, whatever valid reply is a valid choice for accepting the request. --- src/agent-connman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/agent-connman.c b/src/agent-connman.c index f3d1bc4..b2049a3 100644 --- a/src/agent-connman.c +++ b/s

[PATCH 2/5] gsupplicant: Add GONegociationRequest signal handler

This will be necessary to handle incoming connection request. Wifi plugin will have to bring the necessary callback to forward this request to the core Peer Agent API where the user will be able to accept or reject the connection. --- gsupplicant/gsupplicant.h | 1 + gsupplicant/supplicant.c | 3

[PATCH 5/5] client: Support agent incoming Peer authorization request

Thus it is possible to accept or reject an incoming peer connection. --- client/agent.c | 52 plugins/wifi.c | 19 +++ 2 files changed, 71 insertions(+) diff --git a/client/agent.c b/client/agent.c index 5a1b944..d020889 100644

[PATCH 4/5] peer: Add a function forward incoming connection to the agent

This let's the incoming connection being handled through the agent. If no agent is present, nothing will happen and the incoming connection request will be ignored. --- include/peer.h | 1 + src/peer.c | 11 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/include/pe

[PATCH 1/5] gsupplicant: Regroup a function for readability

Just a minor issue, g_supplicant_interface_is_p2p_finding() was not declared along with other g_supplicant_interface_* functions. --- gsupplicant/gsupplicant.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 28cfe10..f

[PATCH 0/5] Incoming connection support

These patches implement the incoming connection request handling, from gsupplicant's signal to the Agent API and it's support in the client. Tomasz Bursztyka (5): gsupplicant: Regroup a function for readability gsupplicant: Add GONegociationRequest signal handler agent

Re: [PATCH 0/2] Solve issues in pending wifi data

Thanks Eduardo, ACK on this patch-set Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] gsupplicant: Check peer_mapping before removing items

Hi Eduardo, ACK Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

[PATCH] peer: Make sure to disconnect relevandly on idle state transition

In case of cancelling the connection, idle will be set, but we might be in the middle of a connection so ensuring it properly cleans via calling disconnect. --- src/peer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/peer.c b/src/peer.c index 33364e2..55531ce 100644 --- a/src/peer.c +

Re: [PATCH 2/3] supplicant: Added a function to detect if p2p is finding

Very minor nitpick here: "supplicant: Added a function to detect if p2p is finding" --> "gsupplicant: Add a function to detect if p2p is finding" ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 0/3] Some improvement in p2p find

Thanks Eduardo, ACK on this patch-set. Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

[PATCH] device: Do not try to bring up an invalid device index

In certain case, the device structure exists but is not related to any device index. This fixes this issue: connmand[2510]: plugins/ofono.c:modem_probe() /ril_0 device 0x1cc9d10 connmand[2510]: src/technology.c:__connman_technology_add_device() device 0x1cc9d10 type Cellular connmand[2510]: src/t

Re: [PATCH v2] device: Make sure the device is up and running before enabling it

Hi Pasi, connmand[2510]: src/device.c:__connman_device_enable() device 0x1cc9d10 connmand[2510]: src/device.c:__connman_device_enable() device 0x1cc9d10, err -19 Can you print also the device index to see it's value? connmand[21072]: src/device.c:__connman_device_enable() device 0x1326e98, err

Re: [PATCH 2/2] wifi: Start P2P find if there's no ongoing discovery

Hi Eduardo, Just to avoid an amount of p2p_call, if another is already taking place. --- gsupplicant/gsupplicant.h | 2 ++ gsupplicant/supplicant.c | 8 plugins/wifi.c| 8 +++- 3 files changed, 17 insertions(+), 1 deletion(-) Can you split this patch in 2? first

Re: [PATCH v2] device: Make sure the device is up and running before enabling it

Hi Pasi, connmand[2510]: src/device.c:__connman_device_enable() device 0x1cc9d10 connmand[2510]: src/device.c:__connman_device_enable() device 0x1cc9d10, err -19 Can you print also the device index to see it's value? Tomasz ___ connman mailing list

Re: Background scan issues?

Hi, Thanks. I agree that it looks hardware related. But several people in the Arch Linux forums were complaining about the same issue, so it might be a widespread Linux driver shortcoming worth considering. Wait, using only ConnMan or not? Because if that happens only with ConnMan... Maybe f

Re: Background scan issues?

Hi, shall I open a new bug for the issue then? Not on ConnMan Bugzilla. This seems to be more hardware related (firmware or driver?). There is no reason for a scan to disconnect the device. The noise value you for instance seems completely bogus to me, and this may trigger roaming even tho

Re: Access Point Support in ConnMan

Hi, I am very new in Genivi ConnMan, trying to understand the design and figure out the features supported by ConnMan. From the source code connman-1.24, so far I have seen that ConnMan supports Station functionalities and P2P support would be integrated in the near future. Also in the README

Re: [PATCH] gsupplicant: Avoid invalid read during system_killed

Hi Eduardo, ACK Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] main: Change cleanup order for proper peer deinit

Hi Eduardo, ACK Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] wifi: Add sanity check in the middle of chicken and egg issue

Hi Eduardo, Got a segmentation fault in the middle of a group configuration, where the pending p2p-wlan was no more available. This check actually comes ahead of another one in interface_added. Indeed. I am pretty sure we will get some cases like that, in different context and time frames.

Re: [PATCH] gsupplicant: Do P2P detection after interface property load

Hi Eduardo, Finally it seems possible for connman to sync up with wpa_supplicant and existing interface (see patch "[PATCH v2] device: Make sure the device is up and running before enabling it" and logs from Richard Röjfors http://pastebin.com/4Bsk5B2N ) So ACK to this patch! Tomasz

[PATCH v2] device: Make sure the device is up and running before enabling it

It can happen that, after a unproper ConnMan exit, a device is still up. Once ConnMan is restarted cleanup_devices() will put this device down. But then, it will never set it up again. 04:08:45 connmand[254]: src/device.c:__connman_device_init() 04:08:45 connmand[254]: src/inet.c:__connman_inet_ge

[PATCH] device: Make sure the device is up and running before enabling it

It can happen that, after a unproper ConnMan exit, a device is still up. Once ConnMan is restarted cleanup_devices() will put this device down. But then, it will never set it up again. 04:08:45 connmand[254]: src/device.c:__connman_device_init() 04:08:45 connmand[254]: src/inet.c:__connman_inet_ge

Re: [PATCH] gsupplicant: Do P2P detection after interface property load

Hi Richard, >Wpa_supplicant should not create interface before ConnMan asks for it. >The only case when it does so, is when it creates the virtual p2p interface, >on that one we don't care to check any support. What if connman is restarted while wpa_supplicant is still running? When connman r

Re: [PATCH] wifi: Remove useless return statement in interface_added

Hi Eduardo, That's a very old left over! ACK Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] gsupplicant: Remove duplicated interface assignment on GroupStarted

Hi Eduardo, ACK Left over from first patch-set and second patch-set. Thanks, Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] gsupplicant: Fix the issue about get an invalid group structure

Hi, peer->groups store group's path, not GSupplicantGroup, so get it from group_mapping Of course... Don't ask me why I introduced this bug. Nice catch. @Patrik: Apply that patch in priority please! Thanks, Tomasz ___ connman mailing list connman@

Re: [PATCH] gsupplicant: Do P2P detection after interface property load

Hi Eduardo, When interface was already created in wpa_supplicant, p2p detection was failing. Thus, calling p2p detection after interface property has been signaled fixes this detection failure. Wpa_supplicant should not create interface before ConnMan asks for it. The only case when it does so

Re: [PATCH 05/16] agent: Provide a function for the Peer RequestPeerAuthorization call

ndatory also for every service? Indeed. Attached the new version of this patch (my git send-email fails currently, for whatever reason). Tomasz >From 111e93054497a2e86cdc79fa63b89dc5e25fb6bf Mon Sep 17 00:00:00 2001 From: Tomasz Bursztyka Date: Fri, 25 Jul 2014 14:43:54 +0300 Subject:

[PATCH] peer: Switch to relevant states when disconnecting

Let's announce first we are disconnecting and, once done, that we are idling again. --- src/peer.c | 4 1 file changed, 4 insertions(+) diff --git a/src/peer.c b/src/peer.c index 7716f67..d314c01 100644 --- a/src/peer.c +++ b/src/peer.c @@ -539,6 +539,8 @@ static int peer_disconnect(struct c

[PATCH 14/16] gsupplicant: Do not use and remove identifier parameter for peer

Wifi plugins is now using path as the only way to identify the peer while connecting or disconnecting. --- gsupplicant/gsupplicant.h | 1 - gsupplicant/supplicant.c | 14 +- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsuppli

[PATCH 16/16] client: Add support for RequestPeerAuthorization on WPS

This method will be requested by ConnMan when it will need to know whether to use WPS PIN or WPS PBC when connecting a peer. --- client/agent.c | 110 ++--- 1 file changed, 82 insertions(+), 28 deletions(-) diff --git a/client/agent.c b/client/a

[PATCH 15/16] client: Add Agent ReportPeerError method support

This will be used to report error from ConnMan. --- client/agent.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/client/agent.c b/client/agent.c index baa0a87..64c84da 100644 --- a/client/agent.c +++ b/client/agent.c @@ -368,6 +368,36 @@ static DBusMessage

[PATCH 07/16] peer: Manage peer connection properly through an Agent report

Thus the upper layer, if providing an agent, will get a report from connman and it will be possible at this point to ask for a proper retry. --- src/peer.c | 68 ++ 1 file changed, 55 insertions(+), 13 deletions(-) diff --git a/src/peer.

[PATCH 13/16] wifi: Find and use peer's path do disconnect

Peer's lookup is done in wifi plugin and not anymore in gsupplicant part. --- plugins/wifi.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 140e684..70eb661 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -306,7 +306,9

[PATCH 10/16] gsupplicant: Add an helper to find a peer via its identifier

Wifi plugin will need to find the peer to check whether it supports WPS PBC or PIN method while connectin, and action upon it. --- gsupplicant/gsupplicant.h | 2 ++ gsupplicant/supplicant.c | 45 +++-- 2 files changed, 29 insertions(+), 18 deletions(-) di

[PATCH 04/16] peer: Provide a utility function to get peer's path in the core

This will be useful in agent-connman code afterwards. --- src/connman.h | 1 + src/peer.c| 8 2 files changed, 9 insertions(+) diff --git a/src/connman.h b/src/connman.h index 068e36f..c16526e 100644 --- a/src/connman.h +++ b/src/connman.h @@ -788,6 +788,7 @@ int __connman_peer_init(

[PATCH 08/16] peer: Call Agent RequestPeerAuthorization on WPS needs

This call will be raised if only a peer support both WPS pbc and pin method and is not currently advertizing for pbc, thus the need for the user to tell which method is necessary to proceed with the connection. --- src/peer.c | 78 +++--- 1 f

[PATCH 12/16] wifi: Handle properly WPS parameters while connecting a peer

It checks whether the peer has proper WPS method requested. It can return ENOKEY in case of none can be decided (thus peer core code will request it through an agent call). --- plugins/wifi.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/plugins

[PATCH 09/16] gsupplicant: WPS PIN and Peer's path parameters are copied value

These are no longer constants, this is necessary for the future changes. --- gsupplicant/gsupplicant.h | 4 ++-- gsupplicant/supplicant.c | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 344459b..6c22aa4 100644 --

[PATCH 11/16] gsupplicant: Add an helper to get the supplicant peer's object path

Since wifi plugin will be looking up for the peer while connecting, it will be the right place to get such information for the connection parameters. --- gsupplicant/gsupplicant.h | 1 + gsupplicant/supplicant.c | 8 2 files changed, 9 insertions(+) diff --git a/gsupplicant/gsupplicant.

[PATCH 06/16] peer: Modify connect driver's signature to handle WPS properly

It will be possible to tell the WPS method which is wanted to connect to the peer. --- include/peer.h | 10 +- plugins/wifi.c | 4 +++- src/peer.c | 3 ++- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/include/peer.h b/include/peer.h index 720d65b..dd118cd 100644 --

[PATCH 05/16] agent: Provide a function for the Peer RequestPeerAuthorization call

This will be used by peer.c when there will be a need to choose between WPS PBC or PIN. This choice will be raised to the user via an agent RequestPeerAuthorization call. --- src/agent-connman.c | 167 ++-- src/connman.h | 8 +++ 2 files chan

[PATCH v2 00/16] Peer's Agent API support

v2: fixed an issue around wps pin handling This patch-set add the Peer's Agent API documentation and implementation. However, this only works in the context when ConnMan initiates the connection and not the other way round (which requires quite a bit of work to get it) Tomasz Bursztyk

[PATCH 02/16] agent: Refactor the error reporting method to be more generic

Thus it will be possible afterwards to implement RequestPeerError very simply. --- include/agent.h | 4 src/agent.c | 17 + 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/include/agent.h b/include/agent.h index 05462df..6961f7a 100644 --- a/include/agent.

[PATCH 01/16] doc: Add RequestPeerInput method to agent API

This method will be used to handle extra input which might be requested when connecting to a peer or in case a peer wants to connect to us. --- doc/agent-api.txt | 49 + 1 file changed, 49 insertions(+) diff --git a/doc/agent-api.txt b/doc/agent-api

[PATCH 03/16] agent: Add a specific function to call ReportPeerError agent method

This will be exclusively used by peer core code to report an error. --- src/agent-connman.c | 10 ++ src/connman.h | 8 2 files changed, 18 insertions(+) diff --git a/src/agent-connman.c b/src/agent-connman.c index ab538f3..7502f0f 100644 --- a/src/agent-connman.c +++ b/sr

[PATCH] agent: The reply of the error callback might be NULL

This fixes a crash when calling connman_agent_cancel(), where agent_finalize_pending() is called with a NULL reply which is then used in the callback. --- src/agent.c | 4 1 file changed, 4 insertions(+) diff --git a/src/agent.c b/src/agent.c index 37cf524..90ff670 100644 --- a/src/agent.c +

[PATCH 2/2] wifi: Handle group changed notification properly

Let's switch to configuration state. If the wifi device is currently connecting this will be handled properly, or will be discarded. --- plugins/wifi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 98d9532..4f7150d 100644 --- a/plugins/

[PATCH 0/2] P2P GC/GO mitigation fix

Hi, Last patch set messed up the GC/GO mitigation in gsupplicant/wifi, ending up in a context where connman thinks it is always the GO. Thanks to Guoqiang Liu and Eduardo Abinader for reporting and testing this. Tomasz Bursztyka (2): gsupplicant: Catch Peer and Group related signals wifi

[PATCH 1/2] gsupplicant: Catch Peer and Group related signals

Catching those signals is useful for 2 cases: - finalizing an on-going peer-group relation (Peer connection) - handling one-to-many context (when src/peer.c will be able to do so) --- gsupplicant/supplicant.c | 8 1 file changed, 8 insertions(+) diff --git a/gsupplicant/supplicant.c b/gs

Re: Background scan issues?

Hi, Thanks, what's the exact syntax for this? I had tried it before posting but nothing got fixed. Is it like this? [General] BackgroundScanning=false Looks like it. Don't know if it affects the parsing having spaces on both sides of the "=". Get the connman+wpa_supplicant logs if the prob

Re: [PATCH 01/16] doc: Add RequestPeerInput method to agent API

Hi, How does ConnMan support the remote peer which only support PIN? It does not make the distinction. This was how wpspin field was specified for connman API 1.0. That will be fixed for 2.0 version of the API probably. Tomasz ___ connman mailing

Re: [PATCH] gsupplicant: Detect p2p support based on capability modes

ACK from me Thanks Eduardo Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: Background scan issues?

Hi, A quick hypothesis is that RSSI drops below a certain threshold (-45?) and connman (actually wpa_supplicant) decides to perform a background scan thinking I'm roaming, which may cause some connectivity problems? Can I alter that threshold or disable bgs on a network per network basis? If b

Re: [PATCH] dhcp: Fixed Crash on Switching Network

Hi, Thanks, patch looks ok to me. But that does not fix the root cause yet since basically, connman should never start dhcp client if the device is not up. Though I think your patch should come in anyway, it's indeed necessary to know if the initialization went fine before proceeding further.

Re: [PATCH] service: Fix connection logic when called from D-Bus

Hi, root:/usr/lib/connman/test> ./test-connman connect wifi_00dbdf140abe_54502d4c494e4b5f343736383741_managed_psk root:/usr/lib/connman/test> ./test-connman connect wifi_00dbdf140abe_54502d4c494e4b5f343736383741_managed_psk net.connman.Error.Failed: Input/Output Error There is actually an er

Re: [PATCH] dhcp: Return true if network not available

ACK from me. Thank you Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] dhcp: only apply dhcp result to service when network available

If there is no network is silently make the function to poss, so returning true. to pAss ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] dhcp: only apply dhcp result to service when network available

Hi, +++ b/src/dhcp.c @@ -459,7 +459,8 @@ static void lease_available_cb(GDHCPClient *dhcp_client, gpointer user_data) __connman_ipconfig_set_gateway(dhcp->ipconfig, gateway); } -if (!apply_lease_available_on_network(dhcp_client, dhcp)) +if (dhcp->network +&& !

Re: [PATCH] dhcp: only apply dhcp result to service when network available

Hi, +++ b/src/dhcp.c @@ -459,7 +459,8 @@ static void lease_available_cb(GDHCPClient *dhcp_client, gpointer user_data) __connman_ipconfig_set_gateway(dhcp->ipconfig, gateway); } - if (!apply_lease_available_on_network(dhcp_client, dhcp)) + if (dhcp->network +

[PATCH 16/16] client: Add support for RequestPeerAuthorization on WPS

This method will be requested by ConnMan when it will need to know whether to use WPS PIN or WPS PBC when connecting a peer. --- client/agent.c | 110 ++--- 1 file changed, 82 insertions(+), 28 deletions(-) diff --git a/client/agent.c b/client/a

[PATCH 12/16] wifi: Handle properly WPS parameters while connecting a peer

It checks whether the peer has proper WPS method requested. It can return ENOKEY in case of none can be decided (thus peer core code will request it through an agent call). --- plugins/wifi.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/plugins/

[PATCH 14/16] gsupplicant: Do not use and remove identifier parameter for peer

Wifi plugins is now using path as the only way to identify the peer while connecting or disconnecting. --- gsupplicant/gsupplicant.h | 1 - gsupplicant/supplicant.c | 14 +- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsuppli

[PATCH 11/16] gsupplicant: Add an helper to get the supplicant peer's object path

Since wifi plugin will be looking up for the peer while connecting, it will be the right place to get such information for the connection parameters. --- gsupplicant/gsupplicant.h | 1 + gsupplicant/supplicant.c | 8 2 files changed, 9 insertions(+) diff --git a/gsupplicant/gsupplicant.

[PATCH 10/16] gsupplicant: Add an helper to find a peer via its identifier

Wifi plugin will need to find the peer to check whether it supports WPS PBC or PIN method while connectin, and action upon it. --- gsupplicant/gsupplicant.h | 2 ++ gsupplicant/supplicant.c | 45 +++-- 2 files changed, 29 insertions(+), 18 deletions(-) di

[PATCH 08/16] peer: Call Agent RequestPeerAuthorization on WPS needs

This call will be raised if only a peer support both WPS pbc and pin method and is not currently advertizing for pbc, thus the need for the user to tell which method is necessary to proceed with the connection. --- src/peer.c | 59 +++ 1 file

[PATCH 15/16] client: Add Agent ReportPeerError method support

This will be used to report error from ConnMan. --- client/agent.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/client/agent.c b/client/agent.c index baa0a87..64c84da 100644 --- a/client/agent.c +++ b/client/agent.c @@ -368,6 +368,36 @@ static DBusMessage

[PATCH 06/16] peer: Modify connect driver's signature to handle WPS properly

It will be possible to tell the WPS method which is wanted to connect to the peer. --- include/peer.h | 10 +- plugins/wifi.c | 4 +++- src/peer.c | 3 ++- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/include/peer.h b/include/peer.h index 720d65b..dd118cd 100644 --

[PATCH 13/16] wifi: Find and use peer's path do disconnect

Peer's lookup is done in wifi plugin and not anymore in gsupplicant part. --- plugins/wifi.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index e789f8c..95bc458 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -305,7 +305,9

[PATCH 09/16] gsupplicant: WPS PIN and Peer's path parameters are copied value

These are no longer constants, this is necessary for the future changes. --- gsupplicant/gsupplicant.h | 4 ++-- gsupplicant/supplicant.c | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 387a3aa..ff56001 100644 --

[PATCH 07/16] peer: Manage peer connection properly through an Agent report

Thus the upper layer, if providing an agent, will get a report from connman and it will be possible at this point to ask for a proper retry. --- src/peer.c | 66 +- 1 file changed, 53 insertions(+), 13 deletions(-) diff --git a/src/peer.

[PATCH 03/16] agent: Add a specific function to call ReportPeerError agent method

This will be exclusively used by peer core code to report an error. --- src/agent-connman.c | 10 ++ src/connman.h | 8 2 files changed, 18 insertions(+) diff --git a/src/agent-connman.c b/src/agent-connman.c index ab538f3..7502f0f 100644 --- a/src/agent-connman.c +++ b/sr

[PATCH 05/16] agent: Provide a function for the Peer RequestPeerAuthorization call

This will be used by peer.c when there will be a need to choose between WPS PBC or PIN. This choice will be raised to the user via an agent RequestPeerAuthorization call. --- src/agent-connman.c | 167 ++-- src/connman.h | 8 +++ 2 files chan

[PATCH 04/16] peer: Provide a utility function to get peer's path in the core

This will be useful in agent-connman code afterwards. --- src/connman.h | 1 + src/peer.c| 8 2 files changed, 9 insertions(+) diff --git a/src/connman.h b/src/connman.h index 068e36f..c16526e 100644 --- a/src/connman.h +++ b/src/connman.h @@ -788,6 +788,7 @@ int __connman_peer_init(

[PATCH 02/16] agent: Refactor the error reporting method to be more generic

Thus it will be possible afterwards to implement RequestPeerError very simply. --- include/agent.h | 4 src/agent.c | 17 + 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/include/agent.h b/include/agent.h index 05462df..6961f7a 100644 --- a/include/agent.

<    1   2   3   4   5   6   7   8   9   10   >