Re: [PATCH v0 13/13] tap-test: Set device name with null termination

Hi Daniel, - strncpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name)); + strncpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name) - 1); Same as patch 4: IFNAMSIZ or these sizeof(), we have to choose 1 way. Tomasz ___ connman mailing list

Re: [PATCH v0 10/13] ipv4ll: Initialize socket variable

Hi Daniel, FWIW, in a couple of other functions memset is used. I do not really care, but would like to have a consistent style. What's the preference? We need Marcel's input on that ;) Tomasz ___ connman mailing list connman@connman.net

Re: [PATCH v0 04/13] inet: Set device name with null termination

Hi Jukka, Either use IFNAMSIZ or sizeof(ifr.ifr_name) but let's not mix both. I would prefer sizeof(), that way you do not need to know how long the buffer is suppose to be. I agree Tomasz ___ connman mailing list connman@connman.net

Re: APIPA regression in connman wired ethernet (bump)

Hi Tim, Could you resend your logs and the exact steps you followed? On my side I just tried: starting connman, plugging in ethernet cable... and it worked. Are your steps different then that? Here is the output: connmand[14904]: Skipping disconnect of carrier, network is connecting.

Re: src/technology.c:technology_get() No matching drivers found for wifi

Hi Steve, Do you have wpa_supplicant installed? (and properly build: look at connman's README file to get the right configuration) Connman's technology drivers are not literally hardware drivers: they are backend drivers (wifi connman's driver is against wpa_supplicant, bluetooth connman's

Re: Cellular connection with oFono/ConnMan

Hi Yannick, You need to ask ConnMan to connect the related cellular service that should show up in the service list. What you are listing here is the supported technologies that ConnMan detected on your setup. Try connmanctl tool, to list the service and to connect the relevant one. Tomasz

[PATCH] service: Proxy should be reset when disconnecting

Fixes an issue where WPAD is started only at first connection, not after a disconnection: it takes for granted the previous proxy setting which is bogus (since last wpad url has be nuked) --- src/service.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/service.c b/src/service.c index

[PATCH] gweb: Properly proceed a request through a proxy when one is set

This fixes a logical bug in gweb, as for a given host: if a proxy address is provided it should resolv its DNS through g_resolv and not getaddrinfo: g_resolv will then use the nameservers that have been set to the g_web session. Indirectly, this fixes a bug when ConnMan was always staying at

[PATCH] wispr: Get the proper proxy address from the result

It has to strip away the PROXY word and spaces from the proxy lookup result, or then gweb won't be able to resolve it. --- src/wispr.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/wispr.c b/src/wispr.c index 7894537..32cf75a 100644 --- a/src/wispr.c +++

[PATCH] service: 32bits boolean should be used due to dbus in relevant places

--- src/service.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index 288deb7..60a9769 100644 --- a/src/service.c +++ b/src/service.c @@ -1412,15 +1412,18 @@ static void immutable_changed(struct connman_service *service) static void

[PATCH 1/5] technology: 32bits boolean should be used due to dbus in relevant places

--- src/technology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/technology.c b/src/technology.c index b3adb86..3f11075 100644 --- a/src/technology.c +++ b/src/technology.c @@ -839,8 +839,8 @@ static DBusMessage *set_property(DBusConnection *conn,

[PATCH 5/5] dundee: 32bits boolean should be used due to dbus in relevant places

--- plugins/dundee.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/plugins/dundee.c b/plugins/dundee.c index e49f0c8..b72c69e 100644 --- a/plugins/dundee.c +++ b/plugins/dundee.c @@ -539,7 +539,10 @@ static gboolean device_changed(DBusConnection *conn, *

[PATCH 0/5] Boolean length issue

Here are my findings about boolean length issues. Patrik has some also to come. Tomasz Bursztyka (5): technology: 32bits boolean should be used due to dbus in relevant places service: 32bits boolean should be used due to dbus in relevant places ofono: 32bits boolean should be used due

[PATCH 2/5] service: 32bits boolean should be used due to dbus in relevant places

--- src/service.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index 288deb7..60a9769 100644 --- a/src/service.c +++ b/src/service.c @@ -1412,15 +1412,18 @@ static void immutable_changed(struct connman_service *service) static void

[PATCH 4/5] vpn: 32bits boolean should be used due to dbus in relevant places

--- plugins/vpn.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/plugins/vpn.c b/plugins/vpn.c index 14a6063..cc38890 100644 --- a/plugins/vpn.c +++ b/plugins/vpn.c @@ -605,7 +605,10 @@ static void add_connection(const char *path, DBusMessageIter *properties,

[PATCH 3/5] ofono: 32bits boolean should be used due to dbus in relevant places

--- plugins/ofono.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 939cd7f..d791b1b 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -1066,7 +1066,7 @@ static int add_cm_context(struct modem_data *modem, const char

[PATCH] technology: 32bits boolean should be used due to dbus in relevant places

--- src/technology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/technology.c b/src/technology.c index b3adb86..3f11075 100644 --- a/src/technology.c +++ b/src/technology.c @@ -839,8 +839,8 @@ static DBusMessage *set_property(DBusConnection *conn,

[PATCH] wifi: Fix a memory leak when trying to connect a disconnecting network

--- plugins/wifi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 7a80076..bac1fc6 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -1367,9 +1367,10 @@ static int network_connect(struct connman_network *network)

[PATCH 1/3] settings: Add support for tweaking autoscan parameters

In particular cases, it can be useful to tweak such parameters. Depending on target device. --- include/setting.h | 1 + src/main.c| 23 ++- src/main.conf | 12 3 files changed, 35 insertions(+), 1 deletion(-) diff --git a/include/setting.h

[pacrunner PATCH] libproxy: Remove useless output

Fixes #CM-647 --- libproxy/proxy.c | 4 1 file changed, 4 deletions(-) diff --git a/libproxy/proxy.c b/libproxy/proxy.c index e2b4978..7a083eb 100644 --- a/libproxy/proxy.c +++ b/libproxy/proxy.c @@ -73,8 +73,6 @@ static char *parse_result(const char *str) char *result; int

[pacrunner PATCH v3 4/7] libproxy: Support slicing the result string into relevant list

Fixes BMC#26021 --- libproxy/proxy.c | 126 ++- 1 file changed, 87 insertions(+), 39 deletions(-) diff --git a/libproxy/proxy.c b/libproxy/proxy.c index ae53a7a..e2b4978 100644 --- a/libproxy/proxy.c +++ b/libproxy/proxy.c @@ -66,55 +66,100 @@

Re: wifi: scan all stored hidden networks relevantly

Hi Grant, On Thu May 16 05:32:29 PDT 2013, Tomasz Bursztyka tomasz.burszt...@linux.intel.com wrote: - if (get_hidden_connections(driver_max_ssids, scan_params) 0) { + if (get_hidden_connections_params(wifi, scan_params) 0) { ret = g_supplicant_interface_scan(wifi

Re: [PATCH] Tethering: Add the open Wi-Fi Access Point

Hi, NACK from me on this one. I will pass the discussion whether we want or not such feature. I will concentrate only on the patch: --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -2035,6 +2035,7 @@ static int tech_set_tethering(struct connman_technology *technology, }

[PATCH v2] wifi: scan all stored hidden networks relevantly

Currently a scan will only scan the first found stored hidden network. This patch fixes it: it will scan all, taking into account the limit of scan parameters the driver can take. Thanks to Jukka for testing this. --- 1 memory leak and 1 invalid read fixed. I simplified how frequencies are

[PATCH] README: update information about wpa_supplicant built config

--- README | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/README b/README index bfb246a..4ad0e83 100644 --- a/README +++ b/README @@ -274,14 +274,21 @@ CONFIG_WPS=y CONFIG_AP=y CONFIG_CTRL_IFACE_DBUS_NEW=y -and, add: +add: CONFIG_BGSCAN_SIMPLE=y This

[PATCH v2] README: update information about wpa_supplicant built config

--- Small typo fixed README | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/README b/README index bfb246a..161c535 100644 --- a/README +++ b/README @@ -274,14 +274,21 @@ CONFIG_WPS=y CONFIG_AP=y CONFIG_CTRL_IFACE_DBUS_NEW=y -and, add: +add:

[PATCH] wifi: scan all stored hidden networks relevantly

Currently a scan will only scan the first found stored hidden network. This patch fixes it: it will scan all, taking into account the limit of scan parameters the driver can take. --- Tested it quickly and seems to work, while enforcing driver_max_ssids to be 1. Please review, plugins/wifi.c |

Re: [PATCH 1/3] doc: add documentation for P2P related API modifications

Hi Simon, + boolean P2P [readwrite] + + This option allows to enable or disable the support + for P2P wireless network also known as WiFi Direct. + + When P2P is enabled scanning will scan for P2P peer +

Re: API proposal for WiFi Direct support

Hi Simon, I am not completely aware of P2P stuff, so some of my comments might be bogus. Attached to this mail are three patches which outline the needed modifications to support group formation (with GO negotiation and autonoumous group support). It would be great if you can take a look

Re: PowerPC Build Failure

Hi Jack, | plugins/tist.c: In function 'set_custom_baud_rate': | plugins/tist.c:283:18: error: 'TCGETS2' undeclared (first use in this function) | plugins/tist.c:283:18: note: each undeclared identifier is reported only once for each function it appears in | plugins/tist.c:291:18: error:

Re: gadget ethernet problem

Hi Petr, Just noticed that you are using connman 1.8 which is not that up to date. Could you switch to later version? From your log it looks like the technology is properly registered, and device found etc... maybe a bug somewhere. Tomasz ___

Re: gadget ethernet problem

Hi Petr, Your logs go fine until src/device.c:connman_device_register() then... no __connman_technology_add_device() Could you rerun connman but with: connmand -n -d src/device.c,src/technology.c,src/rtnl.c,plugins/ethernet.c Just modprobe your usb module, don't configure anything with

Re: [PACRunner PATCH 0/2] Fix JAVASCRIPT_ROUTINES for v8

Hi Joshua, Thanks for the patch! ACK from me. Tomasz We'd noticed that PACRunner's FindProxyForURL() was always returning DIRECT when using the v8 backend. Tomasz helped trace the issue to an error from v8 Uncaught TypeError: object is not a function Which, with some further digging, was

Re: Wifi direct support for connman

Hi Simon, Afaik nobody is working on it. Some people before have told having the same interest as you on wifi direct (or p2p) but no news since then. So patches are warmly welcome! Br, Tomasz Hey everybody, I am pretty interested in wifi direct support within connman. I know there were

[PATCH] neard: RequestOOB() method sends empty dictionnary

Reported by Ravikumar Veeramally --- plugins/neard.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/plugins/neard.c b/plugins/neard.c index 85cf06b..83561fe 100644 --- a/plugins/neard.c +++ b/plugins/neard.c @@ -172,6 +172,9 @@ static int

Re: [RFC] iptables-test: Add dump command

Hi Daniel, Hi Tomasz, What do you think about this? Yes I agree the __connman_log_init() is dirty but we can't really add '-d' because that belongs also to iptables command set. And enabling __connman_log_init() always is bit too much in my opinion. Looks fine to me, iptables-test is a test

Re: [PATCH v6 00/14] iptables refactoring

Hi Daniel, ACK from me :) Tomasz ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH v5 00/12] [RESEND] iptables refactoring

Hi Daniel, ACK from me. Let's put aside patch 4 as we discussed. Cheers, Tomasz ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH v4 11/11] iptables: find_chain_tail should return last entry

Le 07/03/2013 16:45, Daniel Wagner a écrit : On 03/07/2013 03:33 PM, Patrik Flykt wrote: On Thu, 2013-03-07 at 14:35 +0100, Daniel Wagner wrote: Currently, find_chain_tail() returns the element after the chain end. Let's keep it the old way until there is a real reason to do something else.

Re: [PATCH v4 10/11] iptables: Refactor iptables_delete_rule()

Le 07/03/2013 15:35, Daniel Wagner a écrit : - /* We have deleted a rule, -* all references should be bumped accordingly */ + /* +* We have deleted a rule, all references should be bumped +* accordingly +*/ What an improvement ;] Just kidding.

Re: [PATCH v4 00/11] iptables refactroring

Hi Daniel, I really should spend more time in explaining stuff in the cover letter. These patches are kind of left overs from the bug fixing session and not really necessary if you think in 'does it fix a bug' or 'it's a new feature'. These patches are just plain maintaining work which

Re: [PATCH v4 10/11] iptables: Refactor iptables_delete_rule()

Hi Daniel, And then I just realized that in iptables_flush_chain() the exact open coded update function exists: Of course duplication is not ok. See, it was worth being picky: now you found a interesting refactorization point, which you patch was not correcting. Please redo your patch

Re: Connman upstream test result_20130308

Hi, reproduced bugs: === 25125 - There is still IP address on client after disable-tethering bluetooth https://bugs.meego.com/show_bug.cgi?id=25125 This one is no longer relevant to reproduce with wrong version of BlueZ. It has been resolved/fixed

Re: [PATCH v3 05/10] iptables: Improve debug log output

Hi Daniel, @@ -1669,7 +1677,18 @@ static struct connman_iptables *pre_load_table(const char *table_name, if (table != NULL) return table; - return iptables_init(table_name); + table = g_hash_table_lookup(table_hash, table_name); + if (table != NULL) +

Re: [PATCH v3 7/9] iptables: Remove wrong sanity check in prepare_rule_inclusion()

As far as I see this patch does not fix anything. nack. Tomasz ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH v3 8/9] iptables: Fix chain tail handling

Hi Daniel, There is no fix here, it's only a refactoring. Please, change the commit message. Tomasz ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH v3 9/9] iptables: Fix setting policy

Hi Daniel and Patrik, On Wed, 2013-03-06 at 12:04 +0100, Daniel Wagner wrote: The policy of a chain is the last element not the first one. Isn't the default policy is applicable only for a builtin chain and is a property of the table itself?? This patch does not make sense: there is no

Re: [PATCH v3 7/9] iptables: Remove wrong sanity check in prepare_rule_inclusion()

Actually: This check does not make sense at all. We want to insert the new rule always on the first position, that means the chain_head points to the 'old' entry. Wait no: this is only true when you insert a rule, not when you append one. And finally - my mistake because I should have

Re: [PATCH v3 7/9] iptables: Remove wrong sanity check in prepare_rule_inclusion()

Hi Daniel, And finally - my mistake because I should have reviewed it properly - I am not happy with your: __connman_iptables_append() I can't follow. __connman_iptables_append() adds the rules at the beginning of the chain. So the name is missleading in my opinion. Append and Insert

Re: [PATCH v3 9/9] iptables: Fix setting policy

Hi Daniel, The orignal code assumes that the builtin chain is empty which is obviously always the right assumption :). That is actually the bug in the original code: it might not be empty. If it is, it does the right change, if not it modifies the 1 rule in the chain. Tomasz

Re: [PATCH v4 6/6] iptables: Allow to set valid policy verdicts only

Hi Daniel, From: Daniel Wagner daniel.wag...@bmw-carit.de --- src/iptables.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/iptables.c b/src/iptables.c index 93778fa..66a7d2a 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -275,6 +275,19 @@

Re: [PATCH v3 9/9] iptables: Fix setting policy

Le 06/03/2013 16:32, Daniel Wagner a écrit : Hi Tomasz, On 03/06/2013 02:11 PM, Tomasz Bursztyka wrote: The orignal code assumes that the builtin chain is empty which is obviously always the right assumption :). That is actually the bug in the original code: it might not be empty

Re: [PATCH v3 7/9] iptables: Remove wrong sanity check in prepare_rule_inclusion()

Hi Daniel, The definition is pretty clear in my opinion. 'append' means insert rule at the end of the chain, 'insert' at any position defined by the index. no? No index in the story here. Moreover we don't handle rule numbers in our code. append put the rule at the and of the list,

Re: [PATCH v5 0/7] iptables bug fixes

ACK from me! From: Daniel Wagner daniel.wag...@bmw-carit.de changes: - patch #6: use opencoding for verdict - patch #7: fix append/insert confusion cheers, daniel original cover letter This is a subset which contains only bugfixes from the series called '[PATCH v0 00/16] Managed iptables

Re: [RFC 01/12] doc: Add method call and signal for tethering information

Hi Martin, 1. MAC address of the remote devices What's the use case? Is there a plan to filter the access by MAC address like in android afterwards? Br, Tomasz ___ connman mailing list connman@connman.net

Re: [PATCH v2] wifi: Preliminary fix for autoscanning known hidden SSIDs

Hi Sameer, Hello Tomasz, I tested your patch and it works when there is only one provisioned hidden service (as expected). Thanks for testing it. I will do a patch for scanning the whole set, but I am a bit busy right now. Let's say end of next week. Br, Tomasz

Re: [PATCH v0 00/16] Managed iptables API

Hi Daniel, So this is almost two years ago. And there were more than 10 releases after this commit. Isn't it so it appeared in version 1.4.8? We could enforce the usage of this version or later when building connman then. Cheers, Tomasz ___

[PATCH v2] wifi: Preliminary fix for autoscanning known hidden SSIDs

Currently, it relies on max_ssids to know how many SSIDs it can provide as paremeters. However, patch 6af0579c434058536fb40480f40f5e9895cfe863, which fixes an issue about fast scanning, affects such feature. Therefore, as a default, it will fallback to 1 if given max_ssids is 0. There is still

Re: [PATCH v1 1/4] iptables: Fix is_fallthrough() check

Hi Daniel, target = ipt_get_target(e-entry); - if (!strcmp(target-u.user.name, )) - return true; + if (!strcmp(target-u.user.name, IPT_STANDARD_TARGET)) { + struct xt_standard_target *t; + t = (struct xt_standard_target *)target; +

Re: [RFC v1 04/16] inet: Add functions to setup fwmark to routing table

Hi Daniel, + +/* + * Tie the table number to interface index number, substract 1 because + * indexes are 0 + */ +static uint32_t get_table_id(int ifindex) +{ + const uint32_t value = ('c' 24) | ('m' 16) | ('a' 8) | 'n'; + + return value + ifindex - 1; +} Don't introduce this

Re: [RFC v1 07/16] netfilter: Add netlink basic infrastructure

Hi Daniel, Instead of factoring out common parts from rtnl.c we add a new implementation for handling the upcoming ACCT netfilter netlink messages. The main reason is not to disturb the working rtnl code (although it has several hidden bugs, which are not triggered by the ussage pattern). The

Re: [RFC v1 13/16] session: Store creation related data into a struct

Hi Daniel, During the creation period we need to keep track of data which is only needed during this period. Let's rename user_config to create_data and store all the necessary data there. This includes the session pointer so that we don't have to pass two void pointers around in the callbacks

Re: [RFC v1 07/16] netfilter: Add netlink basic infrastructure

Hi Marcel, Let's adapt (and fix if necessary) rtnl instead. In the near future there is a nicer netlink handling code which is coming also, so it will require a bit of work in rtnl anyway. You might want to wait for this maybe. Check this with Marcel. is ACCT netfilter plain netlink or

Re: Autoconnect to a hidden wifi service.

Hi Sameer, I am wondering whether connman is supposed to be able to autoconnect to this hidden wifi service or is this the expected behaviour. It should autoconnect also with hidden service. Works perfectly with my config but there is maybe an issue with yours. Could you provide the logs of

Re: Understanding connman's ONLINE state change.

Hi Sameer, I guess this is the expected behaviour. You guess right. I would like to know if it is possible to instruct connman to connect all available technologies, so that at startup it connects to the wired as well as the wireless services and then decides which one to setup as the

[PATCH] neard: Use -1 instead of DBUS_TIMEOUT_USE_DEFAULT for compatibility reason

DBUS_TIMEOUT_USE_DEFAULT appeared only in dbus-1.4.12, but earlier version is still in use in some distribution like Fedora 17. --- plugins/neard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/neard.c b/plugins/neard.c index 145ab9e..30ad49a 100644 ---

[PATCH v2] neard: Use a timeout instead of DBUS_TIMEOUT_USE_DEFAULT for compatibility reason

DBUS_TIMEOUT_USE_DEFAULT appeared only in dbus-1.4.12, but earlier version is still in use in some distribution like Fedora 17. --- plugins/neard.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/neard.c b/plugins/neard.c index 145ab9e..85cf06b 100644 ---

Re: [PATCH v0 07/16] iptables: Print xtables version code only once

Hi Daniel, I am actually wondering if we should not just get rid of support of previous xtables (= 5). Which distro is still using such old xtables version? Tomasz ___ connman mailing list connman@connman.net

Re: [PATCH v0 09/16] iptables: Avoid inline ifdef by refactoring option table update

Hi Daniel, I don't see much point of this refactoring as well. Moreover we should verify if we can get rid of old xtables support. Tomasz ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH v0 11/16] iptables: Add managed append/delete functions

Hi Daniel, +int __connman_iptables_managed_append(const char *table_name, + const char *chain, + const char *rule_spec) +{ + return __connman_iptables_append(table_name, chain, rule_spec); +} + +int

Re: [PATCH v0 13/16] iptables: Flush connman chains

Le 27/02/2013 17:55, Daniel Wagner a écrit : From: Daniel Wagner daniel.wag...@bmw-carit.de Flush only ConnMan's own rules and chains. The chains naming pattern is connman-[CHAIN NAME]. That makes it simple to find again. --- src/iptables.c | 97

Re: [PATCH v0 14/16] iptables: Add managed infrastructure

Hi Daniel, +} + +static int chain_to_index(const char *chain_name) +{ + if (!strcmp(hooknames[NF_IP_PRE_ROUTING], chain_name)) + return 0; + if (!strcmp(hooknames[NF_IP_LOCAL_IN], chain_name)) + return 1; + if (!strcmp(hooknames[NF_IP_FORWARD],

Re: [PATCH v0 16/16] nat: Use managed iptables API

Hi Daniel, diff --git a/src/nat.c b/src/nat.c index 5447eb7..e30101b 100644 --- a/src/nat.c +++ b/src/nat.c @@ -73,7 +73,7 @@ static int enable_nat(struct connman_nat *nat) nat-address, nat-prefixlen,

Re: [PATCH v0 00/16] Managed iptables API

Hi Daniel, then what's happening isL iptables -t filter -N connman-OUTPUT iptables -t filter -A OUTPUT -j connman-OUTPUT iptables -t filter -A connman-OUTPUT -j LOG Obviously, the secound rule should not append but insert at first position in the builtin chain. Will fix this in the

Re: [PATCH v0 08/16] iptables: Improve debug log output

Hi Daniel, + table-name = g_strdup(table_name); + g_hash_table_insert(table_hash, g_strdup(table_name), table); Duplicate storage here. Change it so: g_hash_table_insert(table_hash, table-name, table); Of course initiate table_hash like: g_hash_table_new(g_str_hash,

Re: [PATCH] doc: Update overview-api.txt

Hi Sameer, Works for me, but i think you should address it from the point of view of Hidden networks and then expand it to say that the grouping also applies to networks with the same SSID / Authentication methods. Since it is more likely that a user is going to encounter this situation with

[PATCH v2] doc: Update overview-api.txt

- Introduce the user to per SSID/Security Wifi networks grouping - Agent is no longer a future feature and user should be aware of how he can provide required information when connecting to a service. --- doc/overview-api.txt | 26 ++ 1 file changed, 22 insertions(+), 4

[PATCH v2 3/6] config: Remove superfluous error code

It simplifies the code removing uselesse variable, moreover such variable has the same name as an existing label in the same function. --- src/config.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/src/config.c b/src/config.c index

[PATCH v2 2/6] neard: Add neard plugin with tethering info sharing support

RequestOOB() agent method is implemented, PushOOB() has yet to be supported. --- Makefile.plugins | 5 + configure.ac | 5 + plugins/neard.c | 382 +++ 3 files changed, 392 insertions(+) create mode 100644 plugins/neard.c diff --git

[PATCH v2 4/6] config: Make load service from each keyfile group as a function

--- src/config.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/src/config.c b/src/config.c index cefe3c9..098ef61 100644 --- a/src/config.c +++ b/src/config.c @@ -714,15 +714,33 @@ err: return FALSE; } +static

[PATCH v2 5/6] config: Add a function to provision mutable service

The point here is to create a virtual configuration, which does not come from a real file. This is a handy way for plugins to be able to provision services without creating any file on the FS. In case of a wifi configuration type and if connect is requested, it will trigger a scan, thus leading

[PATCH v2 6/6] neard: Add partial support for wifi provisionning via NFC

PushOOB() method implementation. Currently it only supports basic open/psk based provisions. EAP has yet to be supported. --- plugins/neard.c | 273 1 file changed, 257 insertions(+), 16 deletions(-) diff --git a/plugins/neard.c

Re: UI implemetation for connecting to a hidden network

Hi Sameer, Now, this is fine if there is only one hidden network listed. Say for example there are 2 hidden networks, user would have a difficult time figuring out the networks they are suppposed to connect to. Of course you can take a best guess based on the security being used, the signal

Re: UI implemetation for connecting to a hidden network

Hi Sameer, Services are grouped by security. You could have 100 hidden service, if all are wpa/wpa2 -- you will see only 1 hidden service on security psk. I had no idea about this. I imagined that each hidden service would be listed. Your response makes a lot of send to me now. Maybe we

Re: UI implemetation for connecting to a hidden network

Hi Marcel, Maybe we can improve the documentation then, you are not the first one who asks about that. we should do exactly that. Explain in the agent documentation how hidden WiFi networks are handled. Can you take care of this? Sure. Tomasz ___

Re: [PATCH] doc: Update overview-api.txt

Hi Sameer, Hello Tomasz, In the patch you have mentioned that: A hidden service will be named as Hidden. In my tests i have found that a hidden network does not have a Name dictionary entry at all. Indeed, was too keen on trusting what my UI tells ;-) Will change that. Thanks for the

Re: [PATCH v1 6/6] neard: Add partial support for wifi provisionning via NFC

*val = htons(tlv_msg[0] | tlv_msg[1] 8); Let's take that one, but with ntohs() (patch has a bug here) Tomasz ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH] gsupplicant: Set the scan callback in g_supplicant_interface_scan

Nice catch! Tomasz ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

[PATCH v1 0/6] Neard plugin

Simple Configuration so there might be an issue on EAP TLS. This provisionning feature has not been tested yet, so I send the patches mostly for review. Tomasz Bursztyka (6): technology: Provide a function to get WiFi tethering informations neard: Add neard plugin with tethering info sharing

[PATCH v1 1/6] technology: Provide a function to get WiFi tethering informations

--- include/technology.h | 2 ++ src/technology.c | 52 2 files changed, 38 insertions(+), 16 deletions(-) diff --git a/include/technology.h b/include/technology.h index f3fab20..2eb35a4 100644 --- a/include/technology.h +++

[PATCH v1 3/6] config: Remove superfluous error code

It simplifies the code removing uselesse variable, moreover such variable has the same name as an existing label in the same function. --- src/config.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/src/config.c b/src/config.c index

[PATCH v1 5/6] config: Add a function to provision mutable service

The point here is to create a virtual configuration, which does not come from a real file. This is a handy way for plugins to be able to provision services without creating any file on the FS. In case of a wifi configuration type and if connect is requested, it will trigger a scan, thus leading

Re: [PATCH 3/8] vpn-provider: Setting VPN properties will send PropertyChanged signal

Hi Jukka, enum { - USER_ROUTES_CHANGED = 0x01, + USER_ROUTES_CHANGED = 0x01, SERVER_ROUTES_CHANGED = 0x02, + TYPE_CHANGED = 0x04, + NAME_CHANGED = 0x08, + HOST_CHANGED = 0x10, + DOMAIN_CHANGED= 0x20, +

[PATCH (RFC) 1/2] gresolv: Do not remove a query on failure if other results are pending

Fixes BMC#25973 In the case one of the resolving failed, the query is removed and destroyed from the queue. So the responses of the requests sent to the other namerservers - which might be successful - will thus be lost since they cannot be matched anymore to their initial request. ---

[PATCH 2/2] gresolv: Optimize the response parser

It will check first if the response belongs to a query, before interpreting any of its content (rcode, count...). --- gweb/gresolv.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gweb/gresolv.c b/gweb/gresolv.c index 9505f67..864d2ad 100644 --- a/gweb/gresolv.c

Re: Unable to connect to open wireless networks

Hi Sameer, Could you send wpa_supplicant's log as well? run it with -dd option so you get a lot of debug. From what I saw in your connman's log, the state transition went from associtating/connecting to disconnected. So we will get more clues from wpa_supplicant logs about the reasons why

[PATCH] test: Fix simple-agent so it can run even if service files are missing

Fixes BMC#25964 --- test/simple-agent | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/test/simple-agent b/test/simple-agent index 2487b7b..01c82ba 100755 --- a/test/simple-agent +++ b/test/simple-agent @@ -276,7 +276,7 @@ def

[PATCH 2/5] client: Use pthread instead of obsolete g_thread API

--- src/client.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/client.c b/src/client.c index c41a738..1919146 100644 --- a/src/client.c +++ b/src/client.c @@ -24,13 +24,14 @@ #endif #include gdbus.h +#include pthread.h #include pacrunner.h struct

[PATCH 3/5] main: Remove obsolete g_thread_init() call

--- src/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/main.c b/src/main.c index 96b4881..edf61a3 100644 --- a/src/main.c +++ b/src/main.c @@ -154,9 +154,6 @@ int main(int argc, char *argv[]) DBusError err; guint signal; - if (g_thread_supported() ==

[PATCH 4/5] unit: Remove obsolete g_thread_init() call

--- unit/test-pacrunner.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/unit/test-pacrunner.c b/unit/test-pacrunner.c index ec63940..f9d3c86 100644 --- a/unit/test-pacrunner.c +++ b/unit/test-pacrunner.c @@ -620,9 +620,6 @@ int main(int argc, char *argv[]) if (file_path != NULL)

<    2   3   4   5   6   7   8   9   10   11   >