Re: [PATCH] gdhcp:Remove unnecessary check

On Mon, 2015-10-05 at 16:05 +0530, Maneesh Jain wrote: > Signed-off-by: Maneesh Jain Please explain in the commit message *why* the client_id check is unnecessary. Quickly looking at the code doesn't immediately reveal the reasoning behind this check. No signed-off-bys

Re: [PATCH] supplicant.c: Fixed Potential Crash issue

Hi, On Mon, 2015-10-05 at 14:31 +0530, Maneesh Jain wrote: > Signed-off-by: Maneesh Jain > --- > gsupplicant/supplicant.c | 6 ++ > 1 files changed, 6 insertions(+) > > diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c > index

Re: [PATCH] gsupplicant:Fix possible memory leak in signal_peer_found function

On Mon, 2015-10-05 at 15:35 +0530, Maneesh Jain wrote: > Signed-off-by: Maneesh Jain We don't do/need signed-off-bys in this project. Short description here of the cause of the fix like "If supplicant_dbus_property_get_all() returns and error, the callback function will

Re: DHCP & hostname faceplant

Hi Patrik, On 09/22/2015 12:12 AM, Patrik Flykt wrote: On Fri, 2015-09-18 at 02:50 +, Daniel Wagner wrote: The WiFi APs provided by the local ISP here in Utah does not like the hostname in the DHCP Request packet. Without it the hostname I get the ACK instead of the NACK as respond. Any

Re: [PATCH v3] IPv6 timeserver for NTP

Hi, On Tue, 2015-10-06 at 23:50 -0700, Naveen Singh wrote: > From: Naveen Singh > > Current NTP code is written with an assumption that timeserver is > always an IPv4 address. If there is an IPv6 timeserver then the socket > operation would fail with error as

Re: [PATCH V2] add management of dsa interface

On Tue, 2015-10-06 at 10:51 +0200, Laurent Vaudoit wrote: > --- Added a commit message in similar style as the VLAN patch. In the future please describe the changes in the commit message! Applied, Patrik ___ connman mailing list

Re: [PATCH] gsupplicant:Fix Potential crash issue in case dbus_malloc() fail

On Mon, 2015-10-05 at 15:24 +0530, Maneesh Jain wrote: > Signed-off-by: Maneesh Jain Added a shor commit message and removed the signed off by. Applied! Patrik ___ connman mailing list connman@connman.net

Re: service state transition to failure

Hi, On Wed, 2015-10-07 at 21:21 -0700, Naveen Singh wrote: > I have few questions about service state transition to failure: > > 1. Can service state transition to Failure w/o generating an error event? I > am seeing that WiFi connection is not going through even if the AP is found > in

[PATCH] gdhcp: Remove unnecessary operation on lease seconds

Lease seconds will not overflow, they are specified as a delta from now to a point in the future. Therefore no truncation of the received value is necessary. --- gdhcp/client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index

Re: clamping issue in dhcp lease

On Wed, 2015-10-07 at 00:33 -0700, Naveen Singh wrote: > lease_seconds &= 0x0fff; This seems to be a bug and at the same time very old code. I'll try to find time to fix this. Patrik ___ connman mailing list connman@connman.net

Re: service state transition to failure

Hi Patrik Thanks for your response. On Thu, Oct 8, 2015 at 6:20 AM, Patrik Flykt wrote: > > Hi, > > On Wed, 2015-10-07 at 21:21 -0700, Naveen Singh wrote: > > I have few questions about service state transition to failure: > > > > 1. Can service state

Re: service state transition to failure

On Thu, Oct 8, 2015 at 6:20 AM, Patrik Flykt wrote: > > Hi, > > On Wed, 2015-10-07 at 21:21 -0700, Naveen Singh wrote: > > I have few questions about service state transition to failure: > > > > 1. Can service state transition to Failure w/o generating an

[PATCH] Resetting the service state to idle on Error event

From: Naveen Singh It is been seen that if the service state has transitioned to failure there is no way for it to get it back to idle. This fix allows the state to be transitioned back to idle as part of handling clear_property handler for error event. Since there is no