[containers-users] Request for comments on BiMap

2018-02-22 Thread SP
I've started working on a BiMap, a map where (key, value) is also (value, key) in a one-to-one relationship. https://github.com/c-cube/ocaml-containers/compare/master...orbifx:bimap As I'm writing this I have written `empty`, `add`, `find_left` and `find_right`. The idea is that when adding a l

Re: [containers-users] Possible additions to Containers and Friends

2018-02-22 Thread SP
> Thanks for the suggestions. I'm no expert in unicode, but I do agree > that such basic functionalities should be more easily available. > Maybe a `Ustring` module in containers would make sense (as a private > alias to `string`); most functionalities below would fit there Is this for facilitatio

Re: [containers-users] Request for comments on BiMap

2018-02-22 Thread Simon Cruanes
Nice! This looks pretty ok (albeit far from complete, a proper module will have to have conversion from/to lists, from/to sequences, and probably some other convenient functions such as membership testing or cardinality or is_empty). Some comments for future inclusion in containers: - The module

Re: [containers-users] Possible additions to Containers and Friends

2018-02-22 Thread Simon Cruanes
Le Fri, 23 Feb 2018, SP wrote: > > Thanks for the suggestions. I'm no expert in unicode, but I do agree > > that such basic functionalities should be more easily available. > > Maybe a `Ustring` module in containers would make sense (as a private > > alias to `string`); most functionalities below w